Fix NFSv3 ACL regression (rhbz 1132786)

NFSv3-Fix-another-acl-regression.patch

@@ -0,0 +1,37 @@
+From 498a0fb58f119bfa222065fc4f2932e81e1510ed Mon Sep 17 00:00:00 2001
+From: Trond Myklebust <trond.myklebust@primarydata.com>
+Date: Sun, 24 Aug 2014 14:46:48 -0400
+Subject: [PATCH] NFSv3: Fix another acl regression
+
+When creating a new object on the NFS server, we should not be sending
+posix setacl requests unless the preceding posix_acl_create returned a
+non-trivial acl. Doing so, causes Solaris servers in particular to
+return an EINVAL.
+
+Fixes: 013cdf1088d72 (nfs: use generic posix ACL infrastructure,,,)
+Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1132786
+Cc: stable@vger.kernel.org # 3.14+
+Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
+---
+ fs/nfs/nfs3acl.c | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/fs/nfs/nfs3acl.c b/fs/nfs/nfs3acl.c
+index d0fec260132a..24c6898159cc 100644
+--- a/fs/nfs/nfs3acl.c
++++ b/fs/nfs/nfs3acl.c
+@@ -129,7 +129,10 @@ static int __nfs3_proc_setacls(struct inode *inode, struct posix_acl *acl,
+ 		.rpc_argp	= &args,
+ 		.rpc_resp	= &fattr,
+ 	};
+-	int status;
++	int status = 0;
++
++	if (acl == NULL && (!S_ISDIR(inode->i_mode) || dfacl == NULL))
++		goto out;
+ 
+ 	status = -EOPNOTSUPP;
+ 	if (!nfs_server_capable(inode, NFS_CAP_ACLS))
+-- 
+1.9.3
+

kernel.spec

@@ -655,6 +655,9 @@ Patch26016: xhci-Disable-streams-on-Via-XHCI-with-device-id-0x34.patch
 #CVE-2014-{5471,5472} rhbz 1134099 1134101
 Patch26017: isofs-Fix-unbounded-recursion-when-processing-relocated-directories.patch
 
+#rhbz 1132786
+Patch26018: NFSv3-Fix-another-acl-regression.patch
+
 # git clone ssh://git.fedorahosted.org/git/kernel-arm64.git, git diff master...devel
 Patch30000: kernel-arm64.patch
 
@@ -1394,6 +1397,9 @@ ApplyPatch xhci-Disable-streams-on-Via-XHCI-with-device-id-0x34.patch
 #CVE-2014-{5471,5472} rhbz 1134099 1134101
 ApplyPatch isofs-Fix-unbounded-recursion-when-processing-relocated-directories.patch
 
+#rhbz 1132786
+ApplyPatch NFSv3-Fix-another-acl-regression.patch
+
 %if 0%{?aarch64patches}
 ApplyPatch kernel-arm64.patch
 %ifnarch aarch64 # this is stupid, but i want to notice before secondary koji does.
@@ -2277,6 +2283,7 @@ fi
 #                                    ||     ||
 %changelog
 * Thu Aug 28 2014 Josh Boyer <jwboyer@fedoraproject.org>
+- Fix NFSv3 ACL regression (rhbz 1132786)
 - Don't enable CONFIG_DEBUG_WW_MUTEX_SLOWPATH (rhbz 1114160)
 
 * Wed Aug 27 2014 Justin M. Forbes <jforbes@fedoraproject.org>