commit af93389d5a821e1c99374aff90f357cc738228d6 Author: Stefan BrĂ¼ns Date: Sat Dec 15 21:11:45 2012 +0100 Use correct signature for DriveEject method arguments The previous commit added the "unmount" parameter as option for the DriveEject method. It also inadvertently changed the method signature of the call from "array of strings" to "string". DIGEST: Fix ejecting CDs/DVDs when using UDisks backend. UDisks2 is not affected REVIEW: 107686 BUG: 311613 FIXED-IN: 4.9.5 diff --git a/solid/solid/backends/udisks/udisksopticaldrive.cpp b/solid/solid/backends/udisks/udisksopticaldrive.cpp index 8ea6194..8286ee7 100644 --- a/solid/solid/backends/udisks/udisksopticaldrive.cpp +++ b/solid/solid/backends/udisks/udisksopticaldrive.cpp @@ -63,7 +63,7 @@ bool UDisksOpticalDrive::eject() QString path = m_device->udi(); QDBusMessage msg = QDBusMessage::createMethodCall(UD_DBUS_SERVICE, path, UD_DBUS_INTERFACE_DISKS_DEVICE, "DriveEject"); - msg << "unmount"; // unmount parameter + msg << (QStringList() << "unmount"); // unmount parameter return c.callWithCallback(msg, this, SLOT(slotDBusReply(QDBusMessage)), SLOT(slotDBusError(QDBusError))); }