rpms/grpc
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update some spec file comments

Browse Source
This commit is contained in:
Benjamin A. Beasley 2021-08-23 15:45:51 -04:00
parent ef054cb40c
commit fcd2e4fe02
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
grpc.spec
View File

@ -1,15 +1,14 @@
# We need to use C++17 to link against the system abseil-cpp, or we get linker # We need to use C++17 to link against the system abseil-cpp, or we get linker
# errors. Besides, we should be compiling C++ libraries with the ABI # errors.
# corresponding to the default C++ standard on the system, since different C++
# versions are not ABI-compatible.
%global cpp_std 17 %global cpp_std 17
# However, gtest in Fedora uses the C++11 ABI, so we get linker errors building # However, we also get linker errors building the tests if we link against the
# the tests if we use C++17. We must therefore bundle a copy of gtest in the # copy of gtest in Fedora (compiled with C++11). The exact root cause is not
# source RPM rather than using the system copy. This is to be discouraged, but # quite clear. We must therefore bundle a copy of gtest in the source RPM
# there is no alternative in this case. It is not treated as a bundled library # rather than using the system copy. This is to be discouraged, but there is no
# because it is used only at build time, and contributes nothing to the # alternative in this case. It is not treated as a bundled library because it
# installed files. We take measures to verify this in %%check. # is used only at build time, and contributes nothing to the installed files.
# We take measures to verify this in %%check.
%global gtest_version 1.11.0 %global gtest_version 1.11.0
%bcond_with system_gtest %bcond_with system_gtest