Compare commits

...

2 Commits
master ... f15

Author SHA1 Message Date
Matthias Clasen
1945851fd3 Prevent segfaults in gnome-rr users on randr-less displays 2011-05-02 14:16:17 -04:00
Matthias Clasen
ae6029dc75 3.0.1 2011-04-26 19:09:30 -04:00
4 changed files with 44 additions and 2 deletions

1
.gitignore vendored
View File

@ -12,3 +12,4 @@ gnome-desktop-2.90.4.tar.bz2
/gnome-desktop-2.91.92.tar.bz2 /gnome-desktop-2.91.92.tar.bz2
/gnome-desktop-2.91.93.tar.bz2 /gnome-desktop-2.91.93.tar.bz2
/gnome-desktop-3.0.0.tar.bz2 /gnome-desktop-3.0.0.tar.bz2
/gnome-desktop-3.0.1.tar.bz2

View File

@ -0,0 +1,30 @@
From aa93854f2ba6b0f72f1bdff9699b5724a72c89c9 Mon Sep 17 00:00:00 2001
From: Matthias Clasen <mclasen@redhat.com>
Date: Sat, 30 Apr 2011 20:48:03 -0400
Subject: [PATCH] Don't fall over if RANDR is missing
When RANDR is not present, the screen object never gets an info,
and since screen_info_free asserts, we must not call it unconditionally
in finalize.
This fixes https://bugzilla.gnome.org/show_bug.cgi?id=649053
---
libgnome-desktop/gnome-rr.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/libgnome-desktop/gnome-rr.c b/libgnome-desktop/gnome-rr.c
index 4a9d98e..eb3d735 100644
--- a/libgnome-desktop/gnome-rr.c
+++ b/libgnome-desktop/gnome-rr.c
@@ -748,7 +748,8 @@ gnome_rr_screen_finalize (GObject *gobject)
gdk_window_remove_filter (screen->priv->gdk_root, screen_on_event, screen);
- screen_info_free (screen->priv->info);
+ if (screen->priv->info)
+ screen_info_free (screen->priv->info);
G_OBJECT_CLASS (gnome_rr_screen_parent_class)->finalize (gobject);
}
--
1.7.5

View File

@ -9,10 +9,14 @@
Summary: Shared code among gnome-panel, gnome-session, nautilus, etc Summary: Shared code among gnome-panel, gnome-session, nautilus, etc
Name: gnome-desktop3 Name: gnome-desktop3
Version: 3.0.0 Version: 3.0.1
Release: 2%{?dist} Release: 2%{?dist}
URL: http://www.gnome.org URL: http://www.gnome.org
Source0: http://download.gnome.org/sources/gnome-desktop/3.0/gnome-desktop-%{version}.tar.bz2 Source0: http://download.gnome.org/sources/gnome-desktop/3.0/gnome-desktop-%{version}.tar.bz2
# Upstream fix
Patch0: 0001-Don-t-fall-over-if-RANDR-is-missing.patch
License: GPLv2+ and LGPLv2+ License: GPLv2+ and LGPLv2+
Group: System Environment/Libraries Group: System Environment/Libraries
@ -67,6 +71,7 @@ libgnomedesktop.
%prep %prep
%setup -q -n gnome-desktop-%{version} %setup -q -n gnome-desktop-%{version}
%patch0 -p1 -b .randr-missing
%build %build
%configure --with-pnp-ids-path="/usr/share/hwdata/pnp.ids" \ %configure --with-pnp-ids-path="/usr/share/hwdata/pnp.ids" \
@ -104,6 +109,12 @@ rm -f $RPM_BUILD_ROOT%{_libdir}/*.a
%doc %{_datadir}/gtk-doc/html/gnome-desktop3/ %doc %{_datadir}/gtk-doc/html/gnome-desktop3/
%changelog %changelog
* Mon May 2 2011 Matthias Clasen <mclasen@redhat.com> - 3.0.1-2
- Prevent segfaults in gnome-rr users on randr-less displays
* Tue Apr 26 2011 Matthias Clasen <mclasen@redhat.com> - 3.0.1-1
- Update to 3.0.1
* Fri Apr 15 2011 Matthias Clasen <mclasen@redhat.com> - 3.0.0-2 * Fri Apr 15 2011 Matthias Clasen <mclasen@redhat.com> - 3.0.0-2
- Require gnome-themes-standard (#674799) - Require gnome-themes-standard (#674799)

View File

@ -1 +1 @@
6215d5fee0a3ab517830d3e6553685f2 gnome-desktop-3.0.0.tar.bz2 ffc0ce6e9413786f78f59f18655e8523 gnome-desktop-3.0.1.tar.bz2