riscv: temporary fix

Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>

glibc-2.28-44-gf44c2ca5ea-riscv.patch

@@ -0,0 +1,13 @@
+diff --git a/sysdeps/unix/sysv/linux/riscv/flush-icache.c b/sysdeps/unix/sysv/linux/riscv/flush-icache.c
+index d612ef4c..de090b18 100644
+--- a/sysdeps/unix/sysv/linux/riscv/flush-icache.c
++++ b/sysdeps/unix/sysv/linux/riscv/flush-icache.c
+@@ -21,7 +21,7 @@
+ #include <stdlib.h>
+ #include <atomic.h>
+ #include <sys/cachectl.h>
+-#include <asm/syscalls.h>
++#include <unistd.h>
+ 
+ typedef int (*func_type) (void *, void *, unsigned long int);
+ 

glibc-ldflags.patch

@@ -1,32 +0,0 @@
-This patch is similar to glibc-asflags.patch and is needed to change
-the ld.so linker flags.  It is needed to work around this valgrind
-bug: https://bugzilla.redhat.com/show_bug.cgi?id=1600034
-
-diff --git a/Makeconfig b/Makeconfig
-index 92e76d6200bbcd5b..376181c8ff06dea7 100644
---- a/Makeconfig
-+++ b/Makeconfig
-@@ -363,12 +363,12 @@ endif
- ifeq (yesyes,$(build-shared)$(have-z-combreloc))
- combreloc-LDFLAGS = -Wl,-z,combreloc
- LDFLAGS.so += $(combreloc-LDFLAGS)
--LDFLAGS-rtld += $(combreloc-LDFLAGS)
-+override LDFLAGS-rtld += $(combreloc-LDFLAGS)
- endif
- 
- relro-LDFLAGS = -Wl,-z,relro
- LDFLAGS.so += $(relro-LDFLAGS)
--LDFLAGS-rtld += $(relro-LDFLAGS)
-+override LDFLAGS-rtld += $(relro-LDFLAGS)
- 
- ifeq (yes,$(have-hash-style))
- # For the time being we unconditionally use 'both'.  At some time we
-@@ -376,7 +376,7 @@ ifeq (yes,$(have-hash-style))
- # with --hash-style=gnu only.
- hashstyle-LDFLAGS = -Wl,--hash-style=both
- LDFLAGS.so += $(hashstyle-LDFLAGS)
--LDFLAGS-rtld += $(hashstyle-LDFLAGS)
-+override LDFLAGS-rtld += $(hashstyle-LDFLAGS)
- endif
- 
- ifeq (yes,$(enable-static-pie))

glibc-rh1614705.patch

@@ -1,254 +0,0 @@
-commit 4b25485f03158959cff45379eecc1d73c7dcdd11
-Author: Florian Weimer <fweimer@redhat.com>
-Date:   Fri Aug 10 11:19:26 2018 +0200
-
-    Linux: Rewrite __old_getdents64 [BZ #23497]
-    
-    Commit 298d0e3129c0b5137f4989275b13fe30d0733c4d ("Consolidate Linux
-    getdents{64} implementation") broke the implementation because it does
-    not take into account struct offset differences.
-    
-    The new implementation is close to the old one, before the
-    consolidation, but has been cleaned up slightly.
-    
-    (cherry picked from commit 690652882b499defb3d950dfeff8fe421d13cab5)
-
-diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
-index f71cc39c7e257a0a..773aaea0e980bdd6 100644
---- a/sysdeps/unix/sysv/linux/Makefile
-+++ b/sysdeps/unix/sysv/linux/Makefile
-@@ -161,6 +161,7 @@ inhibit-glue = yes
- 
- ifeq ($(subdir),dirent)
- sysdep_routines += getdirentries getdirentries64
-+tests-internal += tst-readdir64-compat
- endif
- 
- ifeq ($(subdir),nis)
-diff --git a/sysdeps/unix/sysv/linux/getdents64.c b/sysdeps/unix/sysv/linux/getdents64.c
-index 3bde0cf4f0226f95..bc140b5a7fac3040 100644
---- a/sysdeps/unix/sysv/linux/getdents64.c
-+++ b/sysdeps/unix/sysv/linux/getdents64.c
-@@ -33,41 +33,80 @@ strong_alias (__getdents64, __getdents)
- # include <shlib-compat.h>
- 
- # if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_2)
--# include <olddirent.h>
-+#  include <olddirent.h>
-+#  include <unistd.h>
- 
--/* kernel definition of as of 3.2.  */
--struct compat_linux_dirent
-+static ssize_t
-+handle_overflow (int fd, __off64_t offset, ssize_t count)
- {
--  /* Both d_ino and d_off are compat_ulong_t which are defined in all
--     architectures as 'u32'.  */
--  uint32_t        d_ino;
--  uint32_t        d_off;
--  unsigned short  d_reclen;
--  char            d_name[1];
--};
-+  /* If this is the first entry in the buffer, we can report the
-+     error.  */
-+  if (count == 0)
-+    {
-+      __set_errno (EOVERFLOW);
-+      return -1;
-+    }
-+
-+  /* Otherwise, seek to the overflowing entry, so that the next call
-+     will report the error, and return the data read so far..  */
-+  if (__lseek64 (fd, offset, SEEK_SET) != 0)
-+    return -1;
-+  return count;
-+}
- 
- ssize_t
- __old_getdents64 (int fd, char *buf, size_t nbytes)
- {
--  ssize_t retval = INLINE_SYSCALL_CALL (getdents, fd, buf, nbytes);
-+  /* We do not move the individual directory entries.  This is only
-+     possible if the target type (struct __old_dirent64) is smaller
-+     than the source type.  */
-+  _Static_assert (offsetof (struct __old_dirent64, d_name)
-+		  <= offsetof (struct dirent64, d_name),
-+		  "__old_dirent64 is larger than dirent64");
-+  _Static_assert (__alignof__ (struct __old_dirent64)
-+		  <= __alignof__ (struct dirent64),
-+		  "alignment of __old_dirent64 is larger than dirent64");
- 
--  /* The kernel added the d_type value after the name.  Change this now.  */
--  if (retval != -1)
-+  ssize_t retval = INLINE_SYSCALL_CALL (getdents64, fd, buf, nbytes);
-+  if (retval > 0)
-     {
--      union
--      {
--	struct compat_linux_dirent k;
--	struct dirent u;
--      } *kbuf = (void *) buf;
--
--      while ((char *) kbuf < buf + retval)
-+      char *p = buf;
-+      char *end = buf + retval;
-+      while (p < end)
- 	{
--	  char d_type = *((char *) kbuf + kbuf->k.d_reclen - 1);
--	  memmove (kbuf->u.d_name, kbuf->k.d_name,
--		   strlen (kbuf->k.d_name) + 1);
--	  kbuf->u.d_type = d_type;
-+	  struct dirent64 *source = (struct dirent64 *) p;
-+
-+	  /* Copy out the fixed-size data.  */
-+	  __ino_t ino = source->d_ino;
-+	  __off64_t offset = source->d_off;
-+	  unsigned int reclen = source->d_reclen;
-+	  unsigned char type = source->d_type;
-+
-+	  /* Check for ino_t overflow.  */
-+	  if (__glibc_unlikely (ino != source->d_ino))
-+	    return handle_overflow (fd, offset, p - buf);
-+
-+	  /* Convert to the target layout.  Use a separate struct and
-+	     memcpy to side-step aliasing issues.  */
-+	  struct __old_dirent64 result;
-+	  result.d_ino = ino;
-+	  result.d_off = offset;
-+	  result.d_reclen = reclen;
-+	  result.d_type = type;
-+
-+	  /* Write the fixed-sized part of the result to the
-+	     buffer.  */
-+	  size_t result_name_offset = offsetof (struct __old_dirent64, d_name);
-+	  memcpy (p, &result, result_name_offset);
-+
-+	  /* Adjust the position of the name if necessary.  Copy
-+	     everything until the end of the record, including the
-+	     terminating NUL byte.  */
-+	  if (result_name_offset != offsetof (struct dirent64, d_name))
-+	    memmove (p + result_name_offset, source->d_name,
-+		     reclen - offsetof (struct dirent64, d_name));
- 
--	  kbuf = (void *) ((char *) kbuf + kbuf->k.d_reclen);
-+	  p += reclen;
- 	}
-      }
-   return retval;
-diff --git a/sysdeps/unix/sysv/linux/tst-readdir64-compat.c b/sysdeps/unix/sysv/linux/tst-readdir64-compat.c
-new file mode 100644
-index 0000000000000000..43c4a8477c7403c5
---- /dev/null
-+++ b/sysdeps/unix/sysv/linux/tst-readdir64-compat.c
-@@ -0,0 +1,111 @@
-+/* Test readdir64 compatibility symbol.
-+   Copyright (C) 2018 Free Software Foundation, Inc.
-+   This file is part of the GNU C Library.
-+
-+   The GNU C Library is free software; you can redistribute it and/or
-+   modify it under the terms of the GNU Lesser General Public
-+   License as published by the Free Software Foundation; either
-+   version 2.1 of the License, or (at your option) any later version.
-+
-+   The GNU C Library is distributed in the hope that it will be useful,
-+   but WITHOUT ANY WARRANTY; without even the implied warranty of
-+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-+   Lesser General Public License for more details.
-+
-+   You should have received a copy of the GNU Lesser General Public
-+   License along with the GNU C Library; if not, see
-+   <http://www.gnu.org/licenses/>.  */
-+
-+#include <dirent.h>
-+#include <dlfcn.h>
-+#include <errno.h>
-+#include <shlib-compat.h>
-+#include <stdbool.h>
-+#include <stdio.h>
-+#include <string.h>
-+#include <support/check.h>
-+
-+/* Copied from <olddirent.h>.  */
-+struct __old_dirent64
-+  {
-+    __ino_t d_ino;
-+    __off64_t d_off;
-+    unsigned short int d_reclen;
-+    unsigned char d_type;
-+    char d_name[256];
-+  };
-+
-+typedef struct __old_dirent64 *(*compat_readdir64_type) (DIR *);
-+
-+#if TEST_COMPAT (libc, GLIBC_2_1, GLIBC_2_2)
-+struct __old_dirent64 *compat_readdir64 (DIR *);
-+compat_symbol_reference (libc, compat_readdir64, readdir64, GLIBC_2_1);
-+#endif
-+
-+static int
-+do_test (void)
-+{
-+#if TEST_COMPAT (libc, GLIBC_2_1, GLIBC_2_2)
-+
-+  /* Directory stream using the non-compat readdir64 symbol.  The test
-+     checks against this.  */
-+  DIR *dir_reference = opendir (".");
-+  TEST_VERIFY_EXIT (dir_reference != NULL);
-+  DIR *dir_test = opendir (".");
-+  TEST_VERIFY_EXIT (dir_test != NULL);
-+
-+  /* This loop assumes that the enumeration order is consistent for
-+     two different handles.  Nothing should write to the current
-+     directory (in the source tree) while this test runs, so there
-+     should not be any difference due to races.  */
-+  size_t count = 0;
-+  while (true)
-+    {
-+      errno = 0;
-+      struct dirent64 *entry_reference = readdir64 (dir_reference);
-+      if (entry_reference == NULL && errno != 0)
-+        FAIL_EXIT1 ("readdir64 entry %zu: %m\n", count);
-+      struct __old_dirent64 *entry_test = compat_readdir64 (dir_test);
-+      if (entry_reference == NULL)
-+        {
-+          if (errno == EOVERFLOW)
-+            {
-+              TEST_VERIFY (entry_reference->d_ino
-+                           != (__ino_t) entry_reference->d_ino);
-+              printf ("info: inode number overflow at entry %zu\n", count);
-+              break;
-+            }
-+          if (errno != 0)
-+            FAIL_EXIT1 ("compat readdir64 entry %zu: %m\n", count);
-+        }
-+
-+      /* Check that both streams end at the same time.  */
-+      if (entry_reference == NULL)
-+        {
-+          TEST_VERIFY (entry_test == NULL);
-+          break;
-+        }
-+      else
-+        TEST_VERIFY_EXIT (entry_test != NULL);
-+
-+      /* Check that the entries are the same.  */
-+      TEST_COMPARE_BLOB (entry_reference->d_name,
-+                         strlen (entry_reference->d_name),
-+                         entry_test->d_name, strlen (entry_test->d_name));
-+      TEST_COMPARE (entry_reference->d_ino, entry_test->d_ino);
-+      TEST_COMPARE (entry_reference->d_off, entry_test->d_off);
-+      TEST_COMPARE (entry_reference->d_type, entry_test->d_type);
-+      TEST_COMPARE (entry_reference->d_reclen, entry_test->d_reclen);
-+
-+      ++count;
-+    }
-+  printf ("info: %zu directory entries found\n", count);
-+  TEST_VERIFY (count >= 3);     /* ".", "..", and some source files.  */
-+
-+  TEST_COMPARE (closedir (dir_test), 0);
-+  TEST_COMPARE (closedir (dir_reference), 0);
-+#endif
-+  return 0;
-+}
-+
-+#include <support/test-driver.c>

glibc.spec

@@ -1,6 +1,6 @@
-%define glibcsrcdir glibc-2.28
+%define glibcsrcdir glibc-2.28-44-gf44c2ca5ea
 %define glibcversion 2.28
-%define glibcrelease 5%{?dist}
+%define glibcrelease 21.0.riscv64%{?dist}
 # Pre-release tarballs are pulled in from git using a command that is
 # effectively:
 #
@@ -159,9 +159,8 @@ Patch18: glibc-c-utf8-locale.patch
 Patch23: glibc-python3.patch
 Patch24: glibc-with-nonshared-cflags.patch
 Patch25: glibc-asflags.patch
-Patch26: glibc-ldflags.patch
-Patch27: glibc-rh1614705.patch
 Patch28: glibc-rh1615608.patch
+Patch40: glibc-2.28-44-gf44c2ca5ea-riscv.patch
 
 ##############################################################################
 # Continued list of core "glibc" package information:
@@ -212,10 +211,12 @@ BuildRequires: valgrind
 # We use systemd rpm macros for nscd
 BuildRequires: systemd
 
-# We use python for the microbenchmarks and locale data regeneration from
-# unicode sources (carried out manually). We choose python3 explicitly
-# because it supports both use cases.
-BuildRequires: python3
+# We use python for the microbenchmarks and locale data regeneration
+# from unicode sources (carried out manually). We choose python3
+# explicitly because it supports both use cases.  On some
+# distributions, python3 does not actually install /usr/bin/python3,
+# so we also depend on python3-devel.
+BuildRequires: python3 python3-devel
 
 # This GCC version is needed for -fstack-clash-protection support.
 BuildRequires: gcc >= 7.2.1-6
@@ -665,6 +666,22 @@ This package provides built benchmark binaries and scripts to run
 microbenchmark tests on the system.
 %endif
 
+##############################################################################
+# compat-libpthread-nonshared
+# See: https://sourceware.org/bugzilla/show_bug.cgi?id=23500
+##############################################################################
+%package -n compat-libpthread-nonshared
+Summary: Compatibility support for linking against libpthread_nonshared.a.
+
+%description -n compat-libpthread-nonshared
+This package provides compatibility support for applications that expect
+libpthread_nonshared.a to exist. The support provided is in the form of
+an empty libpthread_nonshared.a that allows dynamic links to succeed.
+Such applications should be adjusted to avoid linking against
+libpthread_nonshared.a which is no longer used. The static library
+libpthread_nonshared.a is an internal implementation detail of the C
+runtime and should not be expected to exist.
+
 ##############################################################################
 # Prepare for the build.
 ##############################################################################
@@ -782,16 +799,7 @@ rpm_inherit_flags \
 # assembler code.  Needs to be passed to make; not preserved by
 # configure.
 %define glibc_make_flags_as ASFLAGS="-g -Wa,--generate-missing-build-notes=yes"
-%define glibc_make_flags %{glibc_make_flags_as} %{glibc_make_flags_ld}
-
-# valgrind reports false positives if ld.so is linked with -z
-# separate-code (the default) on i686, so we work around that here.
-# See <https://bugzilla.redhat.com/show_bug.cgi?id=1600034>.
-%ifarch %{ix86}
-%define glibc_make_flags_ld LDFLAGS-rtld="-Wl,-z,noseparate-code"
-%else
-%define glibc_make_flags_ld %{nil}
-%endif
+%define glibc_make_flags %{glibc_make_flags_as}
 
 ##############################################################################
 # %%build - Generic options.
@@ -903,7 +911,9 @@ make -j1 install_root=%{glibc_sysroot} install -C build-%{target}
 # locales.
 %ifnarch %{auxarches}
 pushd build-%{target}
-make %{?_smp_mflags} -O install_root=%{glibc_sysroot} \
+# Do not use a parallel make here because the hardlink optimization in
+# localedef is not fully reproducible when running concurrently.
+make install_root=%{glibc_sysroot} \
 	install-locales -C ../localedata objdir=`pwd`
 popd
 %endif
@@ -1027,7 +1037,7 @@ $olddir/build-%{target}/elf/ld.so \
         --library-path $olddir/build-%{target}/ \
         $olddir/build-%{target}/locale/localedef \
         --prefix %{glibc_sysroot} --add-to-archive \
-        *_*
+        eo *_*
 # Setup the locale-archive template for use by glibc-all-langpacks.
 mv locale-archive{,.tmpl}
 # Create the file lists for the language specific sub-packages:
@@ -1219,6 +1229,13 @@ for i in %{glibc_sysroot}%{_prefix}/bin/{xtrace,memusage}; do
       -i $i
 done
 
+##############################################################################
+# Build an empty libpthread_nonshared.a for compatiliby with applications
+# that have old linker scripts that reference this file. We ship this only
+# in compat-libpthread-nonshared sub-package.
+##############################################################################
+ar cr %{glibc_sysroot}%{_prefix}/%{_lib}/libpthread_nonshared.a
+
 ##############################################################################
 # Beyond this point in the install process we no longer modify the set of
 # installed files, with one exception, for auxarches we cleanup the file list
@@ -1254,6 +1271,8 @@ done
 #       - File lists for nss_* NSS module subpackages.
 # * nss-devel.filelist
 #       - File list with the .so symbolic links for NSS packages.
+# * compat-libpthread-nonshared.filelist.
+#	- File list for compat-libpthread-nonshared subpackage.
 # * debuginfo.filelist
 #	- Files for the glibc debuginfo package.
 # * debuginfocommon.filelist
@@ -1275,6 +1294,7 @@ touch libnsl.filelist
 touch nss_db.filelist
 touch nss_hesiod.filelist
 touch nss-devel.filelist
+touch compat-libpthread-nonshared.filelist
 touch debuginfo.filelist
 touch debuginfocommon.filelist
 
@@ -1518,6 +1538,11 @@ echo "%{_prefix}/libexec/glibc-benchtests/import_bench.py*" >> benchtests.fileli
 echo "%{_prefix}/libexec/glibc-benchtests/validate_benchout.py*" >> benchtests.filelist
 %endif
 
+###############################################################################
+# compat-libpthread-nonshared
+###############################################################################
+echo "%{_libdir}/libpthread_nonshared.a" >> compat-libpthread-nonshared.filelist
+
 ###############################################################################
 # glibc-debuginfocommon, and glibc-debuginfo
 ###############################################################################
@@ -1876,7 +1901,99 @@ fi
 %files benchtests -f benchtests.filelist
 %endif
 
+%files -f compat-libpthread-nonshared.filelist -n compat-libpthread-nonshared
+
 %changelog
+* Tue Nov 27 2018 David Abdurachmanov <david.abdurachmanov@gmail.com> - 2.28-21.0.riscv64
+- Temporary fix for RISC-V (riscv64)
+
+* Mon Nov 26 2018 Florian Weimer <fweimer@redhat.com> - 2.28-21
+- Do not use parallel make for building locales (#1652228)
+
+* Mon Nov 19 2018 Florian Weimer <fweimer@redhat.com> - 2.28-20
+- Auto-sync with upstream branch release/2.28/master,
+  commit f44c2ca5eacd2df76fc38be75f9ebb8f0ff555eb:
+- Update system call list to Linux 4.19
+- time: Fix tzfile low-memory assertion failure (swbz#21716)
+- Add newlines in __libc_fatal calls (swbz#20271)
+- nscd: Fix use-after-free in addgetnetgrentX (swbz#23520)
+- malloc: Additional heap integrity checks
+- Add an additional test to resolv/tst-resolv-network.c (swbz#17630)
+
+* Fri Nov 09 2018 Florian Weimer <fweimer@redhat.com> - 2.28-19
+- Auto-sync with upstream branch release/2.28/master,
+  commit 3e8d8dd5afba18a847ff7a80f473336f777cc329:
+- Disable CET for binaries created by older link editors (#1648297)
+
+* Wed Nov 07 2018 Florian Weimer <fweimer@redhat.com> - 2.28-18
+- Drop patches that were applied to upstream release/2.28/master branch:
+    glibc-rh1614705.patch
+    glibc-rh1615608.patch
+    glibc-error-va_end.patch
+    glibc-nscd-leak.patch
+    glibc-nss_files-leak.patch
+    glibc-rh1622669.patch
+    glibc-1622674-1.patch
+    glibc-1622674-2.patch
+    glibc-rh1631338-1.patch
+    glibc-rh1631338-2.patch
+    glibc-rh1623519.patch
+    glibc-rh1631719.patch
+    glibc-rh1631728.patch
+    glibc-rh1623519-2.patch
+- Auto-sync with upstream branch release/2.28/master,
+  commit fc0e3393ff775aa795b523083bb0db7f18d3b91e:
+- RISC-V: Move libc_fesetround_riscv after libc_feholdexcept_riscv
+- pthread_spawn: Fix potential segfault in maybe_script_execute
+- preadv2/pwritev2: Fix misreported errno (swbz#23579)
+- kl_GL: Fix spelling of Sunday, should be "sapaat" (swbz#20209)
+- i386: Use _dl_runtime_[resolve|profile]_shstk for SHSTK (swbz#23716)
+- pthread_mutex_lock: Fix race while promoting to PTHREAD_MUTEX_ELISION_NP
+  (swbz#23275)
+- signal: Use correct type for si_band in siginfo_t (swbz#23562)
+- stdlib/test-bz22786: Avoid spurious test failures using alias mappings
+- x86: Fix Haswell CPU string flags (swbz#23709)
+- libanl: Fix crash if first helper thread creation failed (#1646381)
+
+* Thu Nov  1 2018 Mike FABIAN <mfabian@redhat.com> - 2.28-17
+- Include Esperanto (eo) in glibc-all-langpacks (#1643756)
+
+* Thu Sep 27 2018 Florian Weimer <fweimer@redhat.com> - 2.28-16
+- stdlib/tst-setcontext9 test suite failure on ppc64le (#1623519)
+
+* Wed Sep 26 2018 Florian Weimer <fweimer@redhat.com> - 2.28-15
+- Add missing ENDBR32 in start.S (#1631728)
+
+* Wed Sep 26 2018 Florian Weimer <fweimer@redhat.com> - 2.28-14
+- Fix bug in generic strstr with large needles (#1631719)
+
+* Wed Sep 26 2018 Florian Weimer <fweimer@redhat.com> - 2.28-13
+- stdlib/tst-setcontext9 test suite failure (#1623519)
+
+* Wed Sep 26 2018 Florian Weimer <fweimer@redhat.com> - 2.28-12
+- gethostid: Missing NULL check for gethostbyname_r result (#1631338)
+
+* Wed Sep  5 2018 Florian Weimer <fweimer@redhat.com> - 2.28-11
+- Add python3-devel build dependency for downstream benefit
+
+* Wed Sep 05 2018 Carlos O'Donell <carlos@redhat.com> - 2.28-10
+- Provide compatibility support for linking against libpthread_nonshared.a
+  (#1625507)
+
+* Wed Aug 29 2018 Florian Weimer <fweimer@redhat.com> - 2.28-9
+- Remove workaround for valgrind bug (#1600034)
+
+* Wed Aug 29 2018 Florian Weimer <fweimer@redhat.com> - 2.28-8
+- regex: Fix memory overread when pattern contains NUL byte (#1622674)
+
+* Wed Aug 29 2018 Florian Weimer <fweimer@redhat.com> - 2.28-7
+- nptl: Fix waiters-after-spinning case in pthread_cond_broadcast (#1622669)
+
+* Sat Aug 25 2018 Carlos O'Donell <carlos@redhat.com> - 2.28-6
+- nss_files: Fix file stream leak in aliases lookup (swbz#23521)
+- nscd: Deallocate existing user names in file parser.
+- error, error_at_line: Add missing va_end calls.
+
 * Mon Aug 13 2018 Carlos O'Donell <carlos@redhat.com> - 2.28-5
 - Remove abort() warning in manual (#1615608)
 

sources

@@ -1 +1 @@
-SHA512 (glibc-2.28.tar.xz) = 521f820953ff07c69ece4c2186f59fc061a7f9747932cd70ef2995c2b2deee76eeb6de700d85071cdca5949179aa8ccee75eda7feca1394121ec7b821ad0a3f3
+SHA512 (glibc-2.28-44-gf44c2ca5ea.tar.xz) = c95747900329098ac2e1af47547fc98665d753690b5edb65659219bf76df5b7d49363f5b5c8acb8ec8a6e2c039a924b9df41a694e57241be8bdf68e6e5d50781