170 lines
5.3 KiB
Diff
170 lines
5.3 KiB
Diff
gdb:
|
|
https://bugzilla.redhat.com/show_bug.cgi?id=623749
|
|
kernel:
|
|
https://bugzilla.redhat.com/show_bug.cgi?id=636937
|
|
|
|
http://sourceware.org/ml/gdb-patches/2010-09/msg00395.html
|
|
Subject: Re: [patch] Fix gcore writer for -Wl,-z,relro (PR corefiles/11804)
|
|
|
|
gdb/testsuite/
|
|
2010-09-22 Jan Kratochvil <jan.kratochvil@redhat.com>
|
|
|
|
Fix gcore writer for -Wl,-z,relro.
|
|
* gdb.base/gcore-relro.exp: New file.
|
|
* gdb.base/gcore-relro-main.c: New file.
|
|
* gdb.base/gcore-relro-lib.c: New file.
|
|
|
|
--- ./gdb/gcore.c 2010-09-23 20:14:56.000000000 +0200
|
|
+++ ./gdb/gcore.c 2010-09-23 20:37:56.000000000 +0200
|
|
@@ -401,6 +401,7 @@ gcore_create_callback (CORE_ADDR vaddr,
|
|
|
|
if (write == 0 && !solib_keep_data_in_core (vaddr, size))
|
|
{
|
|
+#if 0 /* https://bugzilla.redhat.com/show_bug.cgi?id=636937 */
|
|
/* See if this region of memory lies inside a known file on disk.
|
|
If so, we can avoid copying its contents by clearing SEC_LOAD. */
|
|
struct objfile *objfile;
|
|
@@ -433,6 +434,7 @@ gcore_create_callback (CORE_ADDR vaddr,
|
|
}
|
|
|
|
keep:
|
|
+#endif
|
|
flags |= SEC_READONLY;
|
|
}
|
|
|
|
--- /dev/null
|
|
+++ b/gdb/testsuite/gdb.base/gcore-relro-lib.c
|
|
@@ -0,0 +1,21 @@
|
|
+/* Copyright 2010 Free Software Foundation, Inc.
|
|
+
|
|
+ This file is part of GDB.
|
|
+
|
|
+ This program is free software; you can redistribute it and/or modify
|
|
+ it under the terms of the GNU General Public License as published by
|
|
+ the Free Software Foundation; either version 3 of the License, or
|
|
+ (at your option) any later version.
|
|
+
|
|
+ This program is distributed in the hope that it will be useful,
|
|
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
+ GNU General Public License for more details.
|
|
+
|
|
+ You should have received a copy of the GNU General Public License
|
|
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
+
|
|
+void
|
|
+lib (void)
|
|
+{
|
|
+}
|
|
--- /dev/null
|
|
+++ b/gdb/testsuite/gdb.base/gcore-relro-main.c
|
|
@@ -0,0 +1,25 @@
|
|
+/* Copyright 2010 Free Software Foundation, Inc.
|
|
+
|
|
+ This file is part of GDB.
|
|
+
|
|
+ This program is free software; you can redistribute it and/or modify
|
|
+ it under the terms of the GNU General Public License as published by
|
|
+ the Free Software Foundation; either version 3 of the License, or
|
|
+ (at your option) any later version.
|
|
+
|
|
+ This program is distributed in the hope that it will be useful,
|
|
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
+ GNU General Public License for more details.
|
|
+
|
|
+ You should have received a copy of the GNU General Public License
|
|
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
+
|
|
+extern void lib (void);
|
|
+
|
|
+int
|
|
+main (void)
|
|
+{
|
|
+ lib ();
|
|
+ return 0;
|
|
+}
|
|
--- /dev/null
|
|
+++ b/gdb/testsuite/gdb.base/gcore-relro.exp
|
|
@@ -0,0 +1,80 @@
|
|
+# Copyright 2010 Free Software Foundation, Inc.
|
|
+
|
|
+# This program is free software; you can redistribute it and/or modify
|
|
+# it under the terms of the GNU General Public License as published by
|
|
+# the Free Software Foundation; either version 3 of the License, or
|
|
+# (at your option) any later version.
|
|
+#
|
|
+# This program is distributed in the hope that it will be useful,
|
|
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
+# GNU General Public License for more details.
|
|
+#
|
|
+# You should have received a copy of the GNU General Public License
|
|
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
+
|
|
+if {[skip_shlib_tests]} {
|
|
+ return 0
|
|
+}
|
|
+
|
|
+set testfile "gcore-relro"
|
|
+set srcmainfile ${testfile}-main.c
|
|
+set srclibfile ${testfile}-lib.c
|
|
+set libfile ${objdir}/${subdir}/${testfile}-lib.so
|
|
+set objfile ${objdir}/${subdir}/${testfile}-main.o
|
|
+set executable ${testfile}-main
|
|
+set binfile ${objdir}/${subdir}/${executable}
|
|
+set gcorefile ${objdir}/${subdir}/${executable}.gcore
|
|
+
|
|
+if { [gdb_compile_shlib ${srcdir}/${subdir}/${srclibfile} ${libfile} {debug}] != ""
|
|
+ || [gdb_compile ${srcdir}/${subdir}/${srcmainfile} ${objfile} object {debug}] != "" } {
|
|
+ untested ${testfile}.exp
|
|
+ return -1
|
|
+}
|
|
+set opts [list debug shlib=${libfile} additional_flags=-Wl,-z,relro]
|
|
+if { [gdb_compile ${objfile} ${binfile} executable $opts] != "" } {
|
|
+ unsupported "-Wl,-z,relro compilation failed"
|
|
+ return -1
|
|
+}
|
|
+
|
|
+clean_restart $executable
|
|
+gdb_load_shlibs $libfile
|
|
+
|
|
+# Does this gdb support gcore?
|
|
+set test "help gcore"
|
|
+gdb_test_multiple $test $test {
|
|
+ -re "Undefined command: .gcore.*\r\n$gdb_prompt $" {
|
|
+ # gcore command not supported -- nothing to test here.
|
|
+ unsupported "gdb does not support gcore on this target"
|
|
+ return -1;
|
|
+ }
|
|
+ -re "Save a core file .*\r\n$gdb_prompt $" {
|
|
+ pass $test
|
|
+ }
|
|
+}
|
|
+
|
|
+if { ![runto lib] } then {
|
|
+ return -1
|
|
+}
|
|
+
|
|
+set escapedfilename [string_to_regexp ${gcorefile}]
|
|
+
|
|
+set test "save a corefile"
|
|
+gdb_test_multiple "gcore ${gcorefile}" $test {
|
|
+ -re "Saved corefile ${escapedfilename}\r\n$gdb_prompt $" {
|
|
+ pass $test
|
|
+ }
|
|
+ -re "Can't create a corefile\r\n$gdb_prompt $" {
|
|
+ unsupported $test
|
|
+ return -1
|
|
+ }
|
|
+}
|
|
+
|
|
+# Now restart gdb and load the corefile.
|
|
+
|
|
+clean_restart $executable
|
|
+gdb_load_shlibs $libfile
|
|
+
|
|
+gdb_test "core ${gcorefile}" "Core was generated by .*" "re-load generated corefile"
|
|
+
|
|
+gdb_test "frame" "#0 \[^\r\n\]* lib .*" "library got loaded"
|