Commit Graph

1185 Commits

Author SHA1 Message Date
Andrew Burgess
f71aced2fd Remove gdb-ccache-workaround.patch
This patch adds a work around for an issue with older versions of
ccache -- the line number for macros defined at the compiler command
line was '1' instead of '0'.

Not only is this ccache issue fixed with newer versions of ccache, but
upstream GDB now disables ccache during testing, see commit:

  commit 49b4de64242d4ae035e0e2197837278e33c187fc
  Date:   Thu Sep 15 14:04:20 2016 +0200

      testsuite: Disable ccache

As a result this work around is no longer needed, and this patch can
be dropped.
2023-05-16 16:38:15 +01:00
Andrew Burgess
2a935aa29b Remove gdb-ppc-power7-test.patch
The test added by this patch claims to be a power7 test, however, it
actually appears to test instructions from power7, power8, and power9.

All the instructions tested by this patch are already tested by
upstream tests:

  gdb.arch/powerpc-power7.exp
  gdb.arch/powerpc-power8.exp
  gdb.arch/powerpc-power9.exp

As such this patch is redundant and can be removed.
2023-05-16 15:23:14 +01:00
Alexandra Hájková
7046f4cf6f Remove gdb-rhel5.9-testcase-xlf-var-inside-mod.patch
The patch adds gdb.fortran/xlf-variable.exp test,
the test can only be run on PPC64 machines which
are not supported anymore.
2023-05-06 18:28:28 +02:00
Kevin Buettner
6c805458b5 Restore changes which fix C89-isms in gdb-6.6-buildid-locate-rpm.patch
These changes, originally added to Fedora GDB by Keith Seitz, and
described in the Nov 30 2022 Changelog eentry, were inadvertently lost
during the GDB 13.1 rebase.  Only downstream/local changes were lost -
the remainder of the changes were in the upstream GDB 13.1 sources.
2023-05-04 13:40:32 -07:00
Andrew Burgess
e19c0f8fb7 Rewrite (and rename) gdb-libexec-add-index.patch
It has been observed that the changes added by
gdb-libexec-add-index.patch will result in GDB testing hanging when
the tests are being run using an in-tree GDB; that is when using 'make
check'.  One test that is known to fail is gdb.base/with-mf.exp,
though any test that calls the gdb-add-index.sh script will also hang.

The problem is that when the gdb-add-index.sh script is run, the GDB
testsuite passes the GDB command to use within the GDB environment
variable.  For in-tree testing this will be something like:

  GDB="/path/to/gdb -data-directory /path/to/data-directory"

Notice that the environment variable contains both an executable and
an argument.

Our changes to gdb-add-index.sh add this:

  GDB2=/usr/libexec/gdb
  if test -x $GDB2 && ! which $GDB &>/dev/null; then
      GDB=$GDB2
  fi

The problem then is that '-data-directory' is treated as a set of
options to 'which'.  Many of these options are not known to 'which',
but the '-i' option is known.  The documentation of '-i' says:

    --read-alias, -i
        Read aliases from stdin, reporting matching ones on
        stdout. This is useful in combination with using an alias for
        which itself. For example
        alias which=´alias | which -i´.

And here's the problem; this option causes 'which' to read from
stdin.  As the GDB testsuite doesn't send any additional input on
stdin then the which command will never complete, and the test will
hang.

The solution I think is to avoid calling 'which' like this on a user
supplied GDB environment variable.

The changes in the gdb-libexec-add-index.patch were really about what
the _default_ GDB executable should be.  The upstream version of this
script does this:

  GDB=${GDB:=gdb}

That is, the default is just 'gdb'.  However, for RH this is not good
enough.  We want to handle two additional cases, first, when only the
gdb-minimal package is installed, in which case the default should be
/usr/bin/gdb.minimal.  Then we also want to handle the case where the
user doesn't have 'gdb' itself in their $PATH, but does have the 'gdb'
executable installed in /usr/libexec/gdb.

The code as it currently stands also has a problem where, if
gdb.minimal is installed on the machine this will _always_ be used in
preference to the user supplied GDB value (assuming the code worked at
all) this means that when doing in-tree testing we wouldn't actually
be using the in-tree GDB to build the index, which isn't ideal.

So in this commit I propose that we rework our gdb-add-index.sh
changes.  Now, we only use the RH special values in the case that
there is no GDB environment variable set.  I believe this handles all
the required use cases:

  1. When doing in-tree testing GDB environment variable will be set,
  and this will always be used as is, with no special processing,

  2. When gdb-add-index.sh is used and GDB environment variable is not
  set then we will use the first of the following as the default:

    (a) /usr/bin/gdb.minimal if this file exists and is executable,
    (b) The first gdb executable that can be found in the $PATH,
    (c) /usr/libexec/gdb if this file exists and is executable.

While I was changing this patch anyway I've removed the libexec part
of the patch name -- this no longer seemed relevant, I suspect this
related to an older version of this patch.
2023-05-04 15:11:19 +01:00
Kevin Buettner
f68e769d70 Backport upstream fix for RHBZ 2192105
Specifically, "Pass const frame_info_ptr reference for
skip_[language_]trampoline". (Mark Wielaard, RHBZ 2192105, build/30413)
2023-05-03 13:32:42 -07:00
Andrew Burgess
7cd90204c9 Remove gdb-opcodes-clflushopt-test.patch
Remove gdb-opcodes-clflushopt-test.patch.  This patch tests that GDB
can disassemble the clflushopt instruction correctly.  Such
disassembly is a feature of libopcode and is covered by the gas
tests i386/x86-64-clflushopt.s and i386/clflushopt.s.  Lets remove
this test from GDB and just rely on the gas tests instead.
2023-05-02 19:15:44 +01:00
Kevin Buettner
b1e9fbcc29 Remove gdb-6.7-charsign-test.patch
This patch originally contained some changes to GDB which were
rejected by upstream maintainers.  All that remained was a testcase
which had a number of failures due to the rest of the work not being
present in GDB.
2023-04-29 19:34:05 -07:00
Bruno Larsen
231ea6585a Remove gdb-6.5-bz109921-DW_AT_decl_file-test.patch
This patch only had a test for basic DWARF-2 support, and the test was
already covered by other tests, such as gdb.linespec/linespec.exp
2023-04-25 14:14:49 +02:00
Bruno Larsen
d18c2a5bd9 Remove gdb-6.5-last-address-space-byte-test.patch
This patch exercised an edge case for 32-bit systems in
target_xfer_memory, a function that has been removed in 2006.
The test that patch added has been irrelevant for some time.
2023-04-24 15:48:54 +02:00
Alexandra Hájková
9dbae0620d Remove gdb-6.3-bz140532-ppc-unwinding-test.patch.
It adds powerpc-bcl-prologue.exp test which seems
to be a subset of upstream powerpc-prologue.exp
2023-04-13 12:22:36 +02:00
Keith Seitz
ff60ea4e26 Backport fix for binutils/29988 2023-04-11 10:32:14 -07:00
Keith Seitz
33590be3ac Backport "Fix crash in inside_main_func"
Resolves: rhbz#2183595
2023-03-31 13:14:15 -07:00
Keith Seitz
8293a5eab7 Use %patch -PNNN
The use of "%patchNNN" to apply patches is deprecated. "%patch -PNNN"
is recommended for maximum compatibility with older versions of `rpm'.

Regenerated all patches and associated files.
2023-03-31 09:53:54 -07:00
Kevin Buettner
45618ff785 Update description and Summary in gdb.spec 2023-03-30 10:01:25 -07:00
Alexandra Hájková
5b461b9481 Update gdb-6.6-buildid-locate.patch to fix RHBZ 2181221. 2023-03-30 16:20:10 +02:00
Andrew Burgess
240ac8eb89 Set distro name using --with-pkgconfig configure option
Instead of placing the distro name (e.g. 'Fedora Linux') into the
version.in file, use the --with-pkgconfig configure option to set the
disto name.

This does change GDB's version output slightly.   Prior to this commit
we might expect to see something like this:

  $ gdb --version
  GNU gdb (GDB) Fedora Linux 13.1-1-fc38
  ...

Now we'll see this:

  $ gdb --version
  GNU gdb (Fedora Linux) 13.1-1-fc38
  ...

Notice that 'Fedora Linux' moved inside the parenthesis.

There are other benefits to this change, the Python gdb.VERSION
string will now contain '13.1-1-fc38' instead of 'Fedora Linux
13.1-1-fc38', this was reported as an issue in this bug:

  https://bugzilla.redhat.com/show_bug.cgi?id=2179554

I've also removed the change to gdb.gdb/selftest.exp as I don't
believe that this was ever being used -- when this test was run we
should have hit an earlier case.

I have added a brand new test that checks our version string.  I've
placed this new test into a separate file, so we should (hopefully)
not have any issues maintaining this as an out of tree test.

For implementation, by default we make use of the %dist_name macro,
however, this is not defined on RHEL 9 or earlier, so to support
reusing this commit on RHEL systems, I also detect the %rhel macro,
and in that case use a hard-coded string.
2023-03-29 16:30:04 +01:00
Kevin Buettner
7403afbaf9 Backport fix for RHBZ 2177655. (Luis Machado) 2023-03-24 19:22:09 -04:00
Bruno Larsen
50c864895c Remove gdb-rhbz1350436-type-printers-error.patch since it is upstreamed.
The test introduced by that patch is now available on upstream commit
83b755117d7a13e75877c3f166dfef1d8b69ec75, and will probably be
backported soon.
2023-03-20 10:18:06 +01:00
Kevin Buettner
92d162c371 Rebase to FSF GDB 13.1
Update gdb-6.3-rh-testversion-20041202.patch.
Update gdb-6.3-bz140532-ppc-unwinding-test.patch.
Update gdb-6.6-buildid-locate.patch.
Update gdb-6.6-buildid-locate-rpm.patch.
Remove 'Recommends: ' line for gcc-gdb-plugin for BZ2149246.
Add 'define _lto_cflags ' to avoid ODR violations.
Add -Wno-stringop-overflow to --enable-gdb-build-warnings to work around
  gcc problem.
2023-03-08 21:42:55 -07:00
Andrew Burgess
17914b3d53 Remove gdb-test-ivy-bridge.patch
The patch 'gdb-test-ivy-bridge.patch' adds some disassembly tests for
various i386/x86-64 instructions.  In fact, the tests added by this
patch are copied directly from gas and should all be covered by
gas/testsuite/gas/i386/i386.exp.

I guess historically, when support for these instructions was first
added, it made sense to have these tests in both GDB and binutils.
But today I think that the testing in binutils is sufficient; if we
really want to validate libopcodes we'd be better off building and
testing gas/binutils as well as GDB.

I propose that we just drop 'gdb-test-ivy-bridge.patch' from the
Fedora GDB tree.
2023-02-12 06:04:03 +00:00
Andrew Burgess
d7818464ae Remove gdb-6.5-readline-long-line-crash-test.patch
Remove gdb-6.5-readline-long-line-crash-test.patch, this test is now
upstream in commit:

  commit bb146a79c7d65e2b578e8c3f652cb118c63741e5
  Date:   Thu Feb 9 10:52:47 2023 +0000

      gdb: add test for readline handling very long commands

As this is only a test, I don't see any point in backporting the
upstream commit, we'll pick this up with a later rebase.
2023-02-11 17:21:20 +00:00
Andrew Burgess
7fd1c9cb3f Remove gdb-6.8-bz442765-threaded-exec-test.patch
Following on from the previous commit, this commit remove
gdb-6.8-bz442765-threaded-exec-test.patch.

Like the previous commit, this patch was a testsuite only patch that
extended the test originally added in the previous commit, in order to
do some additional threads/exec related testing.

The issue exposed by this test (Bug bz442765) was present on Fedora 9,
with GDB 6.8-1.fc9.  I have setup a Fedora 9 VM and recreated the
failure with the test in the patch I'm deleting here.

The test does a number of exec's, in each iteration the test binary
runs in a different mode.  However, the failure is triggered when we
have a main thread that spawns a worker thread and then called exec
from the main thread.

Just like the previous commit, this situation already exists in the
upstream test gdb.threads/execl.exp, and, if I copy this upstream test
to my Fedora 9 VM, I can reproduce the failure using this upstream
test.

The test being deleted here does do a number of other permutations of
threading and execing, for example it tests calling exec in a
non-threaded inferior, but this is also tested upstream with things
like gdb.base/foll-exec.exp.

In summary, I don't believe there is anything new added by this test
that is not already covered with existing upstream tests, as such, I
think we should drop this patch.
2023-02-10 15:39:01 +00:00
Andrew Burgess
89f20beb5e Remove gdb-6.3-bz202689-exec-from-pthread-test.patch
Remove gdb-6.3-bz202689-exec-from-pthread-test.patch.  The test
included in this patch is covered by the already upstream test
gdb/testsuite/gdb.threads/execl.exp which was added with this commit:

  commit 49fd4a422bb6152043b2b41a1f734694056dbf3b
  Date:   Thu Jun 5 21:03:59 2008 +0000

Unfortunately, the situation is not as simple as just removing this
patch file.  The later patch gdb-6.8-bz442765-threaded-exec-test.patch
builds on the earlier test to cover additional cases.

So, what I've actually done is remove the first patch, but merged the
test entirely into the second patch.  I think this is a better
reflection of the current situation; the first patch is
redundant (it's test is already covered upstream), while the second
patch has not yet been reviewed, so it _might_ contain a useful test.

To confirm that the upstream test quoted above actually covers this
test case I did the following:

  - Setup a Fedora 3 virtual machine,

  - Built the test from the first patch and confirmed that it failed
    as described in bug bz202689,

  - Copied the upstream execl.exp sources to the virtual machine, and
    built the test binary,

  - Manually ran the test binary just as the .exp script does, and
    confirmed that it failed in the same way as the test from the
    original patch.
2023-02-10 12:33:43 +00:00
Andrew Burgess
ad65e1854b Remove gdb-6.6-bz230000-power6-disassembly-test.patch
Remove gdb-6.6-bz230000-power6-disassembly-test.patch as this is now
covered by upstream tests.  This patch added some tests of the Power6
disassembler.  Disassembler tests are better carried in the gas tree.

Upstream commit:

  commit 0fcf99b8ab5ccbde30fa7d36742e670cd4df48ef
  Date:   Mon Jan 30 11:47:31 2023 +0000

      gas/ppc: Additional tests for DFP instructions

Added some new assembler/disassembler tests to the gas tree that
covered all the instructions that were covered by our local patch.
2023-01-31 09:38:56 +00:00
Kevin Buettner
00fe7519d4 Update gdb-6.3-rh-testversion-20041202.patch
...so that $_gdb_major and $_gdb_minor will be obtained correctly.

Also, change define of 'use_guile' from empty (which rpmbuild
complained about) to a value of 1.  I encountered this problem
while attempting to build on F37.
2023-01-27 12:02:27 -07:00
Andrew Burgess
a5f9e28701 Remove gdb-6.3-focus-cmd-prev-test.patch this test is now upstream
This upstream commit:

  commit 24f3aded1d42f515527e2de7e8e9e26f0b77c932
  Date:   Tue Dec 20 15:01:29 2022 +0000

      gdb/testsuite/tui: more testing of the 'focus' command

replaces the tests added in gdb-6.3-focus-cmd-prev-test.patch.  As
this patch was only adding a test I see no need to back-port the
upstream commit, we'll pick this up in a later rebase.
2023-01-26 14:50:06 +00:00
Bruno Larsen
6de2f1fd32 Remove gdb-rhbz1398387-tab-crash-test.patch as that test didn't work anymore 2023-01-26 12:40:53 +01:00
Keith Seitz
06da7ee788 NVR bump for failed infra on -14 build. 2023-01-24 10:03:00 -08:00
Kevin Buettner
8d8fb49148 More tweaks to gdb-6.6-buildid-locate-rpm.patch
...in which rpmTag is replaced with rpmDbiTagVal.
2023-01-23 20:12:05 -07:00
Keith Seitz
e2df45df10 Backport of backtrace/29374
(Simon Marchi, sw backtrace/29374)
2023-01-23 04:26:24 -08:00
Kevin Buettner
b443fb3970 Fixes to get GDB to build again with GCC 13 and Python 3.12
- Backport fix for problems associated with GCC 13's self-move warning.
- Tweak gdb-6.6-buildid-locate-rpm.patch so that running GDB's configure
  script will not error out due to GCC 13's warnings.
- Backport replace deprecated distutils.sysconfig in python-config.
2023-01-20 17:14:37 -07:00
Alexandra Hájková
ed2e95dc63 Backport replace deprecated distutils.sysconfig in python-config.
(Lancelot SIX)
2023-01-19 19:33:30 +01:00
Fedora Release Engineering
8e9d3a4cf8 Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2023-01-19 04:29:26 +00:00
Andrew Burgess
69f0c792d6 Back-port fix for RHBZ 2152431
Fixes RHBZ 2152431, an issue where reading a label symbol's value
would cause GDB to crash.  This pulls in two upstream commits
38665d717a3 and c3efaf0afd9 both of which should be in GDB 13 when it
is released.
2022-12-19 17:01:56 +00:00
Keith Seitz
0f5a6ebc3c Remove more unneeded tests and patches
Changes in this commit:
- Remove gdb-bz601887-dwarf4-rh-test.patch
  This adds a very simple test to check whether DWARF4
  is implemented. GDB has been using DWARF4 for several
  years, and the testsuite coverage supercedes this patch.
- Remove gdb-6.6-buildid-locate-rpm-scl.patch
  This patch is applicable only on RHEL6 where .gdb_index
  version 5 is used. In recent GDBs, i.e., all DTS releases,
  this version could only be read with the option
  "use-deprecated-index-sections". RHEL7+ use .gdb_index version 8.
  Since RHEL6 is no longer supported, this is unnecessary.
  Also remove GDB_INDEX_VERIFY_VENDOR references/code from
  gdb-6.6-buildid-locate.patch and gdb.spec
2022-12-16 09:14:19 -08:00
Michal Kolar
4896bb074a plans/ci.fmf: fix deprecated fmf plan attribute 2022-12-15 12:42:14 +00:00
Andrew Burgess
b3008271fb remove gdb-fortran-frame-string.patch file
Remove the 'gdb-fortran-frame-string.patch' patch from Fedora GDB.  I
have pushed an upstream test that covers everything that this test
covered, see upstream GDB commit:

  commit 1c01b23603766fbca4ed4dd12fdd710860e6038e
  Date:   Fri Nov 4 14:51:11 2022 +0000

      gdb/fortran/testsuite: print values and types of string variables

As this is just a testsuite patch, I'm not going to backport this to
Fedora GDB, but when we next rebase, we will pick up this test.
2022-12-09 19:14:01 +00:00
Andrew Burgess
056260a609 remove gdb-bfd-aliasing.patch file
The patch 'gdb-bfd-aliasing.patch' is no longer applied as part of the
Fedora GDB build, since this commit to the Fedora GDB repository:

  commit c0cbb1aae4
  Date:   Sat Mar 19 21:26:41 2016 +0100

      .spec cleanup: Drop strict-aliasing GCC bug workaround (from RH BZ 1315191).

I propose that we remove this file from the repository.
2022-12-09 19:12:35 +00:00
Andrew Burgess
47989c5833 gdb-entryval-crash-*.patch files
The three patches:

  gdb-entryval-crash-1of3.patch
  gdb-entryval-crash-2of3.patch
  gdb-entryval-crash-3of3.patch

are not being applied to the Fedora build of GDB, since this commit to
the Fedora GDB repository:

  commit 902c8e5abc
  Date:   Thu Jul 24 20:04:47 2014 +0200

      Rebase to FSF GDB 7.7.91.20140724 (pre-7.8 snapshot).

The contents of the first two were reverting an upstream commit,
which, based on the dialog in the patch files, was done to mask a bug
in a different part of GDB, which I assume is now fixed.

The third patch adds a couple of tests, which are now all upstream,
and passing, I assume these tests covered the issue that was causing
the problem with the first two patches.

Given these patches are not being applied, and the relevant work seems
to be in upstream GDB, I propose we drop these three files from the
repository.
2022-12-09 19:12:35 +00:00
Keith Seitz
c09759de79 Disable Guile support on F38+
Resolves: rhbz#2151328
2022-12-07 12:03:23 -08:00
Keith Seitz
7e69ec9711 Remove several unnecessary test patches
- gdb-physname-pr11734-test.patch
- gdb-physname-pr12273-test.patch
These two tests were merged upstream under a different file name.

- gdb-runtest-pie-override.patch
This patch appears unnecessary today. I have tested on all supported
host architectures and detected no regressions. I presume this was
fixed in a different manner through the years.

- gdb-test-expr-cumulative-archer.patch
The patch contains two tests. Both are upstream already.
While one is a little more involved than what landed upstream,
both tests are equivalent. The other test, gdb.cp/namespace-no-imports.exp,
is identical to upstream's gdb.cp/nsnoimports.exp with whitespace
and other trivial changes.
2022-12-05 14:51:32 -08:00
Kevin Buettner
7ca61ebe91 Remove gdb-6.3-threaded-watchpoints2-20050225.patch
The test added by this patch from 2005 is a tweaked verion of the upstream
test gdb.threads/watchthreads.exp from 2004.  (The current version of
gdb.threads/watchthreads.exp has changed somewhat since 2004.)

The tweaks added to the circa 2004 upstream test consist of setting
a breakpoint on thread_function and then continuing to it.  At
that point, initial / runtime values of args[2] and args[3] are
fetched and saved in some TCL variables (which are renamed versions
of args_0 and args_1 in watchthreads.exp).  The rest of the changes
to the tweaked script are mostly related to the renaming related to
args_0 and args_1.  The other major difference is that watchthreads.exp
places hardware watchpoints on args[0] and args[1] whereas the
tweaked test instead watches args[2] and args[3].  However, all
of these initialized to 0.  In the tweaked test, fetching the
initial values when the thread function is first hit should result
in zero values being fetched for args[2] and args[3].

So, in conclusion, the tweaked version of the test doesn't actually
test anything new.  I took a look at old posts / threads from the
gdb-patches mailing list, but I couldn't find a post where Jeff
Johnston included this patch (and an explanation of what it does over
the other patch.)

Since this test doesn't offer anything new/better over what's already
upstream, I'm deleting it.
2022-12-01 19:20:12 -07:00
Andrew Burgess
e1f49fc494 disable more features when using 'git format-patch'
In my .gitconfig I have this:

  [format]
          useAutoBase = true
          thread = shallow

As a consequence, when I run generate-patches-from-git-repo.sh I see
two problems, first, I see lots of errors like this:

  fatal: failed to get upstream, if you want to record base commit automatically,
  please use git branch --set-upstream-to to track a remote branch.
  Or you could specify base commit by --base=<base-commit-id> manually

These are caused by the use of the useAutoBase option.

If I disable useAutoBase, and regenerate the patches, I see that every
patch changes, with the addition of a line like this:

  Message-Id: <some message id string here...>

This is caused by the use of the thread option.

Rather than forcing me to not have these settings in my .gitconfig, I
propose that we add --no-base and --no-thread to our invocation of
'git format-patch' in generate-patches-from-git-repo.sh, this fixes
both of the above problems.

With these new options the 'git format-patch' line was getting pretty
long, so I've wrapped it to make it more readable.
2022-12-01 14:13:48 +00:00
Bruno Larsen
46e82ad3b5 Remove gdb-rhbz1325795-framefilters-test.patch. This test doesn't
pass in the curret state, and the code that introduced the original
problem has been changed beyong recognition at this point.
2022-12-01 09:17:51 +01:00
Keith Seitz
910689b88d Updates for "ModernC" initiative
Resolves: rhbz#2143992
2022-11-29 14:19:51 -08:00
Kevin Buettner
3d614802ea Remove gdb-6.3-inheritancetest-20050726.patch. Upstream testcase
gdb.cp/impl-this.exp tests the printing of an instance variable from
an inherited class in the "print c" test.
2022-11-23 14:05:18 -07:00
Kevin Buettner
7de4cb0e83 Remove gdb-6.3-test-movedir-20050125.patch
Upstream test gdb.base/fullname.exp provides coverage for this case
and more.
2022-11-18 12:25:59 -07:00
Keith Seitz
73953d59d4 Constify target_desc and enable LTO
This patch backports the upstream commit to constify
target_desc. This eliminates the problems preventing us
from enabling LTO.
2022-11-03 06:40:16 -07:00
Bruno Larsen
eff447ffe1 backport fix to gdb.base/break-main-file-remove-fail 2022-10-18 12:10:01 +02:00