From d7818464ae78724c781e4e01ffc9454c5317265d Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Sat, 11 Feb 2023 17:21:20 +0000 Subject: [PATCH] Remove gdb-6.5-readline-long-line-crash-test.patch Remove gdb-6.5-readline-long-line-crash-test.patch, this test is now upstream in commit: commit bb146a79c7d65e2b578e8c3f652cb118c63741e5 Date: Thu Feb 9 10:52:47 2023 +0000 gdb: add test for readline handling very long commands As this is only a test, I don't see any point in backporting the upstream commit, we'll pick this up with a later rebase. --- _gdb.spec.Patch.include | 120 ++++++++++---------- _gdb.spec.patch.include | 1 - _patch_order | 1 - gdb-6.5-readline-long-line-crash-test.patch | 111 ------------------ 4 files changed, 58 insertions(+), 175 deletions(-) delete mode 100644 gdb-6.5-readline-long-line-crash-test.patch diff --git a/_gdb.spec.Patch.include b/_gdb.spec.Patch.include index 1d5b9f8..2083765 100644 --- a/_gdb.spec.Patch.include +++ b/_gdb.spec.Patch.include @@ -24,210 +24,206 @@ Patch005: gdb-6.5-BEA-testsuite.patch #=fedoratest Patch006: gdb-6.5-last-address-space-byte-test.patch -# Fix readline segfault on excessively long hand-typed lines. -#=fedoratest -Patch007: gdb-6.5-readline-long-line-crash-test.patch - # Test sideeffects of skipping ppc .so libs trampolines (BZ 218379). #=fedoratest -Patch008: gdb-6.5-bz218379-ppc-solib-trampoline-test.patch +Patch007: gdb-6.5-bz218379-ppc-solib-trampoline-test.patch # Find symbols properly at their original (included) file (BZ 109921). #=fedoratest -Patch009: gdb-6.5-bz109921-DW_AT_decl_file-test.patch +Patch008: gdb-6.5-bz109921-DW_AT_decl_file-test.patch # Update PPC unwinding patches to their upstream variants (BZ 140532). #=fedoratest -Patch010: gdb-6.3-bz140532-ppc-unwinding-test.patch +Patch009: gdb-6.3-bz140532-ppc-unwinding-test.patch # Allow running `/usr/bin/gcore' with provided but inaccessible tty (BZ 229517). #=fedoratest -Patch011: gdb-6.6-bz229517-gcore-without-terminal.patch +Patch010: gdb-6.6-bz229517-gcore-without-terminal.patch # Avoid too long timeouts on failing cases of "annota1.exp annota3.exp". #=fedoratest -Patch012: gdb-6.6-testsuite-timeouts.patch +Patch011: gdb-6.6-testsuite-timeouts.patch # Support for stepping over PPC atomic instruction sequences (BZ 237572). #=fedoratest -Patch013: gdb-6.6-bz237572-ppc-atomic-sequence-test.patch +Patch012: gdb-6.6-bz237572-ppc-atomic-sequence-test.patch # Test kernel VDSO decoding while attaching to an i386 process. #=fedoratest -Patch014: gdb-6.3-attach-see-vdso-test.patch +Patch013: gdb-6.3-attach-see-vdso-test.patch # Test leftover zombie process (BZ 243845). #=fedoratest -Patch015: gdb-6.5-bz243845-stale-testing-zombie-test.patch +Patch014: gdb-6.5-bz243845-stale-testing-zombie-test.patch # New locating of the matching binaries from the pure core file (build-id). #=push+jan -Patch016: gdb-6.6-buildid-locate.patch +Patch015: gdb-6.6-buildid-locate.patch # Fix loading of core files without build-ids but with build-ids in executables. # Load strictly build-id-checked core files only if no executable is specified # (Jan Kratochvil, RH BZ 1339862). #=push+jan -Patch017: gdb-6.6-buildid-locate-solib-missing-ids.patch +Patch016: gdb-6.6-buildid-locate-solib-missing-ids.patch #=push+jan -Patch018: gdb-6.6-buildid-locate-rpm.patch +Patch017: gdb-6.6-buildid-locate-rpm.patch # Fix displaying of numeric char arrays as strings (BZ 224128). #=fedoratest: But it is failing anyway, one should check the behavior more. -Patch019: gdb-6.7-charsign-test.patch +Patch018: gdb-6.7-charsign-test.patch # Test PPC hiding of call-volatile parameter register. #=fedoratest -Patch020: gdb-6.7-ppc-clobbered-registers-O2-test.patch +Patch019: gdb-6.7-ppc-clobbered-registers-O2-test.patch # Testsuite fixes for more stable/comparable results. #=fedoratest -Patch021: gdb-6.7-testsuite-stable-results.patch +Patch020: gdb-6.7-testsuite-stable-results.patch # Test ia64 memory leaks of the code using libunwind. #=fedoratest -Patch022: gdb-6.5-ia64-libunwind-leak-test.patch +Patch021: gdb-6.5-ia64-libunwind-leak-test.patch # Test hiding unexpected breakpoints on intentional step commands. #=fedoratest -Patch023: gdb-6.5-missed-trap-on-step-test.patch +Patch022: gdb-6.5-missed-trap-on-step-test.patch # Test gcore memory and time requirements for large inferiors. #=fedoratest -Patch024: gdb-6.5-gcore-buffer-limit-test.patch +Patch023: gdb-6.5-gcore-buffer-limit-test.patch # Test GCORE for shmid 0 shared memory mappings. #=fedoratest: But it is broken anyway, sometimes the case being tested is not reproducible. -Patch025: gdb-6.3-mapping-zero-inode-test.patch +Patch024: gdb-6.3-mapping-zero-inode-test.patch # Test a crash on libraries missing the .text section. #=fedoratest -Patch026: gdb-6.5-section-num-fixup-test.patch +Patch025: gdb-6.5-section-num-fixup-test.patch # Fix resolving of variables at locations lists in prelinked libs (BZ 466901). #=fedoratest -Patch027: gdb-6.8-bz466901-backtrace-full-prelinked.patch +Patch026: gdb-6.8-bz466901-backtrace-full-prelinked.patch # New test for step-resume breakpoint placed in multiple threads at once. #=fedoratest -Patch028: gdb-simultaneous-step-resume-breakpoint-test.patch +Patch027: gdb-simultaneous-step-resume-breakpoint-test.patch # Fix GNU/Linux core open: Can't read pathname for load map: Input/output error. # Fix regression of undisplayed missing shared libraries caused by a fix for. #=fedoratest: It should be in glibc: libc-alpha: <20091004161706.GA27450@.*> -Patch029: gdb-core-open-vdso-warning.patch +Patch028: gdb-core-open-vdso-warning.patch # Workaround ccache making lineno non-zero for command-line definitions. #=fedoratest: ccache is rarely used and it is even fixed now. -Patch030: gdb-ccache-workaround.patch +Patch029: gdb-ccache-workaround.patch # Testcase for "Do not make up line information" fix by Daniel Jacobowitz. #=fedoratest -Patch031: gdb-lineno-makeup-test.patch +Patch030: gdb-lineno-makeup-test.patch # Test power7 ppc disassembly. #=fedoratest -Patch032: gdb-ppc-power7-test.patch +Patch031: gdb-ppc-power7-test.patch # Fix follow-exec for C++ programs (bugreported by Martin Stransky). #=fedoratest -Patch033: gdb-archer-next-over-throw-cxx-exec.patch +Patch032: gdb-archer-next-over-throw-cxx-exec.patch # Workaround librpm BZ 643031 due to its unexpected exit() calls (BZ 642879). #=push+jan -Patch034: gdb-6.6-buildid-locate-rpm-librpm-workaround.patch +Patch033: gdb-6.6-buildid-locate-rpm-librpm-workaround.patch # [delayed-symfile] Test a backtrace regression on CFIs without DIE (BZ 614604). #=fedoratest -Patch035: gdb-test-bt-cfi-without-die.patch +Patch034: gdb-test-bt-cfi-without-die.patch # Verify GDB Python built-in function gdb.solib_address exists (BZ # 634108). #=fedoratest -Patch036: gdb-bz634108-solib_address.patch +Patch035: gdb-bz634108-solib_address.patch # New test gdb.arch/x86_64-pid0-core.exp for kernel PID 0 cores (BZ 611435). #=fedoratest -Patch037: gdb-test-pid0-core.patch +Patch036: gdb-test-pid0-core.patch # [archer-tromey-delayed-symfile] New test gdb.dwarf2/dw2-aranges.exp. #=fedoratest -Patch038: gdb-test-dw2-aranges.patch +Patch037: gdb-test-dw2-aranges.patch # Test GDB opcodes/ disassembly of Intel Ivy Bridge instructions (BZ 696890). #=fedoratest -Patch039: gdb-test-ivy-bridge.patch +Patch038: gdb-test-ivy-bridge.patch # Workaround PR libc/14166 for inferior calls of strstr. #=fedoratest: Compatibility with RHELs (unchecked which ones). -Patch040: gdb-glibc-strstr-workaround.patch +Patch039: gdb-glibc-strstr-workaround.patch # Include testcase for `Unable to see a variable inside a module (XLF)' (BZ 823789). #=fedoratest -Patch041: gdb-rhel5.9-testcase-xlf-var-inside-mod.patch +Patch040: gdb-rhel5.9-testcase-xlf-var-inside-mod.patch # Testcase for `Setting solib-absolute-prefix breaks vDSO' (BZ 818343). #=fedoratest -Patch042: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch +Patch041: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch # Import regression test for `gdb/findvar.c:417: internal-error: # read_var_value: Assertion `frame' failed.' (RH BZ 947564) from RHEL 6.5. #=fedoratest -Patch043: gdb-rhbz947564-findvar-assertion-frame-failed-testcase.patch +Patch042: gdb-rhbz947564-findvar-assertion-frame-failed-testcase.patch # Fix 'memory leak in infpy_read_memory()' (RH BZ 1007614) #=fedoratest -Patch044: gdb-rhbz1007614-memleak-infpy_read_memory-test.patch +Patch043: gdb-rhbz1007614-memleak-infpy_read_memory-test.patch # Fix 'gdb gives highly misleading error when debuginfo pkg is present, # but not corresponding binary pkg' (RH BZ 981154). #=push+jan -Patch045: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch +Patch044: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch # Testcase for '[SAP] Recursive dlopen causes SAP HANA installer to # crash.' (RH BZ 1156192). #=fedoratest -Patch046: gdb-rhbz1156192-recursive-dlopen-test.patch +Patch045: gdb-rhbz1156192-recursive-dlopen-test.patch # Fix '`catch syscall' doesn't work for parent after `fork' is called' # (Philippe Waroquiers, RH BZ 1149205). #=fedoratest -Patch047: gdb-rhbz1149205-catch-syscall-after-fork-test.patch +Patch046: gdb-rhbz1149205-catch-syscall-after-fork-test.patch # Fix 'backport GDB 7.4 fix to RHEL 6.6 GDB' [Original Sourceware bug # description: 'C++ (and objc): Internal error on unqualified name # re-set', PR 11657] (RH BZ 1186476). #=fedoratest -Patch048: gdb-rhbz1186476-internal-error-unqualified-name-re-set-test.patch +Patch047: gdb-rhbz1186476-internal-error-unqualified-name-re-set-test.patch # Test 'info type-printers' Python error (RH BZ 1350436). #=fedoratest -Patch049: gdb-rhbz1350436-type-printers-error.patch +Patch048: gdb-rhbz1350436-type-printers-error.patch # Fix '[ppc64] and [s390x] wrong prologue skip on -O2 -g code' (Jan # Kratochvil, RH BZ 1084404). #=fedoratest -Patch050: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch +Patch049: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch # Force libncursesw over libncurses to match the includes (RH BZ 1270534). #=push+jan -Patch051: gdb-fedora-libncursesw.patch +Patch050: gdb-fedora-libncursesw.patch # Test clflushopt instruction decode (for RH BZ 1262471). #=fedoratest -Patch052: gdb-opcodes-clflushopt-test.patch +Patch051: gdb-opcodes-clflushopt-test.patch # [aarch64] Fix hardware watchpoints (RH BZ 1261564). #=fedoratest -Patch053: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch +Patch052: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch # Add messages suggesting more recent RHEL gdbserver (RH BZ 1321114). #=fedora -Patch054: gdb-container-rh-pkg.patch +Patch053: gdb-container-rh-pkg.patch # [dts+el7] [x86*] Bundle linux_perf.h for libipt (RH BZ 1256513). #=fedora -Patch055: gdb-linux_perf-bundle.patch +Patch054: gdb-linux_perf-bundle.patch # Fix gdb-headless /usr/bin/ executables (BZ 1390251). # @@ -236,39 +232,39 @@ Patch055: gdb-linux_perf-bundle.patch # # https://fedoraproject.org/wiki/Changes/Minimal_GDB_in_buildroot #=fedora -Patch056: gdb-libexec-add-index.patch +Patch055: gdb-libexec-add-index.patch # [s390x] Backport arch12 instructions decoding (RH BZ 1553104). # =fedoratest -Patch057: gdb-rhbz1553104-s390x-arch12-test.patch +Patch056: gdb-rhbz1553104-s390x-arch12-test.patch -Patch058: gdb-backport-readline_support.patch +Patch057: gdb-backport-readline_support.patch # [gdb/testsuite] Use prototype to call libc functions # (Tom de Vries) -Patch059: gdb-backport-fix-break-main-file-remove-fail.patch +Patch058: gdb-backport-fix-break-main-file-remove-fail.patch # Constify target_desc to fix PPC ODR violations. # (Keith Seitz, build/22395) -Patch060: gdb-sw22395-constify-target_desc.patch +Patch059: gdb-sw22395-constify-target_desc.patch # libiberty: Fix C89-isms in configure tests # (Florian Weimer, RHBZ 2143992) -Patch061: gdb-rhbz2143992-libiberty-fix-c89isms-in-configure.patch +Patch060: gdb-rhbz2143992-libiberty-fix-c89isms-in-configure.patch -Patch062: gdb-rhbz2152431-label-symbol-value.patch +Patch061: gdb-rhbz2152431-label-symbol-value.patch #Backport replace deprecated distutils.sysconfig in #python-config (Lancelot SIX) -Patch063: gdb-backport-python-config-replace-deprecated-distutils.patch +Patch062: gdb-backport-python-config-replace-deprecated-distutils.patch # gcc 13 fallout: Backport Jan-Benedict Glaw's fix for the self-move # warning check -Patch064: gdb-gcc-13-backport-self-move-diagnostic-fix +Patch063: gdb-gcc-13-backport-self-move-diagnostic-fix # Backport "call check_typedef at beginning of dwarf_expr_context::fetch_result" # (Simon Marchi, backtrace/29374) -Patch065: gdb-backport-call-check_typedef-at-beginning-of-dwarf_expr_context.patch +Patch064: gdb-backport-call-check_typedef-at-beginning-of-dwarf_expr_context.patch diff --git a/_gdb.spec.patch.include b/_gdb.spec.patch.include index 173f4d4..a2afd6e 100644 --- a/_gdb.spec.patch.include +++ b/_gdb.spec.patch.include @@ -62,4 +62,3 @@ %patch062 -p1 %patch063 -p1 %patch064 -p1 -%patch065 -p1 diff --git a/_patch_order b/_patch_order index cbedb83..925fb4e 100644 --- a/_patch_order +++ b/_patch_order @@ -4,7 +4,6 @@ gdb-6.5-bz185337-resolve-tls-without-debuginfo-v2.patch gdb-6.5-sharedlibrary-path.patch gdb-6.5-BEA-testsuite.patch gdb-6.5-last-address-space-byte-test.patch -gdb-6.5-readline-long-line-crash-test.patch gdb-6.5-bz218379-ppc-solib-trampoline-test.patch gdb-6.5-bz109921-DW_AT_decl_file-test.patch gdb-6.3-bz140532-ppc-unwinding-test.patch diff --git a/gdb-6.5-readline-long-line-crash-test.patch b/gdb-6.5-readline-long-line-crash-test.patch deleted file mode 100644 index 087f916..0000000 --- a/gdb-6.5-readline-long-line-crash-test.patch +++ /dev/null @@ -1,111 +0,0 @@ -From FEDORA_PATCHES Mon Sep 17 00:00:00 2001 -From: Fedora GDB patches -Date: Fri, 27 Oct 2017 21:07:50 +0200 -Subject: gdb-6.5-readline-long-line-crash-test.patch - -;; Fix readline segfault on excessively long hand-typed lines. -;;=fedoratest - -https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214196 - -diff --git a/gdb/testsuite/gdb.base/readline-overflow.exp b/gdb/testsuite/gdb.base/readline-overflow.exp -new file mode 100644 ---- /dev/null -+++ b/gdb/testsuite/gdb.base/readline-overflow.exp -@@ -0,0 +1,96 @@ -+# Copyright 2006 Free Software Foundation, Inc. -+ -+# This program is free software; you can redistribute it and/or modify -+# it under the terms of the GNU General Public License as published by -+# the Free Software Foundation; either version 2 of the License, or -+# (at your option) any later version. -+# -+# This program is distributed in the hope that it will be useful, -+# but WITHOUT ANY WARRANTY; without even the implied warranty of -+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -+# GNU General Public License for more details. -+# -+# You should have received a copy of the GNU General Public License -+# along with this program; if not, write to the Free Software -+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. -+ -+# Please email any bugs, comments, and/or additions to this file to: -+# bug-gdb@prep.ai.mit.edu -+ -+# This file was written by Jan Kratochvil -+ -+# This file is part of the gdb testsuite. -+ -+# -+# Tests for readline buffer overflow. -+# -+ -+if $tracelevel { -+ strace $tracelevel -+} -+ -+global env -+ -+save_vars { env(GDBHISTFILE) env(HISTSIZE) TERM timeout } { -+ # The arrow key test relies on the standard VT100 bindings, so -+ # make sure that an appropriate terminal is selected. The same -+ # bug doesn't show up if we use ^P / ^N instead. -+ setenv TERM vt100 -+ -+ set timeout 600 -+ -+ set env(GDBHISTFILE) "${srcdir}/${subdir}/gdb_history" -+ set env(HISTSIZE) "10" -+ -+ gdb_exit -+ gdb_start -+ gdb_reinitialize_dir $srcdir/$subdir -+ -+ -+ set width 11 -+ gdb_test "set width $width" \ -+ "" \ -+ "Setting width to $width." -+ #gdb_test "set height 1" \ -+ # "" \ -+ # "Setting height to 1." -+ send_gdb "run X" -+ set i 0 -+ # It crashes using `set width 7' on `set total 3560'. -+ # Sometimes it corrupts screen on `set width 7'. -+ # Bugreport used `set total 130001': -+ # https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214196 -+ # Check also `timeout' above. -+ set total 4200 -+ gdb_expect { -+ -re X { -+ incr i -+ if {$i <= $total} { -+ send_gdb "X" -+ exp_continue -+ } -+ } -+ -re "\[ \b\r\n\]" { -+ exp_continue -+ } -+ eof { -+ fail "gdb sending total $total characters" -+ note "Failed after sending $i characters, reason: EOF" -+ gdb_clear_suppressed -+ } -+ timeout { -+ fail "gdb sending total $total characters" -+ note "Failed after sending $i characters (timeout $timeout), reason: TIMEOUT" -+ gdb_clear_suppressed -+ } -+ default { -+ fail "gdb sending total $total characters" -+ note "Failed after sending $i characters, reason: 0=\[$expect_out(0,string)\] buffer=\[$expect_out(buffer)\]" -+ gdb_clear_suppressed -+ } -+ } -+ send_gdb "\r" -+ gdb_test "" \ -+ "No executable file specified..*" \ -+ "All the characters transferred" -+}