From d18c2a5bd9b894b58ed45ffc8c31fabff2c2b2f1 Mon Sep 17 00:00:00 2001 From: Bruno Larsen Date: Mon, 24 Apr 2023 15:48:54 +0200 Subject: [PATCH] Remove gdb-6.5-last-address-space-byte-test.patch This patch exercised an edge case for 32-bit systems in target_xfer_memory, a function that has been removed in 2006. The test that patch added has been irrelevant for some time. --- _gdb.spec.Patch.include | 104 ++++++++++----------- _gdb.spec.patch.include | 2 - _patch_order | 1 - gdb-6.5-last-address-space-byte-test.patch | 62 ------------ gdb.spec | 5 + 5 files changed, 55 insertions(+), 119 deletions(-) delete mode 100644 gdb-6.5-last-address-space-byte-test.patch diff --git a/_gdb.spec.Patch.include b/_gdb.spec.Patch.include index 5a3eb2c..6e0c915 100644 --- a/_gdb.spec.Patch.include +++ b/_gdb.spec.Patch.include @@ -19,198 +19,194 @@ Patch004: gdb-6.5-sharedlibrary-path.patch #=fedoratest: For upstream it should be rewritten as a dejagnu test, the test of no "??" was useful. Patch005: gdb-6.5-BEA-testsuite.patch -# Testcase for deadlocking on last address space byte; for corrupted backtraces. -#=fedoratest -Patch006: gdb-6.5-last-address-space-byte-test.patch - # Test sideeffects of skipping ppc .so libs trampolines (BZ 218379). #=fedoratest -Patch007: gdb-6.5-bz218379-ppc-solib-trampoline-test.patch +Patch006: gdb-6.5-bz218379-ppc-solib-trampoline-test.patch # Find symbols properly at their original (included) file (BZ 109921). #=fedoratest -Patch008: gdb-6.5-bz109921-DW_AT_decl_file-test.patch +Patch007: gdb-6.5-bz109921-DW_AT_decl_file-test.patch # Allow running `/usr/bin/gcore' with provided but inaccessible tty (BZ 229517). #=fedoratest -Patch009: gdb-6.6-bz229517-gcore-without-terminal.patch +Patch008: gdb-6.6-bz229517-gcore-without-terminal.patch # Avoid too long timeouts on failing cases of "annota1.exp annota3.exp". #=fedoratest -Patch010: gdb-6.6-testsuite-timeouts.patch +Patch009: gdb-6.6-testsuite-timeouts.patch # Support for stepping over PPC atomic instruction sequences (BZ 237572). #=fedoratest -Patch011: gdb-6.6-bz237572-ppc-atomic-sequence-test.patch +Patch010: gdb-6.6-bz237572-ppc-atomic-sequence-test.patch # Test kernel VDSO decoding while attaching to an i386 process. #=fedoratest -Patch012: gdb-6.3-attach-see-vdso-test.patch +Patch011: gdb-6.3-attach-see-vdso-test.patch # Test leftover zombie process (BZ 243845). #=fedoratest -Patch013: gdb-6.5-bz243845-stale-testing-zombie-test.patch +Patch012: gdb-6.5-bz243845-stale-testing-zombie-test.patch # New locating of the matching binaries from the pure core file (build-id). #=push+jan -Patch014: gdb-6.6-buildid-locate.patch +Patch013: gdb-6.6-buildid-locate.patch # Fix loading of core files without build-ids but with build-ids in executables. # Load strictly build-id-checked core files only if no executable is specified # (Jan Kratochvil, RH BZ 1339862). #=push+jan -Patch015: gdb-6.6-buildid-locate-solib-missing-ids.patch +Patch014: gdb-6.6-buildid-locate-solib-missing-ids.patch #=push+jan -Patch016: gdb-6.6-buildid-locate-rpm.patch +Patch015: gdb-6.6-buildid-locate-rpm.patch # Fix displaying of numeric char arrays as strings (BZ 224128). #=fedoratest: But it is failing anyway, one should check the behavior more. -Patch017: gdb-6.7-charsign-test.patch +Patch016: gdb-6.7-charsign-test.patch # Test PPC hiding of call-volatile parameter register. #=fedoratest -Patch018: gdb-6.7-ppc-clobbered-registers-O2-test.patch +Patch017: gdb-6.7-ppc-clobbered-registers-O2-test.patch # Testsuite fixes for more stable/comparable results. #=fedoratest -Patch019: gdb-6.7-testsuite-stable-results.patch +Patch018: gdb-6.7-testsuite-stable-results.patch # Test ia64 memory leaks of the code using libunwind. #=fedoratest -Patch020: gdb-6.5-ia64-libunwind-leak-test.patch +Patch019: gdb-6.5-ia64-libunwind-leak-test.patch # Test hiding unexpected breakpoints on intentional step commands. #=fedoratest -Patch021: gdb-6.5-missed-trap-on-step-test.patch +Patch020: gdb-6.5-missed-trap-on-step-test.patch # Test gcore memory and time requirements for large inferiors. #=fedoratest -Patch022: gdb-6.5-gcore-buffer-limit-test.patch +Patch021: gdb-6.5-gcore-buffer-limit-test.patch # Test GCORE for shmid 0 shared memory mappings. #=fedoratest: But it is broken anyway, sometimes the case being tested is not reproducible. -Patch023: gdb-6.3-mapping-zero-inode-test.patch +Patch022: gdb-6.3-mapping-zero-inode-test.patch # Test a crash on libraries missing the .text section. #=fedoratest -Patch024: gdb-6.5-section-num-fixup-test.patch +Patch023: gdb-6.5-section-num-fixup-test.patch # Fix resolving of variables at locations lists in prelinked libs (BZ 466901). #=fedoratest -Patch025: gdb-6.8-bz466901-backtrace-full-prelinked.patch +Patch024: gdb-6.8-bz466901-backtrace-full-prelinked.patch # New test for step-resume breakpoint placed in multiple threads at once. #=fedoratest -Patch026: gdb-simultaneous-step-resume-breakpoint-test.patch +Patch025: gdb-simultaneous-step-resume-breakpoint-test.patch # Fix GNU/Linux core open: Can't read pathname for load map: Input/output error. # Fix regression of undisplayed missing shared libraries caused by a fix for. #=fedoratest: It should be in glibc: libc-alpha: <20091004161706.GA27450@.*> -Patch027: gdb-core-open-vdso-warning.patch +Patch026: gdb-core-open-vdso-warning.patch # Workaround ccache making lineno non-zero for command-line definitions. #=fedoratest: ccache is rarely used and it is even fixed now. -Patch028: gdb-ccache-workaround.patch +Patch027: gdb-ccache-workaround.patch # Testcase for "Do not make up line information" fix by Daniel Jacobowitz. #=fedoratest -Patch029: gdb-lineno-makeup-test.patch +Patch028: gdb-lineno-makeup-test.patch # Test power7 ppc disassembly. #=fedoratest -Patch030: gdb-ppc-power7-test.patch +Patch029: gdb-ppc-power7-test.patch # Fix follow-exec for C++ programs (bugreported by Martin Stransky). #=fedoratest -Patch031: gdb-archer-next-over-throw-cxx-exec.patch +Patch030: gdb-archer-next-over-throw-cxx-exec.patch # Workaround librpm BZ 643031 due to its unexpected exit() calls (BZ 642879). #=push+jan -Patch032: gdb-6.6-buildid-locate-rpm-librpm-workaround.patch +Patch031: gdb-6.6-buildid-locate-rpm-librpm-workaround.patch # [delayed-symfile] Test a backtrace regression on CFIs without DIE (BZ 614604). #=fedoratest -Patch033: gdb-test-bt-cfi-without-die.patch +Patch032: gdb-test-bt-cfi-without-die.patch # Verify GDB Python built-in function gdb.solib_address exists (BZ # 634108). #=fedoratest -Patch034: gdb-bz634108-solib_address.patch +Patch033: gdb-bz634108-solib_address.patch # New test gdb.arch/x86_64-pid0-core.exp for kernel PID 0 cores (BZ 611435). #=fedoratest -Patch035: gdb-test-pid0-core.patch +Patch034: gdb-test-pid0-core.patch # [archer-tromey-delayed-symfile] New test gdb.dwarf2/dw2-aranges.exp. #=fedoratest -Patch036: gdb-test-dw2-aranges.patch +Patch035: gdb-test-dw2-aranges.patch # Workaround PR libc/14166 for inferior calls of strstr. #=fedoratest: Compatibility with RHELs (unchecked which ones). -Patch037: gdb-glibc-strstr-workaround.patch +Patch036: gdb-glibc-strstr-workaround.patch # Include testcase for `Unable to see a variable inside a module (XLF)' (BZ 823789). #=fedoratest -Patch038: gdb-rhel5.9-testcase-xlf-var-inside-mod.patch +Patch037: gdb-rhel5.9-testcase-xlf-var-inside-mod.patch # Testcase for `Setting solib-absolute-prefix breaks vDSO' (BZ 818343). #=fedoratest -Patch039: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch +Patch038: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch # Import regression test for `gdb/findvar.c:417: internal-error: # read_var_value: Assertion `frame' failed.' (RH BZ 947564) from RHEL 6.5. #=fedoratest -Patch040: gdb-rhbz947564-findvar-assertion-frame-failed-testcase.patch +Patch039: gdb-rhbz947564-findvar-assertion-frame-failed-testcase.patch # Fix 'memory leak in infpy_read_memory()' (RH BZ 1007614) #=fedoratest -Patch041: gdb-rhbz1007614-memleak-infpy_read_memory-test.patch +Patch040: gdb-rhbz1007614-memleak-infpy_read_memory-test.patch # Fix 'gdb gives highly misleading error when debuginfo pkg is present, # but not corresponding binary pkg' (RH BZ 981154). #=push+jan -Patch042: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch +Patch041: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch # Testcase for '[SAP] Recursive dlopen causes SAP HANA installer to # crash.' (RH BZ 1156192). #=fedoratest -Patch043: gdb-rhbz1156192-recursive-dlopen-test.patch +Patch042: gdb-rhbz1156192-recursive-dlopen-test.patch # Fix '`catch syscall' doesn't work for parent after `fork' is called' # (Philippe Waroquiers, RH BZ 1149205). #=fedoratest -Patch044: gdb-rhbz1149205-catch-syscall-after-fork-test.patch +Patch043: gdb-rhbz1149205-catch-syscall-after-fork-test.patch # Fix 'backport GDB 7.4 fix to RHEL 6.6 GDB' [Original Sourceware bug # description: 'C++ (and objc): Internal error on unqualified name # re-set', PR 11657] (RH BZ 1186476). #=fedoratest -Patch045: gdb-rhbz1186476-internal-error-unqualified-name-re-set-test.patch +Patch044: gdb-rhbz1186476-internal-error-unqualified-name-re-set-test.patch # Fix '[ppc64] and [s390x] wrong prologue skip on -O2 -g code' (Jan # Kratochvil, RH BZ 1084404). #=fedoratest -Patch046: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch +Patch045: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch # Force libncursesw over libncurses to match the includes (RH BZ 1270534). #=push+jan -Patch047: gdb-fedora-libncursesw.patch +Patch046: gdb-fedora-libncursesw.patch # Test clflushopt instruction decode (for RH BZ 1262471). #=fedoratest -Patch048: gdb-opcodes-clflushopt-test.patch +Patch047: gdb-opcodes-clflushopt-test.patch # [aarch64] Fix hardware watchpoints (RH BZ 1261564). #=fedoratest -Patch049: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch +Patch048: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch # Add messages suggesting more recent RHEL gdbserver (RH BZ 1321114). #=fedora -Patch050: gdb-container-rh-pkg.patch +Patch049: gdb-container-rh-pkg.patch # [dts+el7] [x86*] Bundle linux_perf.h for libipt (RH BZ 1256513). #=fedora -Patch051: gdb-linux_perf-bundle.patch +Patch050: gdb-linux_perf-bundle.patch # Fix gdb-headless /usr/bin/ executables (BZ 1390251). # @@ -219,20 +215,20 @@ Patch051: gdb-linux_perf-bundle.patch # # https://fedoraproject.org/wiki/Changes/Minimal_GDB_in_buildroot #=fedora -Patch052: gdb-libexec-add-index.patch +Patch051: gdb-libexec-add-index.patch # [s390x] Backport arch12 instructions decoding (RH BZ 1553104). # =fedoratest -Patch053: gdb-rhbz1553104-s390x-arch12-test.patch +Patch052: gdb-rhbz1553104-s390x-arch12-test.patch # [aarch64] Backport fix from Luis Machado for RH BZ 2177655. -Patch054: gdb-rhbz2177655-aarch64-pauth-valid-regcache.patch +Patch053: gdb-rhbz2177655-aarch64-pauth-valid-regcache.patch # Backport "Fix crash in inside_main_func" # (Tom Tromey, RHBZ 2183595) -Patch055: gdb-rhbz2183595-rustc-inside_main.patch +Patch054: gdb-rhbz2183595-rustc-inside_main.patch # Backport "Fix a potential illegal memory access in the BFD library..." # (Nick Clifton, binutils/29988) -Patch057: gdb-binutils29988-read_indexed_address.patch +Patch055: gdb-binutils29988-read_indexed_address.patch diff --git a/_gdb.spec.patch.include b/_gdb.spec.patch.include index c13c1cc..b72c412 100644 --- a/_gdb.spec.patch.include +++ b/_gdb.spec.patch.include @@ -53,5 +53,3 @@ %patch -p1 -P053 %patch -p1 -P054 %patch -p1 -P055 -%patch -p1 -P056 -%patch -p1 -P057 diff --git a/_patch_order b/_patch_order index cd98115..222c6fa 100644 --- a/_patch_order +++ b/_patch_order @@ -3,7 +3,6 @@ gdb-6.3-gstack-20050411.patch gdb-6.5-bz185337-resolve-tls-without-debuginfo-v2.patch gdb-6.5-sharedlibrary-path.patch gdb-6.5-BEA-testsuite.patch -gdb-6.5-last-address-space-byte-test.patch gdb-6.5-bz218379-ppc-solib-trampoline-test.patch gdb-6.5-bz109921-DW_AT_decl_file-test.patch gdb-6.6-bz229517-gcore-without-terminal.patch diff --git a/gdb-6.5-last-address-space-byte-test.patch b/gdb-6.5-last-address-space-byte-test.patch deleted file mode 100644 index e99d811..0000000 --- a/gdb-6.5-last-address-space-byte-test.patch +++ /dev/null @@ -1,62 +0,0 @@ -From FEDORA_PATCHES Mon Sep 17 00:00:00 2001 -From: Fedora GDB patches -Date: Fri, 27 Oct 2017 21:07:50 +0200 -Subject: gdb-6.5-last-address-space-byte-test.patch - -;; Testcase for deadlocking on last address space byte; for corrupted backtraces. -;;=fedoratest - -diff --git a/gdb/testsuite/gdb.base/largecore-last-address-lock.exp b/gdb/testsuite/gdb.base/largecore-last-address-lock.exp -new file mode 100644 ---- /dev/null -+++ b/gdb/testsuite/gdb.base/largecore-last-address-lock.exp -@@ -0,0 +1,49 @@ -+# Copyright 2006 Free Software Foundation, Inc. -+ -+# This program is free software; you can redistribute it and/or modify -+# it under the terms of the GNU General Public License as published by -+# the Free Software Foundation; either version 2 of the License, or -+# (at your option) any later version. -+# -+# This program is distributed in the hope that it will be useful, -+# but WITHOUT ANY WARRANTY; without even the implied warranty of -+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -+# GNU General Public License for more details. -+# -+# You should have received a copy of the GNU General Public License -+# along with this program; if not, write to the Free Software -+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. -+ -+if $tracelevel then { -+ strace $tracelevel -+} -+ -+# Get things started. -+ -+gdb_exit -+gdb_start -+ -+# i386 (32-bit) only: gdb with Red Hat largecore patch did lock up: -+# https://enterprise.redhat.com/issue-tracker/?module=issues&action=view&tid=103263 -+# https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210614 -+ -+# i386: Bug exists when the `target_xfer_memory' condition -+# `(memaddr + len < region->hi)' operates on 64-bit operands on -+# largecore-patched with 32-bit addresses and so it can get `false' with -+# arbitrary `len'. -+ -+# x86_64: The bug is not present as the operands and calculations have the same -+# bit size. Would would still need to pass there the highest address -+# (`memaddr == 0xffffffffffffffff') but we would need to pass `len == 0' -+# to make the condition `(memaddr + len < region->hi)' false. -+# `len == 0' would get caught eariler. -+ -+# Error in the success case is immediate. -+set timeoutold ${timeout} -+set timeout 10 -+ -+gdb_test "x/xb 0xffffffff" \ -+ "Cannot access memory at address 0xffffffff" \ -+ "Read the last address space byte" -+ -+set timeout ${timeoutold} diff --git a/gdb.spec b/gdb.spec index d44d55a..eb3b904 100644 --- a/gdb.spec +++ b/gdb.spec @@ -1249,6 +1249,11 @@ fi %endif %changelog +* Mon Apr 24 2023 Bruno Larsen +- Remove gdb-6.5-last-address-space-byte-test.patch. It was used to + test for a regression in target_xfer_memory, a function that has + been removed from upstream back in 2006. + * Thu Apr 13 2023 Alexandra Hájková - Remove gdb-6.3-bz140532-ppc-unwinding-test.patch, it adds powerpc-bcl-prologue.exp test which seems to be a subset of