- Fix `errno' resolving on glibc with broken DW_AT_MIPS_linkage_name.
- Imported 6.7 PPC hiding of call-volatile parameter registers.
This commit is contained in:
parent
a2e23a1b95
commit
bf98f1521f
@ -1,7 +1,7 @@
|
|||||||
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185337
|
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185337
|
||||||
|
|
||||||
|
|
||||||
currently for trivia nonthreaded helloworld with no debug info up to -ggdb2 you
|
currently for trivial nonthreaded helloworld with no debug info up to -ggdb2 you
|
||||||
will get:
|
will get:
|
||||||
(gdb) p errno
|
(gdb) p errno
|
||||||
[some error]
|
[some error]
|
||||||
@ -17,17 +17,155 @@ Attached suggestion patch how to deal with the most common "errno" symbol
|
|||||||
for the most common under-ggdb3 compiled programs.
|
for the most common under-ggdb3 compiled programs.
|
||||||
|
|
||||||
|
|
||||||
2006-08-25 Jan Kratochvil <jan.kratochvil@redhat.com>
|
|
||||||
|
|
||||||
* target.c (target_translate_tls_address): Provided warnings for TLS
|
2007-11-03 Jan Kratochvil <jan.kratochvil@redhat.com>
|
||||||
`errno' on non-TLS targets.
|
|
||||||
|
* ./gdb/dwarf2read.c (read_partial_die, dwarf2_linkage_name): Prefer
|
||||||
|
DW_AT_MIPS_linkage_name over DW_AT_name now only for non-C.
|
||||||
|
|
||||||
|
glibc-debuginfo-2.7-2.x86_64: /usr/lib/debug/lib64/libc.so.6.debug:
|
||||||
|
<81a2> DW_AT_name : (indirect string, offset: 0x280e): __errno_location
|
||||||
|
<81a8> DW_AT_MIPS_linkage_name: (indirect string, offset: 0x2808): *__GI___errno_location
|
||||||
|
|
||||||
|
--- ./gdb/dwarf2read.c 25 Oct 2007 20:54:27 -0000 1.236
|
||||||
|
+++ ./gdb/dwarf2read.c 3 Nov 2007 21:03:43 -0000
|
||||||
|
@@ -5550,8 +5550,8 @@ read_partial_die (struct partial_die_inf
|
||||||
|
{
|
||||||
|
case DW_AT_name:
|
||||||
|
|
||||||
|
- /* Prefer DW_AT_MIPS_linkage_name over DW_AT_name. */
|
||||||
|
- if (part_die->name == NULL)
|
||||||
|
+ /* Prefer DW_AT_MIPS_linkage_name over DW_AT_name for non-C. */
|
||||||
|
+ if (cu->language == language_c || part_die->name == NULL)
|
||||||
|
part_die->name = DW_STRING (&attr);
|
||||||
|
break;
|
||||||
|
case DW_AT_comp_dir:
|
||||||
|
@@ -5559,7 +5559,9 @@ read_partial_die (struct partial_die_inf
|
||||||
|
part_die->dirname = DW_STRING (&attr);
|
||||||
|
break;
|
||||||
|
case DW_AT_MIPS_linkage_name:
|
||||||
|
- part_die->name = DW_STRING (&attr);
|
||||||
|
+ /* Prefer DW_AT_MIPS_linkage_name over DW_AT_name for non-C. */
|
||||||
|
+ if (cu->language != language_c || part_die->name == NULL)
|
||||||
|
+ part_die->name = DW_STRING (&attr);
|
||||||
|
break;
|
||||||
|
case DW_AT_low_pc:
|
||||||
|
has_low_pc_attr = 1;
|
||||||
|
@@ -7871,9 +7873,13 @@ dwarf2_linkage_name (struct die_info *di
|
||||||
|
{
|
||||||
|
struct attribute *attr;
|
||||||
|
|
||||||
|
- attr = dwarf2_attr (die, DW_AT_MIPS_linkage_name, cu);
|
||||||
|
- if (attr && DW_STRING (attr))
|
||||||
|
- return DW_STRING (attr);
|
||||||
|
+ /* Prefer DW_AT_MIPS_linkage_name over DW_AT_name for non-C. */
|
||||||
|
+ if (cu->language != language_c)
|
||||||
|
+ {
|
||||||
|
+ attr = dwarf2_attr (die, DW_AT_MIPS_linkage_name, cu);
|
||||||
|
+ if (attr && DW_STRING (attr))
|
||||||
|
+ return DW_STRING (attr);
|
||||||
|
+ }
|
||||||
|
attr = dwarf2_attr (die, DW_AT_name, cu);
|
||||||
|
if (attr && DW_STRING (attr))
|
||||||
|
return DW_STRING (attr);
|
||||||
|
|
||||||
|
|
||||||
Index: gdb-6.6/gdb/target.c
|
|
||||||
===================================================================
|
diff -u -X /home/jkratoch/.diffi.list -rup gdb-6.6-orig/gdb/gdbtypes.c gdb-6.6/gdb/gdbtypes.c
|
||||||
--- gdb-6.6.orig/gdb/target.c 2007-01-17 01:25:31.000000000 +0100
|
--- gdb-6.6-orig/gdb/gdbtypes.c 2006-08-22 21:45:12.000000000 +0200
|
||||||
+++ gdb-6.6/gdb/target.c 2007-01-20 06:31:36.000000000 +0100
|
+++ gdb-6.6/gdb/gdbtypes.c 2007-11-08 22:23:37.000000000 +0100
|
||||||
@@ -898,7 +898,18 @@
|
@@ -49,6 +49,7 @@ struct type *builtin_type_char;
|
||||||
|
struct type *builtin_type_true_char;
|
||||||
|
struct type *builtin_type_short;
|
||||||
|
struct type *builtin_type_int;
|
||||||
|
+struct type *builtin_type_int_ptr;
|
||||||
|
struct type *builtin_type_long;
|
||||||
|
struct type *builtin_type_long_long;
|
||||||
|
struct type *builtin_type_signed_char;
|
||||||
|
@@ -3330,6 +3331,7 @@ build_gdbtypes (void)
|
||||||
|
init_type (TYPE_CODE_INT, TARGET_INT_BIT / TARGET_CHAR_BIT,
|
||||||
|
0,
|
||||||
|
"int", (struct objfile *) NULL);
|
||||||
|
+ builtin_type_int_ptr = make_pointer_type (builtin_type_int, NULL);
|
||||||
|
builtin_type_unsigned_int =
|
||||||
|
init_type (TYPE_CODE_INT, TARGET_INT_BIT / TARGET_CHAR_BIT,
|
||||||
|
TYPE_FLAG_UNSIGNED,
|
||||||
|
diff -u -X /home/jkratoch/.diffi.list -rup gdb-6.6-orig/gdb/gdbtypes.h gdb-6.6/gdb/gdbtypes.h
|
||||||
|
--- gdb-6.6-orig/gdb/gdbtypes.h 2007-11-08 22:07:59.000000000 +0100
|
||||||
|
+++ gdb-6.6/gdb/gdbtypes.h 2007-11-08 22:24:49.000000000 +0100
|
||||||
|
@@ -1024,6 +1024,7 @@ extern struct type *builtin_type_void;
|
||||||
|
extern struct type *builtin_type_char;
|
||||||
|
extern struct type *builtin_type_short;
|
||||||
|
extern struct type *builtin_type_int;
|
||||||
|
+extern struct type *builtin_type_int_ptr;
|
||||||
|
extern struct type *builtin_type_long;
|
||||||
|
extern struct type *builtin_type_signed_char;
|
||||||
|
extern struct type *builtin_type_unsigned_char;
|
||||||
|
diff -u -X /home/jkratoch/.diffi.list -rup gdb-6.6-orig/gdb/parse.c gdb-6.6/gdb/parse.c
|
||||||
|
--- gdb-6.6-orig/gdb/parse.c 2006-11-22 01:05:37.000000000 +0100
|
||||||
|
+++ gdb-6.6/gdb/parse.c 2007-11-08 22:22:42.000000000 +0100
|
||||||
|
@@ -386,6 +386,7 @@ write_exp_bitstring (struct stoken str)
|
||||||
|
the initial rationale is gone. */
|
||||||
|
|
||||||
|
static struct type *msym_text_symbol_type;
|
||||||
|
+static struct type *msym_text_symbol_errno_location_type;
|
||||||
|
static struct type *msym_data_symbol_type;
|
||||||
|
static struct type *msym_unknown_symbol_type;
|
||||||
|
static struct type *msym_tls_symbol_type;
|
||||||
|
@@ -431,7 +432,11 @@ write_exp_msymbol (struct minimal_symbol
|
||||||
|
case mst_text:
|
||||||
|
case mst_file_text:
|
||||||
|
case mst_solib_trampoline:
|
||||||
|
- write_exp_elt_type (msym_text_symbol_type);
|
||||||
|
+ if (msym_text_symbol_errno_location_type != NULL
|
||||||
|
+ && strcmp (SYMBOL_LINKAGE_NAME (msymbol), "__errno_location") == 0)
|
||||||
|
+ write_exp_elt_type (msym_text_symbol_errno_location_type);
|
||||||
|
+ else
|
||||||
|
+ write_exp_elt_type (msym_text_symbol_type);
|
||||||
|
break;
|
||||||
|
|
||||||
|
case mst_data:
|
||||||
|
@@ -1367,6 +1372,10 @@ build_parse (void)
|
||||||
|
msym_text_symbol_type =
|
||||||
|
init_type (TYPE_CODE_FUNC, 1, 0, "<text variable, no debug info>", NULL);
|
||||||
|
TYPE_TARGET_TYPE (msym_text_symbol_type) = builtin_type_int;
|
||||||
|
+ msym_text_symbol_errno_location_type =
|
||||||
|
+ init_type (TYPE_CODE_FUNC,
|
||||||
|
+ 1, 0, "<text variable for __errno_location, no debug info>", NULL);
|
||||||
|
+ TYPE_TARGET_TYPE (msym_text_symbol_errno_location_type ) = builtin_type_int_ptr;
|
||||||
|
msym_data_symbol_type =
|
||||||
|
init_type (TYPE_CODE_INT, TARGET_INT_BIT / HOST_CHAR_BIT, 0,
|
||||||
|
"<data variable, no debug info>", NULL);
|
||||||
|
diff -u -X /home/jkratoch/.diffi.list -rup gdb-6.6-orig/gdb/target.c gdb-6.6/gdb/target.c
|
||||||
|
--- gdb-6.6-orig/gdb/target.c 2007-11-08 22:07:59.000000000 +0100
|
||||||
|
+++ gdb-6.6/gdb/target.c 2007-11-08 22:35:34.000000000 +0100
|
||||||
|
@@ -817,6 +817,25 @@ pop_target (void)
|
||||||
|
internal_error (__FILE__, __LINE__, _("failed internal consistency check"));
|
||||||
|
}
|
||||||
|
|
||||||
|
+static int
|
||||||
|
+resolve_errno (void *arg)
|
||||||
|
+{
|
||||||
|
+ CORE_ADDR *arg_addr = arg;
|
||||||
|
+ struct expression *expr;
|
||||||
|
+ struct cleanup *old_chain = 0;
|
||||||
|
+ struct value *val;
|
||||||
|
+
|
||||||
|
+ expr = parse_expression ("__errno_location()");
|
||||||
|
+ old_chain = make_cleanup (free_current_contents, &expr);
|
||||||
|
+ val = evaluate_expression (expr);
|
||||||
|
+ *arg_addr = value_as_address (val);
|
||||||
|
+ release_value (val);
|
||||||
|
+ value_free (val);
|
||||||
|
+ do_cleanups (old_chain);
|
||||||
|
+
|
||||||
|
+ return 1;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
/* Using the objfile specified in BATON, find the address for the
|
||||||
|
current thread's thread-local storage with offset OFFSET. */
|
||||||
|
CORE_ADDR
|
||||||
|
@@ -904,7 +923,28 @@ target_translate_tls_address (struct obj
|
||||||
/* It wouldn't be wrong here to try a gdbarch method, too; finding
|
/* It wouldn't be wrong here to try a gdbarch method, too; finding
|
||||||
TLS is an ABI-specific thing. But we don't do that yet. */
|
TLS is an ABI-specific thing. But we don't do that yet. */
|
||||||
else
|
else
|
||||||
@ -38,12 +176,125 @@ Index: gdb-6.6/gdb/target.c
|
|||||||
+ msymbol = lookup_minimal_symbol ("errno", NULL, NULL);
|
+ msymbol = lookup_minimal_symbol ("errno", NULL, NULL);
|
||||||
+ if (msymbol != NULL
|
+ if (msymbol != NULL
|
||||||
+ && SYMBOL_VALUE_ADDRESS (msymbol) == offset
|
+ && SYMBOL_VALUE_ADDRESS (msymbol) == offset
|
||||||
+ && SYMBOL_BFD_SECTION (msymbol)->owner == objfile->obfd)
|
+ && (SYMBOL_BFD_SECTION (msymbol)->owner == objfile->obfd
|
||||||
+ error (_("TLS symbol `errno' not resolved for non-TLS program."
|
+ || (objfile->separate_debug_objfile != NULL
|
||||||
+ " You should use symbol \"(*__errno_location ())\" or"
|
+ && SYMBOL_BFD_SECTION (msymbol)->owner
|
||||||
+ " compile the program with `gcc -ggdb3' or `gcc -pthread'."));
|
+ == objfile->separate_debug_objfile->obfd)
|
||||||
+ error (_("Cannot find thread-local variables on this target"));
|
+ || (objfile->separate_debug_objfile_backlink != NULL
|
||||||
|
+ && SYMBOL_BFD_SECTION (msymbol)->owner
|
||||||
|
+ == objfile->separate_debug_objfile_backlink->obfd)))
|
||||||
|
+ {
|
||||||
|
+ if (!catch_errors (resolve_errno, (void *) &addr, "",
|
||||||
|
+ RETURN_MASK_ALL))
|
||||||
|
+ error (_("TLS symbol `errno' not resolved for non-TLS program."
|
||||||
|
+ " You should compile the program with `gcc -pthread'."));
|
||||||
|
+ }
|
||||||
|
+ else
|
||||||
|
+ error (_("Cannot find thread-local variables on this target"));
|
||||||
+ }
|
+ }
|
||||||
|
|
||||||
return addr;
|
return addr;
|
||||||
}
|
}
|
||||||
|
diff -u -X /home/jkratoch/.diffi.list -rup gdb-6.7.1/gdb/testsuite/gdb.dwarf2/dw2-errno.c gdb-6.7.1-patched/gdb/testsuite/gdb.dwarf2/dw2-errno.c
|
||||||
|
--- gdb-6.7.1/gdb/testsuite/gdb.dwarf2/dw2-errno.c 2007-11-04 01:43:41.000000000 +0100
|
||||||
|
+++ gdb-6.7.1-patched/gdb/testsuite/gdb.dwarf2/dw2-errno.c 2007-11-03 23:29:02.000000000 +0100
|
||||||
|
@@ -0,0 +1,28 @@
|
||||||
|
+/* This testcase is part of GDB, the GNU debugger.
|
||||||
|
+
|
||||||
|
+ Copyright 2005, 2007 Free Software Foundation, Inc.
|
||||||
|
+
|
||||||
|
+ This program is free software; you can redistribute it and/or modify
|
||||||
|
+ it under the terms of the GNU General Public License as published by
|
||||||
|
+ the Free Software Foundation; either version 3 of the License, or
|
||||||
|
+ (at your option) any later version.
|
||||||
|
+
|
||||||
|
+ This program is distributed in the hope that it will be useful,
|
||||||
|
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
+ GNU General Public License for more details.
|
||||||
|
+
|
||||||
|
+ You should have received a copy of the GNU General Public License
|
||||||
|
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||||
|
+
|
||||||
|
+ Please email any bugs, comments, and/or additions to this file to:
|
||||||
|
+ bug-gdb@prep.ai.mit.edu */
|
||||||
|
+
|
||||||
|
+#include <errno.h>
|
||||||
|
+
|
||||||
|
+int main()
|
||||||
|
+{
|
||||||
|
+ errno = 42;
|
||||||
|
+
|
||||||
|
+ return 0; /* breakpoint */
|
||||||
|
+}
|
||||||
|
diff -u -X /home/jkratoch/.diffi.list -rup gdb-6.7.1/gdb/testsuite/gdb.dwarf2/dw2-errno.exp gdb-6.7.1-patched/gdb/testsuite/gdb.dwarf2/dw2-errno.exp
|
||||||
|
--- gdb-6.7.1/gdb/testsuite/gdb.dwarf2/dw2-errno.exp 2007-11-04 01:43:39.000000000 +0100
|
||||||
|
+++ gdb-6.7.1-patched/gdb/testsuite/gdb.dwarf2/dw2-errno.exp 2007-11-04 01:41:46.000000000 +0100
|
||||||
|
@@ -0,0 +1,67 @@
|
||||||
|
+# Copyright 2007 Free Software Foundation, Inc.
|
||||||
|
+
|
||||||
|
+# This program is free software; you can redistribute it and/or modify
|
||||||
|
+# it under the terms of the GNU General Public License as published by
|
||||||
|
+# the Free Software Foundation; either version 3 of the License, or
|
||||||
|
+# (at your option) any later version.
|
||||||
|
+#
|
||||||
|
+# This program is distributed in the hope that it will be useful,
|
||||||
|
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
+# GNU General Public License for more details.
|
||||||
|
+#
|
||||||
|
+# You should have received a copy of the GNU General Public License
|
||||||
|
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||||
|
+
|
||||||
|
+if $tracelevel then {
|
||||||
|
+ strace $tracelevel
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+set prms_id 0
|
||||||
|
+set bug_id 0
|
||||||
|
+
|
||||||
|
+set testfile dw2-errno
|
||||||
|
+set srcfile ${testfile}.c
|
||||||
|
+set binfile ${objdir}/${subdir}/${testfile}
|
||||||
|
+
|
||||||
|
+proc prep {} {
|
||||||
|
+ global srcdir subdir binfile
|
||||||
|
+ gdb_exit
|
||||||
|
+ gdb_start
|
||||||
|
+ gdb_reinitialize_dir $srcdir/$subdir
|
||||||
|
+ gdb_load ${binfile}
|
||||||
|
+
|
||||||
|
+ runto_main
|
||||||
|
+
|
||||||
|
+ gdb_breakpoint [gdb_get_line_number "breakpoint"]
|
||||||
|
+ gdb_continue_to_breakpoint "breakpoint"
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable "additional_flags=-g2"] != "" } {
|
||||||
|
+ untested "Couldn't compile test program"
|
||||||
|
+ return -1
|
||||||
|
+}
|
||||||
|
+prep
|
||||||
|
+gdb_test "print errno" ".* = 42" "errno with macros=N threads=N"
|
||||||
|
+
|
||||||
|
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable "additional_flags=-g3"] != "" } {
|
||||||
|
+ untested "Couldn't compile test program"
|
||||||
|
+ return -1
|
||||||
|
+}
|
||||||
|
+prep
|
||||||
|
+gdb_test "print errno" ".* = 42" "errno with macros=Y threads=N"
|
||||||
|
+
|
||||||
|
+if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable "additional_flags=-g2"] != "" } {
|
||||||
|
+ return -1
|
||||||
|
+}
|
||||||
|
+prep
|
||||||
|
+gdb_test "print errno" ".* = 42" "errno with macros=N threads=Y"
|
||||||
|
+
|
||||||
|
+if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable "additional_flags=-g3"] != "" } {
|
||||||
|
+ return -1
|
||||||
|
+}
|
||||||
|
+prep
|
||||||
|
+gdb_test "print errno" ".* = 42" "errno with macros=Y threads=Y"
|
||||||
|
+
|
||||||
|
+# TODO: Test the error on resolving ERRNO with only libc loaded.
|
||||||
|
+# Just how to find the current libc filename?
|
||||||
|
92
gdb-6.7-ppc-clobbered-registers-O2-fix.patch
Normal file
92
gdb-6.7-ppc-clobbered-registers-O2-fix.patch
Normal file
@ -0,0 +1,92 @@
|
|||||||
|
2007-10-21 Luis Machado <luisgpm@br.ibm.com>
|
||||||
|
|
||||||
|
* rs6000-tdep.c (ppc_dwarf2_frame_init_reg): New function.
|
||||||
|
* (rs6000_gdbarch_init): Install ppc_dwarf2_frame_init_reg as
|
||||||
|
default dwarf2_frame_set_init_reg function.
|
||||||
|
|
||||||
|
===================================================================
|
||||||
|
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
|
||||||
|
retrieving revision 1.292
|
||||||
|
retrieving revision 1.293
|
||||||
|
diff -u -r1.292 -r1.293
|
||||||
|
--- src/gdb/rs6000-tdep.c 2007/10/19 12:26:34 1.292
|
||||||
|
+++ src/gdb/rs6000-tdep.c 2007/10/21 20:04:47 1.293
|
||||||
|
@@ -2947,6 +2947,68 @@
|
||||||
|
return &rs6000_frame_base;
|
||||||
|
}
|
||||||
|
|
||||||
|
+/* DWARF-2 frame support. Used to handle the detection of
|
||||||
|
+ clobbered registers during function calls. */
|
||||||
|
+
|
||||||
|
+static void
|
||||||
|
+ppc_dwarf2_frame_init_reg (struct gdbarch *gdbarch, int regnum,
|
||||||
|
+ struct dwarf2_frame_state_reg *reg,
|
||||||
|
+ struct frame_info *next_frame)
|
||||||
|
+{
|
||||||
|
+ struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
|
||||||
|
+
|
||||||
|
+ /* PPC32 and PPC64 ABI's are the same regarding volatile and
|
||||||
|
+ non-volatile registers. We will use the same code for both. */
|
||||||
|
+
|
||||||
|
+ /* Call-saved GP registers. */
|
||||||
|
+ if ((regnum >= tdep->ppc_gp0_regnum + 14
|
||||||
|
+ && regnum <= tdep->ppc_gp0_regnum + 31)
|
||||||
|
+ || (regnum == tdep->ppc_gp0_regnum + 1))
|
||||||
|
+ reg->how = DWARF2_FRAME_REG_SAME_VALUE;
|
||||||
|
+
|
||||||
|
+ /* Call-clobbered GP registers. */
|
||||||
|
+ if ((regnum >= tdep->ppc_gp0_regnum + 3
|
||||||
|
+ && regnum <= tdep->ppc_gp0_regnum + 12)
|
||||||
|
+ || (regnum == tdep->ppc_gp0_regnum))
|
||||||
|
+ reg->how = DWARF2_FRAME_REG_UNDEFINED;
|
||||||
|
+
|
||||||
|
+ /* Deal with FP registers, if supported. */
|
||||||
|
+ if (tdep->ppc_fp0_regnum >= 0)
|
||||||
|
+ {
|
||||||
|
+ /* Call-saved FP registers. */
|
||||||
|
+ if ((regnum >= tdep->ppc_fp0_regnum + 14
|
||||||
|
+ && regnum <= tdep->ppc_fp0_regnum + 31))
|
||||||
|
+ reg->how = DWARF2_FRAME_REG_SAME_VALUE;
|
||||||
|
+
|
||||||
|
+ /* Call-clobbered FP registers. */
|
||||||
|
+ if ((regnum >= tdep->ppc_fp0_regnum
|
||||||
|
+ && regnum <= tdep->ppc_fp0_regnum + 13))
|
||||||
|
+ reg->how = DWARF2_FRAME_REG_UNDEFINED;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ /* Deal with ALTIVEC registers, if supported. */
|
||||||
|
+ if (tdep->ppc_vr0_regnum > 0 && tdep->ppc_vrsave_regnum > 0)
|
||||||
|
+ {
|
||||||
|
+ /* Call-saved Altivec registers. */
|
||||||
|
+ if ((regnum >= tdep->ppc_vr0_regnum + 20
|
||||||
|
+ && regnum <= tdep->ppc_vr0_regnum + 31)
|
||||||
|
+ || regnum == tdep->ppc_vrsave_regnum)
|
||||||
|
+ reg->how = DWARF2_FRAME_REG_SAME_VALUE;
|
||||||
|
+
|
||||||
|
+ /* Call-clobbered Altivec registers. */
|
||||||
|
+ if ((regnum >= tdep->ppc_vr0_regnum
|
||||||
|
+ && regnum <= tdep->ppc_vr0_regnum + 19))
|
||||||
|
+ reg->how = DWARF2_FRAME_REG_UNDEFINED;
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
+ /* Handle PC register and Stack Pointer correctly. */
|
||||||
|
+ if (regnum == gdbarch_pc_regnum (current_gdbarch))
|
||||||
|
+ reg->how = DWARF2_FRAME_REG_RA;
|
||||||
|
+ else if (regnum == gdbarch_sp_regnum (current_gdbarch))
|
||||||
|
+ reg->how = DWARF2_FRAME_REG_CFA;
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+
|
||||||
|
/* Initialize the current architecture based on INFO. If possible, re-use an
|
||||||
|
architecture from ARCHES, which is a list of architectures already created
|
||||||
|
during this debugging session.
|
||||||
|
@@ -3410,6 +3472,9 @@
|
||||||
|
frame_unwind_append_sniffer (gdbarch, dwarf2_frame_sniffer);
|
||||||
|
dwarf2_frame_set_adjust_regnum (gdbarch, rs6000_adjust_frame_regnum);
|
||||||
|
|
||||||
|
+ /* Frame handling. */
|
||||||
|
+ dwarf2_frame_set_init_reg (gdbarch, ppc_dwarf2_frame_init_reg);
|
||||||
|
+
|
||||||
|
/* Hook in ABI-specific overrides, if they have been registered. */
|
||||||
|
gdbarch_init_osabi (info, gdbarch);
|
||||||
|
|
103
gdb-6.7-ppc-clobbered-registers-O2-test.patch
Normal file
103
gdb-6.7-ppc-clobbered-registers-O2-test.patch
Normal file
@ -0,0 +1,103 @@
|
|||||||
|
2007-11-04 Jan Kratochvil <jan.kratochvil@redhat.com>
|
||||||
|
|
||||||
|
* gdb.arch/ppc-clobbered-registers-O2.exp: `powerpc64' changed to
|
||||||
|
`powerpc*'.
|
||||||
|
|
||||||
|
Testcase for:
|
||||||
|
|
||||||
|
http://sourceware.org/ml/gdb-patches/2007-09/msg00228.html
|
||||||
|
|
||||||
|
2007-10-21 Luis Machado <luisgpm@br.ibm.com>
|
||||||
|
|
||||||
|
* rs6000-tdep.c (ppc_dwarf2_frame_init_reg): New function.
|
||||||
|
* (rs6000_gdbarch_init): Install ppc_dwarf2_frame_init_reg as
|
||||||
|
default dwarf2_frame_set_init_reg function.
|
||||||
|
|
||||||
|
--- /dev/null 1 Jan 1970 00:00:00 -0000
|
||||||
|
+++ ./gdb/testsuite/gdb.arch/ppc-clobbered-registers-O2.c 3 Nov 2007 22:22:28 -0000
|
||||||
|
@@ -0,0 +1,21 @@
|
||||||
|
+
|
||||||
|
+unsigned * __attribute__((noinline))
|
||||||
|
+start_sequence (unsigned * x, unsigned * y)
|
||||||
|
+{
|
||||||
|
+ return (unsigned *)0xdeadbeef;
|
||||||
|
+};
|
||||||
|
+
|
||||||
|
+unsigned __attribute__((noinline))
|
||||||
|
+gen_movsd (unsigned * operand0, unsigned * operand1)
|
||||||
|
+{
|
||||||
|
+ return *start_sequence(operand0, operand1);
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+int main(void)
|
||||||
|
+{
|
||||||
|
+ unsigned x, y;
|
||||||
|
+
|
||||||
|
+ x = 13;
|
||||||
|
+ y = 14;
|
||||||
|
+ return (int)gen_movsd (&x, &y);
|
||||||
|
+}
|
||||||
|
--- /dev/null 1 Jan 1970 00:00:00 -0000
|
||||||
|
+++ ./gdb/testsuite/gdb.arch/ppc-clobbered-registers-O2.exp 3 Nov 2007 22:22:28 -0000
|
||||||
|
@@ -0,0 +1,61 @@
|
||||||
|
+# Copyright 2006 Free Software Foundation, Inc.
|
||||||
|
+#
|
||||||
|
+# This program is free software; you can redistribute it and/or modify
|
||||||
|
+# it under the terms of the GNU General Public License as published by
|
||||||
|
+# the Free Software Foundation; either version 2 of the License, or
|
||||||
|
+# (at your option) any later version.
|
||||||
|
+#
|
||||||
|
+# This program is distributed in the hope that it will be useful,
|
||||||
|
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||||
|
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||||
|
+# GNU General Public License for more details.
|
||||||
|
+#
|
||||||
|
+# You should have received a copy of the GNU General Public License
|
||||||
|
+# along with this program; if not, write to the Free Software
|
||||||
|
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
|
||||||
|
+#
|
||||||
|
+# This file is part of the gdb testsuite.
|
||||||
|
+
|
||||||
|
+if $tracelevel {
|
||||||
|
+ strace $tracelevel
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+# Test displaying call clobbered registers in optimized binaries for ppc.
|
||||||
|
+# GDB should not show incorrect values.
|
||||||
|
+
|
||||||
|
+set prms_id 0
|
||||||
|
+set bug_id 0
|
||||||
|
+
|
||||||
|
+if ![istarget "powerpc*-*"] then {
|
||||||
|
+ verbose "Skipping powerpc* call clobbered registers testing."
|
||||||
|
+ return
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+set testfile "ppc-clobbered-registers-O2"
|
||||||
|
+set srcfile ${testfile}.c
|
||||||
|
+set binfile ${objdir}/${subdir}/${testfile}
|
||||||
|
+set compile_flags "debug additional_flags=-O2"
|
||||||
|
+
|
||||||
|
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable ${compile_flags}] != "" } {
|
||||||
|
+ unsupported "Testcase compile failed."
|
||||||
|
+ return -1
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+gdb_exit
|
||||||
|
+gdb_start
|
||||||
|
+gdb_reinitialize_dir $srcdir/$subdir
|
||||||
|
+gdb_load ${binfile}
|
||||||
|
+
|
||||||
|
+if ![runto_main] then {
|
||||||
|
+ perror "Couldn't run to breakpoint"
|
||||||
|
+ continue
|
||||||
|
+}
|
||||||
|
+
|
||||||
|
+gdb_test "b start_sequence" ".*Breakpoint 2 at.*line 6.*" \
|
||||||
|
+ "Insert breakpoint at problematic function"
|
||||||
|
+
|
||||||
|
+gdb_test continue ".*Breakpoint 2.*in start_sequence.*" \
|
||||||
|
+ "Run until problematic function"
|
||||||
|
+
|
||||||
|
+gdb_test backtrace ".*operand0=<value optimized out>.*operand1=<value optimized out>.*" \
|
||||||
|
+ "Check value of call clobbered registers"
|
13
gdb.spec
13
gdb.spec
@ -11,7 +11,7 @@ Name: gdb
|
|||||||
Version: 6.6
|
Version: 6.6
|
||||||
|
|
||||||
# The release always contains a leading reserved number, start it at 1.
|
# The release always contains a leading reserved number, start it at 1.
|
||||||
Release: 35%{?dist}
|
Release: 36%{?dist}
|
||||||
|
|
||||||
License: GPL
|
License: GPL
|
||||||
Group: Development/Debuggers
|
Group: Development/Debuggers
|
||||||
@ -229,7 +229,6 @@ Patch190: gdb-6.5-dwarf-stack-overflow.patch
|
|||||||
Patch191: gdb-6.5-bz205551-printf-p.patch
|
Patch191: gdb-6.5-bz205551-printf-p.patch
|
||||||
|
|
||||||
# Support TLS symbols (+`errno' suggestion if no pthread is found) (BZ 185337).
|
# Support TLS symbols (+`errno' suggestion if no pthread is found) (BZ 185337).
|
||||||
# FIXME: Still to be updated.
|
|
||||||
Patch194: gdb-6.5-bz185337-resolve-tls-without-debuginfo-v2.patch
|
Patch194: gdb-6.5-bz185337-resolve-tls-without-debuginfo-v2.patch
|
||||||
|
|
||||||
# Fix TLS symbols resolving for objects with separate .debug file (-debuginfo).
|
# Fix TLS symbols resolving for objects with separate .debug file (-debuginfo).
|
||||||
@ -386,6 +385,10 @@ Patch278: gdb-6.6-cu-ranges.patch
|
|||||||
# Fix hardware watchpoints after inferior forks-off some process.
|
# Fix hardware watchpoints after inferior forks-off some process.
|
||||||
Patch280: gdb-6.6-multifork-debugreg-for-i386-and-x86_64.patch
|
Patch280: gdb-6.6-multifork-debugreg-for-i386-and-x86_64.patch
|
||||||
|
|
||||||
|
# Fix PPC hiding of call-volatile parameter register.
|
||||||
|
Patch285: gdb-6.7-ppc-clobbered-registers-O2-fix.patch
|
||||||
|
Patch284: gdb-6.7-ppc-clobbered-registers-O2-test.patch
|
||||||
|
|
||||||
BuildRequires: ncurses-devel glibc-devel gcc make gzip texinfo dejagnu gettext
|
BuildRequires: ncurses-devel glibc-devel gcc make gzip texinfo dejagnu gettext
|
||||||
BuildRequires: flex bison sharutils expat-devel
|
BuildRequires: flex bison sharutils expat-devel
|
||||||
Requires: readline
|
Requires: readline
|
||||||
@ -545,6 +548,8 @@ rm -f gdb/jv-exp.c gdb/m2-exp.c gdb/objc-exp.c gdb/p-exp.c
|
|||||||
%patch277 -p1
|
%patch277 -p1
|
||||||
%patch278 -p1
|
%patch278 -p1
|
||||||
%patch280 -p1
|
%patch280 -p1
|
||||||
|
%patch284 -p1
|
||||||
|
%patch285 -p1
|
||||||
|
|
||||||
# Change the version that gets printed at GDB startup, so it is RedHat
|
# Change the version that gets printed at GDB startup, so it is RedHat
|
||||||
# specific.
|
# specific.
|
||||||
@ -701,6 +706,10 @@ fi
|
|||||||
# don't include the files in include, they are part of binutils
|
# don't include the files in include, they are part of binutils
|
||||||
|
|
||||||
%changelog
|
%changelog
|
||||||
|
* Thu Nov 8 2007 Jan Kratochvil <jan.kratochvil@redhat.com> - 6.6-36
|
||||||
|
- Fix `errno' resolving on glibc with broken DW_AT_MIPS_linkage_name.
|
||||||
|
- Imported 6.7 PPC hiding of call-volatile parameter registers.
|
||||||
|
|
||||||
* Fri Oct 19 2007 Jan Kratochvil <jan.kratochvil@redhat.com> - 6.6-35
|
* Fri Oct 19 2007 Jan Kratochvil <jan.kratochvil@redhat.com> - 6.6-35
|
||||||
- Fix hiding unexpected breakpoints on intentional step/next commands.
|
- Fix hiding unexpected breakpoints on intentional step/next commands.
|
||||||
- Fix s390 compilation warning/failure due to a wrongly sized type-cast.
|
- Fix s390 compilation warning/failure due to a wrongly sized type-cast.
|
||||||
|
Loading…
Reference in New Issue
Block a user