- Modify non-threaded watchpoint patch to use new observer.

This commit is contained in:
Jeff Johnston 2005-01-19 23:29:48 +00:00
parent bc60002377
commit 0e6ea417f2
2 changed files with 81 additions and 17 deletions

View File

@ -1,12 +1,18 @@
2005-01-17 Jeff Johnston <jjohnstn@redhat.com>
* linux-nat.c (iterate_over_lwps): Add logic to handle
non-threaded applications using this function for watchpoints.
(linux_nat_inferior_created): New observer.
(_initialize_linux_nat): Register new observer.
--- gdb-6.3/gdb/linux-nat.c.fix Mon Jan 17 19:35:43 2005
+++ gdb-6.3/gdb/linux-nat.c Mon Jan 17 19:37:58 2005
--- gdb-6.3/gdb/doc/observer.texi.fix Tue Jan 18 16:51:56 2005
+++ gdb-6.3/gdb/doc/observer.texi Tue Jan 18 17:38:57 2005
@@ -91,6 +91,10 @@ at the entry-point instruction. For @sa
inferior, and before any information on the inferior has been printed.
@end deftypefun
+@deftypefun void mourn_inferior (struct target_ops *@var{target})
+@value{GDBN} has just detached from an inferior.
+@end deftypefun
+
@deftypefun void solib_unloaded (struct so_list *@var{solib})
The specified shared library has been discovered to be unloaded.
@end deftypefun
--- gdb-6.3/gdb/linux-nat.c.fix Tue Jan 18 16:52:24 2005
+++ gdb-6.3/gdb/linux-nat.c Tue Jan 18 17:14:01 2005
@@ -1,6 +1,6 @@
/* GNU/Linux native-dependent code common to multiple platforms.
@ -42,17 +48,18 @@
}
return NULL;
@@ -3103,6 +3115,17 @@ linux_proc_pending_signals (int pid, sig
@@ -3103,6 +3115,18 @@ linux_proc_pending_signals (int pid, sig
fclose (procfile);
}
+/* Observer function for an inferior creation event. This is needed
+/* Observer function for a mourn inferior event. This is needed
+ because if iterate_over_lwps is called for a non-threaded program
+ to handle watchpoints, the lwp list gets initialized but there is
+ no corresponding clean-up if the program gets rerun or a new
+ program is run. */
+ no corresponding clean-up when the inferior is detached. In
+ a threaded program, the observer is simply redundant as the
+ same clean-up gets done in linux_nat_mourn_inferior. */
+static void
+linux_nat_inferior_created (struct target_ops *objfile, int from_tty)
+linux_nat_mourn_inferior_observer (struct target_ops *objfile)
+{
+ init_lwp_list ();
+}
@ -60,14 +67,68 @@
void
_initialize_linux_nat (void)
{
@@ -3120,7 +3143,9 @@ Specify any of the following keywords fo
@@ -3120,7 +3144,9 @@ Specify any of the following keywords fo
stat -- list a bunch of random process info.\n\
status -- list a different bunch of random process info.\n\
all -- list all available /proc info.");
-
+
+ observer_attach_inferior_created (linux_nat_inferior_created);
+ observer_attach_mourn_inferior (linux_nat_mourn_inferior_observer);
+
init_linux_nat_ops ();
add_target (&linux_nat_ops);
thread_db_init (&linux_nat_ops);
--- gdb-6.3/gdb/target.c.fix Tue Jan 18 17:02:37 2005
+++ gdb-6.3/gdb/target.c Tue Jan 18 17:39:43 2005
@@ -1,7 +1,7 @@
/* Select target systems and architectures at runtime for GDB.
Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998,
- 1999, 2000, 2001, 2002, 2003, 2004 Free Software Foundation, Inc.
+ 1999, 2000, 2001, 2002, 2003, 2004, 2005 Free Software Foundation, Inc.
Contributed by Cygnus Support.
@@ -38,6 +38,7 @@
#include "regcache.h"
#include "gdb_assert.h"
#include "gdbcore.h"
+#include "observer.h"
static void target_info (char *, int);
@@ -266,6 +267,13 @@ target_load (char *arg, int from_tty)
(*current_target.to_load) (arg, from_tty);
}
+void
+target_mourn_inferior (void)
+{
+ (*current_target.to_mourn_inferior) ();
+ observer_notify_mourn_inferior (&current_target);
+}
+
static int
nomemory (CORE_ADDR memaddr, char *myaddr, int len, int write,
struct target_ops *t)
--- gdb-6.3/gdb/target.h.fix Tue Jan 18 17:02:42 2005
+++ gdb-6.3/gdb/target.h Tue Jan 18 17:15:30 2005
@@ -1,7 +1,7 @@
/* Interface between GDB and target environments, including files and processes
Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998,
- 1999, 2000, 2001, 2002, 2003, 2004 Free Software Foundation, Inc.
+ 1999, 2000, 2001, 2002, 2003, 2004, 2005 Free Software Foundation, Inc.
Contributed by Cygnus Support. Written by John Gilmore.
@@ -779,8 +779,7 @@ extern void target_load (char *arg, int
/* The inferior process has died. Do what is right. */
-#define target_mourn_inferior() \
- (*current_target.to_mourn_inferior) ()
+extern void target_mourn_inferior (void);
/* Does target have enough data to do a run or attach command? */

View File

@ -11,7 +11,7 @@ Name: gdb
Version: 6.3.0.0
# The release always contains a leading reserved number, start it at 0.
Release: 0.3
Release: 0.4
License: GPL
Group: Development/Debuggers
@ -386,6 +386,9 @@ fi
# don't include the files in include, they are part of binutils
%changelog
* Tue Jan 18 2005 Jeff Johnston <jjohnstn@redhat.com> 6.3.0.0-0.4
- Modify non-threaded watchpoint patch to use new observer.
* Mon Jan 17 2005 Jeff Johnston <jjohnstn@redhat.com> 6.3.0.0-0.3
- Fix for non-threaded watchpoints.