2017-12-08 04:31:26 +00:00
|
|
|
# Match the Fedora's version info.
|
|
|
|
|
#=fedora
|
|
|
|
|
Patch001: gdb-6.3-rh-testversion-20041202.patch
|
|
|
|
|
|
|
|
|
|
# Add a wrapper script to GDB that implements pstack using the
|
|
|
|
|
# --readnever option.
|
|
|
|
|
#=push
|
2021-06-06 21:54:47 +00:00
|
|
|
Patch002: gdb-6.3-gstack-20050411.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Support TLS symbols (+`errno' suggestion if no pthread is found) (BZ 185337).
|
|
|
|
|
#=push+jan: It should be replaced by Infinity project.
|
2022-12-01 03:03:06 +00:00
|
|
|
Patch003: gdb-6.5-bz185337-resolve-tls-without-debuginfo-v2.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix TLS symbols resolving for shared libraries with a relative pathname.
|
|
|
|
|
# The testsuite needs `gdb-6.5-tls-of-separate-debuginfo.patch'.
|
|
|
|
|
#=fedoratest: One should recheck if it is really fixed upstream.
|
2022-12-01 03:03:06 +00:00
|
|
|
Patch004: gdb-6.5-sharedlibrary-path.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Improved testsuite results by the testsuite provided by the courtesy of BEA.
|
|
|
|
|
#=fedoratest: For upstream it should be rewritten as a dejagnu test, the test of no "??" was useful.
|
2022-12-01 03:03:06 +00:00
|
|
|
Patch005: gdb-6.5-BEA-testsuite.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Testcase for deadlocking on last address space byte; for corrupted backtraces.
|
|
|
|
|
#=fedoratest
|
2022-12-01 03:03:06 +00:00
|
|
|
Patch006: gdb-6.5-last-address-space-byte-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix readline segfault on excessively long hand-typed lines.
|
|
|
|
|
#=fedoratest
|
2022-12-01 03:03:06 +00:00
|
|
|
Patch007: gdb-6.5-readline-long-line-crash-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Test sideeffects of skipping ppc .so libs trampolines (BZ 218379).
|
|
|
|
|
#=fedoratest
|
2022-12-01 03:03:06 +00:00
|
|
|
Patch008: gdb-6.5-bz218379-ppc-solib-trampoline-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Find symbols properly at their original (included) file (BZ 109921).
|
|
|
|
|
#=fedoratest
|
2022-12-01 03:03:06 +00:00
|
|
|
Patch009: gdb-6.5-bz109921-DW_AT_decl_file-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Update PPC unwinding patches to their upstream variants (BZ 140532).
|
|
|
|
|
#=fedoratest
|
2022-12-01 03:03:06 +00:00
|
|
|
Patch010: gdb-6.3-bz140532-ppc-unwinding-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Testcase for exec() from threaded program (BZ 202689).
|
|
|
|
|
#=fedoratest
|
2022-12-01 03:03:06 +00:00
|
|
|
Patch011: gdb-6.3-bz202689-exec-from-pthread-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Allow running `/usr/bin/gcore' with provided but inaccessible tty (BZ 229517).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch012: gdb-6.6-bz229517-gcore-without-terminal.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Avoid too long timeouts on failing cases of "annota1.exp annota3.exp".
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch013: gdb-6.6-testsuite-timeouts.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Support for stepping over PPC atomic instruction sequences (BZ 237572).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch014: gdb-6.6-bz237572-ppc-atomic-sequence-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
2021-02-18 01:28:52 +00:00
|
|
|
# Test kernel VDSO decoding while attaching to an i386 process.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch015: gdb-6.3-attach-see-vdso-test.patch
|
2021-02-18 01:28:52 +00:00
|
|
|
|
2017-12-08 04:31:26 +00:00
|
|
|
# Test leftover zombie process (BZ 243845).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch016: gdb-6.5-bz243845-stale-testing-zombie-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# New locating of the matching binaries from the pure core file (build-id).
|
|
|
|
|
#=push+jan
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch017: gdb-6.6-buildid-locate.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix loading of core files without build-ids but with build-ids in executables.
|
|
|
|
|
# Load strictly build-id-checked core files only if no executable is specified
|
|
|
|
|
# (Jan Kratochvil, RH BZ 1339862).
|
|
|
|
|
#=push+jan
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch018: gdb-6.6-buildid-locate-solib-missing-ids.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
#=push+jan
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch019: gdb-6.6-buildid-locate-rpm.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix displaying of numeric char arrays as strings (BZ 224128).
|
|
|
|
|
#=fedoratest: But it is failing anyway, one should check the behavior more.
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch020: gdb-6.7-charsign-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Test PPC hiding of call-volatile parameter register.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch021: gdb-6.7-ppc-clobbered-registers-O2-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Testsuite fixes for more stable/comparable results.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch022: gdb-6.7-testsuite-stable-results.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Test ia64 memory leaks of the code using libunwind.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch023: gdb-6.5-ia64-libunwind-leak-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
2021-02-18 01:28:52 +00:00
|
|
|
# Test hiding unexpected breakpoints on intentional step commands.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch024: gdb-6.5-missed-trap-on-step-test.patch
|
2021-02-18 01:28:52 +00:00
|
|
|
|
|
|
|
|
# Test gcore memory and time requirements for large inferiors.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch025: gdb-6.5-gcore-buffer-limit-test.patch
|
2021-02-18 01:28:52 +00:00
|
|
|
|
2017-12-08 04:31:26 +00:00
|
|
|
# Test GCORE for shmid 0 shared memory mappings.
|
|
|
|
|
#=fedoratest: But it is broken anyway, sometimes the case being tested is not reproducible.
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch026: gdb-6.3-mapping-zero-inode-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Test various forms of threads tracking across exec() (BZ 442765).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch027: gdb-6.8-bz442765-threaded-exec-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Test a crash on libraries missing the .text section.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch028: gdb-6.5-section-num-fixup-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix resolving of variables at locations lists in prelinked libs (BZ 466901).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch029: gdb-6.8-bz466901-backtrace-full-prelinked.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# New test for step-resume breakpoint placed in multiple threads at once.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch030: gdb-simultaneous-step-resume-breakpoint-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix GNU/Linux core open: Can't read pathname for load map: Input/output error.
|
|
|
|
|
# Fix regression of undisplayed missing shared libraries caused by a fix for.
|
|
|
|
|
#=fedoratest: It should be in glibc: libc-alpha: <20091004161706.GA27450@.*>
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch031: gdb-core-open-vdso-warning.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Workaround ccache making lineno non-zero for command-line definitions.
|
|
|
|
|
#=fedoratest: ccache is rarely used and it is even fixed now.
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch032: gdb-ccache-workaround.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Testcase for "Do not make up line information" fix by Daniel Jacobowitz.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch033: gdb-lineno-makeup-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Test power7 ppc disassembly.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch034: gdb-ppc-power7-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix follow-exec for C++ programs (bugreported by Martin Stransky).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch035: gdb-archer-next-over-throw-cxx-exec.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Workaround librpm BZ 643031 due to its unexpected exit() calls (BZ 642879).
|
|
|
|
|
#=push+jan
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch036: gdb-6.6-buildid-locate-rpm-librpm-workaround.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# [delayed-symfile] Test a backtrace regression on CFIs without DIE (BZ 614604).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch037: gdb-test-bt-cfi-without-die.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Verify GDB Python built-in function gdb.solib_address exists (BZ # 634108).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch038: gdb-bz634108-solib_address.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# New test gdb.arch/x86_64-pid0-core.exp for kernel PID 0 cores (BZ 611435).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch039: gdb-test-pid0-core.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# [archer-tromey-delayed-symfile] New test gdb.dwarf2/dw2-aranges.exp.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch040: gdb-test-dw2-aranges.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Test GDB opcodes/ disassembly of Intel Ivy Bridge instructions (BZ 696890).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch041: gdb-test-ivy-bridge.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Workaround PR libc/14166 for inferior calls of strstr.
|
2018-12-11 21:37:09 +00:00
|
|
|
#=fedoratest: Compatibility with RHELs (unchecked which ones).
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch042: gdb-glibc-strstr-workaround.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Include testcase for `Unable to see a variable inside a module (XLF)' (BZ 823789).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch043: gdb-rhel5.9-testcase-xlf-var-inside-mod.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Testcase for `Setting solib-absolute-prefix breaks vDSO' (BZ 818343).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch044: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Import regression test for `gdb/findvar.c:417: internal-error:
|
|
|
|
|
# read_var_value: Assertion `frame' failed.' (RH BZ 947564) from RHEL 6.5.
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch045: gdb-rhbz947564-findvar-assertion-frame-failed-testcase.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix 'memory leak in infpy_read_memory()' (RH BZ 1007614)
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch046: gdb-rhbz1007614-memleak-infpy_read_memory-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix 'gdb gives highly misleading error when debuginfo pkg is present,
|
|
|
|
|
# but not corresponding binary pkg' (RH BZ 981154).
|
|
|
|
|
#=push+jan
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch047: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Testcase for '[SAP] Recursive dlopen causes SAP HANA installer to
|
|
|
|
|
# crash.' (RH BZ 1156192).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch048: gdb-rhbz1156192-recursive-dlopen-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix '`catch syscall' doesn't work for parent after `fork' is called'
|
|
|
|
|
# (Philippe Waroquiers, RH BZ 1149205).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch049: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix 'backport GDB 7.4 fix to RHEL 6.6 GDB' [Original Sourceware bug
|
|
|
|
|
# description: 'C++ (and objc): Internal error on unqualified name
|
|
|
|
|
# re-set', PR 11657] (RH BZ 1186476).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch050: gdb-rhbz1186476-internal-error-unqualified-name-re-set-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Test 'info type-printers' Python error (RH BZ 1350436).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch051: gdb-rhbz1350436-type-printers-error.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Fix '[ppc64] and [s390x] wrong prologue skip on -O2 -g code' (Jan
|
|
|
|
|
# Kratochvil, RH BZ 1084404).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch052: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Force libncursesw over libncurses to match the includes (RH BZ 1270534).
|
|
|
|
|
#=push+jan
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch053: gdb-fedora-libncursesw.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Test clflushopt instruction decode (for RH BZ 1262471).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch054: gdb-opcodes-clflushopt-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# [aarch64] Fix hardware watchpoints (RH BZ 1261564).
|
|
|
|
|
#=fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch055: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# Add messages suggesting more recent RHEL gdbserver (RH BZ 1321114).
|
|
|
|
|
#=fedora
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch056: gdb-container-rh-pkg.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
|
|
|
|
# [dts+el7] [x86*] Bundle linux_perf.h for libipt (RH BZ 1256513).
|
|
|
|
|
#=fedora
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch057: gdb-linux_perf-bundle.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
Rewrite (and rename) gdb-libexec-add-index.patch
It has been observed that the changes added by
gdb-libexec-add-index.patch will result in GDB testing hanging when
the tests are being run using an in-tree GDB; that is when using 'make
check'. One test that is known to fail is gdb.base/with-mf.exp,
though any test that calls the gdb-add-index.sh script will also hang.
The problem is that when the gdb-add-index.sh script is run, the GDB
testsuite passes the GDB command to use within the GDB environment
variable. For in-tree testing this will be something like:
GDB="/path/to/gdb -data-directory /path/to/data-directory"
Notice that the environment variable contains both an executable and
an argument.
Our changes to gdb-add-index.sh add this:
GDB2=/usr/libexec/gdb
if test -x $GDB2 && ! which $GDB &>/dev/null; then
GDB=$GDB2
fi
The problem then is that '-data-directory' is treated as a set of
options to 'which'. Many of these options are not known to 'which',
but the '-i' option is known. The documentation of '-i' says:
--read-alias, -i
Read aliases from stdin, reporting matching ones on
stdout. This is useful in combination with using an alias for
which itself. For example
alias which=´alias | which -i´.
And here's the problem; this option causes 'which' to read from
stdin. As the GDB testsuite doesn't send any additional input on
stdin then the which command will never complete, and the test will
hang.
The solution I think is to avoid calling 'which' like this on a user
supplied GDB environment variable.
The changes in the gdb-libexec-add-index.patch were really about what
the _default_ GDB executable should be. The upstream version of this
script does this:
GDB=${GDB:=gdb}
That is, the default is just 'gdb'. However, for RH this is not good
enough. We want to handle two additional cases, first, when only the
gdb-minimal package is installed, in which case the default should be
/usr/bin/gdb.minimal. Then we also want to handle the case where the
user doesn't have 'gdb' itself in their $PATH, but does have the 'gdb'
executable installed in /usr/libexec/gdb.
The code as it currently stands also has a problem where, if
gdb.minimal is installed on the machine this will _always_ be used in
preference to the user supplied GDB value (assuming the code worked at
all) this means that when doing in-tree testing we wouldn't actually
be using the in-tree GDB to build the index, which isn't ideal.
So in this commit I propose that we rework our gdb-add-index.sh
changes. Now, we only use the RH special values in the case that
there is no GDB environment variable set. I believe this handles all
the required use cases:
1. When doing in-tree testing GDB environment variable will be set,
and this will always be used as is, with no special processing,
2. When gdb-add-index.sh is used and GDB environment variable is not
set then we will use the first of the following as the default:
(a) /usr/bin/gdb.minimal if this file exists and is executable,
(b) The first gdb executable that can be found in the $PATH,
(c) /usr/libexec/gdb if this file exists and is executable.
While I was changing this patch anyway I've removed the libexec part
of the patch name -- this no longer seemed relevant, I suspect this
related to an older version of this patch.
2023-05-04 14:11:19 +00:00
|
|
|
# Update gdb-add-index.sh such that, when the GDB environment
|
|
|
|
|
# variable is not set, the script is smarter than just looking for
|
|
|
|
|
# 'gdb' in the $PATH.
|
2019-04-29 00:46:29 +00:00
|
|
|
#
|
Rewrite (and rename) gdb-libexec-add-index.patch
It has been observed that the changes added by
gdb-libexec-add-index.patch will result in GDB testing hanging when
the tests are being run using an in-tree GDB; that is when using 'make
check'. One test that is known to fail is gdb.base/with-mf.exp,
though any test that calls the gdb-add-index.sh script will also hang.
The problem is that when the gdb-add-index.sh script is run, the GDB
testsuite passes the GDB command to use within the GDB environment
variable. For in-tree testing this will be something like:
GDB="/path/to/gdb -data-directory /path/to/data-directory"
Notice that the environment variable contains both an executable and
an argument.
Our changes to gdb-add-index.sh add this:
GDB2=/usr/libexec/gdb
if test -x $GDB2 && ! which $GDB &>/dev/null; then
GDB=$GDB2
fi
The problem then is that '-data-directory' is treated as a set of
options to 'which'. Many of these options are not known to 'which',
but the '-i' option is known. The documentation of '-i' says:
--read-alias, -i
Read aliases from stdin, reporting matching ones on
stdout. This is useful in combination with using an alias for
which itself. For example
alias which=´alias | which -i´.
And here's the problem; this option causes 'which' to read from
stdin. As the GDB testsuite doesn't send any additional input on
stdin then the which command will never complete, and the test will
hang.
The solution I think is to avoid calling 'which' like this on a user
supplied GDB environment variable.
The changes in the gdb-libexec-add-index.patch were really about what
the _default_ GDB executable should be. The upstream version of this
script does this:
GDB=${GDB:=gdb}
That is, the default is just 'gdb'. However, for RH this is not good
enough. We want to handle two additional cases, first, when only the
gdb-minimal package is installed, in which case the default should be
/usr/bin/gdb.minimal. Then we also want to handle the case where the
user doesn't have 'gdb' itself in their $PATH, but does have the 'gdb'
executable installed in /usr/libexec/gdb.
The code as it currently stands also has a problem where, if
gdb.minimal is installed on the machine this will _always_ be used in
preference to the user supplied GDB value (assuming the code worked at
all) this means that when doing in-tree testing we wouldn't actually
be using the in-tree GDB to build the index, which isn't ideal.
So in this commit I propose that we rework our gdb-add-index.sh
changes. Now, we only use the RH special values in the case that
there is no GDB environment variable set. I believe this handles all
the required use cases:
1. When doing in-tree testing GDB environment variable will be set,
and this will always be used as is, with no special processing,
2. When gdb-add-index.sh is used and GDB environment variable is not
set then we will use the first of the following as the default:
(a) /usr/bin/gdb.minimal if this file exists and is executable,
(b) The first gdb executable that can be found in the $PATH,
(c) /usr/libexec/gdb if this file exists and is executable.
While I was changing this patch anyway I've removed the libexec part
of the patch name -- this no longer seemed relevant, I suspect this
related to an older version of this patch.
2023-05-04 14:11:19 +00:00
|
|
|
# The actual search order is now: /usr/bin/gdb.minimal, gdb (in the
|
|
|
|
|
# $PATH), then /usr/libexec/gdb.
|
|
|
|
|
#
|
|
|
|
|
# For the rationale of looking for gdb.minimal see:
|
2019-04-29 00:46:29 +00:00
|
|
|
#
|
|
|
|
|
# https://fedoraproject.org/wiki/Changes/Minimal_GDB_in_buildroot
|
Rewrite (and rename) gdb-libexec-add-index.patch
It has been observed that the changes added by
gdb-libexec-add-index.patch will result in GDB testing hanging when
the tests are being run using an in-tree GDB; that is when using 'make
check'. One test that is known to fail is gdb.base/with-mf.exp,
though any test that calls the gdb-add-index.sh script will also hang.
The problem is that when the gdb-add-index.sh script is run, the GDB
testsuite passes the GDB command to use within the GDB environment
variable. For in-tree testing this will be something like:
GDB="/path/to/gdb -data-directory /path/to/data-directory"
Notice that the environment variable contains both an executable and
an argument.
Our changes to gdb-add-index.sh add this:
GDB2=/usr/libexec/gdb
if test -x $GDB2 && ! which $GDB &>/dev/null; then
GDB=$GDB2
fi
The problem then is that '-data-directory' is treated as a set of
options to 'which'. Many of these options are not known to 'which',
but the '-i' option is known. The documentation of '-i' says:
--read-alias, -i
Read aliases from stdin, reporting matching ones on
stdout. This is useful in combination with using an alias for
which itself. For example
alias which=´alias | which -i´.
And here's the problem; this option causes 'which' to read from
stdin. As the GDB testsuite doesn't send any additional input on
stdin then the which command will never complete, and the test will
hang.
The solution I think is to avoid calling 'which' like this on a user
supplied GDB environment variable.
The changes in the gdb-libexec-add-index.patch were really about what
the _default_ GDB executable should be. The upstream version of this
script does this:
GDB=${GDB:=gdb}
That is, the default is just 'gdb'. However, for RH this is not good
enough. We want to handle two additional cases, first, when only the
gdb-minimal package is installed, in which case the default should be
/usr/bin/gdb.minimal. Then we also want to handle the case where the
user doesn't have 'gdb' itself in their $PATH, but does have the 'gdb'
executable installed in /usr/libexec/gdb.
The code as it currently stands also has a problem where, if
gdb.minimal is installed on the machine this will _always_ be used in
preference to the user supplied GDB value (assuming the code worked at
all) this means that when doing in-tree testing we wouldn't actually
be using the in-tree GDB to build the index, which isn't ideal.
So in this commit I propose that we rework our gdb-add-index.sh
changes. Now, we only use the RH special values in the case that
there is no GDB environment variable set. I believe this handles all
the required use cases:
1. When doing in-tree testing GDB environment variable will be set,
and this will always be used as is, with no special processing,
2. When gdb-add-index.sh is used and GDB environment variable is not
set then we will use the first of the following as the default:
(a) /usr/bin/gdb.minimal if this file exists and is executable,
(b) The first gdb executable that can be found in the $PATH,
(c) /usr/libexec/gdb if this file exists and is executable.
While I was changing this patch anyway I've removed the libexec part
of the patch name -- this no longer seemed relevant, I suspect this
related to an older version of this patch.
2023-05-04 14:11:19 +00:00
|
|
|
#
|
2017-12-08 04:31:26 +00:00
|
|
|
#=fedora
|
Rewrite (and rename) gdb-libexec-add-index.patch
It has been observed that the changes added by
gdb-libexec-add-index.patch will result in GDB testing hanging when
the tests are being run using an in-tree GDB; that is when using 'make
check'. One test that is known to fail is gdb.base/with-mf.exp,
though any test that calls the gdb-add-index.sh script will also hang.
The problem is that when the gdb-add-index.sh script is run, the GDB
testsuite passes the GDB command to use within the GDB environment
variable. For in-tree testing this will be something like:
GDB="/path/to/gdb -data-directory /path/to/data-directory"
Notice that the environment variable contains both an executable and
an argument.
Our changes to gdb-add-index.sh add this:
GDB2=/usr/libexec/gdb
if test -x $GDB2 && ! which $GDB &>/dev/null; then
GDB=$GDB2
fi
The problem then is that '-data-directory' is treated as a set of
options to 'which'. Many of these options are not known to 'which',
but the '-i' option is known. The documentation of '-i' says:
--read-alias, -i
Read aliases from stdin, reporting matching ones on
stdout. This is useful in combination with using an alias for
which itself. For example
alias which=´alias | which -i´.
And here's the problem; this option causes 'which' to read from
stdin. As the GDB testsuite doesn't send any additional input on
stdin then the which command will never complete, and the test will
hang.
The solution I think is to avoid calling 'which' like this on a user
supplied GDB environment variable.
The changes in the gdb-libexec-add-index.patch were really about what
the _default_ GDB executable should be. The upstream version of this
script does this:
GDB=${GDB:=gdb}
That is, the default is just 'gdb'. However, for RH this is not good
enough. We want to handle two additional cases, first, when only the
gdb-minimal package is installed, in which case the default should be
/usr/bin/gdb.minimal. Then we also want to handle the case where the
user doesn't have 'gdb' itself in their $PATH, but does have the 'gdb'
executable installed in /usr/libexec/gdb.
The code as it currently stands also has a problem where, if
gdb.minimal is installed on the machine this will _always_ be used in
preference to the user supplied GDB value (assuming the code worked at
all) this means that when doing in-tree testing we wouldn't actually
be using the in-tree GDB to build the index, which isn't ideal.
So in this commit I propose that we rework our gdb-add-index.sh
changes. Now, we only use the RH special values in the case that
there is no GDB environment variable set. I believe this handles all
the required use cases:
1. When doing in-tree testing GDB environment variable will be set,
and this will always be used as is, with no special processing,
2. When gdb-add-index.sh is used and GDB environment variable is not
set then we will use the first of the following as the default:
(a) /usr/bin/gdb.minimal if this file exists and is executable,
(b) The first gdb executable that can be found in the $PATH,
(c) /usr/libexec/gdb if this file exists and is executable.
While I was changing this patch anyway I've removed the libexec part
of the patch name -- this no longer seemed relevant, I suspect this
related to an older version of this patch.
2023-05-04 14:11:19 +00:00
|
|
|
Patch058: gdb-add-index.patch
|
2017-12-08 04:31:26 +00:00
|
|
|
|
2018-03-23 19:50:27 +00:00
|
|
|
# [s390x] Backport arch12 instructions decoding (RH BZ 1553104).
|
|
|
|
|
# =fedoratest
|
2023-01-31 09:38:56 +00:00
|
|
|
Patch059: gdb-rhbz1553104-s390x-arch12-test.patch
|
2018-08-09 16:37:55 +00:00
|
|
|
|
2023-04-11 17:47:14 +00:00
|
|
|
# Backport "Fix a potential illegal memory access in the BFD library..."
|
|
|
|
|
# (Nick Clifton, binutils/29988)
|
2023-06-08 20:52:37 +00:00
|
|
|
Patch060: gdb-binutils29988-read_indexed_address.patch
|
2023-04-11 17:47:14 +00:00
|
|
|
|
2023-05-03 20:27:40 +00:00
|
|
|
# Backport upstream patch fixing a "dangling pointer" build problem
|
|
|
|
|
# first seen when building with GCC 13.1.1 20230426 (Red Hat ;; 13.1.1-1).
|
2023-06-08 20:52:37 +00:00
|
|
|
Patch061: gdb-rhbz2192105-ftbs-dangling-pointer
|
2023-05-03 20:27:40 +00:00
|
|
|
|
2023-07-01 00:58:51 +00:00
|
|
|
# Backport two commits, 0ad504dd464 and ea70f941f9b, from Lancelot SIX
|
|
|
|
|
# which prevent repeated warnings from being printed while loading a
|
|
|
|
|
# core file. (RH BZ 2160211)
|
|
|
|
|
Patch062: gdb-rhbz2160211-excessive-core-file-warnings.patch
|
|
|
|
|
|
