do not require gets() to be declared

findutils-4.5.10-automake.patch

@@ -0,0 +1,26 @@
+From 4a848a5e9bda989f9fd31ab4b388e6849ea6381e Mon Sep 17 00:00:00 2001
+From: Kamil Dudka <kdudka@redhat.com>
+Date: Tue, 28 Aug 2012 16:54:15 +0200
+Subject: [PATCH] configure.ac: do not use the AM_C_PROTOTYPES macro
+
+It was removed in Automake 1.12.
+---
+ configure.ac |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 704b5ea..038a3d8 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -77,7 +77,7 @@ AC_PROG_CPP
+ dnl for gnulib
+ gl_EARLY
+ 
+-AM_C_PROTOTYPES
++dnl AM_C_PROTOTYPES
+ 
+ AC_PROG_INSTALL
+ AC_PROG_RANLIB
+-- 
+1.7.1
+

findutils-4.5.10-gets.patch

@@ -0,0 +1,29 @@
+From fe7079ab7e5794b9222af5e56c6f25b424ca72f3 Mon Sep 17 00:00:00 2001
+From: Kamil Dudka <kdudka@redhat.com>
+Date: Tue, 28 Aug 2012 17:24:21 +0200
+Subject: [PATCH] gnulib: do not require gets() to be declared
+
+---
+ gnulib/lib/stdio.in.h |    6 ------
+ 1 files changed, 0 insertions(+), 6 deletions(-)
+
+diff --git a/gnulib/lib/stdio.in.h b/gnulib/lib/stdio.in.h
+index 57e93ba..b1e5bb6 100644
+--- a/gnulib/lib/stdio.in.h
++++ b/gnulib/lib/stdio.in.h
+@@ -175,12 +175,6 @@ _GL_WARN_ON_USE (fflush, "fflush is not always POSIX compliant - "
+                  "use gnulib module fflush for portable POSIX compliance");
+ #endif
+ 
+-/* It is very rare that the developer ever has full control of stdin,
+-   so any use of gets warrants an unconditional warning.  Assume it is
+-   always declared, since it is required by C89.  */
+-#undef gets
+-_GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
+-
+ #if @GNULIB_FOPEN@
+ # if @REPLACE_FOPEN@
+ #  if !(defined __cplusplus && defined GNULIB_NAMESPACE)
+-- 
+1.7.1
+

findutils.spec

@@ -1,13 +1,12 @@
 Summary: The GNU versions of find utilities (find and xargs)
 Name: findutils
 Version: 4.5.10
-Release: 6%{?dist}
+Release: 7%{?dist}
 Epoch: 1
 License: GPLv3+
 Group: Applications/File
 URL: http://www.gnu.org/software/findutils/
-Source0: ftp://ftp.gnu.org/gnu/findutils/%{name}-%{version}.tar.gz
-Source1: ftp://ftp.gnu.org/gnu/findutils/%{name}-%{version}.tar.gz.sig
+Source0: ftp://alpha.gnu.org/gnu/findutils/%{name}-%{version}.tar.gz
 
 # do not build locate
 Patch1: findutils-4.4.0-no-locate.patch
@@ -23,6 +22,12 @@ Patch3: findutils-4.4.2-xautofs.patch
 # eliminate compile-time warnings
 Patch4: findutils-4.5.7-warnings.patch
 
+# configure.ac: do not use the AM_C_PROTOTYPES macro (removed in Automake 1.12)
+Patch5: findutils-4.5.10-automake.patch
+
+# gnulib: do not require gets() to be declared
+Patch6: findutils-4.5.10-gets.patch
+
 Requires(post): /sbin/install-info
 Requires(preun): /sbin/install-info
 Conflicts: filesystem < 3
@@ -53,6 +58,8 @@ useful for finding things on your system.
 %patch2 -p1
 %patch3 -p1
 %patch4 -p1
+%patch5 -p1
+%patch6 -p1
 
 # needed because of findutils-4.4.0-no-locate.patch
 aclocal -I gnulib/m4 -I m4
@@ -71,7 +78,6 @@ make %{?_smp_mflags}
 make check
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 
 rm -f $RPM_BUILD_ROOT%{_infodir}/dir
@@ -90,11 +96,7 @@ if [ $1 = 0 ]; then
   fi
 fi
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %files -f %{name}.lang
-%defattr(-,root,root,-)
 %doc AUTHORS COPYING NEWS README THANKS TODO ChangeLog
 %{_bindir}/find
 %{_bindir}/oldfind
@@ -105,6 +107,11 @@ rm -rf $RPM_BUILD_ROOT
 %{_infodir}/find-maint.info.gz
 
 %changelog
+* Tue Aug 28 2012 Kamil Dudka <kdudka@redhat.com> - 1:4.5.10-7
+- fix specfile issues reported by the fedora-review script
+- do not use the AM_C_PROTOTYPES macro (removed in Automake 1.12)
+- do not require gets() to be declared
+
 * Thu Jul 19 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1:4.5.10-6
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild