Fix crashes on closing of Evince

Resolves: #2178016
This commit is contained in:
Marek Kasik 2023-03-14 12:13:41 +01:00
parent 7f4c875725
commit 74a328f0b8
3 changed files with 62 additions and 1 deletions

View File

@ -0,0 +1,27 @@
From df8c32e2d90ec3cf7cb9c6369c7defd1ee1121fb Mon Sep 17 00:00:00 2001
From: Marek Kasik <mkasik@redhat.com>
Date: Tue, 14 Mar 2023 10:30:35 +0100
Subject: [PATCH] ev-window-title: Avoid a crash caused by double free
Variable "title_header" of ev_window_title_update()
should not be freed at the end of the function as
it points to window_title->doc_title.
---
shell/ev-window-title.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/shell/ev-window-title.c b/shell/ev-window-title.c
index 2f754e17..02bd9f1b 100644
--- a/shell/ev-window-title.c
+++ b/shell/ev-window-title.c
@@ -165,7 +165,6 @@ ev_window_title_update (EvWindowTitle *window_title)
}
g_free (title);
- g_free (title_header);
}
EvWindowTitle *
--
2.39.2

View File

@ -0,0 +1,27 @@
From 68d71634312ed2ba3b1d9e8bb101d06ccf7b4bc5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nelson=20Ben=C3=ADtez=20Le=C3=B3n?= <nbenitezl@gmail.com>
Date: Sat, 11 Mar 2023 22:23:27 -0400
Subject: [PATCH] fix double free of GtkEntryCompletion
It can be seen when closing Evince
after having used the Outline search.
---
libmisc/ev-page-action-widget.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libmisc/ev-page-action-widget.c b/libmisc/ev-page-action-widget.c
index d7a70491..e32b1dac 100644
--- a/libmisc/ev-page-action-widget.c
+++ b/libmisc/ev-page-action-widget.c
@@ -615,8 +615,6 @@ ev_page_action_widget_update_links_model (EvPageActionWidget *proxy, GtkTreeMode
(GtkCellLayoutDataFunc) display_completion_text,
proxy, NULL);
gtk_entry_set_completion (GTK_ENTRY (proxy->entry), completion);
-
- g_object_unref (completion);
}
void
--
2.39.2

View File

@ -9,13 +9,16 @@
Name: evince
Version: 44~rc
Release: 1%{?dist}
Release: 2%{?dist}
Summary: Document viewer
License: GPLv2+ and GPLv3+ and LGPLv2+ and MIT and Afmparse
URL: https://wiki.gnome.org/Apps/Evince
Source0: https://download.gnome.org/sources/%{name}/44/%{name}-%{tarball_version}.tar.xz
Patch0: 0001-ev-window-title-Avoid-a-crash-caused-by-double-free.patch
Patch1: 0001-fix-double-free-of-GtkEntryCompletion.patch
BuildRequires: gcc
BuildRequires: gettext-devel
BuildRequires: pkgconfig(adwaita-icon-theme)
@ -279,6 +282,10 @@ desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/org.gnome.Evince-p
%{_mandir}/man1/evince-previewer.1*
%changelog
* Tue Mar 14 2023 Marek Kasik <mkasik@redhat.com> - 44~rc-2
- Fix crashes on closing of Evince
- Resolves: #2178016
* Wed Mar 08 2023 David King <amigadave@amigadave.com> - 44~rc-1
- Update to 44.rc