There are several reasons to prefer keeping the upstream default location for the samples files:
* Consistency with upstream
* The current location, /usr/share/doc/eccodes/, places the samples (which are binary files) into the -doc subpackage
- The -doc subpackage is not Required by the eccodes package, so the sample files which are required by e.g. `src/grib_handle.c:grib_external_template_path`, will fail to load by default and cause an ECCODES error
- Even if the user manually installs the -doc subpackage, because the build was not configured with this alternative path using `-DECCODES_SAMPLES_PATH`, the user will also have to set the environment variable `ECCODES_SAMPLES_PATH` to this alternative path. See `/usr/bin/codes_info` for the configured paths.
Note that this issue does not show up in the testing of eccodes itself because the test sets `ECCODES_SAMPLES_PATH` to the build directory samples directory (see `tests/include.ctest.sh.in`).