From 21304d94106e89d53847979d5cc5dc5f82e02576 Mon Sep 17 00:00:00 2001
From: Tim Waugh <twaugh@fedoraproject.org>
Date: Tue, 8 Dec 2009 10:59:20 +0000
Subject: [PATCH] - Use upstream fix for SNMP detection (bug #542857, STR
 #3413).

---
 cups-str3413.patch | 37 ++++++++++++++-----------------------
 cups.spec          |  1 +
 2 files changed, 15 insertions(+), 23 deletions(-)

diff --git a/cups-str3413.patch b/cups-str3413.patch
index ea2872a..a74e7ec 100644
--- a/cups-str3413.patch
+++ b/cups-str3413.patch
@@ -1,6 +1,6 @@
 diff -up cups-1.4.2/backend/snmp.c.str3413 cups-1.4.2/backend/snmp.c
 --- cups-1.4.2/backend/snmp.c.str3413	2009-01-14 22:40:58.000000000 +0000
-+++ cups-1.4.2/backend/snmp.c	2009-12-03 10:01:27.933335209 +0000
++++ cups-1.4.2/backend/snmp.c	2009-12-08 10:54:11.798515550 +0000
 @@ -999,7 +999,7 @@ read_snmp_response(int fd)		/* I - SNMP 
  		       DEVICE_PRODUCT, LexmarkProductOID2);
  	_cupsSNMPWrite(fd, &(packet.address), CUPS_SNMP_VERSION_1,
@@ -10,33 +10,24 @@ diff -up cups-1.4.2/backend/snmp.c.str3413 cups-1.4.2/backend/snmp.c
  	_cupsSNMPWrite(fd, &(packet.address), CUPS_SNMP_VERSION_1,
  	               packet.community, CUPS_ASN1_GET_REQUEST,
  		       DEVICE_PRODUCT, XeroxProductOID);
-@@ -1064,7 +1064,19 @@ read_snmp_response(int fd)		/* I - SNMP 
+@@ -1054,7 +1054,9 @@ read_snmp_response(int fd)		/* I - SNMP 
+ 	break;
  
- 
- 	  if (device->id)
-+	  {
-+	    if (strlen (device->id) >
-+		strlen ((char *)packet.object_value.string.bytes))
-+	    {
-+	     /*
-+	      * The Device ID we already saw was more complete.
-+	      */
-+
-+	      break;
-+	    }
-+
- 	    free(device->id);
-+	  }
- 
- 	  device->id = strdup((char *)packet.object_value.string.bytes);
- 
-@@ -1107,7 +1119,8 @@ read_snmp_response(int fd)		/* I - SNMP 
+     case DEVICE_ID :
+-	if (device && packet.object_type == CUPS_ASN1_OCTET_STRING)
++	if (device && packet.object_type == CUPS_ASN1_OCTET_STRING &&
++	    (!device->id ||
++	     strlen(device->id) < packet.object_value.string.num_bytes))
+ 	{
+ 	 /*
+ 	  * Update an existing cache entry...
+@@ -1107,7 +1109,7 @@ read_snmp_response(int fd)		/* I - SNMP 
  
      case DEVICE_URI :
  	if (device && packet.object_type == CUPS_ASN1_OCTET_STRING &&
 -	    !device->uri)
-+	    !device->uri &&
-+	    (char *)packet.object_value.string.bytes[0] != '\0')
++	    !device->uri && packet.object_value.string.num_bytes > 0)
  	{
  	 /*
  	  * Update an existing cache entry...
+diff -up cups-1.4.2/CHANGES-1.4.txt.str3413 cups-1.4.2/CHANGES-1.4.txt
diff --git a/cups.spec b/cups.spec
index 8f7cab3..02924c2 100644
--- a/cups.spec
+++ b/cups.spec
@@ -522,6 +522,7 @@ rm -rf $RPM_BUILD_ROOT
 
 %changelog
 * Tue Dec  8 2009 Tim Waugh <twaugh@redhat.com> - 1:1.4.2-14
+- Use upstream fix for SNMP detection (bug #542857, STR #3413).
 - Use the text filter for text/css files (bug #545026, STR #3442).
 - Show conflicting option values in web UI (bug #544326, STR #3440).
 - Use upstream fix for adjustment of conflicting options