d3d47dee12
Error: COMPILER_WARNING:
coreutils-8.30/lib/mgetgroups.c: scope_hint: In function 'mgetgroups'
coreutils-8.30/lib/mgetgroups.c:167:11: warning: implicit declaration of function 'xrealloc'; did you mean 'realloc'? [-Wimplicit-function-declaration]
g = xrealloc (g, max_n_groups * sizeof (GETGROUPS_T));
^~~~~~~~
165| {
166| max_n_groups = ng;
167|-> g = xrealloc (g, max_n_groups * sizeof (GETGROUPS_T));
168| }
169| if (e == -1)
95 lines
2.4 KiB
Diff
95 lines
2.4 KiB
Diff
diff --git a/lib/getugroups.c b/lib/getugroups.c
|
|
index 299bae6..8ece29b 100644
|
|
--- a/lib/getugroups.c
|
|
+++ b/lib/getugroups.c
|
|
@@ -19,6 +19,9 @@
|
|
|
|
#include <config.h>
|
|
|
|
+/* We do not need this code if getgrouplist(3) is available. */
|
|
+#ifndef HAVE_GETGROUPLIST
|
|
+
|
|
#include "getugroups.h"
|
|
|
|
#include <errno.h>
|
|
@@ -126,3 +129,4 @@ getugroups (int maxcount, gid_t *grouplist, char const *username,
|
|
}
|
|
|
|
#endif /* HAVE_GRP_H */
|
|
+#endif /* have getgrouplist */
|
|
diff --git a/lib/mgetgroups.c b/lib/mgetgroups.c
|
|
index 76474c2..0a9d221 100644
|
|
--- a/lib/mgetgroups.c
|
|
+++ b/lib/mgetgroups.c
|
|
@@ -31,6 +31,7 @@
|
|
#endif
|
|
|
|
#include "getugroups.h"
|
|
+#include "xalloc.h"
|
|
#include "xalloc-oversized.h"
|
|
|
|
/* Work around an incompatibility of OS X 10.11: getgrouplist
|
|
@@ -121,9 +122,17 @@ mgetgroups (char const *username, gid_t gid, gid_t **groups)
|
|
/* else no username, so fall through and use getgroups. */
|
|
#endif
|
|
|
|
- max_n_groups = (username
|
|
- ? getugroups (0, NULL, username, gid)
|
|
- : getgroups (0, NULL));
|
|
+ if (!username)
|
|
+ max_n_groups = getgroups(0, NULL);
|
|
+ else
|
|
+ {
|
|
+#ifdef HAVE_GETGROUPLIST
|
|
+ max_n_groups = 0;
|
|
+ getgrouplist (username, gid, NULL, &max_n_groups);
|
|
+#else
|
|
+ max_n_groups = getugroups (0, NULL, username, gid);
|
|
+#endif
|
|
+ }
|
|
|
|
/* If we failed to count groups because there is no supplemental
|
|
group support, then return an array containing just GID.
|
|
@@ -145,10 +154,25 @@ mgetgroups (char const *username, gid_t gid, gid_t **groups)
|
|
if (g == NULL)
|
|
return -1;
|
|
|
|
- ng = (username
|
|
- ? getugroups (max_n_groups, g, username, gid)
|
|
- : getgroups (max_n_groups - (gid != (gid_t) -1),
|
|
- g + (gid != (gid_t) -1)));
|
|
+ if (!username)
|
|
+ ng = getgroups (max_n_groups - (gid != (gid_t)-1), g + (gid != (gid_t)-1));
|
|
+ else
|
|
+ {
|
|
+#ifdef HAVE_GETGROUPLIST
|
|
+ int e;
|
|
+ ng = max_n_groups;
|
|
+ while ((e = getgrouplist (username, gid, g, &ng)) == -1
|
|
+ && ng > max_n_groups)
|
|
+ {
|
|
+ max_n_groups = ng;
|
|
+ g = xrealloc (g, max_n_groups * sizeof (GETGROUPS_T));
|
|
+ }
|
|
+ if (e == -1)
|
|
+ ng = -1;
|
|
+#else
|
|
+ ng = getugroups (max_n_groups, g, username, gid);
|
|
+#endif
|
|
+ }
|
|
|
|
if (ng < 0)
|
|
{
|
|
diff --git a/m4/jm-macros.m4 b/m4/jm-macros.m4
|
|
index 62777c7..5180243 100644
|
|
--- a/m4/jm-macros.m4
|
|
+++ b/m4/jm-macros.m4
|
|
@@ -82,6 +82,7 @@ AC_DEFUN([coreutils_MACROS],
|
|
fchown
|
|
fchmod
|
|
ftruncate
|
|
+ getgrouplist
|
|
iswspace
|
|
mkfifo
|
|
mbrlen
|