2ea649d73a
Fix a potential memory exhaustion in the BFD library when parsing corrupt DWARF debug information. (#1771678)
63 lines
2.1 KiB
Diff
63 lines
2.1 KiB
Diff
--- binutils.orig/bfd/dwarf2.c 2019-11-13 11:49:52.211121564 +0000
|
|
+++ binutils-2.33.1/bfd/dwarf2.c 2019-11-13 11:53:26.991423055 +0000
|
|
@@ -2813,8 +2813,8 @@ static bfd_boolean comp_unit_maybe_decod
|
|
|
|
static bfd_boolean
|
|
find_abstract_instance (struct comp_unit * unit,
|
|
- bfd_byte * orig_info_ptr,
|
|
struct attribute * attr_ptr,
|
|
+ unsigned int recur_count,
|
|
const char ** pname,
|
|
bfd_boolean * is_linkage,
|
|
char ** filename_ptr,
|
|
@@ -2829,6 +2829,14 @@ find_abstract_instance (struct comp_unit
|
|
struct attribute attr;
|
|
const char *name = NULL;
|
|
|
|
+ if (recur_count == 100)
|
|
+ {
|
|
+ _bfd_error_handler
|
|
+ (_("DWARF error: abstract instance recursion detected"));
|
|
+ bfd_set_error (bfd_error_bad_value);
|
|
+ return FALSE;
|
|
+ }
|
|
+
|
|
/* DW_FORM_ref_addr can reference an entry in a different CU. It
|
|
is an offset from the .debug_info section, not the current CU. */
|
|
if (attr_ptr->form == DW_FORM_ref_addr)
|
|
@@ -2962,15 +2970,7 @@ find_abstract_instance (struct comp_unit
|
|
info_ptr, info_ptr_end);
|
|
if (info_ptr == NULL)
|
|
break;
|
|
- /* It doesn't ever make sense for DW_AT_specification to
|
|
- refer to the same DIE. Stop simple recursion. */
|
|
- if (info_ptr == orig_info_ptr)
|
|
- {
|
|
- _bfd_error_handler
|
|
- (_("DWARF error: abstract instance recursion detected"));
|
|
- bfd_set_error (bfd_error_bad_value);
|
|
- return FALSE;
|
|
- }
|
|
+
|
|
switch (attr.name)
|
|
{
|
|
case DW_AT_name:
|
|
@@ -2984,7 +2984,7 @@ find_abstract_instance (struct comp_unit
|
|
}
|
|
break;
|
|
case DW_AT_specification:
|
|
- if (!find_abstract_instance (unit, info_ptr, &attr,
|
|
+ if (!find_abstract_instance (unit, &attr, recur_count + 1,
|
|
&name, is_linkage,
|
|
filename_ptr, linenumber_ptr))
|
|
return FALSE;
|
|
@@ -3200,7 +3200,7 @@ scan_unit_for_symbols (struct comp_unit
|
|
|
|
case DW_AT_abstract_origin:
|
|
case DW_AT_specification:
|
|
- if (!find_abstract_instance (unit, info_ptr, &attr,
|
|
+ if (!find_abstract_instance (unit, &attr, 0,
|
|
&func->name,
|
|
&func->is_linkage,
|
|
&func->file,
|