From c7ad9ce6c40d4d6904495a62503d1f7f413ee89e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=A1clav=20Kadl=C4=8D=C3=ADk?= Date: Mon, 12 Apr 2021 10:59:29 +0200 Subject: [PATCH] Import RHEL's regression test for #1693661 --- .../Makefile | 64 +++++++++++++ .../PURPOSE | 5 + .../foo.c | 4 + .../main.c | 8 ++ .../main.fmf | 15 +++ .../runtest.sh | 94 +++++++++++++++++++ 6 files changed, 190 insertions(+) create mode 100644 tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/Makefile create mode 100644 tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/PURPOSE create mode 100644 tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/foo.c create mode 100644 tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/main.c create mode 100644 tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/main.fmf create mode 100755 tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/runtest.sh diff --git a/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/Makefile b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/Makefile new file mode 100644 index 0000000..ce74be8 --- /dev/null +++ b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/Makefile @@ -0,0 +1,64 @@ +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Makefile of /tools/binutils/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main +# Description: Test for BZ#1693661 (rhel8 gold does not resolve the address of main()) +# Author: Edjunior Machado +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Copyright (c) 2019 Red Hat, Inc. +# +# This program is free software: you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation, either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied +# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR +# PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +export TEST=/tools/binutils/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main +export TESTVERSION=1.0 + +BUILT_FILES= + +FILES=$(METADATA) runtest.sh Makefile PURPOSE main.c foo.c + +.PHONY: all install download clean + +run: $(FILES) build + ./runtest.sh + +build: $(BUILT_FILES) + test -x runtest.sh || chmod a+x runtest.sh + +clean: + rm -f *~ $(BUILT_FILES) + + +include /usr/share/rhts/lib/rhts-make.include + +$(METADATA): Makefile + @echo "Owner: Edjunior Machado " > $(METADATA) + @echo "Name: $(TEST)" >> $(METADATA) + @echo "TestVersion: $(TESTVERSION)" >> $(METADATA) + @echo "Path: $(TEST_DIR)" >> $(METADATA) + @echo "Description: Test for BZ#1693661 (rhel8 gold does not resolve the address of main())" >> $(METADATA) + @echo "Type: Regression" >> $(METADATA) + @echo "TestTime: 5m" >> $(METADATA) + @echo "RunFor: binutils" >> $(METADATA) + @echo "Requires: binutils gcc" >> $(METADATA) + @echo "Priority: Normal" >> $(METADATA) + @echo "License: GPLv2+" >> $(METADATA) + @echo "Confidential: no" >> $(METADATA) + @echo "Destructive: no" >> $(METADATA) + @echo "Bug: 1693661" >> $(METADATA) + @echo "Releases: -RHEL4 -RHEL6 -RHELClient5 -RHELServer5" >> $(METADATA) + + rhts-lint $(METADATA) diff --git a/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/PURPOSE b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/PURPOSE new file mode 100644 index 0000000..8764050 --- /dev/null +++ b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/PURPOSE @@ -0,0 +1,5 @@ +PURPOSE of /tools/binutils/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main +Description: Test for BZ#1693661 (rhel8 gold does not resolve the address of main()) +Author: Edjunior Machado +Bug summary: rhel8 gold does not resolve the address of main() when it is in a shared library in aarch64 +Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1693661 diff --git a/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/foo.c b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/foo.c new file mode 100644 index 0000000..cbce2f9 --- /dev/null +++ b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/foo.c @@ -0,0 +1,4 @@ +int __attribute__ ((noinline)) foo(int x, int y) +{ + return x & y; +} diff --git a/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/main.c b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/main.c new file mode 100644 index 0000000..3662069 --- /dev/null +++ b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/main.c @@ -0,0 +1,8 @@ +#include +extern int foo(int, int); + +int main() +{ + printf("%d\n", foo(1, 3)); + return 0; +} diff --git a/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/main.fmf b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/main.fmf new file mode 100644 index 0000000..75f0dcf --- /dev/null +++ b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/main.fmf @@ -0,0 +1,15 @@ +summary: Test for BZ#1693661 (rhel8 gold does not resolve the address of main()) +description: | + Bug summary: rhel8 gold does not resolve the address of main() when it is in a shared library in aarch64 + Bugzilla link: https://bugzilla.redhat.com/show_bug.cgi?id=1693661 +contact: Edjunior Machado +component: +- binutils +test: ./runtest.sh +framework: beakerlib +recommend: +- binutils +- gcc +duration: 5m +extra-summary: /tools/binutils/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main +extra-task: /tools/binutils/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main diff --git a/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/runtest.sh b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/runtest.sh new file mode 100755 index 0000000..ae424e7 --- /dev/null +++ b/tests/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main/runtest.sh @@ -0,0 +1,94 @@ +#!/bin/bash +# vim: dict+=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# runtest.sh of /tools/binutils/Regression/bz1693661-rhel8-gold-does-not-resolve-the-address-of-main +# Description: Test for BZ#1693661 (rhel8 gold does not resolve the address of main()) +# Author: Edjunior Machado +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Copyright (c) 2019 Red Hat, Inc. +# +# This program is free software: you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation, either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied +# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR +# PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +# Include Beaker environment +. /usr/share/beakerlib/beakerlib.sh || exit 1 + +LD="${LD:-$(which ld.gold)}" +GCC="${GCC:-$(which gcc)}" + +PACKAGE="${PACKAGE:-$(rpm --qf '%{name}\n' -qf $(which $LD) | head -1)}" +GCC_PACKAGE="${GCC_PACKAGE:-$(rpm --qf '%{name}\n' -qf $(which $GCC) | head -1)}" + +PACKAGES="${PACKAGES:-$PACKAGE}" +REQUIRES="${REQUIRES:-$GCC_PACKAGE}" + +rlJournalStart + rlPhaseStartSetup + rlLogInfo "PACKAGES=$PACKAGES" + rlLogInfo "REQUIRES=$REQUIRES" + rlLogInfo "COLLECTIONS=$COLLECTIONS" + rlLogInfo "PACKAGE=$PACKAGE" + rlLogInfo "LD=$LD" + rlLogInfo "GCC=$GCC" + + rlLogInfo "SKIP_COLLECTION_METAPACKAGE_CHECK=$SKIP_COLLECTION_METAPACKAGE_CHECK" + + # We optionally need to skip checking for the presence of the metapackage + # because that would pull in all the dependent toolset subrpms. We do not + # always want that, especially in CI. + _COLLECTIONS="$COLLECTIONS" + if ! test -z $SKIP_COLLECTION_METAPACKAGE_CHECK; then + for c in $SKIP_COLLECTION_METAPACKAGE_CHECK; do + rlLogInfo "ignoring metapackage check for collection $c" + export COLLECTIONS=$(shopt -s extglob && echo ${COLLECTIONS//$c/}) + done + fi + + rlLogInfo "(without skipped) COLLECTIONS=$COLLECTIONS" + + rlAssertRpm --all + + export COLLECTIONS="$_COLLECTIONS" + + rlRun "TmpDir=\$(mktemp -d)" 0 "Creating tmp directory" + rlRun "cp main.c foo.c $TmpDir/" + rlRun "pushd $TmpDir" + rlPhaseEnd + + rlPhaseStartTest + rlRun "gcc -o main.o -fPIC -c main.c" + rlRun "gcc -shared -o libmain.so main.o" + rlRun "gcc -o foo.o -c foo.c" + + rlLogInfo "Linking with gold..." + rlRun "gcc -fuse-ld=gold -o gold.out -lmain -L$PWD -Wl,-v,-rpath=$PWD foo.o" + rlAssertExists "gold.out" + rlRun "./gold.out" # On bz#1693661, it segfaults + + rlLogInfo "Linking with bfd..." + rlRun "gcc -fuse-ld=bfd -o bfd.out -lmain -L$PWD -Wl,-v,-rpath=$PWD foo.o" + rlAssertExists "bfd.out" + rlRun "./bfd.out" + rlPhaseEnd + + rlPhaseStartCleanup + rlRun "popd" + rlRun "rm -r $TmpDir" 0 "Removing tmp directory" + rlPhaseEnd +rlJournalPrintText +rlJournalEnd