fix typo in changelog

rh #1261428, rh #1264676, rh #1263959, rh #1265993, rh #1266003, rh #1272974

.gitignore

@@ -319,115 +319,5 @@ network-manager-applet-0.8.1.tar.bz2
 /NetworkManager-1.0.4.git20150713.38bf2cb0.tar.bz2
 /NetworkManager-1.0.4.tar.xz
 /NetworkManager-1.0.6.tar.xz
-/NetworkManager-1.2.0.tar.xz
-/NetworkManager-1.1.90.tar.xz
-/NetworkManager-1.1.91.tar.xz
-/NetworkManager-1.1.92.tar.xz
-/NetworkManager-1.1.93.tar.xz
-/NetworkManager-1.1.94.tar.xz
-/NetworkManager-1.2.2.tar.xz
-/NetworkManager-1.3.0.git20160621.072358da.tar.xz
-/NetworkManager-1.4.0.tar.xz
-/NetworkManager-1.4.2.tar.xz
-/NetworkManager-1.5.2.tar.xz
-/NetworkManager-1.5.3.tar.xz
-/NetworkManager-1.5.90.tar.xz
-/NetworkManager-1.6.0.tar.xz
-/NetworkManager-1.6.2.tar.xz
-/NetworkManager-1.7.2.tar.xz
-/NetworkManager-1.7.91.tar.xz
-/NetworkManager-1.7.92.tar.xz
-/NetworkManager-1.8.0.tar.xz
-/NetworkManager-1.8.2.tar.xz
-/NetworkManager-1.8.4.tar.xz
-/NetworkManager-1.10.2.tar.xz
-/NetworkManager-1.10.4.tar.xz
-/NetworkManager-1.10.6.tar.xz
-/NetworkManager-1.10.8.tar.xz
-/NetworkManager-1.11.4.tar.xz
-/NetworkManager-1.11.90.tar.xz
-/NetworkManager-1.12.0.tar.xz
-/NetworkManager-1.12.2.tar.xz
-/NetworkManager-1.14.0.tar.xz
-/NetworkManager-1.14.2.tar.xz
-/NetworkManager-1.14.4.tar.xz
-/NetworkManager-1.15.90.tar.xz
-/NetworkManager-1.15.91.tar.xz
-/NetworkManager-1.16.0.tar.xz
-/NetworkManager-1.18.0.tar.xz
-/NetworkManager-1.19.2.tar.xz
-/NetworkManager-1.19.3.tar.xz
-/NetworkManager-1.19.5.tar.xz
-/NetworkManager-1.19.90.tar.xz
-/NetworkManager-1.20.0.tar.xz
-/NetworkManager-1.20.2.tar.xz
-/NetworkManager-1.20.4.tar.xz
-/NetworkManager-1.21.3.tar.xz
-/NetworkManager-1.21.90.tar.xz
-/NetworkManager-1.22.0.tar.xz
-/NetworkManager-1.22.2.tar.xz
-/NetworkManager-1.22.4.tar.xz
-/NetworkManager-1.22.6.tar.xz
-/NetworkManager-1.22.8.tar.xz
-/NetworkManager-1.22.10.tar.xz
-/NetworkManager-1.23.90.tar.xz
-/NetworkManager-1.23.91.tar.xz
-/NetworkManager-1.24.0.tar.xz
-/NetworkManager-1.24.2.tar.xz
-/NetworkManager-1.25.90.tar.xz
-/NetworkManager-1.26.0.tar.xz
-/NetworkManager-1.26.2.tar.xz
-/NetworkManager-1.27.90.tar.xz
-/NetworkManager-1.27.91.tar.xz
-/NetworkManager-1.28.0.tar.xz
-/NetworkManager-1.29.8.tar.xz
-/NetworkManager-1.29.9.tar.xz
-/NetworkManager-1.29.11.tar.xz
-/NetworkManager-1.29.90.tar.xz
-/NetworkManager-1.30.0.tar.xz
-/NetworkManager-1.30.2.tar.xz
-/NetworkManager-1.31.2.tar.xz
-/NetworkManager-1.31.3.tar.xz
-/NetworkManager-1.31.4.tar.xz
-/NetworkManager-1.31.90.tar.xz
-/NetworkManager-1.32.0.tar.xz
-/NetworkManager-1.32.4.tar.xz
-/NetworkManager-1.32.6.tar.xz
-/NetworkManager-1.32.8.tar.xz
-/NetworkManager-1.32.10.tar.xz
-/NetworkManager-1.32.12.tar.xz
-/NetworkManager-1.35.1.tar.xz
-/NetworkManager-1.35.2.tar.xz
-/NetworkManager-1.35.3.tar.xz
-/NetworkManager-1.35.4.tar.xz
-/NetworkManager-1.35.6.tar.xz
-/NetworkManager-1.35.7.tar.xz
-/NetworkManager-1.35.90.tar.xz
-/NetworkManager-1.35.91.tar.xz
-/NetworkManager-1.35.92.tar.xz
-/NetworkManager-1.36.0.tar.xz
-/NetworkManager-1.36.2.tar.xz
-/NetworkManager-1.36.4.tar.xz
-/NetworkManager-1.37.3.tar.xz
-/NetworkManager-1.37.90.tar.xz
-/NetworkManager-1.37.91.tar.xz
-/NetworkManager-1.37.92.tar.xz
-/NetworkManager-1.38.0.tar.xz
-/NetworkManager-1.39.8.tar.xz
-/NetworkManager-1.39.10.tar.xz
-/NetworkManager-1.39.11.tar.xz
-/NetworkManager-1.39.90.tar.xz
-/NetworkManager-1.40.0.tar.xz
-/NetworkManager-1.41.3.tar.xz
-/NetworkManager-1.41.4.tar.xz
-/NetworkManager-1.41.5.tar.xz
-/NetworkManager-1.41.6.tar.xz
-/NetworkManager-1.41.7.tar.xz
-/NetworkManager-1.41.8.tar.xz
-/NetworkManager-1.41.90.tar.xz
-/NetworkManager-1.41.91.tar.xz
-/NetworkManager-1.42.0.tar.xz
-/NetworkManager-1.43.3.tar.xz
-/NetworkManager-1.43.4.tar.xz
-/NetworkManager-1.43.5.tar.xz
-/NetworkManager-1.43.6.tar.xz
+/NetworkManager-1.0.8.tar.xz
+/NetworkManager-1.0.10.tar.xz

00-server.conf

@@ -1,8 +1,14 @@
-# This configuration file changes NetworkManager's behavior to
+# This configuration file, when placed into into
+# /etc/NetworkManager/conf.d changes NetworkManager's behavior to
 # what's expected on "traditional UNIX server" type deployments.
 #
 # See "man NetworkManager.conf" for more information about these
 # and other keys.
+#
+# Do not edit this file; it will be overwritten on upgrades. If you
+# want to override the values here, or set additional values, you can
+# do so by adding another file (eg, "99-local.conf") to this directory
+# and setting keys there.
 
 [main]
 # Do not do automatic (DHCP/SLAAC) configuration on ethernet devices

0000-explain-dns1-dns2.patch

@@ -0,0 +1,27 @@
+diff -up NetworkManager-0.8.2/src/dns-manager/nm-dns-manager.c.explain-dns1-dns2 NetworkManager-0.8.2/src/dns-manager/nm-dns-manager.c
+--- NetworkManager-0.8.2/src/dns-manager/nm-dns-manager.c.explain-dns1-dns2	2010-10-18 18:44:05.000000000 -0500
++++ NetworkManager-0.8.2/src/dns-manager/nm-dns-manager.c	2010-11-03 13:51:56.614584001 -0500
+@@ -358,7 +358,7 @@ write_resolv_conf (FILE *f, const char *
+ 
+ 	str = g_string_new ("");
+ 
+-	if (nameservers) {
++	if (nameservers && g_strv_length (nameservers)) {
+ 		int num = g_strv_length (nameservers);
+ 
+ 		for (i = 0; i < num; i++) {
+@@ -374,6 +374,14 @@ write_resolv_conf (FILE *f, const char *
+ 			g_string_append (str, nameservers[i]);
+ 			g_string_append_c (str, '\n');
+ 		}
++	} else {
++		g_string_append_printf (str, "\n\n%s%s%s%s%s%s",
++		                        "# No nameservers found; try putting DNS servers into your\n",
++		                        "# ifcfg files in /etc/sysconfig/network-scripts like so:\n",
++		                        "#\n",
++		                        "# DNS1=xxx.xxx.xxx.xxx\n",
++		                        "# DNS2=xxx.xxx.xxx.xxx\n",
++		                        "# DOMAIN=lab.foo.com bar.foo.com\n");
+ 	}
+ 
+ 	nameservers_str = g_string_free (str, FALSE);

0001-rh1294309-peer-device-route.patch

@@ -0,0 +1,55 @@
+From 01ec441715e24ce43394fe7aad34501ef538386e Mon Sep 17 00:00:00 2001
+From: Thomas Haller <thaller@redhat.com>
+Date: Mon, 4 Jan 2016 18:54:26 +0100
+Subject: [PATCH 1/1] core: fix failure to configure routes due to wrong
+ device-route for IPv4 peer-addresses
+
+As in the case of a OpenVPN connection, we might add an address like:
+  10.8.0.58/32 ptp 10.8.0.57
+
+In this case, kernel would automatically add a device-route like:
+  10.8.0.57/32 via 0.0.0.0 dev 32 metric 0 mss 0 src rtprot-kernel scope link pref-src 10.8.0.58
+
+nm_ip4_config_commit() checks all IP addresses to figure out
+the present device-routes. Then the routes are synced by NMRouteManager.
+Due to a bug, we would not consider the peer-address, but the local-address
+and configure a route 10.8.0.58/32, instead of 10.8.0.57/32.
+
+That stays mostly unnoticed, because usually the peer and the local-address are
+in the same subnet, so that there is no difference (/32 is an example of the
+peer-address being in a different subnet).
+
+It also seems that due to a bug fixed by df4e5357521 this issue didn't surface.
+Probably because we would not notice the 10.8.0.57/32 right away and thus
+nm_route_manager_ip4_route_sync() would not wrongly delete it.
+
+https://bugzilla.gnome.org/show_bug.cgi?id=759892
+
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809195
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809494
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=809526
+https://bugs.archlinux.org/task/47535
+https://bugzilla.redhat.com/show_bug.cgi?id=1294309
+https://mail.gnome.org/archives/networkmanager-list/2015-December/msg00059.html
+(cherry picked from commit 11aa07ed939193e85516c287a57dee1837242972)
+---
+ src/nm-ip4-config.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/src/nm-ip4-config.c b/src/nm-ip4-config.c
+index f625d35..61e29af 100644
+--- a/src/nm-ip4-config.c
++++ b/src/nm-ip4-config.c
+@@ -298,7 +298,8 @@ nm_ip4_config_commit (const NMIP4Config *config, int ifindex, gboolean routes_fu
+ 
+ 				route.ifindex = ifindex;
+ 				route.source = NM_IP_CONFIG_SOURCE_KERNEL;
+-				route.network = nm_utils_ip4_address_clear_host_address (addr->address, addr->plen);
++				route.network = nm_utils_ip4_address_clear_host_address (addr->peer_address ? : addr->address,
++				                                                         addr->plen);
+ 				route.plen = addr->plen;
+ 				route.pref_src = addr->address;
+ 				route.metric = default_route_metric;
+-- 
+2.5.0
+

0002-wifi-avoid-crash-reusing-supplicant-rh1298007.patch

@@ -0,0 +1,42 @@
+From dd8ee9be472ddf799e63e035bf0c82f072dc1881 Mon Sep 17 00:00:00 2001
+From: Thomas Haller <thaller@redhat.com>
+Date: Thu, 21 Jan 2016 15:03:44 +0100
+Subject: [PATCH 1/1] wifi: assert against returning cached
+ NMSupplicantInterface instances
+
+nm_supplicant_manager_iface_get() returning a cached instance leads to
+a crash when the first owner releases the object, as no ownership is
+transferred.
+
+That was fixed on master by commit f1fba3eb02c5d102a1b0e85c371dce81e5bd0d3b.
+Instead of backporting the entire refactoring (which also asserts against
+reuse), just disallow reusing here.
+
+The assertion should not be hit. If it would we need to investigate.
+Also, this way the assertion avoids a hard crash.
+
+https://bugzilla.redhat.com/show_bug.cgi?id=1298007
+(cherry picked from commit bd27102277e5d7e52d87bd26711ae6c431e08192)
+---
+ src/supplicant-manager/nm-supplicant-manager.c | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/src/supplicant-manager/nm-supplicant-manager.c b/src/supplicant-manager/nm-supplicant-manager.c
+index 083f2eb..e31e726 100644
+--- a/src/supplicant-manager/nm-supplicant-manager.c
++++ b/src/supplicant-manager/nm-supplicant-manager.c
+@@ -93,7 +93,10 @@ nm_supplicant_manager_iface_get (NMSupplicantManager * self,
+ 			                     iface);
+ 		}
+ 	} else {
+-		nm_log_dbg (LOGD_SUPPLICANT, "(%s): returning existing supplicant interface", ifname);
++		/* nm_supplicant_manager_iface_get() and release() implements no form of ref-counting
++		 * to properly handle reusing a cached instance. It's also unclear whether that is
++		 * even necessary or desired. Assert here and error out (rh #1298007). */
++		g_return_val_if_reached (NULL);
+ 	}
+ 
+ 	return iface;
+-- 
+2.5.0
+

10-ibft-plugin.conf

@@ -0,0 +1,11 @@
+# This file enables the standalone 'iBFT' settings plugin to read
+# iBFT information with iscsiadm and create connections from that
+# data.
+#
+# Do not edit this file; it will be overwritten on upgrades. If you
+# want to override the values here, or set additional values, you can
+# do so by adding another file (eg, "99-local.conf") to this directory
+# and setting keys there.
+
+[main]
+plugins+=ibft

20-connectivity-fedora.conf

@@ -1,10 +1,4 @@
-# Enable connectivity checking for NetworkManager.
-# See `man NetworkManager.conf`.
-#
-# Note that connectivity checking works badly with rp_filter set to
-# strict. Check "/proc/sys/net/ipv4/conf/*/rp_filter".
 [connectivity]
-enabled=true
 uri=http://fedoraproject.org/static/hotspot.txt
 response=OK
 interval=300

20-connectivity-redhat.conf

@@ -1,10 +0,0 @@
-# Enable connectivity checking for NetworkManager.
-# See `man NetworkManager.conf`.
-#
-# Note that connectivity checking works badly with rp_filter set to
-# strict. Check "/proc/sys/net/ipv4/conf/*/rp_filter".
-[connectivity]
-enabled=true
-uri=http://static.redhat.com/test/rhel-networkmanager.txt
-response=OK
-interval=300

70-nm-connectivity.conf

@@ -1,15 +0,0 @@
-# The Strict mode of RFC3704 Reverse Path filtering breaks some pretty
-# common and reasonable use cases.
-#
-# Notably, it makes it impossible for NetworkManager to do connectivity
-# check on a newly arriving default route (it starts with a higher metric
-# and is bumped lower if there's connectivity).
-#
-# Kernel's default is 0 (no filter), systemd configures a Loose filter since
-# commit 230450d4e4f1 ('sysctl.d: switch net.ipv4.conf.all.rp_filter from 1
-# to 2'). However, RHEL systemd package happens to default to Strict mode
-# for historic reasons. Let's override it if we're doing connectivity
-# checking.
-
-# Source route verification
-net.ipv4.conf.all.rp_filter = 0

NetworkManager.conf

@@ -2,51 +2,14 @@
 #
 # See "man 5 NetworkManager.conf" for details.
 #
-# The directories /usr/lib/NetworkManager/conf.d/ and /run/NetworkManager/conf.d/
-# can contain additional .conf snippets installed by packages. These files are
-# read before NetworkManager.conf and have thus lowest priority.
-# The directory /etc/NetworkManager/conf.d/ can contain additional .conf
-# snippets. Those snippets are merged last and overwrite the settings from this main
-# file.
-#
-# The files within one conf.d/ directory are read in asciibetical order.
-#
-# You can prevent loading a file /usr/lib/NetworkManager/conf.d/NAME.conf
-# by having a file NAME.conf in either /run/NetworkManager/conf.d/ or /etc/NetworkManager/conf.d/.
-# Likewise, snippets from /run can be prevented from loading by placing
-# a file with the same name in /etc/NetworkManager/conf.d/.
-#
-# If two files define the same key, the one that is read afterwards will overwrite
-# the previous one.
+# The directory /etc/NetworkManager/conf.d/ can contain additional configuration
+# snippets that are installed by some packages. Those snippets override the
+# settings from this main file.
+# To override a configuration from a conf.d/ snippet, add another configuration
+# with a name sorted lastly (such as 99-my.conf).
 
 [main]
-#plugins=keyfile,ifcfg-rh
-
+plugins=ifcfg-rh,ibft
 
 [logging]
-# When debugging NetworkManager, enabling debug logging is of great help.
-#
-# Logfiles contain no passwords and little sensitive information. But please
-# check before posting the file online. You can also personally hand over the
-# logfile to a NM developer to treat it confidential. Meet us on #nm on Libera.Chat.
-#
-# You can also change the log-level at runtime via
-#   $ nmcli general logging level TRACE domains ALL
-# However, usually it's cleaner to enable debug logging
-# in the configuration and restart NetworkManager so that
-# debug logging is enabled from the start.
-#
-# You will find the logfiles in syslog, for example via
-#   $ journalctl -u NetworkManager
-#
-# Please post full logfiles for bug reports without pre-filtering or truncation.
-# Also, for debugging the entire `journalctl` output can be interesting. Don't
-# limit unnecessarily with `journalctl -u`. Exceptions are if you are worried
-# about private data. Check before posting logfiles!
-#
-# Note that debug logging of NetworkManager can be quite verbose. Some messages
-# might be rate-limited by the logging daemon (see RateLimitIntervalSec, RateLimitBurst
-# in man journald.conf). Please disable rate-limiting before collecting debug logs!
-#
-#level=TRACE
-#domains=ALL
+#level=DEBUG

readme-ifcfg-rh.txt

@@ -1,31 +0,0 @@
-NetworkManager stores new network profiles in keyfile format in the
-/etc/NetworkManager/system-connections/ directory.
-
-Previously, NetworkManager stored network profiles in ifcfg format
-in this directory (/etc/sysconfig/network-scripts/). However, the ifcfg
-format is deprecated. By default, NetworkManager no longer creates
-new profiles in this format.
-
-Connection profiles in keyfile format have many benefits. For example,
-this format is INI file-based and can easily be parsed and generated.
-
-Each section in NetworkManager keyfiles corresponds to a NetworkManager
-setting name as described in the nm-settings(5) and nm-settings-keyfile(5)
-man pages. Each key-value-pair in a section is one of the properties
-listed in the settings specification of the man page.
-
-If you still use network profiles in ifcfg format, consider migrating
-them to keyfile format. To migrate all profiles at once, enter:
-
-# nmcli connection migrate
-
-This command migrates all profiles from ifcfg format to keyfile
-format and stores them in /etc/NetworkManager/system-connections/.
-
-Alternatively, to migrate only a specific profile, enter:
-
-# nmcli connection migrate <profile_name|UUID|D-Bus_path>
-
-For further details, see:
-* nm-settings-keyfile(5)
-* nmcli(1)

sources

@@ -1 +1 @@
-SHA512 (NetworkManager-1.43.6.tar.xz) = e1d898d3e6154018defcf189bc017a962ed93b9f5d7bafd90642cd70f9bbd4885874b24f716d524e52cf9e44c7ba338e3c416e78bd7b6ec6eaa1cb5066244504
+a8f54460a4708efd840358f32d0968fd  NetworkManager-1.0.10.tar.xz

tests/tests.yml

@@ -1,13 +0,0 @@
-# Tests for NetworkManager
-- hosts: localhost
-  roles:
-  - role: standard-test-basic
-    tags:
-    - classic
-    repositories:
-    - repo: "https://github.com/NetworkManager/NetworkManager-ci"
-      dest: "NetworkManager-ci"
-    tests:
-    - sanity-tests:
-        dir: NetworkManager-ci
-        run: run/osci/run-tests fedora28