Eric W. Biederman de12a7878c [PATCH] de_thread: Don't confuse users do_each_thread.
Oleg Nesterov spotted two interesting bugs with the current de_thread
code.  The simplest is a long standing double decrement of
__get_cpu_var(process_counts) in __unhash_process.  Caused by
two processes exiting when only one was created.

The other is that since we no longer detach from the thread_group list
it is possible for do_each_thread when run under the tasklist_lock to
see the same task_struct twice.  Once on the task list as a
thread_group_leader, and once on the thread list of another
thread.

The double appearance in do_each_thread can cause a double increment
of mm_core_waiters in zap_threads resulting in problems later on in
coredump_wait.

To remedy those two problems this patch takes the simple approach
of changing the old thread group leader into a child thread.
The only routine in release_task that cares is __unhash_process,
and it can be trivially seen that we handle cleaning up a
thread group leader properly.

Since de_thread doesn't change the pid of the exiting leader process
and instead shares it with the new leader process.  I change
thread_group_leader to recognize group leadership based on the
group_leader field and not based on pids.  This should also be
slightly cheaper then the existing thread_group_leader macro.

I performed a quick audit and I couldn't see any user of
thread_group_leader that cared about the difference.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-04-10 16:36:50 -07:00
..
2006-01-08 20:14:02 -08:00
2006-03-21 08:52:18 -08:00
2006-02-22 09:32:46 +00:00
2006-03-31 12:18:48 -08:00
2006-01-13 16:29:56 -08:00
2005-11-13 18:14:17 -08:00
2006-03-20 14:08:55 -05:00
2006-01-13 09:12:21 -08:00
2005-10-04 13:22:01 -07:00
2005-09-10 10:06:21 -07:00
2006-03-24 07:33:20 -08:00
2006-03-28 09:16:05 -08:00
2006-03-23 07:38:09 -08:00
2005-09-10 10:16:27 -07:00
2006-03-27 08:44:59 -08:00
2006-01-08 20:14:02 -08:00
2006-03-27 08:44:59 -08:00
2006-01-08 20:13:49 -08:00
2005-11-05 21:00:02 -05:00
2006-03-31 12:18:54 -08:00
2006-01-18 19:20:29 -08:00
2006-04-01 01:41:22 +02:00
2006-04-02 00:08:05 -05:00
2005-11-10 02:26:41 +01:00
2006-01-14 18:27:09 -08:00
2006-03-26 08:56:56 -08:00
2006-03-27 08:44:51 -08:00
2005-11-08 17:14:08 +01:00
2005-11-08 09:40:47 -08:00
2005-08-29 16:01:32 -07:00
2005-09-19 15:41:28 -07:00
2006-03-20 17:09:11 -08:00
2005-08-29 16:01:32 -07:00
2006-03-20 22:41:23 -08:00
2006-01-06 13:24:54 -08:00
2006-04-02 00:10:28 -05:00
2006-02-01 08:53:13 -08:00
2006-02-08 01:03:52 -05:00
2006-01-06 13:24:29 -08:00
2006-03-26 08:56:56 -08:00
2006-03-20 22:21:10 -08:00
2005-11-07 14:18:56 +01:00
2005-09-17 11:50:02 -07:00
2005-10-08 15:00:57 -07:00
2006-03-20 13:42:59 -08:00
2006-03-23 07:38:12 -08:00
2005-10-30 17:37:17 -08:00
2006-03-23 07:38:12 -08:00
2006-03-27 08:44:52 -08:00
2005-10-28 08:16:47 -07:00
2005-09-14 08:46:21 -04:00
2006-03-22 07:53:57 -08:00
2006-03-27 08:44:48 -08:00
2006-03-23 07:38:13 -08:00
2006-03-23 07:38:14 -08:00
2006-03-23 07:38:14 -08:00
2006-03-20 13:44:40 -05:00
2006-03-20 13:44:27 -05:00
2006-03-29 13:24:50 +11:00
2006-03-08 14:14:01 -08:00
2006-01-15 02:12:54 +01:00
2006-03-27 08:44:48 -08:00
2006-03-25 08:22:51 -08:00
2006-03-25 08:22:53 -08:00
2005-11-07 07:53:46 -08:00
2006-03-27 08:44:51 -08:00
2005-10-30 11:14:39 +11:00
2006-01-10 08:01:42 -08:00
2006-01-08 20:14:02 -08:00
2005-11-07 07:53:41 -08:00
2006-03-23 07:38:12 -08:00
2005-10-30 17:37:32 -08:00
2006-04-02 00:08:05 -05:00
2005-11-07 07:53:37 -08:00
2006-01-14 18:27:13 -08:00
2006-03-20 22:41:23 -08:00
2006-03-28 09:16:05 -08:00
2005-09-10 10:06:21 -07:00
2006-03-24 07:33:31 -08:00
2006-03-23 07:38:07 -08:00
2005-09-05 00:05:45 -07:00
2006-03-31 12:18:54 -08:00
2005-10-30 17:37:32 -08:00
2005-09-18 00:18:32 -07:00
2006-03-26 08:57:03 -08:00
2006-03-31 12:18:56 -08:00
2006-01-12 14:06:38 -08:00
2006-01-10 08:01:59 -08:00
2006-03-23 07:38:11 -08:00
2006-03-26 08:57:00 -08:00
2006-03-23 07:38:14 -08:00
2006-03-28 09:16:05 -08:00
2005-10-29 21:40:35 -07:00
2005-11-07 07:53:41 -08:00
2006-03-23 07:12:57 -05:00
2006-01-10 08:01:57 -08:00