Anton Vorontsov d407e32efe PCI: Fix oops in pci_vpd_truncate ... pci_vpd_truncate() should check for dev->vpd->attr, otherwise this might happen: sky2 driver version 1.22 Unable to handle kernel paging request for data at address 0x0000000c Faulting instruction address: 0xc01836fc Oops: Kernel access of bad area, sig: 11 [#1] [...] NIP [c01836fc] pci_vpd_truncate+0x38/0x40 LR [c029be18] sky2_probe+0x14c/0x518 Call Trace: [ef82bde0] [c029bda4] sky2_probe+0xd8/0x518 (unreliable) [ef82be20] [c018a11c] local_pci_probe+0x24/0x34 [ef82be30] [c018a14c] pci_call_probe+0x20/0x30 [ef82be50] [c018a330] __pci_device_probe+0x64/0x78 [ef82be60] [c018a44c] pci_device_probe+0x30/0x58 [ef82be80] [c01aa270] really_probe+0x78/0x1a0 [ef82bea0] [c01aa460] __driver_attach+0xa4/0xa8 [ef82bec0] [c01a96ac] bus_for_each_dev+0x60/0x9c [ef82bef0] [c01aa0b4] driver_attach+0x24/0x34 [ef82bf00] [c01a9e08] bus_add_driver+0x12c/0x1cc [ef82bf20] [c01aa87c] driver_register+0x6c/0x110 [ef82bf30] [c018a770] __pci_register_driver+0x4c/0x9c [ef82bf50] [c03782c8] sky2_init_module+0x30/0x40 [ef82bf60] [c0001dbc] do_one_initcall+0x34/0x1a0 [ef82bfd0] [c0362240] do_initcalls+0x38/0x58 This happens with CONFIG_SKY2=y, and "ip=on" kernel command line, so pci_vpd_truncate() is called before late_initcall(pci_sysfs_init), therefore ->attr isn't yet initialized. Acked-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2009-04-07 08:05:38 -07:00
..
accessibility
acpi	ACPI: processor: use .notify method instead of installing handler directly	2009-04-05 02:25:07 -04:00
amba
ata
atm
auxdisplay
base	Merge git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-cpumask	2009-04-05 10:33:07 -07:00
block
bluetooth
cdrom
char	rio: addition has higher precedence than ?:	2009-04-06 14:36:43 -07:00
clocksource
connector
cpufreq
cpuidle
crypto
dca
dio
dma
edac
eisa
firewire
firmware
gpio	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2009-04-03 15:24:35 -07:00
gpu	Merge branch 'linus' into release	2009-04-05 02:14:15 -04:00
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid	2009-04-03 15:25:44 -07:00
hwmon	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2009-04-03 15:24:35 -07:00
i2c	i2c: Delete unused i2c-algo-sgi helper module	2009-04-06 18:12:25 +02:00
ide
idle
ieee1394
infiniband
input	Merge git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6	2009-04-05 11:15:54 -07:00
isdn	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6	2009-04-06 18:05:43 -07:00
leds	leds: introduce lp5521 led driver	2009-04-06 16:06:27 +01:00
lguest
macintosh
mca
md	md/raid1: fix build breakage	2009-04-06 14:40:07 -07:00
media	cx231xx: Convert to snd_card_create()	2009-04-06 21:44:53 -03:00
memstick
message
mfd	mfd: fix da903x warning	2009-04-05 00:32:25 +02:00
misc	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2009-04-03 15:24:35 -07:00
mmc	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc	2009-04-05 10:18:21 -07:00
mtd	Merge branch 'linux-next' of git://git.infradead.org/ubi-2.6	2009-04-06 15:00:00 -07:00
net	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6	2009-04-06 18:05:43 -07:00
nubus
of
oprofile	Merge branch 'tracing-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip	2009-04-05 11:04:19 -07:00
parisc
parport
pci	PCI: Fix oops in pci_vpd_truncate	2009-04-07 08:05:38 -07:00
pcmcia
platform	Merge branch 'linus' into release	2009-04-05 02:14:15 -04:00
pnp	Merge branch 'linus' into release	2009-04-05 02:14:15 -04:00
power	Merge branch 'linus' into release	2009-04-05 02:14:15 -04:00
ps3
rapidio
regulator
rtc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/lethal/sh-2.6	2009-04-05 11:15:54 -07:00
s390
sbus
scsi	Merge git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6	2009-04-06 13:24:49 -07:00
serial	Merge branch 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc	2009-04-07 07:40:55 -07:00
sh
sn
spi
ssb
staging	Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6	2009-04-05 11:06:45 -07:00
tc
telephony
thermal
uio
usb	symbol: Remove various bits of left over junk	2009-04-06 14:36:42 -07:00
uwb
video	Merge branch 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc	2009-04-07 07:40:55 -07:00
virtio
w1	mfd: remove DS1WM clock handling	2009-04-05 00:32:22 +02:00
watchdog	powerpc/wdrtas: Update wdrtas_get_interval to use rtas_data_buf	2009-04-07 15:07:43 +10:00
xen	Merge git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-cpumask	2009-04-05 10:33:07 -07:00
zorro
Kconfig
Makefile