Paul Mackerras 7c3fbbdd04 slab: fix nodeid bounds check for non-contiguous node IDs ... The bounds check for nodeid in ____cache_alloc_node gives false positives on machines where the node IDs are not contiguous, leading to a panic at boot time. For example, on a POWER8 machine the node IDs are typically 0, 1, 16 and 17. This means that num_online_nodes() returns 4, so when ____cache_alloc_node is called with nodeid = 16 the VM_BUG_ON triggers, like this: kernel BUG at /home/paulus/kernel/kvm/mm/slab.c:3079! Call Trace: .____cache_alloc_node+0x5c/0x270 (unreliable) .kmem_cache_alloc_node_trace+0xdc/0x360 .init_list+0x3c/0x128 .kmem_cache_init+0x1dc/0x258 .start_kernel+0x2a0/0x568 start_here_common+0x20/0xa8 To fix this, we instead compare the nodeid with MAX_NUMNODES, and additionally make sure it isn't negative (since nodeid is an int). The check is there mainly to protect the array dereference in the get_node() call in the next line, and the array being dereferenced is of size MAX_NUMNODES. If the nodeid is in range but invalid (for example if the node is off-line), the BUG_ON in the next line will catch that. Fixes: 14e50c6a9b ("mm: slab: Verify the nodeid passed to ____cache_alloc_node") Signed-off-by: Paul Mackerras <paulus@samba.org> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Reviewed-by: Pekka Enberg <penberg@kernel.org> Acked-by: David Rientjes <rientjes@google.com> Cc: Christoph Lameter <cl@linux.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2014-12-03 09:36:04 -08:00
..
backing-dev.c	Merge branch 'for-3.18/core' of git://git.kernel.dk/linux-block	2014-10-18 11:53:51 -07:00
balloon_compaction.c	mm/balloon_compaction: fix deflation when compaction is disabled	2014-10-29 16:33:15 -07:00
bootmem.c	mem-hotplug: reset node managed pages when hot-adding a new pgdat	2014-11-13 16:17:06 -08:00
cleancache.c
cma.c	mm: cma: Use %pa to print physical addresses	2014-10-27 13:00:55 +01:00
compaction.c	mm, compaction: prevent infinite loop in compact_zone	2014-11-13 16:17:06 -08:00
debug-pagealloc.c
debug.c	mm/debug.c: use pr_emerg()	2014-10-09 22:25:59 -04:00
dmapool.c	mm/dmapool.c: fixed a brace coding style issue	2014-10-09 22:26:00 -04:00
early_ioremap.c
fadvise.c
failslab.c
filemap_xip.c
filemap.c	mm/filemap.c: remove trailing whitespace	2014-10-09 22:26:00 -04:00
fremap.c
frontswap.c	mm: frontswap: invalidate expired data on a dup-store failure	2014-12-02 17:32:07 -08:00
gup.c	mm: introduce a general RCU get_user_pages_fast()	2014-10-09 22:26:00 -04:00
highmem.c	mm/highmem: make kmap cache coloring aware	2014-08-06 18:01:22 -07:00
huge_memory.c	mm, thp: fix collapsing of hugepages on madvise	2014-10-29 16:33:14 -07:00
hugetlb_cgroup.c	hugetlb_cgroup: use lockdep_assert_held rather than spin_is_locked	2014-08-29 16:28:16 -07:00
hugetlb.c	mm: convert a few VM_BUG_ON callers to VM_BUG_ON_VMA	2014-10-09 22:25:57 -04:00
hwpoison-inject.c	mm/hwpoison-inject.c: remove unnecessary null test before debugfs_remove_recursive	2014-08-06 18:01:19 -07:00
init-mm.c
internal.h	mm/page_alloc: restrict max order of merging on isolated pageblock	2014-11-13 16:17:05 -08:00
interval_tree.c	mm: convert a few VM_BUG_ON callers to VM_BUG_ON_VMA	2014-10-09 22:25:57 -04:00
iov_iter.c	Fix thinko in iov_iter_single_seg_count	2014-11-13 13:28:55 -05:00
Kconfig	mm/balloon_compaction: add vmstat counters and kpageflags bit	2014-10-09 22:26:01 -04:00
Kconfig.debug
kmemcheck.c	mm/slab_common: move kmem_cache definition to internal header	2014-10-09 22:25:50 -04:00
kmemleak-test.c
kmemleak.c
ksm.c	mm: ksm use pr_err instead of printk	2014-10-09 22:26:00 -04:00
list_lru.c
maccess.c
madvise.c
Makefile	Fixup for 3.18: use PATCHv2 of "mm: Support compiling out madvise and fadvise"	2014-10-12 09:21:57 -04:00
memblock.c	mem-hotplug: let memblock skip the hotpluggable memory regions in __next_mem_range()	2014-09-10 15:42:12 -07:00
memcontrol.c	mm: memcontrol: fix missed end-writeback page accounting	2014-10-29 16:33:15 -07:00
memory_hotplug.c	mem-hotplug: reset node present pages when hot-adding a new pgdat	2014-11-13 16:17:06 -08:00
memory-failure.c	cgroup: remove redundant check in cgroup_ino()	2014-09-19 09:16:23 -04:00
memory.c	mm: fix swapoff hang after page migration and fork	2014-12-03 09:36:03 -08:00
mempolicy.c	mm: mempolicy: skip inaccessible VMAs when setting MPOL_MF_LAZY	2014-10-09 22:26:02 -04:00
mempool.c
migrate.c	mm/balloon_compaction: redesign ballooned pages management	2014-10-09 22:26:01 -04:00
mincore.c
mlock.c	Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2014-10-13 15:44:12 +02:00
mm_init.c
mmap.c	mm: fix anon_vma_clone() error treatment	2014-12-03 09:36:04 -08:00
mmu_context.c
mmu_notifier.c	kvm: Fix page ageing bugs	2014-09-24 14:07:58 +02:00
mmzone.c
mprotect.c	mm: softdirty: enable write notifications on VMAs after VM_SOFTDIRTY cleared	2014-10-14 02:18:28 +02:00
mremap.c	mm/mremap.c: use linux headers	2014-10-09 22:26:00 -04:00
msync.c
nobootmem.c	mem-hotplug: reset node managed pages when hot-adding a new pgdat	2014-11-13 16:17:06 -08:00
nommu.c	percpu_counter: add @gfp to percpu_counter_init()	2014-09-08 09:51:29 +09:00
oom_kill.c	OOM, PM: OOM killed task shouldn't escape PM suspend	2014-10-21 23:44:21 +02:00
page_alloc.c	mm/debug-pagealloc: correct freepage accounting and order resetting	2014-11-13 16:17:06 -08:00
page_cgroup.c	cgroup/kmemleak: add kmemleak_free() for cgroup deallocations.	2014-10-29 16:33:13 -07:00
page_io.c
page_isolation.c	mm/page_alloc: restrict max order of merging on isolated pageblock	2014-11-13 16:17:05 -08:00
page-writeback.c	mm: memcontrol: fix missed end-writeback page accounting	2014-10-29 16:33:15 -07:00
pagewalk.c	mm: use VM_BUG_ON_MM where possible	2014-10-09 22:25:58 -04:00
percpu-km.c	percpu: implmeent pcpu_nr_empty_pop_pages and chunk->nr_populated	2014-09-02 14:46:05 -04:00
percpu-vm.c	percpu: move region iterations out of pcpu_[de]populate_chunk()	2014-09-02 14:46:02 -04:00
percpu.c	percpu: fix how @gfp is interpreted by the percpu allocator	2014-10-08 12:01:52 -04:00
pgtable-generic.c	mm: actually clear pmd_numa before invalidating	2014-08-29 16:28:15 -07:00
process_vm_access.c
quicklist.c
readahead.c
rmap.c	mm: fix anon_vma_clone() error treatment	2014-12-03 09:36:04 -08:00
shmem.c	shmem: support RENAME_WHITEOUT	2014-10-24 00:14:37 +02:00
slab_common.c	mm/slab: fix unalignment problem on Malta with EVA due to slab merge	2014-11-13 16:17:05 -08:00
slab.c	slab: fix nodeid bounds check for non-contiguous node IDs	2014-12-03 09:36:04 -08:00
slab.h	mm/slab: use percpu allocator for cpu cache	2014-10-09 22:25:51 -04:00
slob.c	mm/sl[ao]b: always track caller in kmalloc_(node_)track_caller()	2014-10-09 22:25:50 -04:00
slub.c	mm/slab_common: commonize slab merge logic	2014-10-09 22:25:51 -04:00
sparse-vmemmap.c
sparse.c
swap_state.c	mm: memcontrol: do not kill uncharge batching in free_pages_and_swap_cache	2014-10-09 22:25:59 -04:00
swap.c	mm: memcontrol: do not kill uncharge batching in free_pages_and_swap_cache	2014-10-09 22:25:59 -04:00
swapfile.c	mm: memcontrol: rewrite uncharge API	2014-08-08 15:57:17 -07:00
truncate.c	mm: Fix comment before truncate_setsize()	2014-11-07 08:29:25 +11:00
util.c	proc/maps: make vm_is_stack() logic namespace-friendly	2014-10-09 22:25:50 -04:00
vmacache.c
vmalloc.c	mm/vmalloc.c: use seq_open_private() instead of seq_open()	2014-10-09 22:25:56 -04:00
vmpressure.c	mm/vmpressure.c: fix race in vmpressure_work_fn()	2014-12-02 17:32:07 -08:00
vmscan.c	mm: memcontrol: fix transparent huge page allocations under pressure	2014-10-09 22:25:59 -04:00
vmstat.c	vmstat: on-demand vmstat workers V8	2014-10-09 22:26:02 -04:00
workingset.c
zbud.c	zbud: avoid accessing last unused freelist	2014-10-09 22:26:03 -04:00
zpool.c	mm/zpool: use prefixed module loading	2014-08-29 16:28:16 -07:00
zsmalloc.c	zsmalloc: simplify init_zspage free obj linking	2014-10-09 22:26:03 -04:00
zswap.c	mm/zswap.c: add __init to zswap_entry_cache_destroy()	2014-08-08 15:57:18 -07:00