b914f3a2a3
The recent changes to add RCU lock verification to rcu_dereference() calls caught out a problem with netlbl_unlhsh_hash(), see below. =================================================== [ INFO: suspicious rcu_dereference_check() usage. ] --------------------------------------------------- net/netlabel/netlabel_unlabeled.c:246 invoked rcu_dereference_check() without protection! This patch fixes this problem as well as others like it in the NetLabel code. Also included in this patch is the identification of future work to eliminate the RCU read lock in netlbl_domhsh_add(), but in the interest of getting this patch out quickly that work will happen in another patch to be finished later. Thanks to Eric Dumazet and Paul McKenney for their help in understanding the recent RCU changes. Signed-off-by: Paul Moore <paul.moore@hp.com> Reported-by: David Howells <dhowells@redhat.com> CC: Eric Dumazet <eric.dumazet@gmail.com> CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Acked-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| netlabel_addrlist.c | ||
| netlabel_addrlist.h | ||
| netlabel_cipso_v4.c | ||
| netlabel_cipso_v4.h | ||
| netlabel_domainhash.c | ||
| netlabel_domainhash.h | ||
| netlabel_kapi.c | ||
| netlabel_mgmt.c | ||
| netlabel_mgmt.h | ||
| netlabel_unlabeled.c | ||
| netlabel_unlabeled.h | ||
| netlabel_user.c | ||
| netlabel_user.h | ||