kernel-ark/drivers/cpufreq
Dominik Brodowski ce6c3997c2 [CPUFREQ] Re-enable cpufreq suspend and resume code
Commit 4bc5d34135 is broken and causes regressions:

(1) cpufreq_driver->resume() and ->suspend() were only called on
__powerpc__, but you could set them on all architectures. In fact,
->resume() was defined and used before the PPC-related commit
42d4dc3f4e complained about in 4bc5d34135.

(2) Therfore, the resume functions in acpi_cpufreq and speedstep-smi
would never be called.

(3) This means speedstep-smi would be unusuable after suspend or resume.

The _real_ problem was calling cpufreq_driver->get() with interrupts
off, but it re-enabling interrupts on some platforms. Why is ->get()
necessary?

Some systems like to change the CPU frequency behind our
back, especially during BIOS-intensive operations like suspend or
resume. If such systems also use a CPU frequency-dependant timing loop,
delays might be off by large factors. Therefore, we need to ascertain
as soon as possible that the CPU frequency is indeed at the speed we
think it is. You can do this two ways: either setting it anew, or trying
to get it. The latter is what was done, the former also has the same IRQ
issue.

So, let's try something different: defer the checking to after interrupts
are re-enabled, by calling cpufreq_update_policy() (via schedule_work()).
Timings may be off until this later stage, so let's watch out for
resume regressions caused by the deferred handling of frequency changes
behind the kernel's back.

Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Dave Jones <davej@redhat.com>
2009-09-01 12:45:08 -04:00
..
cpufreq_conservative.c [CPUFREQ] Fix NULL pointer dereference regression in conservative governor 2009-08-04 14:32:10 -04:00
cpufreq_ondemand.c [CPUFREQ] Cleanup locking in ondemand governor 2009-07-06 21:38:28 -04:00
cpufreq_performance.c [CPUFREQ] Don't export governors for default governor 2008-10-09 13:52:44 -04:00
cpufreq_powersave.c [CPUFREQ] Don't export governors for default governor 2008-10-09 13:52:44 -04:00
cpufreq_stats.c [CPUFREQ] checkpatch cleanups for cpufreq_stats 2009-02-24 22:47:30 -05:00
cpufreq_userspace.c [CPUFREQ] checkpatch cleanups for userspace governor 2009-02-24 22:47:30 -05:00
cpufreq.c [CPUFREQ] Re-enable cpufreq suspend and resume code 2009-09-01 12:45:08 -04:00
freq_table.c [CPUFREQ] checkpatch cleanups for freq_table 2009-02-24 22:47:30 -05:00
Kconfig trivial: fix an -> a typos in documentation and comments 2009-01-06 11:28:07 +01:00
Makefile [CPUFREQ] Conservative cpufreq governer 2005-05-31 19:03:47 -07:00