5160ee6fc8
Some long time ago, dentry struct was carefully tuned so that on 32 bits UP, sizeof(struct dentry) was exactly 128, ie a power of 2, and a multiple of memory cache lines. Then RCU was added and dentry struct enlarged by two pointers, with nice results for SMP, but not so good on UP, because breaking the above tuning (128 + 8 = 136 bytes) This patch reverts this unwanted side effect, by using an union (d_u), where d_rcu and d_child are placed so that these two fields can share their memory needs. At the time d_free() is called (and d_rcu is really used), d_child is known to be empty and not touched by the dentry freeing. Lockless lookups only access d_name, d_parent, d_lock, d_op, d_flags (so the previous content of d_child is not needed if said dentry was unhashed but still accessed by a CPU because of RCU constraints) As dentry cache easily contains millions of entries, a size reduction is worth the extra complexity of the ugly C union. Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> Cc: Dipankar Sarma <dipankar@in.ibm.com> Cc: Maneesh Soni <maneesh@in.ibm.com> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: "Paul E. McKenney" <paulmck@us.ibm.com> Cc: Ian Kent <raven@themaw.net> Cc: Paul Jackson <pj@sgi.com> Cc: Al Viro <viro@ftp.linux.org.uk> Cc: Christoph Hellwig <hch@lst.de> Cc: Trond Myklebust <trond.myklebust@fys.uio.no> Cc: Neil Brown <neilb@cse.unsw.edu.au> Cc: James Morris <jmorris@namei.org> Cc: Stephen Smalley <sds@epoch.ncsc.mil> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
121 lines
2.9 KiB
C
121 lines
2.9 KiB
C
/*
|
|
* Cache operations for Coda.
|
|
* For Linux 2.1: (C) 1997 Carnegie Mellon University
|
|
* For Linux 2.3: (C) 2000 Carnegie Mellon University
|
|
*
|
|
* Carnegie Mellon encourages users of this code to contribute improvements
|
|
* to the Coda project http://www.coda.cs.cmu.edu/ <coda@cs.cmu.edu>.
|
|
*/
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/time.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/stat.h>
|
|
#include <linux/errno.h>
|
|
#include <asm/uaccess.h>
|
|
#include <linux/string.h>
|
|
#include <linux/list.h>
|
|
|
|
#include <linux/coda.h>
|
|
#include <linux/coda_linux.h>
|
|
#include <linux/coda_psdev.h>
|
|
#include <linux/coda_fs_i.h>
|
|
#include <linux/coda_cache.h>
|
|
|
|
static atomic_t permission_epoch = ATOMIC_INIT(0);
|
|
|
|
/* replace or extend an acl cache hit */
|
|
void coda_cache_enter(struct inode *inode, int mask)
|
|
{
|
|
struct coda_inode_info *cii = ITOC(inode);
|
|
|
|
cii->c_cached_epoch = atomic_read(&permission_epoch);
|
|
if (cii->c_uid != current->fsuid) {
|
|
cii->c_uid = current->fsuid;
|
|
cii->c_cached_perm = mask;
|
|
} else
|
|
cii->c_cached_perm |= mask;
|
|
}
|
|
|
|
/* remove cached acl from an inode */
|
|
void coda_cache_clear_inode(struct inode *inode)
|
|
{
|
|
struct coda_inode_info *cii = ITOC(inode);
|
|
cii->c_cached_perm = 0;
|
|
}
|
|
|
|
/* remove all acl caches */
|
|
void coda_cache_clear_all(struct super_block *sb)
|
|
{
|
|
struct coda_sb_info *sbi;
|
|
|
|
sbi = coda_sbp(sb);
|
|
if (!sbi) BUG();
|
|
|
|
atomic_inc(&permission_epoch);
|
|
}
|
|
|
|
|
|
/* check if the mask has been matched against the acl already */
|
|
int coda_cache_check(struct inode *inode, int mask)
|
|
{
|
|
struct coda_inode_info *cii = ITOC(inode);
|
|
int hit;
|
|
|
|
hit = (mask & cii->c_cached_perm) == mask &&
|
|
cii->c_uid == current->fsuid &&
|
|
cii->c_cached_epoch == atomic_read(&permission_epoch);
|
|
|
|
return hit;
|
|
}
|
|
|
|
|
|
/* Purging dentries and children */
|
|
/* The following routines drop dentries which are not
|
|
in use and flag dentries which are in use to be
|
|
zapped later.
|
|
|
|
The flags are detected by:
|
|
- coda_dentry_revalidate (for lookups) if the flag is C_PURGE
|
|
- coda_dentry_delete: to remove dentry from the cache when d_count
|
|
falls to zero
|
|
- an inode method coda_revalidate (for attributes) if the
|
|
flag is C_VATTR
|
|
*/
|
|
|
|
/* this won't do any harm: just flag all children */
|
|
static void coda_flag_children(struct dentry *parent, int flag)
|
|
{
|
|
struct list_head *child;
|
|
struct dentry *de;
|
|
|
|
spin_lock(&dcache_lock);
|
|
list_for_each(child, &parent->d_subdirs)
|
|
{
|
|
de = list_entry(child, struct dentry, d_u.d_child);
|
|
/* don't know what to do with negative dentries */
|
|
if ( ! de->d_inode )
|
|
continue;
|
|
coda_flag_inode(de->d_inode, flag);
|
|
}
|
|
spin_unlock(&dcache_lock);
|
|
return;
|
|
}
|
|
|
|
void coda_flag_inode_children(struct inode *inode, int flag)
|
|
{
|
|
struct dentry *alias_de;
|
|
|
|
if ( !inode || !S_ISDIR(inode->i_mode))
|
|
return;
|
|
|
|
alias_de = d_find_alias(inode);
|
|
if (!alias_de)
|
|
return;
|
|
coda_flag_children(alias_de, flag);
|
|
shrink_dcache_parent(alias_de);
|
|
dput(alias_de);
|
|
}
|
|
|