kernel-ark/drivers/block
Tejun Heo ba02508248 [PATCH] blk: fix tag shrinking (revive real_max_size)
My patch in commit fa72b903f7 incorrectly
removed blk_queue_tag->real_max_depth.

The original resize implementation was incorrect in the following
points.

 * actual allocation size of tag_index was shorter than real_max_size,
   but assumed to be of the same size, possibly causing memory access
   beyond the allocated area.
 * bits in tag_map between max_deptn and real_max_depth were
   initialized to 1's, making the tags permanently reserved.

In an attempt to fix above two bugs, I had removed allocation optimization
in init_tag_map and real_max_size.  Tag map/index were allocated and freed
immediately during resize.

Unfortunately, I wasn't considering that tag map/index can be resized
dynamically with tags beyond new_depth active.  This led to accessing
freed area after shrinking tags and led to the following bug reporting
thread on linux-scsi.

   http://marc.theaimsgroup.com/?l=linux-scsi&m=112319898111885&w=2

To fix the problem, I've revived real_max_depth without allocation
optimization in init_tag_map, and Andrew Vasquez confirmed that the
problem was fixed.  As Jens is not going to be available for a week, he
asked me to make sure that this patch reaches you.

   http://marc.theaimsgroup.com/?l=linux-scsi&m=112325778530886&w=2

Also, a comment was added to make sure that real_max_size is needed for
dynamic shrinking.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-08-05 13:43:16 -07:00
..
aoe [PATCH] class: convert drivers/block/* to use the new class api instead of class_simple 2005-06-20 15:15:07 -07:00
paride [PATCH] class: convert drivers/block/* to use the new class api instead of class_simple 2005-06-20 15:15:07 -07:00
acsi_slm.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
acsi.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
amiflop.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
as-iosched.c [PATCH] as-iosched tunable encoding fix 2005-07-27 16:25:50 -07:00
ataflop.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cciss_cmd.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cciss_scsi.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cciss_scsi.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cciss.c [PATCH] cciss per disk queue 2005-07-28 08:39:01 -07:00
cciss.h [PATCH] cciss per disk queue 2005-07-28 08:39:01 -07:00
cfq-iosched.c [PATCH] cfq-iosched: fix problem with barriers and max_depth == 1 2005-08-02 11:19:18 -07:00
cpqarray.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cpqarray.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
cryptoloop.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
DAC960.c [PATCH] DAC960: add support for Mylex AcceleRAID 4/5/600 2005-05-05 16:36:43 -07:00
DAC960.h [PATCH] DAC960: add support for Mylex AcceleRAID 4/5/600 2005-05-05 16:36:43 -07:00
deadline-iosched.c [PATCH] Update cfq io scheduler to time sliced design 2005-06-27 14:33:29 -07:00
elevator.c [PATCH] Update cfq io scheduler to time sliced design 2005-06-27 14:33:29 -07:00
floppy.c [PATCH] remove do_sync parameter from __invalidate_device 2005-05-05 16:36:44 -07:00
genhd.c [PATCH] add check to /proc/devices read routines 2005-06-23 09:45:19 -07:00
ida_cmd.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ida_ioctl.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ioctl.c [PATCH] block: add unlocked_ioctl support for block devices 2005-06-23 09:45:32 -07:00
Kconfig [PATCH] ISA DMA Kconfig fixes - part 3 2005-05-04 07:33:14 -07:00
Kconfig.iosched Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
ll_rw_blk.c [PATCH] blk: fix tag shrinking (revive real_max_size) 2005-08-05 13:43:16 -07:00
loop.c [PATCH] optimise loop driver a bit 2005-06-23 09:45:18 -07:00
Makefile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
nbd.c [PATCH] nbd: Don't create all MAX_NBD devices by default all the time 2005-05-01 08:59:07 -07:00
noop-iosched.c [PATCH] noop-iosched: kill O(N) merge scan 2005-05-01 08:59:06 -07:00
pktcdvd.c [PATCH] Cleanup patch for process freezing 2005-06-25 17:10:13 -07:00
ps2esdi.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
rd.c [PATCH] drivers/block/rd.c: rd_size shouldn't be static 2005-05-06 16:58:18 -07:00
scsi_ioctl.c [PATCH] consolidate timeout defintions in scsi.h 2005-04-18 12:31:52 -05:00
smart1,2.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
swim3.c [PATCH] ppc32: Remove CONFIG_PMAC_PBOOK 2005-06-27 15:11:43 -07:00
swim_iop.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
sx8.c [PATCH] turn many #if $undefined_string into #ifdef $undefined_string 2005-07-27 16:26:08 -07:00
ub.c [PATCH] ub: fix for blank CDs 2005-07-27 16:25:52 -07:00
umem.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
viodasd.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
xd.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
xd.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
z2ram.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00