kernel-ark/drivers/usb
David Woodhouse 80193195f8 Fix oops on close of hot-unplugged FTDI serial converter
Commit c45d6320 ("fix reference counting of ftdi_private") stopped
ftdi_sio_port_remove() from directly freeing the port-private data, with
the intention if the port was still open, it would be freed when
ftdi_close() is eventually called and releases the last refcount on the
structure.

That's all very well, but ftdi_sio_port_remove() still contains a call
to usb_set_serial_port_data(port, NULL) -- so by the time we get to
ftdi_close() for the port which was unplugged, it _still_ oopses on
dereferencing that NULL pointer, as it did before (and does in 2.6.29).

The fix is just not to clear the private data in ftdi_sio_port_remove().
Then the refcount is properly reduced to zero when the final kref_put()
happens in ftdi_close().

Remove a bogus comment too, while we're at it. And stop doing things
inside "if (priv)" -- it must _always_ be there.

Based loosely on an earlier patch by Daniel Mack, and suggestions by
Alan Stern.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Tested-by: Daniel Mack <daniel@caiaq.de>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-05-18 08:37:15 -07:00
..
atm USB: cxacru: Fix negative dB output 2009-05-08 19:34:56 -07:00
c67x00 usb/c67x00 endianness annotations 2008-06-04 08:06:01 -07:00
class USB: correct error handling in cdc-wdm 2009-04-23 14:15:30 -07:00
core USB: pass mem_flags to dma_alloc_coherent 2009-04-23 14:15:28 -07:00
gadget USB: Gadget: fix UTF conversion in the usbstring library 2009-05-08 19:34:56 -07:00
host USB: ehci-sched.c: EHCI SITD scheduling bugfix 2009-04-23 14:15:28 -07:00
image USB: replace uses of __constant_{endian} 2009-03-24 16:20:33 -07:00
misc USB: remove phidget drivers from kernel tree. 2009-03-24 16:20:37 -07:00
mon USB: usbmon: Add binary API v1 2009-03-24 16:20:36 -07:00
musb USB: musb: fix build when !CONFIG_PM 2009-04-23 14:15:27 -07:00
otg USB: otg: Fix bug on remove path without transceiver 2009-04-23 14:15:31 -07:00
serial Fix oops on close of hot-unplugged FTDI serial converter 2009-05-18 08:37:15 -07:00
storage USB: unusual_devs: extend nokia 6288 bcd range 2009-05-08 19:34:57 -07:00
wusbcore WUSB: correct format of wusb_chid sysfs file 2009-04-17 10:50:29 -07:00
Kconfig sh: Add OHCI USB support for SH7786 2009-03-16 19:40:34 +09:00
Makefile USB: Fix makefile so that CONFIG_WDM and CONFIG_TMC work. 2009-05-08 19:34:56 -07:00
README USB: fix directory references in usb/README 2007-11-28 13:58:34 -08:00
usb-skeleton.c USB: skeleton: Use dev_info instead of info 2009-03-24 16:20:30 -07:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("khubd").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.