a1bdc7aad8
There are a number of sparse warnings from the latest sparse snapshot being generated from the drivers/base build. The main culprits are due to the initialisation functions not being declared in a header file. Also, the firmware.c file should include <linux/device.h> to get the prototype of firmware_register() and firmware_unregister(). This patch moves the init function declerations from the init.c file to the base.h, and ensures it is included in all the relevant c sources. It also adds <linux/device.h> to the included headers for firmware.c. The patch does not solve all the sparse errors generated, but reduces the count significantly. drivers/base/core.c:161:1: warning: symbol 'devices_subsys' was not declared. Should it be static? drivers/base/core.c:417:12: warning: symbol 'devices_init' was not declared. Should it be static? drivers/base/sys.c:253:6: warning: symbol 'sysdev_shutdown' was not declared. Should it be static? drivers/base/sys.c:326:5: warning: symbol 'sysdev_suspend' was not declared. Should it be static? drivers/base/sys.c:428:5: warning: symbol 'sysdev_resume' was not declared. Should it be static? drivers/base/sys.c:450:12: warning: symbol 'system_bus_init' was not declared. Should it be static? drivers/base/bus.c:133:1: warning: symbol 'bus_subsys' was not declared. Should it be static? drivers/base/bus.c:667:12: warning: symbol 'buses_init' was not declared. Should it be static? drivers/base/class.c:759:12: warning: symbol 'classes_init' was not declared. Should it be static? drivers/base/platform.c:313:12: warning: symbol 'platform_bus_init' was not declared. Should it be static? drivers/base/cpu.c:110:12: warning: symbol 'cpu_dev_init' was not declared. Should it be static? drivers/base/firmware.c:17:5: warning: symbol 'firmware_register' was not declared. Should it be static? drivers/base/firmware.c:23:6: warning: symbol 'firmware_unregister' was not declared. Should it be static? drivers/base/firmware.c:28:12: warning: symbol 'firmware_init' was not declared. Should it be static? drivers/base/init.c:28:13: warning: symbol 'driver_init' was not declared. Should it be static? drivers/base/dmapool.c:174:10: warning: implicit cast from nocast type drivers/base/attribute_container.c:439:1: warning: symbol 'attribute_container_init' was not declared. Should it be static? drivers/base/power/runtime.c:76:6: warning: symbol 'dpm_set_power_state' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben-linux@fluff.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
115 lines
2.5 KiB
C
115 lines
2.5 KiB
C
/*
|
|
* drivers/base/cpu.c - basic CPU class support
|
|
*/
|
|
|
|
#include <linux/sysdev.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/cpu.h>
|
|
#include <linux/topology.h>
|
|
#include <linux/device.h>
|
|
|
|
#include "base.h"
|
|
|
|
struct sysdev_class cpu_sysdev_class = {
|
|
set_kset_name("cpu"),
|
|
};
|
|
EXPORT_SYMBOL(cpu_sysdev_class);
|
|
|
|
#ifdef CONFIG_HOTPLUG_CPU
|
|
int __attribute__((weak)) smp_prepare_cpu (int cpu)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static ssize_t show_online(struct sys_device *dev, char *buf)
|
|
{
|
|
struct cpu *cpu = container_of(dev, struct cpu, sysdev);
|
|
|
|
return sprintf(buf, "%u\n", !!cpu_online(cpu->sysdev.id));
|
|
}
|
|
|
|
static ssize_t store_online(struct sys_device *dev, const char *buf,
|
|
size_t count)
|
|
{
|
|
struct cpu *cpu = container_of(dev, struct cpu, sysdev);
|
|
ssize_t ret;
|
|
|
|
switch (buf[0]) {
|
|
case '0':
|
|
ret = cpu_down(cpu->sysdev.id);
|
|
if (!ret)
|
|
kobject_hotplug(&dev->kobj, KOBJ_OFFLINE);
|
|
break;
|
|
case '1':
|
|
ret = smp_prepare_cpu(cpu->sysdev.id);
|
|
if (!ret)
|
|
ret = cpu_up(cpu->sysdev.id);
|
|
if (!ret)
|
|
kobject_hotplug(&dev->kobj, KOBJ_ONLINE);
|
|
break;
|
|
default:
|
|
ret = -EINVAL;
|
|
}
|
|
|
|
if (ret >= 0)
|
|
ret = count;
|
|
return ret;
|
|
}
|
|
static SYSDEV_ATTR(online, 0600, show_online, store_online);
|
|
|
|
static void __devinit register_cpu_control(struct cpu *cpu)
|
|
{
|
|
sysdev_create_file(&cpu->sysdev, &attr_online);
|
|
}
|
|
void unregister_cpu(struct cpu *cpu, struct node *root)
|
|
{
|
|
|
|
if (root)
|
|
sysfs_remove_link(&root->sysdev.kobj,
|
|
kobject_name(&cpu->sysdev.kobj));
|
|
sysdev_remove_file(&cpu->sysdev, &attr_online);
|
|
|
|
sysdev_unregister(&cpu->sysdev);
|
|
|
|
return;
|
|
}
|
|
#else /* ... !CONFIG_HOTPLUG_CPU */
|
|
static inline void register_cpu_control(struct cpu *cpu)
|
|
{
|
|
}
|
|
#endif /* CONFIG_HOTPLUG_CPU */
|
|
|
|
/*
|
|
* register_cpu - Setup a driverfs device for a CPU.
|
|
* @cpu - Callers can set the cpu->no_control field to 1, to indicate not to
|
|
* generate a control file in sysfs for this CPU.
|
|
* @num - CPU number to use when creating the device.
|
|
*
|
|
* Initialize and register the CPU device.
|
|
*/
|
|
int __devinit register_cpu(struct cpu *cpu, int num, struct node *root)
|
|
{
|
|
int error;
|
|
|
|
cpu->node_id = cpu_to_node(num);
|
|
cpu->sysdev.id = num;
|
|
cpu->sysdev.cls = &cpu_sysdev_class;
|
|
|
|
error = sysdev_register(&cpu->sysdev);
|
|
if (!error && root)
|
|
error = sysfs_create_link(&root->sysdev.kobj,
|
|
&cpu->sysdev.kobj,
|
|
kobject_name(&cpu->sysdev.kobj));
|
|
if (!error && !cpu->no_control)
|
|
register_cpu_control(cpu);
|
|
return error;
|
|
}
|
|
|
|
|
|
|
|
int __init cpu_dev_init(void)
|
|
{
|
|
return sysdev_class_register(&cpu_sysdev_class);
|
|
}
|