34173a4aad
The problem comes when ks0108/cfag12864b are built-in and no parallel port is present. ks0108_init() is called first, as it should be, but fails to load (as there is no parallel port to use). After that, cfag12864b_init() gets called, without knowing anything about ks0108 failed, and calls ks0108_writecontrol(), which dereferences an uninitialized pointer. Init order is OK, I think. The problem is how to stop cfag12864b_init() being called if ks0108 failed to load. modprobe does it for us, but, how when built-in? Signed-off-by: Miguel Ojeda Sandonis <maxextreme@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
83 lines
2.1 KiB
C
83 lines
2.1 KiB
C
/*
|
|
* Filename: cfag12864b.h
|
|
* Version: 0.1.0
|
|
* Description: cfag12864b LCD driver header
|
|
* License: GPLv2
|
|
*
|
|
* Author: Copyright (C) Miguel Ojeda Sandonis <maxextreme@gmail.com>
|
|
* Date: 2006-10-12
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
*/
|
|
|
|
#ifndef _CFAG12864B_H_
|
|
#define _CFAG12864B_H_
|
|
|
|
#define CFAG12864B_WIDTH (128)
|
|
#define CFAG12864B_HEIGHT (64)
|
|
#define CFAG12864B_CONTROLLERS (2)
|
|
#define CFAG12864B_PAGES (8)
|
|
#define CFAG12864B_ADDRESSES (64)
|
|
#define CFAG12864B_SIZE ((CFAG12864B_CONTROLLERS) * \
|
|
(CFAG12864B_PAGES) * \
|
|
(CFAG12864B_ADDRESSES))
|
|
|
|
/*
|
|
* The driver will blit this buffer to the LCD
|
|
*
|
|
* Its size is CFAG12864B_SIZE.
|
|
*/
|
|
extern unsigned char * cfag12864b_buffer;
|
|
|
|
/*
|
|
* Get the refresh rate of the LCD
|
|
*
|
|
* Returns the refresh rate (hertzs).
|
|
*/
|
|
extern unsigned int cfag12864b_getrate(void);
|
|
|
|
/*
|
|
* Enable refreshing
|
|
*
|
|
* Returns 0 if successful (anyone was using it),
|
|
* or != 0 if failed (someone is using it).
|
|
*/
|
|
extern unsigned char cfag12864b_enable(void);
|
|
|
|
/*
|
|
* Disable refreshing
|
|
*
|
|
* You should call this only when you finish using the LCD.
|
|
*/
|
|
extern void cfag12864b_disable(void);
|
|
|
|
/*
|
|
* Is enabled refreshing? (is anyone using the module?)
|
|
*
|
|
* Returns 0 if refreshing is not enabled (anyone is using it),
|
|
* or != 0 if refreshing is enabled (someone is using it).
|
|
*
|
|
* Useful for buffer read-only modules.
|
|
*/
|
|
extern unsigned char cfag12864b_isenabled(void);
|
|
|
|
/*
|
|
* Is the module inited?
|
|
*/
|
|
extern unsigned char cfag12864b_isinited(void);
|
|
|
|
#endif /* _CFAG12864B_H_ */
|
|
|