Alexey Dobriyan 9774a1f54f [PATCH] Compile-time check re world-writeable module params
One of the mistakes a module_param() user can make is to supply default
value of module parameter as the last argument.  module_param() accepts
permissions instead.  If default value is, say, 3 (-------wx), parameter
becomes world-writeable.

So far, the only remedy was to apply grep(1) and read drivers submitted
to -mm. BTDT.

With this patch applied, compiler will finally do some job.

*) bounds checking on permissions
*) world-writeable bit checking on permissions
*) compile breakage if checks trigger

First version of this check (only "& 2" part) directly caught 4 out of 7
places during my last grep.

    Subject: Neverending module_param() bugs
    [X] drivers/acpi/sbs.c:101:module_param(capacity_mode, int, CAPACITY_UNIT);
    [X] drivers/acpi/sbs.c:102:module_param(update_mode, int, UPDATE_MODE);
    [ ] drivers/acpi/sbs.c:103:module_param(update_info_mode, int, UPDATE_INFO_MODE);
    [ ] drivers/acpi/sbs.c:104:module_param(update_time, int, UPDATE_TIME);
    [ ] drivers/acpi/sbs.c:105:module_param(update_time2, int, UPDATE_TIME2);
    [X] drivers/char/watchdog/sbc8360.c:203:module_param(timeout, int, 27);
    [X] drivers/media/video/tuner-simple.c:13:module_param(offset, int, 0666);

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-12-07 08:39:34 -08:00
..
2006-12-07 08:39:25 -08:00
2006-12-04 02:00:22 -05:00
2006-12-02 21:22:55 -08:00
2006-12-02 21:22:55 -08:00
2006-12-02 21:22:55 -08:00
2006-12-07 08:39:20 -08:00
2006-11-22 14:57:56 +00:00
2006-12-02 21:30:59 -08:00
2006-12-07 08:39:25 -08:00
2006-10-11 11:14:17 -07:00
2006-12-07 08:39:31 -08:00
2006-12-07 08:39:32 -08:00
2006-12-07 08:39:21 -08:00
2006-12-07 08:39:25 -08:00
2006-12-02 21:21:24 -08:00
2006-12-02 21:21:17 -08:00
2006-12-04 02:00:34 -05:00
2006-12-02 21:21:21 -08:00
2006-12-07 08:39:20 -08:00
2006-10-11 11:14:23 -07:00
2006-10-10 15:37:22 -07:00
2006-12-02 21:21:21 -08:00
2006-12-02 21:21:21 -08:00
2006-11-30 05:24:39 +01:00
2006-12-07 08:39:25 -08:00
2006-12-07 08:39:25 -08:00
2006-11-30 04:53:49 +01:00
2006-11-30 01:14:44 +00:00
2006-10-11 11:14:15 -07:00
2006-12-04 02:00:22 -05:00
2006-11-30 04:40:22 +01:00
2006-11-16 11:43:38 -08:00
2006-11-22 14:57:56 +00:00
2006-12-02 21:22:57 -08:00
2006-12-04 02:00:34 -05:00
2006-12-02 21:22:56 -08:00
2006-12-02 21:21:18 -08:00
2006-11-03 12:27:58 -08:00
2006-12-04 02:00:36 -05:00
2006-11-22 14:57:56 +00:00
2006-12-07 08:39:25 -08:00
2006-12-07 08:39:32 -08:00
2006-12-02 21:26:16 -08:00
2006-12-02 21:21:34 -08:00
2006-12-07 08:39:30 -08:00
2006-10-11 01:45:31 -04:00
2006-12-07 08:39:25 -08:00
2006-12-07 08:39:25 -08:00
2006-10-10 16:15:34 -07:00
2006-12-07 08:39:20 -08:00
2006-10-11 11:14:21 -07:00
2006-11-30 05:32:19 +01:00
2006-12-02 21:21:08 -08:00
2006-12-02 00:11:58 -05:00