kernel-ark/drivers/usb
Stephen Warren 91a687d8fe USB: EHCI: tegra: fix circular module dependencies
The Tegra EHCI driver directly calls various functions in the Tegra USB
PHY driver. The reverse is also true; the PHY driver calls into the EHCI
driver. This is problematic when the two are built as modules.

The calls from the PHY to EHCI driver were originally added in commit
bbdabdb "usb: add APIs to access host registers from Tegra PHY", for the
following reasons:

1) The register being touched is an EHCI register, so logically only the
   EHCI driver should touch it.
2) (1) implies that some locking may be needed to correctly implement the
   r/m/w access to this shared register.
3) We were expecting to pass only the PHY register space to the Tegra PHY
   driver, and hence it would not have access to touch the shared
   registers.

To solve this, that commit added functions in the EHCI driver to touch the
shared register on behalf of the PHY driver.

In practice, we ended up not having any locking in the implementaiton of
those functions, and I've been led to believe this is safe. Equally, (3)
did not happen either. Hence, it is possible for the PHY driver to touch
the shared register directly.

Given that, this patch moves the code to touch the shared register back
into the PHY driver, to eliminate the module problems. If we actually
need locking or co-ordination in the future, I propose we put the lock
support into some pre-existing core module, or into a third separate
module, in order to avoid the circular dependencies.

I apologize for my contribution to code churn here.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-06-17 13:54:48 -07:00
..
atm USB: cxacru: potential underflow in cxacru_cm_get_array() 2013-05-20 11:35:47 -07:00
c67x00 usb: c67x00 RetryCnt value in c67x00 TD should be 3 2013-03-07 12:31:37 +08:00
chipidea usb: chipidea: get rid of camelcase names 2013-06-17 13:47:25 -07:00
class USB: cdc-acm: remove unneeded spin_lock_irqsave/restore on write path 2013-06-17 13:37:07 -07:00
core Merge 3.10-rc5 into usb-next 2013-06-08 21:27:51 -07:00
dwc3 usb: patches for v3.11 merge window 2013-06-12 14:44:13 -07:00
early
gadget usb/gadget: Kconfig: fix separate building of configfs-enabled functions 2013-06-17 13:41:57 -07:00
host USB: EHCI: tegra: fix circular module dependencies 2013-06-17 13:54:48 -07:00
image USB: regroup all depends on USB within an if USB block 2013-04-09 16:49:07 -07:00
misc usb: misc: usb3503: Remove 100ms sleep on reset, conform to data sheet 2013-06-03 11:01:09 -07:00
mon USB: regroup all depends on USB within an if USB block 2013-04-09 16:49:07 -07:00
musb usb: patches for v3.11 merge window 2013-06-12 14:44:13 -07:00
phy USB: EHCI: tegra: fix circular module dependencies 2013-06-17 13:54:48 -07:00
renesas_usbhs USB: regroup all depends on USB within an if USB block 2013-04-09 16:49:07 -07:00
serial USB: serial: increase the number of devices we support 2013-06-17 13:34:15 -07:00
storage Merge 3.10-rc3 into usb-next 2013-05-27 11:00:52 +09:00
wusbcore usb: wire adapter: add scatter gather support 2013-06-17 13:41:58 -07:00
Kconfig usb: host: make USB_ARCH_HAS_?HCI obsolete 2013-06-06 11:16:44 -07:00
Makefile usb host: Faraday USB2.0 FUSBH200-HCD driver 2013-05-17 10:12:52 -07:00
README
usb-common.c usb: add devicetree helpers for determining dr_mode and phy_type 2013-06-17 13:47:09 -07:00
usb-skeleton.c USB: usb-skeleton.c: fix blocked forever in skel_read 2013-03-25 13:32:20 -07:00

To understand all the Linux-USB framework, you'll use these resources:

    * This source code.  This is necessarily an evolving work, and
      includes kerneldoc that should help you get a current overview.
      ("make pdfdocs", and then look at "usb.pdf" for host side and
      "gadget.pdf" for peripheral side.)  Also, Documentation/usb has
      more information.

    * The USB 2.0 specification (from www.usb.org), with supplements
      such as those for USB OTG and the various device classes.
      The USB specification has a good overview chapter, and USB
      peripherals conform to the widely known "Chapter 9".

    * Chip specifications for USB controllers.  Examples include
      host controllers (on PCs, servers, and more); peripheral
      controllers (in devices with Linux firmware, like printers or
      cell phones); and hard-wired peripherals like Ethernet adapters.

    * Specifications for other protocols implemented by USB peripheral
      functions.  Some are vendor-specific; others are vendor-neutral
      but just standardized outside of the www.usb.org team.

Here is a list of what each subdirectory here is, and what is contained in
them.

core/		- This is for the core USB host code, including the
		  usbfs files and the hub class driver ("khubd").

host/		- This is for USB host controller drivers.  This
		  includes UHCI, OHCI, EHCI, and others that might
		  be used with more specialized "embedded" systems.

gadget/		- This is for USB peripheral controller drivers and
		  the various gadget drivers which talk to them.


Individual USB driver directories.  A new driver should be added to the
first subdirectory in the list below that it fits into.

image/		- This is for still image drivers, like scanners or
		  digital cameras.
../input/	- This is for any driver that uses the input subsystem,
		  like keyboard, mice, touchscreens, tablets, etc.
../media/	- This is for multimedia drivers, like video cameras,
		  radios, and any other drivers that talk to the v4l
		  subsystem.
../net/		- This is for network drivers.
serial/		- This is for USB to serial drivers.
storage/	- This is for USB mass-storage drivers.
class/		- This is for all USB device drivers that do not fit
		  into any of the above categories, and work for a range
		  of USB Class specified devices. 
misc/		- This is for all USB device drivers that do not fit
		  into any of the above categories.