9e4d59ada4
This is a fix for Linux 4.10-rc1.
In C language specification, a bit-field is interpreted as a signed or
unsigned integer type consisting of the specified number of bits.
In GCC manual, the range of a signed bit field of N bits is from
-(2^N) / 2 to ((2^N) / 2) - 1
https://www.gnu.org/software/gnu-c-manual/gnu-c-manual.html#Bit-Fields
Therefore, when defined as 1 bit-field with signed type, variables can
represents -1 and 0.
The snd-soc-hdmi-codec module includes a structure which has signed type
members with bit-fields. Codes of this module assign 0 and 1 to the
members. This seems to result in implementation-dependent behaviours.
As of v4.10-rc1 merge window, outside of sound subsystem, this structure
is referred by below GPU modules.
- tda998x
- sti-drm
- mediatek-drm-hdmi
- msm
As long as I review their codes relevant to the structure, the structure
members are used just for condition statements and printk formats.
My proposal of change is a bit intrusive to the printk formats but this
may be acceptable.
Totally, it's reasonable to use unsigned type for the structure members.
This bug is detected by Sparse, static code analyzer with below warnings.
./include/sound/hdmi-codec.h:39:26: error: dubious one-bit signed bitfield
./include/sound/hdmi-codec.h:40:28: error: dubious one-bit signed bitfield
./include/sound/hdmi-codec.h:41:29: error: dubious one-bit signed bitfield
./include/sound/hdmi-codec.h:42:31: error: dubious one-bit signed bitfield
Fixes: 09184118a8 ("ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
CC: stable@vger.kernel.org
104 lines
2.2 KiB
C
104 lines
2.2 KiB
C
/*
|
|
* hdmi-codec.h - HDMI Codec driver API
|
|
*
|
|
* Copyright (C) 2014 Texas Instruments Incorporated - http://www.ti.com
|
|
*
|
|
* Author: Jyri Sarha <jsarha@ti.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* version 2 as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*/
|
|
|
|
#ifndef __HDMI_CODEC_H__
|
|
#define __HDMI_CODEC_H__
|
|
|
|
#include <linux/hdmi.h>
|
|
#include <drm/drm_edid.h>
|
|
#include <sound/asoundef.h>
|
|
#include <uapi/sound/asound.h>
|
|
|
|
/*
|
|
* Protocol between ASoC cpu-dai and HDMI-encoder
|
|
*/
|
|
struct hdmi_codec_daifmt {
|
|
enum {
|
|
HDMI_I2S,
|
|
HDMI_RIGHT_J,
|
|
HDMI_LEFT_J,
|
|
HDMI_DSP_A,
|
|
HDMI_DSP_B,
|
|
HDMI_AC97,
|
|
HDMI_SPDIF,
|
|
} fmt;
|
|
unsigned int bit_clk_inv:1;
|
|
unsigned int frame_clk_inv:1;
|
|
unsigned int bit_clk_master:1;
|
|
unsigned int frame_clk_master:1;
|
|
};
|
|
|
|
/*
|
|
* HDMI audio parameters
|
|
*/
|
|
struct hdmi_codec_params {
|
|
struct hdmi_audio_infoframe cea;
|
|
struct snd_aes_iec958 iec;
|
|
int sample_rate;
|
|
int sample_width;
|
|
int channels;
|
|
};
|
|
|
|
struct hdmi_codec_pdata;
|
|
struct hdmi_codec_ops {
|
|
/*
|
|
* Called when ASoC starts an audio stream setup.
|
|
* Optional
|
|
*/
|
|
int (*audio_startup)(struct device *dev, void *data);
|
|
|
|
/*
|
|
* Configures HDMI-encoder for audio stream.
|
|
* Mandatory
|
|
*/
|
|
int (*hw_params)(struct device *dev, void *data,
|
|
struct hdmi_codec_daifmt *fmt,
|
|
struct hdmi_codec_params *hparms);
|
|
|
|
/*
|
|
* Shuts down the audio stream.
|
|
* Mandatory
|
|
*/
|
|
void (*audio_shutdown)(struct device *dev, void *data);
|
|
|
|
/*
|
|
* Mute/unmute HDMI audio stream.
|
|
* Optional
|
|
*/
|
|
int (*digital_mute)(struct device *dev, void *data, bool enable);
|
|
|
|
/*
|
|
* Provides EDID-Like-Data from connected HDMI device.
|
|
* Optional
|
|
*/
|
|
int (*get_eld)(struct device *dev, void *data,
|
|
uint8_t *buf, size_t len);
|
|
};
|
|
|
|
/* HDMI codec initalization data */
|
|
struct hdmi_codec_pdata {
|
|
const struct hdmi_codec_ops *ops;
|
|
uint i2s:1;
|
|
uint spdif:1;
|
|
int max_i2s_channels;
|
|
void *data;
|
|
};
|
|
|
|
#define HDMI_CODEC_DRV_NAME "hdmi-audio-codec"
|
|
|
|
#endif /* __HDMI_CODEC_H__ */
|