ed9cbda63d
The bcdDevice field is defined as |Device release number in binary-coded decimal in the USB 2.0 specification. We use this field to distinguish the UDCs from each other. In theory this could be used on the host side to apply certain quirks if the "special" UDC in combination with this gadget is used. This hasn't been done as far as I am aware. In practice it would be better to fix the UDC driver before shipping since a later release might not need this quirk anymore. There are some driver in tree (on the host side) which use the bcdDevice field to figure out special workarounds for a given firmware revision. This seems to make sense. Therefore this patch converts all gadgets (except a few) to use the kernel version instead a random 2 or 3 plus the UDC number. The few that don't report kernel's version are: - webcam This one reports always a version 0x10 so allow it to do so in future. - nokia This one reports always 0x211. The comment says that this gadget works only if the UDC supports altsettings so I added a check for this. - serial This one reports 0x2400 + UDC number. Since the gadget version is 2.4 this could make sense. Therefore bcdDevice is 0x2400 here. I also remove various gadget_is_<name> macros which are unused. The remaining few macros should be moved to feature / bug bitfield. Acked-by: Michal Nazarewicz <mina86@mina86.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Felipe Balbi <balbi@ti.com>
56 lines
1.8 KiB
C
56 lines
1.8 KiB
C
/*
|
|
* USB device controllers have lots of quirks. Use these macros in
|
|
* gadget drivers or other code that needs to deal with them, and which
|
|
* autoconfigures instead of using early binding to the hardware.
|
|
*
|
|
* This SHOULD eventually work like the ARM mach_is_*() stuff, driven by
|
|
* some config file that gets updated as new hardware is supported.
|
|
* (And avoiding all runtime comparisons in typical one-choice configs!)
|
|
*
|
|
* NOTE: some of these controller drivers may not be available yet.
|
|
* Some are available on 2.4 kernels; several are available, but not
|
|
* yet pushed in the 2.6 mainline tree.
|
|
*/
|
|
|
|
#ifndef __GADGET_CHIPS_H
|
|
#define __GADGET_CHIPS_H
|
|
|
|
#include <linux/usb/gadget.h>
|
|
|
|
/*
|
|
* NOTICE: the entries below are alphabetical and should be kept
|
|
* that way.
|
|
*
|
|
* Always be sure to add new entries to the correct position or
|
|
* accept the bashing later.
|
|
*
|
|
* If you have forgotten the alphabetical order let VIM/EMACS
|
|
* do that for you.
|
|
*/
|
|
#define gadget_is_at91(g) (!strcmp("at91_udc", (g)->name))
|
|
#define gadget_is_goku(g) (!strcmp("goku_udc", (g)->name))
|
|
#define gadget_is_musbhdrc(g) (!strcmp("musb-hdrc", (g)->name))
|
|
#define gadget_is_net2280(g) (!strcmp("net2280", (g)->name))
|
|
#define gadget_is_pxa(g) (!strcmp("pxa25x_udc", (g)->name))
|
|
#define gadget_is_pxa27x(g) (!strcmp("pxa27x_udc", (g)->name))
|
|
|
|
/**
|
|
* gadget_supports_altsettings - return true if altsettings work
|
|
* @gadget: the gadget in question
|
|
*/
|
|
static inline bool gadget_supports_altsettings(struct usb_gadget *gadget)
|
|
{
|
|
/* PXA 21x/25x/26x has no altsettings at all */
|
|
if (gadget_is_pxa(gadget))
|
|
return false;
|
|
|
|
/* PXA 27x and 3xx have *broken* altsetting support */
|
|
if (gadget_is_pxa27x(gadget))
|
|
return false;
|
|
|
|
/* Everything else is *presumably* fine ... */
|
|
return true;
|
|
}
|
|
|
|
#endif /* __GADGET_CHIPS_H */
|