Tejun Heo 6dd9ad7df2 block: don't call blk_drain_queue() if elevator is not up ... blk_cleanup_queue() may be called before elevator is set up on a queue which triggers the following oops. BUG: unable to handle kernel NULL pointer dereference at (null) IP: [<ffffffff8125a69c>] elv_drain_elevator+0x1c/0x70 ... Pid: 830, comm: kworker/0:2 Not tainted 3.1.0-next-20111025_64+ #1590 Bochs Bochs RIP: 0010:[<ffffffff8125a69c>] [<ffffffff8125a69c>] elv_drain_elevator+0x1c/0x70 ... Call Trace: [<ffffffff8125da92>] blk_drain_queue+0x42/0x70 [<ffffffff8125db90>] blk_cleanup_queue+0xd0/0x1c0 [<ffffffff81469640>] md_free+0x50/0x70 [<ffffffff8126f43b>] kobject_release+0x8b/0x1d0 [<ffffffff81270d56>] kref_put+0x36/0xa0 [<ffffffff8126f2b7>] kobject_put+0x27/0x60 [<ffffffff814693af>] mddev_delayed_delete+0x2f/0x40 [<ffffffff81083450>] process_one_work+0x100/0x3b0 [<ffffffff8108527f>] worker_thread+0x15f/0x3a0 [<ffffffff81089937>] kthread+0x87/0x90 [<ffffffff81621834>] kernel_thread_helper+0x4/0x10 Fix it by making blk_cleanup_queue() check whether q->elevator is set up before invoking blk_drain_queue. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-and-tested-by: Jiri Slaby <jslaby@suse.cz> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2011-11-03 18:52:11 +01:00
..
blk-cgroup.c	blk-throttle: Take blkcg->lock while traversing blkcg->policy_list	2011-10-25 15:48:12 +02:00
blk-cgroup.h	block: fix a typo in the blk-cgroup.h file	2011-10-24 16:08:38 +02:00
blk-core.c	block: don't call blk_drain_queue() if elevator is not up	2011-11-03 18:52:11 +01:00
blk-exec.c	[SCSI] fix crash in scsi_dispatch_cmd()	2011-07-21 14:21:18 -07:00
blk-flush.c	blk-flush: move the queue kick into	2011-10-24 16:24:31 +02:00
blk-integrity.c	dm: improve block integrity support	2011-04-05 23:52:43 +02:00
blk-ioc.c	Merge branch 'for-linus' into for-3.1/core	2011-07-01 16:17:13 +02:00
blk-iopoll.c	tree-wide: fix assorted typos all over the place	2009-12-04 15:39:55 +01:00
blk-lib.c	block: fix patch import error in max_discard_sectors check	2011-07-23 20:34:59 +02:00
blk-map.c	block: check for proper length of iov entries earlier in blk_rq_map_user_iov()	2010-11-29 10:04:50 +01:00
blk-merge.c	block: attempt to merge with existing requests on plug flush	2011-03-21 10:14:27 +01:00
blk-settings.c	block: Fix discard topology stacking and reporting	2011-05-18 10:37:35 +02:00
blk-softirq.c	block: Don't check QUEUE_FLAG_SAME_COMP in __blk_complete_request	2011-09-14 09:31:01 +02:00
blk-sysfs.c	block: fix request_queue lifetime handling by making blk_queue_cleanup() properly shutdown	2011-10-19 14:42:16 +02:00
blk-tag.c	block: warn if tag is greater than real_max_depth.	2011-10-25 10:20:05 +02:00
blk-throttle.c	blk-throttle: use queue_is_locked() instead of lockdep_is_held()	2011-10-25 15:51:48 +02:00
blk-timeout.c	fault-injection: add ability to export fault_attr in arbitrary directory	2011-08-03 14:25:20 -10:00
blk.h	block: fix request_queue lifetime handling by making blk_queue_cleanup() properly shutdown	2011-10-19 14:42:16 +02:00
bsg-lib.c	bsg-lib: add module.h include	2011-08-02 10:43:35 +02:00
bsg.c	bsg: fix address space warning from sparse	2011-06-20 13:27:45 +02:00
cfq-iosched.c	block: separate priority boosting from REQ_META	2011-08-23 14:50:29 +02:00
cfq.h	blk-cgroup: Add unaccounted time to timeslice_used.	2011-03-12 16:54:00 +01:00
compat_ioctl.c	compat_ioctl: fix warning caused by qemu	2011-07-01 22:32:26 +02:00
deadline-iosched.c	iosched: prevent aliased requests from starving other I/O	2011-06-02 21:19:05 +02:00
elevator.c	block: fix request_queue lifetime handling by making blk_queue_cleanup() properly shutdown	2011-10-19 14:42:16 +02:00
genhd.c	block: make gendisk hold a reference to its queue	2011-10-24 16:24:31 +02:00
ioctl.c	block: fix refcounting in BLKBSZSET	2011-02-24 08:54:21 -08:00
Kconfig	block: add bsg helper library	2011-07-31 22:05:09 +02:00
Kconfig.iosched	blk-cgroup: config options re-arrangement	2010-04-26 19:27:56 +02:00
Makefile	block: add bsg helper library	2011-07-31 22:05:09 +02:00
noop-iosched.c	block: remove per-queue plugging	2011-03-10 08:52:07 +01:00
scsi_ioctl.c	block: drop unnecessary blk_get/put_queue() in scsi_cmd_ioctl() and blk_get_tg()	2011-10-19 14:31:25 +02:00