2ed2d5b33c
The deadlock is found through the following scenario.
sys_mkdir()
-> f2fs_add_link()
-> __f2fs_add_link()
-> init_inode_metadata()
: lock_page(inode);
-> f2fs_init_acl()
-> f2fs_set_acl()
-> f2fs_setxattr(..., NULL)
: This NULL page incurs a deadlock at update_inode_page().
So, likewise f2fs_init_security(), this patch adds a parameter to transfer the
locked inode page to f2fs_setxattr().
Found by Linux File System Verification project (linuxtesting.org).
Reported-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
59 lines
1.2 KiB
C
59 lines
1.2 KiB
C
/*
|
|
* fs/f2fs/acl.h
|
|
*
|
|
* Copyright (c) 2012 Samsung Electronics Co., Ltd.
|
|
* http://www.samsung.com/
|
|
*
|
|
* Portions of this code from linux/fs/ext2/acl.h
|
|
*
|
|
* Copyright (C) 2001-2003 Andreas Gruenbacher, <agruen@suse.de>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
#ifndef __F2FS_ACL_H__
|
|
#define __F2FS_ACL_H__
|
|
|
|
#include <linux/posix_acl_xattr.h>
|
|
|
|
#define F2FS_ACL_VERSION 0x0001
|
|
|
|
struct f2fs_acl_entry {
|
|
__le16 e_tag;
|
|
__le16 e_perm;
|
|
__le32 e_id;
|
|
};
|
|
|
|
struct f2fs_acl_entry_short {
|
|
__le16 e_tag;
|
|
__le16 e_perm;
|
|
};
|
|
|
|
struct f2fs_acl_header {
|
|
__le32 a_version;
|
|
};
|
|
|
|
#ifdef CONFIG_F2FS_FS_POSIX_ACL
|
|
|
|
extern struct posix_acl *f2fs_get_acl(struct inode *, int);
|
|
extern int f2fs_acl_chmod(struct inode *);
|
|
extern int f2fs_init_acl(struct inode *, struct inode *, struct page *);
|
|
#else
|
|
#define f2fs_check_acl NULL
|
|
#define f2fs_get_acl NULL
|
|
#define f2fs_set_acl NULL
|
|
|
|
static inline int f2fs_acl_chmod(struct inode *inode)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int f2fs_init_acl(struct inode *inode, struct inode *dir,
|
|
struct page *page)
|
|
{
|
|
return 0;
|
|
}
|
|
#endif
|
|
#endif /* __F2FS_ACL_H__ */
|