Stefan Richter 0ca49345b6 firewire: ohci: fix probe failure with Agere/LSI controllers ... Since commit bd972688eb "firewire: ohci: Fix 'failed to read phy reg' on FW643 rev8", there is a high chance that firewire-ohci fails to initialize LSI née Agere controllers. https://bugzilla.kernel.org/show_bug.cgi?id=65151 Peter Hurley points out the reason: IEEE 1394a:2000 clause 5A.1 (or IEEE 1394:2008 clause 17.2.1) say: "The PHY shall insure that no more than 10 ms elapse from the reassertion of LPS until the interface is reset. The link shall not assert LReq until the reset is complete." In other words, the link needs to give the PHY at least 10 ms to get the interface operational. With just the msleep(1) in bd972688eb, the first read_phy_reg() during ohci_enable() may happen before the phy-link interface reset was finished, and fail. Due to the high variability of msleep(n) with small n, this failure was not fully reproducible, and not apparent at all with low CONFIG_HZ setting. On the other hand, Peter can no longer reproduce the issue with FW643 rev8. The read phy reg failures that happened back then may have had an unrelated cause. So, just revert bd972688eb, except for the valid comment on TSB82AA2 cards. Reported-by: Mikhail Gavrilov Reported-by: Jay Fenlason <fenlason@redhat.com> Reported-by: Clemens Ladisch <clemens@ladisch.de> Reported-by: Peter Hurley <peter@hurleysoftware.com> Cc: stable@vger.kernel.org # v3.10+ Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>		2014-03-06 21:36:23 +01:00
..
core-card.c	IEEE 1394 (FireWire) subsystem updates post v3.4:	2012-05-24 12:57:47 -07:00
core-cdev.c	firewire: core: typecast from gfp_t to bool more safely	2013-07-30 15:46:18 +02:00
core-device.c	firewire: remove support of fw_driver.driver.probe and .remove methods	2013-06-09 18:15:00 +02:00
core-iso.c	firewire: core: fix multichannel IR with buffers larger than 2 GB	2012-06-17 19:35:26 +02:00
core-topology.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
core-transaction.c	firewire: Enable remote DMA above 4 GB	2014-01-20 01:11:13 +01:00
core.h	firewire: Enable remote DMA above 4 GB	2014-01-20 01:11:13 +01:00
init_ohci1394_dma.c	various: Fix spelling of "asynchronous" in comments.	2012-11-19 14:32:13 +01:00
Kconfig	firewire net, ipv6: IPv6 over Firewire (RFC3146) support.	2013-03-26 12:32:13 -04:00
Makefile
net.c	firewire: net: fix use after free	2014-02-28 11:02:51 +01:00
nosy-user.h
nosy.c	firewire: remove use of __devinitdata	2012-11-28 12:40:42 -08:00
nosy.h
ohci.c	firewire: ohci: fix probe failure with Agere/LSI controllers	2014-03-06 21:36:23 +01:00
ohci.h
sbp2.c	firewire: sbp2: bring back WRITE SAME support	2013-12-15 16:32:32 +01:00