591ad7feae
Currently, wait queue, used for polling of RPC pipe changes from user-space, is a part of RPC pipe. But the pipe data itself can be released on NFS umount prior to dentry-inode pair, connected to it (is case of this pair is open by some process). This is not a problem for almost all pipe users, because all PipeFS file operations checks pipe reference prior to using it. Except evenfd. This thing registers itself with "poll" file operation and thus has a reference to pipe wait queue. This leads to oopses on destroying eventfd after NFS umount (like rpc_idmapd do) since not pipe data left to the point already. The solution is to wait queue from pipe data to internal RPC inode data. This looks more logical, because this wiat queue used only for user-space processes, which already holds inode reference. Note: upcalls have to get pipe->dentry prior to dereferecing wait queue to make sure, that mount point won't disappear from underneath us. Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
98 lines
2.5 KiB
C
98 lines
2.5 KiB
C
#ifndef _LINUX_SUNRPC_RPC_PIPE_FS_H
|
|
#define _LINUX_SUNRPC_RPC_PIPE_FS_H
|
|
|
|
#ifdef __KERNEL__
|
|
|
|
#include <linux/workqueue.h>
|
|
|
|
struct rpc_pipe_msg {
|
|
struct list_head list;
|
|
void *data;
|
|
size_t len;
|
|
size_t copied;
|
|
int errno;
|
|
};
|
|
|
|
struct rpc_pipe_ops {
|
|
ssize_t (*upcall)(struct file *, struct rpc_pipe_msg *, char __user *, size_t);
|
|
ssize_t (*downcall)(struct file *, const char __user *, size_t);
|
|
void (*release_pipe)(struct inode *);
|
|
int (*open_pipe)(struct inode *);
|
|
void (*destroy_msg)(struct rpc_pipe_msg *);
|
|
};
|
|
|
|
struct rpc_pipe {
|
|
struct list_head pipe;
|
|
struct list_head in_upcall;
|
|
struct list_head in_downcall;
|
|
int pipelen;
|
|
int nreaders;
|
|
int nwriters;
|
|
#define RPC_PIPE_WAIT_FOR_OPEN 1
|
|
int flags;
|
|
struct delayed_work queue_timeout;
|
|
const struct rpc_pipe_ops *ops;
|
|
spinlock_t lock;
|
|
struct dentry *dentry;
|
|
};
|
|
|
|
struct rpc_inode {
|
|
struct inode vfs_inode;
|
|
void *private;
|
|
struct rpc_pipe *pipe;
|
|
wait_queue_head_t waitq;
|
|
};
|
|
|
|
static inline struct rpc_inode *
|
|
RPC_I(struct inode *inode)
|
|
{
|
|
return container_of(inode, struct rpc_inode, vfs_inode);
|
|
}
|
|
|
|
enum {
|
|
SUNRPC_PIPEFS_NFS_PRIO,
|
|
SUNRPC_PIPEFS_RPC_PRIO,
|
|
};
|
|
|
|
extern int rpc_pipefs_notifier_register(struct notifier_block *);
|
|
extern void rpc_pipefs_notifier_unregister(struct notifier_block *);
|
|
|
|
enum {
|
|
RPC_PIPEFS_MOUNT,
|
|
RPC_PIPEFS_UMOUNT,
|
|
};
|
|
|
|
extern struct dentry *rpc_d_lookup_sb(const struct super_block *sb,
|
|
const unsigned char *dir_name);
|
|
extern void rpc_pipefs_init_net(struct net *net);
|
|
extern struct super_block *rpc_get_sb_net(const struct net *net);
|
|
extern void rpc_put_sb_net(const struct net *net);
|
|
|
|
extern ssize_t rpc_pipe_generic_upcall(struct file *, struct rpc_pipe_msg *,
|
|
char __user *, size_t);
|
|
extern int rpc_queue_upcall(struct rpc_pipe *, struct rpc_pipe_msg *);
|
|
|
|
struct rpc_clnt;
|
|
extern struct dentry *rpc_create_client_dir(struct dentry *, struct qstr *, struct rpc_clnt *);
|
|
extern int rpc_remove_client_dir(struct dentry *);
|
|
|
|
struct cache_detail;
|
|
extern struct dentry *rpc_create_cache_dir(struct dentry *,
|
|
struct qstr *,
|
|
umode_t umode,
|
|
struct cache_detail *);
|
|
extern void rpc_remove_cache_dir(struct dentry *);
|
|
|
|
extern int rpc_rmdir(struct dentry *dentry);
|
|
|
|
struct rpc_pipe *rpc_mkpipe_data(const struct rpc_pipe_ops *ops, int flags);
|
|
void rpc_destroy_pipe_data(struct rpc_pipe *pipe);
|
|
extern struct dentry *rpc_mkpipe_dentry(struct dentry *, const char *, void *,
|
|
struct rpc_pipe *);
|
|
extern int rpc_unlink(struct dentry *);
|
|
extern int register_rpc_pipefs(void);
|
|
extern void unregister_rpc_pipefs(void);
|
|
|
|
#endif
|
|
#endif
|