Oleg Nesterov 05d5bcd60e [PATCH] bacct_add_tsk: fix unsafe and wrong parent/group_leader dereference ... 1. ts = timespec_sub(uptime, current->group_leader->start_time); It is possible that current != tsk. Probably it was supposed to be 'tsk->group_leader->start_time. But why we are reading group_leader's start_time ? This accounting is per thread, not per procees, I changed this to 'tsk->start_time. Please corect me. 2. stats->ac_ppid = (tsk->parent) ? tsk->parent->pid : 0; tsk->parent never == NULL, and it is unsafe to dereference it. Both the task and it's parent may exit after the caller unlocks tasklist_lock, the memory could be unmapped (DEBUG_SLAB). (And we should use ->real_parent->tgid in fact). Q: I don't understand the 'if (thread_group_leader(tsk))' check. Why it is needed ? Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Cc: Shailabh Nagar <nagar@watson.ibm.com> Cc: Balbir Singh <balbir@in.ibm.com> Acked-by: Jay Lan <jlan@sgi.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>		2006-10-28 11:30:54 -07:00
..
irq	[PATCH] genirq: clean up irq-flow-type naming	2006-10-17 08:18:45 -07:00
power	[PATCH] swsusp: fix memory leaks	2006-10-17 08:18:44 -07:00
time	[PATCH] i386 Time: Avoid PIT SMP lockups	2006-10-17 08:18:42 -07:00
.gitignore
acct.c
audit.c	[PATCH] kauditd_thread warning fix	2006-10-06 08:53:39 -07:00
audit.h
auditfilter.c	[PATCH] arch filter lists with < or > should not be accepted	2006-10-04 08:31:16 -04:00
auditsc.c	[PATCH] name_count array overrun	2006-10-04 08:31:21 -04:00
capability.c
compat.c	[PATCH] Constify compat_get_bitmap argument	2006-10-28 11:30:54 -07:00
configs.c
cpu.c	[PATCH] Convert cpu hotplug notifiers to use raw_notifier instead of blocking_notifier	2006-10-17 08:18:48 -07:00
cpuset.c	[PATCH] cpuset ANSI prototype	2006-10-10 15:37:23 -07:00
delayacct.c
dma.c	[PATCH] kernel-doc for kernel/dma.c	2006-10-03 08:03:41 -07:00
exec_domain.c
exit.c
extable.c
fork.c	[PATCH] rt-mutex: fixup rt-mutex debug code	2006-10-17 08:18:48 -07:00
futex_compat.c	[PATCH] __user annotations: futex	2006-10-10 15:37:22 -07:00
futex.c	[PATCH] __user annotations: futex	2006-10-10 15:37:22 -07:00
hrtimer.c
itimer.c
kallsyms.c	[PATCH] Create kallsyms_lookup_size_offset()	2006-10-03 08:03:41 -07:00
Kconfig.hz
Kconfig.preempt
kexec.c
kfifo.c
kmod.c
kprobes.c
ksysfs.c
kthread.c
latency.c
lockdep_internals.h
lockdep_proc.c
lockdep.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2006-10-17 08:56:43 -07:00
Makefile	[PATCH] srcu-3: RCU variant permitting read-side blocking	2006-10-04 07:55:30 -07:00
module.c	[PATCH] Add missing space in module.c for taintskernel	2006-10-28 11:30:53 -07:00
mutex-debug.c	Lockdep: add lockdep_set_class_and_subclass() and lockdep_set_subclass()	2006-10-11 01:45:14 -04:00
mutex-debug.h
mutex.c
mutex.h
nsproxy.c	[PATCH] kernel/nsproxy.c: use kmemdup()	2006-10-20 10:26:44 -07:00
panic.c
params.c
pid.c
posix-cpu-timers.c	[PATCH] posix-cpu-timers: prevent signal delivery starvation	2006-10-17 08:18:43 -07:00
posix-timers.c	fix file specification in comments	2006-10-03 23:01:26 +02:00
printk.c	[PATCH] lockdep: fix printk recursion logic	2006-10-11 11:14:24 -07:00
profile.c	[PATCH] bitmap: parse input from kernel and user buffers	2006-10-11 11:14:22 -07:00
ptrace.c
rcupdate.c	[PATCH] rcu: simplify/improve batch tuning	2006-10-04 07:55:31 -07:00
rcutorture.c	[PATCH] rcu: add sched torture type to rcutorture	2006-10-04 07:55:31 -07:00
relay.c	[PATCH] make kernel/relay.c __user-clean	2006-10-10 15:37:22 -07:00
resource.c	[PATCH] kernel-doc for kernel/resource.c	2006-10-03 08:03:41 -07:00
rtmutex_common.h
rtmutex-debug.c	Remove all inclusions of <linux/config.h>	2006-10-04 03:38:54 -04:00
rtmutex-debug.h
rtmutex-tester.c	Remove all inclusions of <linux/config.h>	2006-10-04 03:38:54 -04:00
rtmutex.c
rtmutex.h
rwsem.c
sched.c	[PATCH] readjust comments of task_timeslice for kernel doc	2006-10-20 10:26:37 -07:00
seccomp.c
signal.c
softirq.c
softlockup.c
spinlock.c
srcu.c	[PATCH] SRCU: report out-of-memory errors	2006-10-04 07:55:30 -07:00
stacktrace.c
stop_machine.c
sys_ni.c	[PATCH] fix epoll_pwait when EPOLL=n	2006-10-16 09:14:05 -07:00
sys.c	[PATCH] SRCU: report out-of-memory errors	2006-10-04 07:55:30 -07:00
sysctl.c	[PATCH] cad_pid sysctl with PROC_FS=n	2006-10-20 10:26:38 -07:00
taskstats.c	[PATCH] fill_tgid: fix task_struct leak and possible oops	2006-10-28 11:30:54 -07:00
time.c
timer.c
tsacct.c	[PATCH] bacct_add_tsk: fix unsafe and wrong parent/group_leader dereference	2006-10-28 11:30:54 -07:00
uid16.c
unwind.c	[PATCH] x86-64: Speed up dwarf2 unwinder	2006-10-21 18:37:01 +02:00
user.c
utsname.c
wait.c
workqueue.c	[PATCH] mm: kevent threads: use MPOL_DEFAULT	2006-10-11 11:14:19 -07:00