davidlt/kernel-ark
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

video: ARM CLCD: fix return value check in versatile_clcd_init_panel()

Browse Source 
In case of error, the function syscon_node_to_regmap() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 25348160e9 ("video: ARM CLCD: add special panel hook for Versatiles")
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Wei Yongjun 2016-08-13 01:26:26 +00:00 committed by Tomi Valkeinen
parent 1121a418b2
commit 763e6366f3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/video/fbdev/amba-clcd-versatile.c
View File

@ -528,9 +528,9 @@ int versatile_clcd_init_panel(struct clcd_fb *fb,
versatile_clcd_type = (enum versatile_clcd)clcd_id->data;
map = syscon_node_to_regmap(np);
if (!map) {
if (IS_ERR(map)) {
dev_err(dev, "no Versatile syscon regmap\n");
return -ENODEV;
return PTR_ERR(map);
}
switch (versatile_clcd_type) {