tile-srom: allow the driver to be built as a module
The code was already configured that way, but the Kconfig file didn't support requesting it. A buglet caused a null pointer deref when unloading the module, but this commit also corrects that issue. Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
e0cb6b2f87
commit
71aeebff2c
@ -577,7 +577,7 @@ config DEVPORT
|
|||||||
source "drivers/s390/char/Kconfig"
|
source "drivers/s390/char/Kconfig"
|
||||||
|
|
||||||
config TILE_SROM
|
config TILE_SROM
|
||||||
bool "Character-device access via hypervisor to the Tilera SPI ROM"
|
tristate "Character-device access via hypervisor to the Tilera SPI ROM"
|
||||||
depends on TILE
|
depends on TILE
|
||||||
default y
|
default y
|
||||||
---help---
|
---help---
|
||||||
|
@ -312,7 +312,8 @@ ATTRIBUTE_GROUPS(srom_dev);
|
|||||||
|
|
||||||
static char *srom_devnode(struct device *dev, umode_t *mode)
|
static char *srom_devnode(struct device *dev, umode_t *mode)
|
||||||
{
|
{
|
||||||
*mode = S_IRUGO | S_IWUSR;
|
if (mode)
|
||||||
|
*mode = 0644;
|
||||||
return kasprintf(GFP_KERNEL, "srom/%s", dev_name(dev));
|
return kasprintf(GFP_KERNEL, "srom/%s", dev_name(dev));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user