2011-08-30 23:41:05 +00:00
|
|
|
/*
|
|
|
|
* Performance events x86 architecture header
|
|
|
|
*
|
|
|
|
* Copyright (C) 2008 Thomas Gleixner <tglx@linutronix.de>
|
|
|
|
* Copyright (C) 2008-2009 Red Hat, Inc., Ingo Molnar
|
|
|
|
* Copyright (C) 2009 Jaswinder Singh Rajput
|
|
|
|
* Copyright (C) 2009 Advanced Micro Devices, Inc., Robert Richter
|
|
|
|
* Copyright (C) 2008-2009 Red Hat, Inc., Peter Zijlstra <pzijlstr@redhat.com>
|
|
|
|
* Copyright (C) 2009 Intel Corporation, <markus.t.metzger@intel.com>
|
|
|
|
* Copyright (C) 2009 Google, Inc., Stephane Eranian
|
|
|
|
*
|
|
|
|
* For licencing details see kernel-base/COPYING
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/perf_event.h>
|
|
|
|
|
2012-05-14 13:25:34 +00:00
|
|
|
#if 0
|
|
|
|
#undef wrmsrl
|
|
|
|
#define wrmsrl(msr, val) \
|
|
|
|
do { \
|
|
|
|
unsigned int _msr = (msr); \
|
|
|
|
u64 _val = (val); \
|
|
|
|
trace_printk("wrmsrl(%x, %Lx)\n", (unsigned int)(_msr), \
|
|
|
|
(unsigned long long)(_val)); \
|
|
|
|
native_write_msr((_msr), (u32)(_val), (u32)(_val >> 32)); \
|
|
|
|
} while (0)
|
|
|
|
#endif
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
/*
|
|
|
|
* | NHM/WSM | SNB |
|
|
|
|
* register -------------------------------
|
|
|
|
* | HT | no HT | HT | no HT |
|
|
|
|
*-----------------------------------------
|
|
|
|
* offcore | core | core | cpu | core |
|
|
|
|
* lbr_sel | core | core | cpu | core |
|
|
|
|
* ld_lat | cpu | core | cpu | core |
|
|
|
|
*-----------------------------------------
|
|
|
|
*
|
|
|
|
* Given that there is a small number of shared regs,
|
|
|
|
* we can pre-allocate their slot in the per-cpu
|
|
|
|
* per-core reg tables.
|
|
|
|
*/
|
|
|
|
enum extra_reg_type {
|
|
|
|
EXTRA_REG_NONE = -1, /* not used */
|
|
|
|
|
|
|
|
EXTRA_REG_RSP_0 = 0, /* offcore_response_0 */
|
|
|
|
EXTRA_REG_RSP_1 = 1, /* offcore_response_1 */
|
2012-02-09 22:20:53 +00:00
|
|
|
EXTRA_REG_LBR = 2, /* lbr_select */
|
2013-01-24 15:10:32 +00:00
|
|
|
EXTRA_REG_LDLAT = 3, /* ld_lat_threshold */
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
EXTRA_REG_MAX /* number of entries needed */
|
|
|
|
};
|
|
|
|
|
|
|
|
struct event_constraint {
|
|
|
|
union {
|
|
|
|
unsigned long idxmsk[BITS_TO_LONGS(X86_PMC_IDX_MAX)];
|
|
|
|
u64 idxmsk64;
|
|
|
|
};
|
|
|
|
u64 code;
|
|
|
|
u64 cmask;
|
|
|
|
int weight;
|
2011-11-18 11:35:22 +00:00
|
|
|
int overlap;
|
2013-01-24 15:10:27 +00:00
|
|
|
int flags;
|
2011-08-30 23:41:05 +00:00
|
|
|
};
|
2013-01-24 15:10:32 +00:00
|
|
|
/*
|
2013-06-20 16:42:54 +00:00
|
|
|
* struct hw_perf_event.flags flags
|
2013-01-24 15:10:32 +00:00
|
|
|
*/
|
2015-04-15 18:14:53 +00:00
|
|
|
#define PERF_X86_EVENT_PEBS_LDLAT 0x0001 /* ld+ldlat data address sampling */
|
|
|
|
#define PERF_X86_EVENT_PEBS_ST 0x0002 /* st data address sampling */
|
|
|
|
#define PERF_X86_EVENT_PEBS_ST_HSW 0x0004 /* haswell style datala, store */
|
|
|
|
#define PERF_X86_EVENT_COMMITTED 0x0008 /* event passed commit_txn */
|
|
|
|
#define PERF_X86_EVENT_PEBS_LD_HSW 0x0010 /* haswell style datala, load */
|
|
|
|
#define PERF_X86_EVENT_PEBS_NA_HSW 0x0020 /* haswell style datala, unknown */
|
|
|
|
#define PERF_X86_EVENT_EXCL 0x0040 /* HT exclusivity on counter */
|
|
|
|
#define PERF_X86_EVENT_DYNAMIC 0x0080 /* dynamic alloc'd constraint */
|
|
|
|
#define PERF_X86_EVENT_RDPMC_ALLOWED 0x0100 /* grant rdpmc permission */
|
2015-05-21 08:57:17 +00:00
|
|
|
#define PERF_X86_EVENT_EXCL_ACCT 0x0200 /* accounted EXCL event */
|
2015-05-06 19:33:47 +00:00
|
|
|
#define PERF_X86_EVENT_AUTO_RELOAD 0x0400 /* use PEBS auto-reload */
|
2014-10-24 22:58:12 +00:00
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
struct amd_nb {
|
|
|
|
int nb_id; /* NorthBridge id */
|
|
|
|
int refcnt; /* reference count */
|
|
|
|
struct perf_event *owners[X86_PMC_IDX_MAX];
|
|
|
|
struct event_constraint event_constraints[X86_PMC_IDX_MAX];
|
|
|
|
};
|
|
|
|
|
|
|
|
/* The maximal number of PEBS events: */
|
2012-06-06 00:56:48 +00:00
|
|
|
#define MAX_PEBS_EVENTS 8
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* A debug store configuration.
|
|
|
|
*
|
|
|
|
* We only support architectures that use 64bit fields.
|
|
|
|
*/
|
|
|
|
struct debug_store {
|
|
|
|
u64 bts_buffer_base;
|
|
|
|
u64 bts_index;
|
|
|
|
u64 bts_absolute_maximum;
|
|
|
|
u64 bts_interrupt_threshold;
|
|
|
|
u64 pebs_buffer_base;
|
|
|
|
u64 pebs_index;
|
|
|
|
u64 pebs_absolute_maximum;
|
|
|
|
u64 pebs_interrupt_threshold;
|
|
|
|
u64 pebs_event_reset[MAX_PEBS_EVENTS];
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Per register state.
|
|
|
|
*/
|
|
|
|
struct er_account {
|
|
|
|
raw_spinlock_t lock; /* per-core: protect structure */
|
|
|
|
u64 config; /* extra MSR config */
|
|
|
|
u64 reg; /* extra MSR number */
|
|
|
|
atomic_t ref; /* reference count */
|
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Per core/cpu state
|
|
|
|
*
|
|
|
|
* Used to coordinate shared registers between HT threads or
|
|
|
|
* among events on a single PMU.
|
|
|
|
*/
|
|
|
|
struct intel_shared_regs {
|
|
|
|
struct er_account regs[EXTRA_REG_MAX];
|
|
|
|
int refcnt; /* per-core: #HT threads */
|
|
|
|
unsigned core_id; /* per-core: core id */
|
|
|
|
};
|
|
|
|
|
2014-11-17 19:06:57 +00:00
|
|
|
enum intel_excl_state_type {
|
|
|
|
INTEL_EXCL_UNUSED = 0, /* counter is unused */
|
|
|
|
INTEL_EXCL_SHARED = 1, /* counter can be used by both threads */
|
|
|
|
INTEL_EXCL_EXCLUSIVE = 2, /* counter can be used by one thread only */
|
|
|
|
};
|
|
|
|
|
|
|
|
struct intel_excl_states {
|
|
|
|
enum intel_excl_state_type state[X86_PMC_IDX_MAX];
|
perf/x86/intel: Implement cross-HT corruption bug workaround
This patch implements a software workaround for a HW erratum
on Intel SandyBridge, IvyBridge and Haswell processors
with Hyperthreading enabled. The errata are documented for
each processor in their respective specification update
documents:
- SandyBridge: BJ122
- IvyBridge: BV98
- Haswell: HSD29
The bug causes silent counter corruption across hyperthreads only
when measuring certain memory events (0xd0, 0xd1, 0xd2, 0xd3).
Counters measuring those events may leak counts to the sibling
counter. For instance, counter 0, thread 0 measuring event 0xd0,
may leak to counter 0, thread 1, regardless of the event measured
there. The size of the leak is not predictible. It all depends on
the workload and the state of each sibling hyper-thread. The
corrupting events do undercount as a consequence of the leak. The
leak is compensated automatically only when the sibling counter measures
the exact same corrupting event AND the workload is on the two threads
is the same. Given, there is no way to guarantee this, a work-around
is necessary. Furthermore, there is a serious problem if the leaked count
is added to a low-occurrence event. In that case the corruption on
the low occurrence event can be very large, e.g., orders of magnitude.
There is no HW or FW workaround for this problem.
The bug is very easy to reproduce on a loaded system.
Here is an example on a Haswell client, where CPU0, CPU4
are siblings. We load the CPUs with a simple triad app
streaming large floating-point vector. We use 0x81d0
corrupting event (MEM_UOPS_RETIRED:ALL_LOADS) and
0x20cc (ROB_MISC_EVENTS:LBR_INSERTS). Given we are not
using the LBR, the 0x20cc event should be zero.
$ taskset -c 0 triad &
$ taskset -c 4 triad &
$ perf stat -a -C 0 -e r81d0 sleep 100 &
$ perf stat -a -C 4 -r20cc sleep 10
Performance counter stats for 'system wide':
139 277 291 r20cc
10,000969126 seconds time elapsed
In this example, 0x81d0 and r20cc ar eusing sinling counters
on CPU0 and CPU4. 0x81d0 leaks into 0x20cc and corrupts it
from 0 to 139 millions occurrences.
This patch provides a software workaround to this problem by modifying the
way events are scheduled onto counters by the kernel. The patch forces
cross-thread mutual exclusion between counters in case a corrupting event
is measured by one of the hyper-threads. If thread 0, counter 0 is measuring
event 0xd0, then nothing can be measured on counter 0, thread 1. If no corrupting
event is measured on any hyper-thread, event scheduling proceeds as before.
The same example run with the workaround enabled, yield the correct answer:
$ taskset -c 0 triad &
$ taskset -c 4 triad &
$ perf stat -a -C 0 -e r81d0 sleep 100 &
$ perf stat -a -C 4 -r20cc sleep 10
Performance counter stats for 'system wide':
0 r20cc
10,000969126 seconds time elapsed
The patch does provide correctness for all non-corrupting events. It does not
"repatriate" the leaked counts back to the leaking counter. This is planned
for a second patch series. This patch series makes this repatriation more
easy by guaranteeing the sibling counter is not measuring any useful event.
The patch introduces dynamic constraints for events. That means that events which
did not have constraints, i.e., could be measured on any counters, may now be
constrained to a subset of the counters depending on what is going on the sibling
thread. The algorithm is similar to a cache coherency protocol. We call it XSU
in reference to Exclusive, Shared, Unused, the 3 possible states of a PMU
counter.
As a consequence of the workaround, users may see an increased amount of event
multiplexing, even in situtations where there are fewer events than counters
measured on a CPU.
Patch has been tested on all three impacted processors. Note that when
HT is off, there is no corruption. However, the workaround is still enabled,
yet not costing too much. Adding a dynamic detection of HT on turned out to
be complex are requiring too much to code to be justified.
This patch addresses the issue when PEBS is not used. A subsequent patch
fixes the problem when PEBS is used.
Signed-off-by: Maria Dimakopoulou <maria.n.dimakopoulou@gmail.com>
[spinlock_t -> raw_spinlock_t]
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Stephane Eranian <eranian@google.com>
Cc: bp@alien8.de
Cc: jolsa@redhat.com
Cc: kan.liang@intel.com
Link: http://lkml.kernel.org/r/1416251225-17721-7-git-send-email-eranian@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2014-11-17 19:06:58 +00:00
|
|
|
bool sched_started; /* true if scheduling has started */
|
2014-11-17 19:06:57 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
struct intel_excl_cntrs {
|
|
|
|
raw_spinlock_t lock;
|
|
|
|
|
|
|
|
struct intel_excl_states states[2];
|
|
|
|
|
2015-05-21 08:57:17 +00:00
|
|
|
union {
|
|
|
|
u16 has_exclusive[2];
|
|
|
|
u32 exclusive_present;
|
|
|
|
};
|
|
|
|
|
2014-11-17 19:06:57 +00:00
|
|
|
int refcnt; /* per-core: #HT threads */
|
|
|
|
unsigned core_id; /* per-core: core id */
|
|
|
|
};
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
#define MAX_LBR_ENTRIES 16
|
|
|
|
|
2014-11-17 19:06:54 +00:00
|
|
|
enum {
|
|
|
|
X86_PERF_KFREE_SHARED = 0,
|
|
|
|
X86_PERF_KFREE_EXCL = 1,
|
|
|
|
X86_PERF_KFREE_MAX
|
|
|
|
};
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
struct cpu_hw_events {
|
|
|
|
/*
|
|
|
|
* Generic x86 PMC bits
|
|
|
|
*/
|
|
|
|
struct perf_event *events[X86_PMC_IDX_MAX]; /* in counter order */
|
|
|
|
unsigned long active_mask[BITS_TO_LONGS(X86_PMC_IDX_MAX)];
|
|
|
|
unsigned long running[BITS_TO_LONGS(X86_PMC_IDX_MAX)];
|
|
|
|
int enabled;
|
|
|
|
|
2014-02-24 11:26:21 +00:00
|
|
|
int n_events; /* the # of events in the below arrays */
|
|
|
|
int n_added; /* the # last events in the below arrays;
|
|
|
|
they've never been enabled yet */
|
|
|
|
int n_txn; /* the # last events in the below arrays;
|
|
|
|
added in the current transaction */
|
2011-08-30 23:41:05 +00:00
|
|
|
int assign[X86_PMC_IDX_MAX]; /* event to counter assignment */
|
|
|
|
u64 tags[X86_PMC_IDX_MAX];
|
2015-05-21 08:57:13 +00:00
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
struct perf_event *event_list[X86_PMC_IDX_MAX]; /* in enabled order */
|
2015-05-21 08:57:13 +00:00
|
|
|
struct event_constraint *event_constraint[X86_PMC_IDX_MAX];
|
|
|
|
|
2015-05-21 08:57:17 +00:00
|
|
|
int n_excl; /* the number of exclusive events */
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
unsigned int group_flag;
|
2012-06-05 13:30:31 +00:00
|
|
|
int is_fake;
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Intel DebugStore bits
|
|
|
|
*/
|
|
|
|
struct debug_store *ds;
|
|
|
|
u64 pebs_enabled;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Intel LBR bits
|
|
|
|
*/
|
|
|
|
int lbr_users;
|
|
|
|
void *lbr_context;
|
|
|
|
struct perf_branch_stack lbr_stack;
|
|
|
|
struct perf_branch_entry lbr_entries[MAX_LBR_ENTRIES];
|
2012-02-09 22:20:53 +00:00
|
|
|
struct er_account *lbr_sel;
|
2012-02-09 22:20:58 +00:00
|
|
|
u64 br_sel;
|
2011-08-30 23:41:05 +00:00
|
|
|
|
2011-10-05 12:01:21 +00:00
|
|
|
/*
|
|
|
|
* Intel host/guest exclude bits
|
|
|
|
*/
|
|
|
|
u64 intel_ctrl_guest_mask;
|
|
|
|
u64 intel_ctrl_host_mask;
|
|
|
|
struct perf_guest_switch_msr guest_switch_msrs[X86_PMC_IDX_MAX];
|
|
|
|
|
2013-09-12 10:53:44 +00:00
|
|
|
/*
|
|
|
|
* Intel checkpoint mask
|
|
|
|
*/
|
|
|
|
u64 intel_cp_status;
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
/*
|
|
|
|
* manage shared (per-core, per-cpu) registers
|
|
|
|
* used on Intel NHM/WSM/SNB
|
|
|
|
*/
|
|
|
|
struct intel_shared_regs *shared_regs;
|
2014-11-17 19:06:57 +00:00
|
|
|
/*
|
|
|
|
* manage exclusive counter access between hyperthread
|
|
|
|
*/
|
|
|
|
struct event_constraint *constraint_list; /* in enable order */
|
|
|
|
struct intel_excl_cntrs *excl_cntrs;
|
|
|
|
int excl_thread_id; /* 0 or 1 */
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* AMD specific bits
|
|
|
|
*/
|
2012-02-29 13:57:32 +00:00
|
|
|
struct amd_nb *amd_nb;
|
|
|
|
/* Inverted mask of bits to clear in the perf_ctr ctrl registers */
|
|
|
|
u64 perf_ctr_virt_mask;
|
2011-08-30 23:41:05 +00:00
|
|
|
|
2014-11-17 19:06:54 +00:00
|
|
|
void *kfree_on_online[X86_PERF_KFREE_MAX];
|
2011-08-30 23:41:05 +00:00
|
|
|
};
|
|
|
|
|
2013-01-24 15:10:27 +00:00
|
|
|
#define __EVENT_CONSTRAINT(c, n, m, w, o, f) {\
|
2011-08-30 23:41:05 +00:00
|
|
|
{ .idxmsk64 = (n) }, \
|
|
|
|
.code = (c), \
|
|
|
|
.cmask = (m), \
|
|
|
|
.weight = (w), \
|
2011-11-18 11:35:22 +00:00
|
|
|
.overlap = (o), \
|
2013-01-24 15:10:27 +00:00
|
|
|
.flags = f, \
|
2011-08-30 23:41:05 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#define EVENT_CONSTRAINT(c, n, m) \
|
2013-01-24 15:10:27 +00:00
|
|
|
__EVENT_CONSTRAINT(c, n, m, HWEIGHT(n), 0, 0)
|
2011-11-18 11:35:22 +00:00
|
|
|
|
2014-11-17 19:06:57 +00:00
|
|
|
#define INTEL_EXCLEVT_CONSTRAINT(c, n) \
|
|
|
|
__EVENT_CONSTRAINT(c, n, ARCH_PERFMON_EVENTSEL_EVENT, HWEIGHT(n),\
|
|
|
|
0, PERF_X86_EVENT_EXCL)
|
|
|
|
|
2011-11-18 11:35:22 +00:00
|
|
|
/*
|
|
|
|
* The overlap flag marks event constraints with overlapping counter
|
|
|
|
* masks. This is the case if the counter mask of such an event is not
|
|
|
|
* a subset of any other counter mask of a constraint with an equal or
|
|
|
|
* higher weight, e.g.:
|
|
|
|
*
|
|
|
|
* c_overlaps = EVENT_CONSTRAINT_OVERLAP(0, 0x09, 0);
|
|
|
|
* c_another1 = EVENT_CONSTRAINT(0, 0x07, 0);
|
|
|
|
* c_another2 = EVENT_CONSTRAINT(0, 0x38, 0);
|
|
|
|
*
|
|
|
|
* The event scheduler may not select the correct counter in the first
|
|
|
|
* cycle because it needs to know which subsequent events will be
|
|
|
|
* scheduled. It may fail to schedule the events then. So we set the
|
|
|
|
* overlap flag for such constraints to give the scheduler a hint which
|
|
|
|
* events to select for counter rescheduling.
|
|
|
|
*
|
|
|
|
* Care must be taken as the rescheduling algorithm is O(n!) which
|
|
|
|
* will increase scheduling cycles for an over-commited system
|
|
|
|
* dramatically. The number of such EVENT_CONSTRAINT_OVERLAP() macros
|
|
|
|
* and its counter masks must be kept at a minimum.
|
|
|
|
*/
|
|
|
|
#define EVENT_CONSTRAINT_OVERLAP(c, n, m) \
|
2013-01-24 15:10:27 +00:00
|
|
|
__EVENT_CONSTRAINT(c, n, m, HWEIGHT(n), 1, 0)
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Constraint on the Event code.
|
|
|
|
*/
|
|
|
|
#define INTEL_EVENT_CONSTRAINT(c, n) \
|
|
|
|
EVENT_CONSTRAINT(c, n, ARCH_PERFMON_EVENTSEL_EVENT)
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Constraint on the Event code + UMask + fixed-mask
|
|
|
|
*
|
|
|
|
* filter mask to validate fixed counter events.
|
|
|
|
* the following filters disqualify for fixed counters:
|
|
|
|
* - inv
|
|
|
|
* - edge
|
|
|
|
* - cnt-mask
|
2013-06-18 00:36:48 +00:00
|
|
|
* - in_tx
|
|
|
|
* - in_tx_checkpointed
|
2011-08-30 23:41:05 +00:00
|
|
|
* The other filters are supported by fixed counters.
|
|
|
|
* The any-thread option is supported starting with v3.
|
|
|
|
*/
|
2013-06-18 00:36:48 +00:00
|
|
|
#define FIXED_EVENT_FLAGS (X86_RAW_EVENT_MASK|HSW_IN_TX|HSW_IN_TX_CHECKPOINTED)
|
2011-08-30 23:41:05 +00:00
|
|
|
#define FIXED_EVENT_CONSTRAINT(c, n) \
|
2013-06-18 00:36:48 +00:00
|
|
|
EVENT_CONSTRAINT(c, (1ULL << (32+n)), FIXED_EVENT_FLAGS)
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Constraint on the Event code + UMask
|
|
|
|
*/
|
|
|
|
#define INTEL_UEVENT_CONSTRAINT(c, n) \
|
|
|
|
EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK)
|
|
|
|
|
2014-09-24 14:34:46 +00:00
|
|
|
/* Like UEVENT_CONSTRAINT, but match flags too */
|
|
|
|
#define INTEL_FLAGS_UEVENT_CONSTRAINT(c, n) \
|
|
|
|
EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS)
|
|
|
|
|
perf/x86/intel: Implement cross-HT corruption bug workaround
This patch implements a software workaround for a HW erratum
on Intel SandyBridge, IvyBridge and Haswell processors
with Hyperthreading enabled. The errata are documented for
each processor in their respective specification update
documents:
- SandyBridge: BJ122
- IvyBridge: BV98
- Haswell: HSD29
The bug causes silent counter corruption across hyperthreads only
when measuring certain memory events (0xd0, 0xd1, 0xd2, 0xd3).
Counters measuring those events may leak counts to the sibling
counter. For instance, counter 0, thread 0 measuring event 0xd0,
may leak to counter 0, thread 1, regardless of the event measured
there. The size of the leak is not predictible. It all depends on
the workload and the state of each sibling hyper-thread. The
corrupting events do undercount as a consequence of the leak. The
leak is compensated automatically only when the sibling counter measures
the exact same corrupting event AND the workload is on the two threads
is the same. Given, there is no way to guarantee this, a work-around
is necessary. Furthermore, there is a serious problem if the leaked count
is added to a low-occurrence event. In that case the corruption on
the low occurrence event can be very large, e.g., orders of magnitude.
There is no HW or FW workaround for this problem.
The bug is very easy to reproduce on a loaded system.
Here is an example on a Haswell client, where CPU0, CPU4
are siblings. We load the CPUs with a simple triad app
streaming large floating-point vector. We use 0x81d0
corrupting event (MEM_UOPS_RETIRED:ALL_LOADS) and
0x20cc (ROB_MISC_EVENTS:LBR_INSERTS). Given we are not
using the LBR, the 0x20cc event should be zero.
$ taskset -c 0 triad &
$ taskset -c 4 triad &
$ perf stat -a -C 0 -e r81d0 sleep 100 &
$ perf stat -a -C 4 -r20cc sleep 10
Performance counter stats for 'system wide':
139 277 291 r20cc
10,000969126 seconds time elapsed
In this example, 0x81d0 and r20cc ar eusing sinling counters
on CPU0 and CPU4. 0x81d0 leaks into 0x20cc and corrupts it
from 0 to 139 millions occurrences.
This patch provides a software workaround to this problem by modifying the
way events are scheduled onto counters by the kernel. The patch forces
cross-thread mutual exclusion between counters in case a corrupting event
is measured by one of the hyper-threads. If thread 0, counter 0 is measuring
event 0xd0, then nothing can be measured on counter 0, thread 1. If no corrupting
event is measured on any hyper-thread, event scheduling proceeds as before.
The same example run with the workaround enabled, yield the correct answer:
$ taskset -c 0 triad &
$ taskset -c 4 triad &
$ perf stat -a -C 0 -e r81d0 sleep 100 &
$ perf stat -a -C 4 -r20cc sleep 10
Performance counter stats for 'system wide':
0 r20cc
10,000969126 seconds time elapsed
The patch does provide correctness for all non-corrupting events. It does not
"repatriate" the leaked counts back to the leaking counter. This is planned
for a second patch series. This patch series makes this repatriation more
easy by guaranteeing the sibling counter is not measuring any useful event.
The patch introduces dynamic constraints for events. That means that events which
did not have constraints, i.e., could be measured on any counters, may now be
constrained to a subset of the counters depending on what is going on the sibling
thread. The algorithm is similar to a cache coherency protocol. We call it XSU
in reference to Exclusive, Shared, Unused, the 3 possible states of a PMU
counter.
As a consequence of the workaround, users may see an increased amount of event
multiplexing, even in situtations where there are fewer events than counters
measured on a CPU.
Patch has been tested on all three impacted processors. Note that when
HT is off, there is no corruption. However, the workaround is still enabled,
yet not costing too much. Adding a dynamic detection of HT on turned out to
be complex are requiring too much to code to be justified.
This patch addresses the issue when PEBS is not used. A subsequent patch
fixes the problem when PEBS is used.
Signed-off-by: Maria Dimakopoulou <maria.n.dimakopoulou@gmail.com>
[spinlock_t -> raw_spinlock_t]
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Stephane Eranian <eranian@google.com>
Cc: bp@alien8.de
Cc: jolsa@redhat.com
Cc: kan.liang@intel.com
Link: http://lkml.kernel.org/r/1416251225-17721-7-git-send-email-eranian@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2014-11-17 19:06:58 +00:00
|
|
|
#define INTEL_EXCLUEVT_CONSTRAINT(c, n) \
|
|
|
|
__EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK, \
|
|
|
|
HWEIGHT(n), 0, PERF_X86_EVENT_EXCL)
|
|
|
|
|
2013-01-24 15:10:32 +00:00
|
|
|
#define INTEL_PLD_CONSTRAINT(c, n) \
|
2014-08-11 19:27:10 +00:00
|
|
|
__EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS, \
|
2013-01-24 15:10:32 +00:00
|
|
|
HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_LDLAT)
|
|
|
|
|
2013-01-24 15:10:34 +00:00
|
|
|
#define INTEL_PST_CONSTRAINT(c, n) \
|
2014-08-11 19:27:10 +00:00
|
|
|
__EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS, \
|
2013-01-24 15:10:34 +00:00
|
|
|
HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_ST)
|
|
|
|
|
2014-08-11 19:27:10 +00:00
|
|
|
/* Event constraint, but match on all event flags too. */
|
|
|
|
#define INTEL_FLAGS_EVENT_CONSTRAINT(c, n) \
|
|
|
|
EVENT_CONSTRAINT(c, n, INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS)
|
|
|
|
|
|
|
|
/* Check only flags, but allow all event/umask */
|
|
|
|
#define INTEL_ALL_EVENT_CONSTRAINT(code, n) \
|
|
|
|
EVENT_CONSTRAINT(code, n, X86_ALL_EVENT_FLAGS)
|
|
|
|
|
|
|
|
/* Check flags and event code, and set the HSW store flag */
|
|
|
|
#define INTEL_FLAGS_EVENT_CONSTRAINT_DATALA_ST(code, n) \
|
|
|
|
__EVENT_CONSTRAINT(code, n, \
|
|
|
|
ARCH_PERFMON_EVENTSEL_EVENT|X86_ALL_EVENT_FLAGS, \
|
|
|
|
HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_ST_HSW)
|
|
|
|
|
|
|
|
/* Check flags and event code, and set the HSW load flag */
|
|
|
|
#define INTEL_FLAGS_EVENT_CONSTRAINT_DATALA_LD(code, n) \
|
2014-11-17 19:07:00 +00:00
|
|
|
__EVENT_CONSTRAINT(code, n, \
|
2014-08-11 19:27:10 +00:00
|
|
|
ARCH_PERFMON_EVENTSEL_EVENT|X86_ALL_EVENT_FLAGS, \
|
|
|
|
HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_LD_HSW)
|
|
|
|
|
2014-11-17 19:07:00 +00:00
|
|
|
#define INTEL_FLAGS_EVENT_CONSTRAINT_DATALA_XLD(code, n) \
|
|
|
|
__EVENT_CONSTRAINT(code, n, \
|
|
|
|
ARCH_PERFMON_EVENTSEL_EVENT|X86_ALL_EVENT_FLAGS, \
|
|
|
|
HWEIGHT(n), 0, \
|
|
|
|
PERF_X86_EVENT_PEBS_LD_HSW|PERF_X86_EVENT_EXCL)
|
|
|
|
|
2014-08-11 19:27:10 +00:00
|
|
|
/* Check flags and event code/umask, and set the HSW store flag */
|
|
|
|
#define INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_ST(code, n) \
|
|
|
|
__EVENT_CONSTRAINT(code, n, \
|
|
|
|
INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS, \
|
2013-06-18 00:36:52 +00:00
|
|
|
HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_ST_HSW)
|
|
|
|
|
2014-11-17 19:07:00 +00:00
|
|
|
#define INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_XST(code, n) \
|
|
|
|
__EVENT_CONSTRAINT(code, n, \
|
|
|
|
INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS, \
|
|
|
|
HWEIGHT(n), 0, \
|
|
|
|
PERF_X86_EVENT_PEBS_ST_HSW|PERF_X86_EVENT_EXCL)
|
|
|
|
|
2014-08-11 19:27:10 +00:00
|
|
|
/* Check flags and event code/umask, and set the HSW load flag */
|
|
|
|
#define INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_LD(code, n) \
|
|
|
|
__EVENT_CONSTRAINT(code, n, \
|
|
|
|
INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS, \
|
|
|
|
HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_LD_HSW)
|
|
|
|
|
2014-11-17 19:07:00 +00:00
|
|
|
#define INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_XLD(code, n) \
|
|
|
|
__EVENT_CONSTRAINT(code, n, \
|
|
|
|
INTEL_ARCH_EVENT_MASK|X86_ALL_EVENT_FLAGS, \
|
|
|
|
HWEIGHT(n), 0, \
|
|
|
|
PERF_X86_EVENT_PEBS_LD_HSW|PERF_X86_EVENT_EXCL)
|
|
|
|
|
2014-08-11 19:27:10 +00:00
|
|
|
/* Check flags and event code/umask, and set the HSW N/A flag */
|
|
|
|
#define INTEL_FLAGS_UEVENT_CONSTRAINT_DATALA_NA(code, n) \
|
|
|
|
__EVENT_CONSTRAINT(code, n, \
|
|
|
|
INTEL_ARCH_EVENT_MASK|INTEL_ARCH_EVENT_MASK, \
|
|
|
|
HWEIGHT(n), 0, PERF_X86_EVENT_PEBS_NA_HSW)
|
|
|
|
|
|
|
|
|
2013-12-04 23:24:37 +00:00
|
|
|
/*
|
|
|
|
* We define the end marker as having a weight of -1
|
|
|
|
* to enable blacklisting of events using a counter bitmask
|
|
|
|
* of zero and thus a weight of zero.
|
|
|
|
* The end marker has a weight that cannot possibly be
|
|
|
|
* obtained from counting the bits in the bitmask.
|
|
|
|
*/
|
|
|
|
#define EVENT_CONSTRAINT_END { .weight = -1 }
|
2011-08-30 23:41:05 +00:00
|
|
|
|
2013-12-04 23:24:37 +00:00
|
|
|
/*
|
|
|
|
* Check for end marker with weight == -1
|
|
|
|
*/
|
2011-08-30 23:41:05 +00:00
|
|
|
#define for_each_event_constraint(e, c) \
|
2013-12-04 23:24:37 +00:00
|
|
|
for ((e) = (c); (e)->weight != -1; (e)++)
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Extra registers for specific events.
|
|
|
|
*
|
|
|
|
* Some events need large masks and require external MSRs.
|
|
|
|
* Those extra MSRs end up being shared for all events on
|
|
|
|
* a PMU and sometimes between PMU of sibling HT threads.
|
|
|
|
* In either case, the kernel needs to handle conflicting
|
|
|
|
* accesses to those extra, shared, regs. The data structure
|
|
|
|
* to manage those registers is stored in cpu_hw_event.
|
|
|
|
*/
|
|
|
|
struct extra_reg {
|
|
|
|
unsigned int event;
|
|
|
|
unsigned int msr;
|
|
|
|
u64 config_mask;
|
|
|
|
u64 valid_mask;
|
|
|
|
int idx; /* per_xxx->regs[] reg index */
|
2014-07-14 19:25:56 +00:00
|
|
|
bool extra_msr_access;
|
2011-08-30 23:41:05 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
#define EVENT_EXTRA_REG(e, ms, m, vm, i) { \
|
2014-07-14 19:25:56 +00:00
|
|
|
.event = (e), \
|
|
|
|
.msr = (ms), \
|
|
|
|
.config_mask = (m), \
|
|
|
|
.valid_mask = (vm), \
|
|
|
|
.idx = EXTRA_REG_##i, \
|
|
|
|
.extra_msr_access = true, \
|
2011-08-30 23:41:05 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#define INTEL_EVENT_EXTRA_REG(event, msr, vm, idx) \
|
|
|
|
EVENT_EXTRA_REG(event, msr, ARCH_PERFMON_EVENTSEL_EVENT, vm, idx)
|
|
|
|
|
2013-01-24 15:10:32 +00:00
|
|
|
#define INTEL_UEVENT_EXTRA_REG(event, msr, vm, idx) \
|
|
|
|
EVENT_EXTRA_REG(event, msr, ARCH_PERFMON_EVENTSEL_EVENT | \
|
|
|
|
ARCH_PERFMON_EVENTSEL_UMASK, vm, idx)
|
|
|
|
|
|
|
|
#define INTEL_UEVENT_PEBS_LDLAT_EXTRA_REG(c) \
|
|
|
|
INTEL_UEVENT_EXTRA_REG(c, \
|
|
|
|
MSR_PEBS_LD_LAT_THRESHOLD, \
|
|
|
|
0xffff, \
|
|
|
|
LDLAT)
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
#define EVENT_EXTRA_END EVENT_EXTRA_REG(0, 0, 0, 0, RSP_0)
|
|
|
|
|
|
|
|
union perf_capabilities {
|
|
|
|
struct {
|
|
|
|
u64 lbr_format:6;
|
|
|
|
u64 pebs_trap:1;
|
|
|
|
u64 pebs_arch_reg:1;
|
|
|
|
u64 pebs_format:4;
|
|
|
|
u64 smm_freeze:1;
|
2013-06-25 15:12:33 +00:00
|
|
|
/*
|
|
|
|
* PMU supports separate counter range for writing
|
|
|
|
* values > 32bit.
|
|
|
|
*/
|
|
|
|
u64 full_width_write:1;
|
2011-08-30 23:41:05 +00:00
|
|
|
};
|
|
|
|
u64 capabilities;
|
|
|
|
};
|
|
|
|
|
2011-12-06 13:07:15 +00:00
|
|
|
struct x86_pmu_quirk {
|
|
|
|
struct x86_pmu_quirk *next;
|
|
|
|
void (*func)(void);
|
|
|
|
};
|
|
|
|
|
2012-03-12 11:44:35 +00:00
|
|
|
union x86_pmu_config {
|
|
|
|
struct {
|
|
|
|
u64 event:8,
|
|
|
|
umask:8,
|
|
|
|
usr:1,
|
|
|
|
os:1,
|
|
|
|
edge:1,
|
|
|
|
pc:1,
|
|
|
|
interrupt:1,
|
|
|
|
__reserved1:1,
|
|
|
|
en:1,
|
|
|
|
inv:1,
|
|
|
|
cmask:8,
|
|
|
|
event2:4,
|
|
|
|
__reserved2:4,
|
|
|
|
go:1,
|
|
|
|
ho:1;
|
|
|
|
} bits;
|
|
|
|
u64 value;
|
|
|
|
};
|
|
|
|
|
|
|
|
#define X86_CONFIG(args...) ((union x86_pmu_config){.bits = {args}}).value
|
|
|
|
|
2015-01-14 12:18:20 +00:00
|
|
|
enum {
|
|
|
|
x86_lbr_exclusive_lbr,
|
2015-01-30 10:40:35 +00:00
|
|
|
x86_lbr_exclusive_bts,
|
2015-01-14 12:18:20 +00:00
|
|
|
x86_lbr_exclusive_pt,
|
|
|
|
x86_lbr_exclusive_max,
|
|
|
|
};
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
/*
|
|
|
|
* struct x86_pmu - generic x86 pmu
|
|
|
|
*/
|
|
|
|
struct x86_pmu {
|
|
|
|
/*
|
|
|
|
* Generic x86 PMC bits
|
|
|
|
*/
|
|
|
|
const char *name;
|
|
|
|
int version;
|
|
|
|
int (*handle_irq)(struct pt_regs *);
|
|
|
|
void (*disable_all)(void);
|
|
|
|
void (*enable_all)(int added);
|
|
|
|
void (*enable)(struct perf_event *);
|
|
|
|
void (*disable)(struct perf_event *);
|
|
|
|
int (*hw_config)(struct perf_event *event);
|
|
|
|
int (*schedule_events)(struct cpu_hw_events *cpuc, int n, int *assign);
|
|
|
|
unsigned eventsel;
|
|
|
|
unsigned perfctr;
|
2013-02-06 17:26:27 +00:00
|
|
|
int (*addr_offset)(int index, bool eventsel);
|
2013-02-06 17:26:28 +00:00
|
|
|
int (*rdpmc_index)(int index);
|
2011-08-30 23:41:05 +00:00
|
|
|
u64 (*event_map)(int);
|
|
|
|
int max_events;
|
|
|
|
int num_counters;
|
|
|
|
int num_counters_fixed;
|
|
|
|
int cntval_bits;
|
|
|
|
u64 cntval_mask;
|
2011-11-10 12:57:26 +00:00
|
|
|
union {
|
|
|
|
unsigned long events_maskl;
|
|
|
|
unsigned long events_mask[BITS_TO_LONGS(ARCH_PERFMON_EVENTS_COUNT)];
|
|
|
|
};
|
|
|
|
int events_mask_len;
|
2011-08-30 23:41:05 +00:00
|
|
|
int apic;
|
|
|
|
u64 max_period;
|
|
|
|
struct event_constraint *
|
|
|
|
(*get_event_constraints)(struct cpu_hw_events *cpuc,
|
2014-11-17 19:06:56 +00:00
|
|
|
int idx,
|
2011-08-30 23:41:05 +00:00
|
|
|
struct perf_event *event);
|
|
|
|
|
|
|
|
void (*put_event_constraints)(struct cpu_hw_events *cpuc,
|
|
|
|
struct perf_event *event);
|
2014-11-17 19:06:55 +00:00
|
|
|
|
|
|
|
void (*start_scheduling)(struct cpu_hw_events *cpuc);
|
|
|
|
|
2015-05-21 08:57:32 +00:00
|
|
|
void (*commit_scheduling)(struct cpu_hw_events *cpuc, int idx, int cntr);
|
|
|
|
|
2014-11-17 19:06:55 +00:00
|
|
|
void (*stop_scheduling)(struct cpu_hw_events *cpuc);
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
struct event_constraint *event_constraints;
|
2011-12-06 13:07:15 +00:00
|
|
|
struct x86_pmu_quirk *quirks;
|
2011-08-30 23:41:05 +00:00
|
|
|
int perfctr_second_write;
|
2013-06-18 00:36:50 +00:00
|
|
|
bool late_ack;
|
perf/x86/intel: Add INST_RETIRED.ALL workarounds
On Broadwell INST_RETIRED.ALL cannot be used with any period
that doesn't have the lowest 6 bits cleared. And the period
should not be smaller than 128.
This is erratum BDM11 and BDM55:
http://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/5th-gen-core-family-spec-update.pdf
BDM11: When using a period < 100; we may get incorrect PEBS/PMI
interrupts and/or an invalid counter state.
BDM55: When bit0-5 of the period are !0 we may get redundant PEBS
records on overflow.
Add a new callback to enforce this, and set it for Broadwell.
How does this handle the case when an app requests a specific
period with some of the bottom bits set?
Short answer:
Any useful instruction sampling period needs to be 4-6 orders
of magnitude larger than 128, as an PMI every 128 instructions
would instantly overwhelm the system and be throttled.
So the +-64 error from this is really small compared to the
period, much smaller than normal system jitter.
Long answer (by Peterz):
IFF we guarantee perf_event_attr::sample_period >= 128.
Suppose we start out with sample_period=192; then we'll set period_left
to 192, we'll end up with left = 128 (we truncate the lower bits). We
get an interrupt, find that period_left = 64 (>0 so we return 0 and
don't get an overflow handler), up that to 128. Then we trigger again,
at n=256. Then we find period_left = -64 (<=0 so we return 1 and do get
an overflow). We increment with sample_period so we get left = 128. We
fire again, at n=384, period_left = 0 (<=0 so we return 1 and get an
overflow). And on and on.
So while the individual interrupts are 'wrong' we get then with
interval=256,128 in exactly the right ratio to average out at 192. And
this works for everything >=128.
So the num_samples*fixed_period thing is still entirely correct +- 127,
which is good enough I'd say, as you already have that error anyhow.
So no need to 'fix' the tools, al we need to do is refuse to create
INST_RETIRED:ALL events with sample_period < 128.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
[ Updated comments and changelog a bit. ]
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1424225886-18652-3-git-send-email-andi@firstfloor.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-02-18 02:18:06 +00:00
|
|
|
unsigned (*limit_period)(struct perf_event *event, unsigned l);
|
2011-08-30 23:41:05 +00:00
|
|
|
|
2011-11-20 22:30:47 +00:00
|
|
|
/*
|
|
|
|
* sysfs attrs
|
|
|
|
*/
|
2014-02-05 19:48:51 +00:00
|
|
|
int attr_rdpmc_broken;
|
2011-11-20 22:30:47 +00:00
|
|
|
int attr_rdpmc;
|
2012-03-15 19:09:14 +00:00
|
|
|
struct attribute **format_attrs;
|
2013-01-24 15:10:32 +00:00
|
|
|
struct attribute **event_attrs;
|
2011-11-20 22:30:47 +00:00
|
|
|
|
2012-10-10 12:53:11 +00:00
|
|
|
ssize_t (*events_sysfs_show)(char *page, u64 config);
|
2013-01-24 15:10:25 +00:00
|
|
|
struct attribute **cpu_events;
|
2012-10-10 12:53:11 +00:00
|
|
|
|
2011-11-20 22:30:47 +00:00
|
|
|
/*
|
|
|
|
* CPU Hotplug hooks
|
|
|
|
*/
|
2011-08-30 23:41:05 +00:00
|
|
|
int (*cpu_prepare)(int cpu);
|
|
|
|
void (*cpu_starting)(int cpu);
|
|
|
|
void (*cpu_dying)(int cpu);
|
|
|
|
void (*cpu_dead)(int cpu);
|
2012-06-08 12:50:50 +00:00
|
|
|
|
|
|
|
void (*check_microcode)(void);
|
2014-11-05 02:55:58 +00:00
|
|
|
void (*sched_task)(struct perf_event_context *ctx,
|
|
|
|
bool sched_in);
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Intel Arch Perfmon v2+
|
|
|
|
*/
|
|
|
|
u64 intel_ctrl;
|
|
|
|
union perf_capabilities intel_cap;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Intel DebugStore bits
|
|
|
|
*/
|
2012-07-09 11:50:23 +00:00
|
|
|
unsigned int bts :1,
|
2012-06-26 21:38:39 +00:00
|
|
|
bts_active :1,
|
|
|
|
pebs :1,
|
|
|
|
pebs_active :1,
|
|
|
|
pebs_broken :1;
|
2011-08-30 23:41:05 +00:00
|
|
|
int pebs_record_size;
|
|
|
|
void (*drain_pebs)(struct pt_regs *regs);
|
|
|
|
struct event_constraint *pebs_constraints;
|
2012-06-05 08:26:43 +00:00
|
|
|
void (*pebs_aliases)(struct perf_event *event);
|
2012-06-06 00:56:48 +00:00
|
|
|
int max_pebs_events;
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Intel LBR
|
|
|
|
*/
|
|
|
|
unsigned long lbr_tos, lbr_from, lbr_to; /* MSR base regs */
|
|
|
|
int lbr_nr; /* hardware stack size */
|
2012-02-09 22:20:53 +00:00
|
|
|
u64 lbr_sel_mask; /* LBR_SELECT valid bits */
|
|
|
|
const int *lbr_sel_map; /* lbr_select mappings */
|
2013-09-20 14:40:44 +00:00
|
|
|
bool lbr_double_abort; /* duplicated lbr aborts */
|
2011-08-30 23:41:05 +00:00
|
|
|
|
2015-01-14 12:18:20 +00:00
|
|
|
/*
|
|
|
|
* Intel PT/LBR/BTS are exclusive
|
|
|
|
*/
|
|
|
|
atomic_t lbr_exclusive[x86_lbr_exclusive_max];
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
/*
|
|
|
|
* Extra registers for events
|
|
|
|
*/
|
|
|
|
struct extra_reg *extra_regs;
|
2014-11-17 19:06:53 +00:00
|
|
|
unsigned int flags;
|
2011-10-05 12:01:21 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Intel host/guest support (KVM)
|
|
|
|
*/
|
|
|
|
struct perf_guest_switch_msr *(*guest_get_msrs)(int *nr);
|
2011-08-30 23:41:05 +00:00
|
|
|
};
|
|
|
|
|
2014-11-05 02:56:03 +00:00
|
|
|
struct x86_perf_task_context {
|
|
|
|
u64 lbr_from[MAX_LBR_ENTRIES];
|
|
|
|
u64 lbr_to[MAX_LBR_ENTRIES];
|
|
|
|
int lbr_callstack_users;
|
|
|
|
int lbr_stack_state;
|
|
|
|
};
|
|
|
|
|
2011-12-06 13:07:15 +00:00
|
|
|
#define x86_add_quirk(func_) \
|
|
|
|
do { \
|
|
|
|
static struct x86_pmu_quirk __quirk __initdata = { \
|
|
|
|
.func = func_, \
|
|
|
|
}; \
|
|
|
|
__quirk.next = x86_pmu.quirks; \
|
|
|
|
x86_pmu.quirks = &__quirk; \
|
|
|
|
} while (0)
|
|
|
|
|
2014-11-17 19:06:53 +00:00
|
|
|
/*
|
|
|
|
* x86_pmu flags
|
|
|
|
*/
|
|
|
|
#define PMU_FL_NO_HT_SHARING 0x1 /* no hyper-threading resource sharing */
|
|
|
|
#define PMU_FL_HAS_RSP_1 0x2 /* has 2 equivalent offcore_rsp regs */
|
2014-11-17 19:06:57 +00:00
|
|
|
#define PMU_FL_EXCL_CNTRS 0x4 /* has exclusive counter requirements */
|
2014-11-17 19:07:04 +00:00
|
|
|
#define PMU_FL_EXCL_ENABLED 0x8 /* exclusive counter active */
|
2011-08-30 23:41:05 +00:00
|
|
|
|
2013-01-24 15:10:26 +00:00
|
|
|
#define EVENT_VAR(_id) event_attr_##_id
|
|
|
|
#define EVENT_PTR(_id) &event_attr_##_id.attr.attr
|
|
|
|
|
|
|
|
#define EVENT_ATTR(_name, _id) \
|
|
|
|
static struct perf_pmu_events_attr EVENT_VAR(_id) = { \
|
|
|
|
.attr = __ATTR(_name, 0444, events_sysfs_show, NULL), \
|
|
|
|
.id = PERF_COUNT_HW_##_id, \
|
|
|
|
.event_str = NULL, \
|
|
|
|
};
|
|
|
|
|
|
|
|
#define EVENT_ATTR_STR(_name, v, str) \
|
|
|
|
static struct perf_pmu_events_attr event_attr_##v = { \
|
|
|
|
.attr = __ATTR(_name, 0444, events_sysfs_show, NULL), \
|
|
|
|
.id = 0, \
|
|
|
|
.event_str = str, \
|
|
|
|
};
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
extern struct x86_pmu x86_pmu __read_mostly;
|
|
|
|
|
perf/x86/intel: Add basic Haswell LBR call stack support
Haswell has a new feature that utilizes the existing LBR facility to
record call chains. To enable this feature, bits (JCC, NEAR_IND_JMP,
NEAR_REL_JMP, FAR_BRANCH, EN_CALLSTACK) in LBR_SELECT must be set to 1,
bits (NEAR_REL_CALL, NEAR-IND_CALL, NEAR_RET) must be cleared. Due to
a hardware bug of Haswell, this feature doesn't work well with
FREEZE_LBRS_ON_PMI.
When the call stack feature is enabled, the LBR stack will capture
unfiltered call data normally, but as return instructions are executed,
the last captured branch record is flushed from the on-chip registers
in a last-in first-out (LIFO) manner. Thus, branch information relative
to leaf functions will not be captured, while preserving the call stack
information of the main line execution path.
This patch defines a separate lbr_sel map for Haswell. The map contains
a new entry for the call stack feature.
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Signed-off-by: Kan Liang <kan.liang@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: eranian@google.com
Cc: jolsa@redhat.com
Link: http://lkml.kernel.org/r/1415156173-10035-5-git-send-email-kan.liang@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2014-11-05 02:56:00 +00:00
|
|
|
static inline bool x86_pmu_has_lbr_callstack(void)
|
|
|
|
{
|
|
|
|
return x86_pmu.lbr_sel_map &&
|
|
|
|
x86_pmu.lbr_sel_map[PERF_SAMPLE_BRANCH_CALL_STACK_SHIFT] > 0;
|
|
|
|
}
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
DECLARE_PER_CPU(struct cpu_hw_events, cpu_hw_events);
|
|
|
|
|
|
|
|
int x86_perf_event_set_period(struct perf_event *event);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Generalized hw caching related hw_event table, filled
|
|
|
|
* in on a per model basis. A value of 0 means
|
|
|
|
* 'not supported', -1 means 'hw_event makes no sense on
|
|
|
|
* this CPU', any other value means the raw hw_event
|
|
|
|
* ID.
|
|
|
|
*/
|
|
|
|
|
|
|
|
#define C(x) PERF_COUNT_HW_CACHE_##x
|
|
|
|
|
|
|
|
extern u64 __read_mostly hw_cache_event_ids
|
|
|
|
[PERF_COUNT_HW_CACHE_MAX]
|
|
|
|
[PERF_COUNT_HW_CACHE_OP_MAX]
|
|
|
|
[PERF_COUNT_HW_CACHE_RESULT_MAX];
|
|
|
|
extern u64 __read_mostly hw_cache_extra_regs
|
|
|
|
[PERF_COUNT_HW_CACHE_MAX]
|
|
|
|
[PERF_COUNT_HW_CACHE_OP_MAX]
|
|
|
|
[PERF_COUNT_HW_CACHE_RESULT_MAX];
|
|
|
|
|
|
|
|
u64 x86_perf_event_update(struct perf_event *event);
|
|
|
|
|
|
|
|
static inline unsigned int x86_pmu_config_addr(int index)
|
|
|
|
{
|
2013-02-06 17:26:27 +00:00
|
|
|
return x86_pmu.eventsel + (x86_pmu.addr_offset ?
|
|
|
|
x86_pmu.addr_offset(index, true) : index);
|
2011-08-30 23:41:05 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static inline unsigned int x86_pmu_event_addr(int index)
|
|
|
|
{
|
2013-02-06 17:26:27 +00:00
|
|
|
return x86_pmu.perfctr + (x86_pmu.addr_offset ?
|
|
|
|
x86_pmu.addr_offset(index, false) : index);
|
2011-08-30 23:41:05 +00:00
|
|
|
}
|
|
|
|
|
2013-02-06 17:26:28 +00:00
|
|
|
static inline int x86_pmu_rdpmc_index(int index)
|
|
|
|
{
|
|
|
|
return x86_pmu.rdpmc_index ? x86_pmu.rdpmc_index(index) : index;
|
|
|
|
}
|
|
|
|
|
2015-01-14 12:18:20 +00:00
|
|
|
int x86_add_exclusive(unsigned int what);
|
|
|
|
|
|
|
|
void x86_del_exclusive(unsigned int what);
|
|
|
|
|
|
|
|
void hw_perf_lbr_event_destroy(struct perf_event *event);
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
int x86_setup_perfctr(struct perf_event *event);
|
|
|
|
|
|
|
|
int x86_pmu_hw_config(struct perf_event *event);
|
|
|
|
|
|
|
|
void x86_pmu_disable_all(void);
|
|
|
|
|
|
|
|
static inline void __x86_pmu_enable_event(struct hw_perf_event *hwc,
|
|
|
|
u64 enable_mask)
|
|
|
|
{
|
2012-02-29 13:57:32 +00:00
|
|
|
u64 disable_mask = __this_cpu_read(cpu_hw_events.perf_ctr_virt_mask);
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
if (hwc->extra_reg.reg)
|
|
|
|
wrmsrl(hwc->extra_reg.reg, hwc->extra_reg.config);
|
2012-02-29 13:57:32 +00:00
|
|
|
wrmsrl(hwc->config_base, (hwc->config | enable_mask) & ~disable_mask);
|
2011-08-30 23:41:05 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void x86_pmu_enable_all(int added);
|
|
|
|
|
2015-05-21 08:57:13 +00:00
|
|
|
int perf_assign_events(struct event_constraint **constraints, int n,
|
2015-05-21 08:57:17 +00:00
|
|
|
int wmin, int wmax, int gpmax, int *assign);
|
2011-08-30 23:41:05 +00:00
|
|
|
int x86_schedule_events(struct cpu_hw_events *cpuc, int n, int *assign);
|
|
|
|
|
|
|
|
void x86_pmu_stop(struct perf_event *event, int flags);
|
|
|
|
|
|
|
|
static inline void x86_pmu_disable_event(struct perf_event *event)
|
|
|
|
{
|
|
|
|
struct hw_perf_event *hwc = &event->hw;
|
|
|
|
|
|
|
|
wrmsrl(hwc->config_base, hwc->config);
|
|
|
|
}
|
|
|
|
|
|
|
|
void x86_pmu_enable_event(struct perf_event *event);
|
|
|
|
|
|
|
|
int x86_pmu_handle_irq(struct pt_regs *regs);
|
|
|
|
|
|
|
|
extern struct event_constraint emptyconstraint;
|
|
|
|
|
|
|
|
extern struct event_constraint unconstrained;
|
|
|
|
|
2012-02-09 22:20:58 +00:00
|
|
|
static inline bool kernel_ip(unsigned long ip)
|
|
|
|
{
|
|
|
|
#ifdef CONFIG_X86_32
|
|
|
|
return ip > PAGE_OFFSET;
|
|
|
|
#else
|
|
|
|
return (long)ip < 0;
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
2012-07-10 07:42:15 +00:00
|
|
|
/*
|
|
|
|
* Not all PMUs provide the right context information to place the reported IP
|
|
|
|
* into full context. Specifically segment registers are typically not
|
|
|
|
* supplied.
|
|
|
|
*
|
|
|
|
* Assuming the address is a linear address (it is for IBS), we fake the CS and
|
|
|
|
* vm86 mode using the known zero-based code segment and 'fix up' the registers
|
|
|
|
* to reflect this.
|
|
|
|
*
|
|
|
|
* Intel PEBS/LBR appear to typically provide the effective address, nothing
|
|
|
|
* much we can do about that but pray and treat it like a linear address.
|
|
|
|
*/
|
|
|
|
static inline void set_linear_ip(struct pt_regs *regs, unsigned long ip)
|
|
|
|
{
|
|
|
|
regs->cs = kernel_ip(ip) ? __KERNEL_CS : __USER_CS;
|
|
|
|
if (regs->flags & X86_VM_MASK)
|
|
|
|
regs->flags ^= (PERF_EFLAGS_VM | X86_VM_MASK);
|
|
|
|
regs->ip = ip;
|
|
|
|
}
|
|
|
|
|
2012-10-10 12:53:14 +00:00
|
|
|
ssize_t x86_event_sysfs_show(char *page, u64 config, u64 event);
|
2012-10-10 12:53:15 +00:00
|
|
|
ssize_t intel_event_sysfs_show(char *page, u64 config);
|
2012-10-10 12:53:13 +00:00
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
#ifdef CONFIG_CPU_SUP_AMD
|
|
|
|
|
|
|
|
int amd_pmu_init(void);
|
|
|
|
|
|
|
|
#else /* CONFIG_CPU_SUP_AMD */
|
|
|
|
|
|
|
|
static inline int amd_pmu_init(void)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* CONFIG_CPU_SUP_AMD */
|
|
|
|
|
|
|
|
#ifdef CONFIG_CPU_SUP_INTEL
|
|
|
|
|
2015-01-14 12:18:20 +00:00
|
|
|
static inline bool intel_pmu_needs_lbr_smpl(struct perf_event *event)
|
|
|
|
{
|
|
|
|
/* user explicitly requested branch sampling */
|
|
|
|
if (has_branch_stack(event))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
/* implicit branch sampling to correct PEBS skid */
|
|
|
|
if (x86_pmu.intel_cap.pebs_trap && event->attr.precise_ip > 1 &&
|
|
|
|
x86_pmu.intel_cap.pebs_format < 2)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool intel_pmu_has_bts(struct perf_event *event)
|
|
|
|
{
|
|
|
|
if (event->attr.config == PERF_COUNT_HW_BRANCH_INSTRUCTIONS &&
|
|
|
|
!event->attr.freq && event->hw.sample_period == 1)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
int intel_pmu_save_and_restart(struct perf_event *event);
|
|
|
|
|
|
|
|
struct event_constraint *
|
2014-11-17 19:06:56 +00:00
|
|
|
x86_get_event_constraints(struct cpu_hw_events *cpuc, int idx,
|
|
|
|
struct perf_event *event);
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
struct intel_shared_regs *allocate_shared_regs(int cpu);
|
|
|
|
|
|
|
|
int intel_pmu_init(void);
|
|
|
|
|
|
|
|
void init_debug_store_on_cpu(int cpu);
|
|
|
|
|
|
|
|
void fini_debug_store_on_cpu(int cpu);
|
|
|
|
|
|
|
|
void release_ds_buffers(void);
|
|
|
|
|
|
|
|
void reserve_ds_buffers(void);
|
|
|
|
|
|
|
|
extern struct event_constraint bts_constraint;
|
|
|
|
|
|
|
|
void intel_pmu_enable_bts(u64 config);
|
|
|
|
|
|
|
|
void intel_pmu_disable_bts(void);
|
|
|
|
|
|
|
|
int intel_pmu_drain_bts_buffer(void);
|
|
|
|
|
|
|
|
extern struct event_constraint intel_core2_pebs_event_constraints[];
|
|
|
|
|
|
|
|
extern struct event_constraint intel_atom_pebs_event_constraints[];
|
|
|
|
|
2013-07-18 09:02:24 +00:00
|
|
|
extern struct event_constraint intel_slm_pebs_event_constraints[];
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
extern struct event_constraint intel_nehalem_pebs_event_constraints[];
|
|
|
|
|
|
|
|
extern struct event_constraint intel_westmere_pebs_event_constraints[];
|
|
|
|
|
|
|
|
extern struct event_constraint intel_snb_pebs_event_constraints[];
|
|
|
|
|
2012-09-10 23:07:01 +00:00
|
|
|
extern struct event_constraint intel_ivb_pebs_event_constraints[];
|
|
|
|
|
2013-06-18 00:36:49 +00:00
|
|
|
extern struct event_constraint intel_hsw_pebs_event_constraints[];
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
struct event_constraint *intel_pebs_constraints(struct perf_event *event);
|
|
|
|
|
|
|
|
void intel_pmu_pebs_enable(struct perf_event *event);
|
|
|
|
|
|
|
|
void intel_pmu_pebs_disable(struct perf_event *event);
|
|
|
|
|
|
|
|
void intel_pmu_pebs_enable_all(void);
|
|
|
|
|
|
|
|
void intel_pmu_pebs_disable_all(void);
|
|
|
|
|
|
|
|
void intel_ds_init(void);
|
|
|
|
|
2014-11-05 02:55:59 +00:00
|
|
|
void intel_pmu_lbr_sched_task(struct perf_event_context *ctx, bool sched_in);
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
void intel_pmu_lbr_reset(void);
|
|
|
|
|
|
|
|
void intel_pmu_lbr_enable(struct perf_event *event);
|
|
|
|
|
|
|
|
void intel_pmu_lbr_disable(struct perf_event *event);
|
|
|
|
|
perf/x86/intel: Streamline LBR MSR handling in PMI
The perf PMI currently does unnecessary MSR accesses when
LBRs are enabled. We use LBR freezing, or when in callstack
mode force the LBRs to only filter on ring 3.
So there is no need to disable the LBRs explicitely in the
PMI handler.
Also we always unnecessarily rewrite LBR_SELECT in the LBR
handler, even though it can never change.
5) | /* write_msr: MSR_LBR_SELECT(1c8), value 0 */
5) | /* read_msr: MSR_IA32_DEBUGCTLMSR(1d9), value 1801 */
5) | /* write_msr: MSR_IA32_DEBUGCTLMSR(1d9), value 1801 */
5) | /* write_msr: MSR_CORE_PERF_GLOBAL_CTRL(38f), value 70000000f */
5) | /* write_msr: MSR_CORE_PERF_GLOBAL_CTRL(38f), value 0 */
5) | /* write_msr: MSR_LBR_SELECT(1c8), value 0 */
5) | /* read_msr: MSR_IA32_DEBUGCTLMSR(1d9), value 1801 */
5) | /* write_msr: MSR_IA32_DEBUGCTLMSR(1d9), value 1801 */
This patch:
- Avoids disabling already frozen LBRs unnecessarily in the PMI
- Avoids changing LBR_SELECT in the PMI
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: eranian@google.com
Link: http://lkml.kernel.org/r/1426871484-21285-1-git-send-email-andi@firstfloor.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2015-03-20 17:11:23 +00:00
|
|
|
void intel_pmu_lbr_enable_all(bool pmi);
|
2011-08-30 23:41:05 +00:00
|
|
|
|
|
|
|
void intel_pmu_lbr_disable_all(void);
|
|
|
|
|
|
|
|
void intel_pmu_lbr_read(void);
|
|
|
|
|
|
|
|
void intel_pmu_lbr_init_core(void);
|
|
|
|
|
|
|
|
void intel_pmu_lbr_init_nhm(void);
|
|
|
|
|
|
|
|
void intel_pmu_lbr_init_atom(void);
|
|
|
|
|
2012-02-09 22:20:55 +00:00
|
|
|
void intel_pmu_lbr_init_snb(void);
|
|
|
|
|
perf/x86/intel: Add basic Haswell LBR call stack support
Haswell has a new feature that utilizes the existing LBR facility to
record call chains. To enable this feature, bits (JCC, NEAR_IND_JMP,
NEAR_REL_JMP, FAR_BRANCH, EN_CALLSTACK) in LBR_SELECT must be set to 1,
bits (NEAR_REL_CALL, NEAR-IND_CALL, NEAR_RET) must be cleared. Due to
a hardware bug of Haswell, this feature doesn't work well with
FREEZE_LBRS_ON_PMI.
When the call stack feature is enabled, the LBR stack will capture
unfiltered call data normally, but as return instructions are executed,
the last captured branch record is flushed from the on-chip registers
in a last-in first-out (LIFO) manner. Thus, branch information relative
to leaf functions will not be captured, while preserving the call stack
information of the main line execution path.
This patch defines a separate lbr_sel map for Haswell. The map contains
a new entry for the call stack feature.
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
Signed-off-by: Kan Liang <kan.liang@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: eranian@google.com
Cc: jolsa@redhat.com
Link: http://lkml.kernel.org/r/1415156173-10035-5-git-send-email-kan.liang@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
2014-11-05 02:56:00 +00:00
|
|
|
void intel_pmu_lbr_init_hsw(void);
|
|
|
|
|
2012-02-09 22:20:57 +00:00
|
|
|
int intel_pmu_setup_lbr_filter(struct perf_event *event);
|
|
|
|
|
2015-01-30 10:39:52 +00:00
|
|
|
void intel_pt_interrupt(void);
|
|
|
|
|
2015-01-30 10:40:35 +00:00
|
|
|
int intel_bts_interrupt(void);
|
|
|
|
|
|
|
|
void intel_bts_enable_local(void);
|
|
|
|
|
|
|
|
void intel_bts_disable_local(void);
|
|
|
|
|
2011-08-30 23:41:05 +00:00
|
|
|
int p4_pmu_init(void);
|
|
|
|
|
|
|
|
int p6_pmu_init(void);
|
|
|
|
|
2012-09-26 18:12:52 +00:00
|
|
|
int knc_pmu_init(void);
|
|
|
|
|
2013-01-24 15:10:32 +00:00
|
|
|
ssize_t events_sysfs_show(struct device *dev, struct device_attribute *attr,
|
|
|
|
char *page);
|
|
|
|
|
2014-11-17 19:07:04 +00:00
|
|
|
static inline int is_ht_workaround_enabled(void)
|
|
|
|
{
|
|
|
|
return !!(x86_pmu.flags & PMU_FL_EXCL_ENABLED);
|
|
|
|
}
|
2011-08-30 23:41:05 +00:00
|
|
|
#else /* CONFIG_CPU_SUP_INTEL */
|
|
|
|
|
|
|
|
static inline void reserve_ds_buffers(void)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void release_ds_buffers(void)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int intel_pmu_init(void)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline struct intel_shared_regs *allocate_shared_regs(int cpu)
|
|
|
|
{
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2015-05-21 08:57:17 +00:00
|
|
|
static inline int is_ht_workaround_enabled(void)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
2011-08-30 23:41:05 +00:00
|
|
|
#endif /* CONFIG_CPU_SUP_INTEL */
|