Commit Graph

5 Commits

Author SHA1 Message Date
Adam Williamson
5ce7252e20 CI: explain better what "git status failed!" means
`make sort` won't usually *fail*, even if it sorts stuff (it'll
only fail if it actually can't sort for some reason). So when
either the PR or the existing state of the repo isn't properly
sorted, what we get is the "git status failed!" case. I *think*
this is likely the only time we'll get that, I don't think
"make validate" would actually change files without failing. So
let's gloss that a git status failure probably means a sorting
issue.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-05-18 09:08:28 -07:00
Adam Williamson
40d2fd12bb validate-comps: don't set -x any more
This is only really useful for debugging the script itself, it's
not useful information for typical execution (especially now I
made it show which test(s) fail more clearly).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-04-24 11:07:30 -07:00
Adam Williamson
076138efdd Fix the validate-comps git status check
...this is how you do that.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-04-24 10:50:37 -07:00
Adam Williamson
03776c8c48 Improve validate-comps to give better info
This will tell us which checks failed, and how many. It also
suppresses some useless spammy output from `make sort` (we never
need to see any actual output, as it never tells us anything
useful; the useful info is what it changes).

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-04-24 10:49:28 -07:00
Adam Williamson
fcf37586a6 Rename all CI files to be (hopefully) unique
Per https://pagure.io/fedora-ci/general/issue/404 , as things are
right now, having CI files with the same names as those in other
repos can cause clashes. Let's rename all of ours to avoid this.
Also drop a path element in validate-comps.yaml that broke the
tests...

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2023-04-24 10:21:47 -07:00