davidlt/fedora-comps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CI: explain better what "git status failed!" means

Browse Source 
`make sort` won't usually *fail*, even if it sorts stuff (it'll
only fail if it actually can't sort for some reason). So when
either the PR or the existing state of the repo isn't properly
sorted, what we get is the "git status failed!" case. I *think*
this is likely the only time we'll get that, I don't think
"make validate" would actually change files without failing. So
let's gloss that a git status failure probably means a sorting
issue.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
This commit is contained in:
Adam Williamson 2023-05-18 09:08:28 -07:00
parent 1cede41744
commit 5ce7252e20
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ci/validate-comps
View File

@ -16,7 +16,7 @@ main() {
# Fail if any changes were made to the repo # Fail if any changes were made to the repo
if [[ -n $(git status --short) ]]; then if [[ -n $(git status --short) ]]; then
echo "git status failed!" echo "git status failed! This likely means the PR or the underlying repo is not sorted"
((failure+=1)) ((failure+=1))
fi fi
if [[ $failure -gt 0 ]]; then if [[ $failure -gt 0 ]]; then