From 5ce7252e20dcbc96ef413bde297ba9c7b9a882b2 Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Thu, 18 May 2023 09:08:28 -0700 Subject: [PATCH] CI: explain better what "git status failed!" means `make sort` won't usually *fail*, even if it sorts stuff (it'll only fail if it actually can't sort for some reason). So when either the PR or the existing state of the repo isn't properly sorted, what we get is the "git status failed!" case. I *think* this is likely the only time we'll get that, I don't think "make validate" would actually change files without failing. So let's gloss that a git status failure probably means a sorting issue. Signed-off-by: Adam Williamson --- ci/validate-comps | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/validate-comps b/ci/validate-comps index 4897eee8..d007893d 100755 --- a/ci/validate-comps +++ b/ci/validate-comps @@ -16,7 +16,7 @@ main() { # Fail if any changes were made to the repo if [[ -n $(git status --short) ]]; then - echo "git status failed!" + echo "git status failed! This likely means the PR or the underlying repo is not sorted" ((failure+=1)) fi if [[ $failure -gt 0 ]]; then