Mock Version: 1.4.21 Mock Version: 1.4.21 ENTER ['do_with_status'](['bash', '--login', '-c', '/usr/bin/rpmbuild -bs --target riscv64 --nodeps /builddir/build/SPECS/simh.spec'], chrootPath='/var/lib/mock/f33-build-147175-43080/root'env={'TERM': 'vt100', 'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf "\\033]0;\\007"', 'PS1': ' \\s-\\v\\$ ', 'LANG': 'en_US.UTF-8'}shell=Falselogger=timeout=432000uid=987gid=135user='mockbuild'nspawn_args=[]unshare_net=TrueprintOutput=False) Executing command: ['bash', '--login', '-c', '/usr/bin/rpmbuild -bs --target riscv64 --nodeps /builddir/build/SPECS/simh.spec'] with env {'TERM': 'vt100', 'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf "\\033]0;\\007"', 'PS1': ' \\s-\\v\\$ ', 'LANG': 'en_US.UTF-8'} and shell False Building target platforms: riscv64 Building for target riscv64 setting SOURCE_DATE_EPOCH=1564099200 Wrote: /builddir/build/SRPMS/simh-3.9.0-12.fc33.src.rpm Child return code was: 0 ENTER ['do_with_status'](['bash', '--login', '-c', '/usr/bin/rpmbuild -bb --target riscv64 --nodeps /builddir/build/SPECS/simh.spec'], chrootPath='/var/lib/mock/f33-build-147175-43080/root'env={'TERM': 'vt100', 'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf "\\033]0;\\007"', 'PS1': ' \\s-\\v\\$ ', 'LANG': 'en_US.UTF-8'}shell=Falselogger=timeout=432000uid=987gid=135user='mockbuild'nspawn_args=[]unshare_net=TrueprintOutput=False) Executing command: ['bash', '--login', '-c', '/usr/bin/rpmbuild -bb --target riscv64 --nodeps /builddir/build/SPECS/simh.spec'] with env {'TERM': 'vt100', 'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf "\\033]0;\\007"', 'PS1': ' \\s-\\v\\$ ', 'LANG': 'en_US.UTF-8'} and shell False Building target platforms: riscv64 Building for target riscv64 setting SOURCE_DATE_EPOCH=1564099200 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.6bEVQ4 + umask 022 + cd /builddir/build/BUILD + cd /builddir/build/BUILD + rm -rf simh-3.9.0 + /usr/bin/gzip -dc /builddir/build/SOURCES/simh-3.9.0-noroms.tar.gz + /usr/bin/tar -xof - + STATUS=0 + '[' 0 -ne 0 ']' + cd simh-3.9.0 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + RPM_EC=0 ++ jobs -p + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.OIUWW3 + umask 022 + cd /builddir/build/BUILD + cd simh-3.9.0 + mkdir -p BIN + make -j4 -e 'ROMS_OPT=-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection' USE_NETWORK=1 lib paths are: /lib/ /lib64/lp64d/ using libm: /lib64/lp64d//libm.so using librt: /lib64/lp64d//librt.so using libpthread: /lib64/lp64d//libpthread.so /usr/include/pthread.h using libdl: /lib64/lp64d//libdl.so /usr/include/dlfcn.h using libpcap: /lib64/lp64d//libpcap.so /usr/include/pcap.h *** *** all Simulators being built with: *** - compiler optimizations and no debugging support. GCC Version: 10.0.1. *** - static networking support using Linux provided libpcap components. *** gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection PDP1/pdp1_lp.c PDP1/pdp1_cpu.c PDP1/pdp1_stddev.c PDP1/pdp1_sys.c PDP1/pdp1_dt.c PDP1/pdp1_drm.c PDP1/pdp1_clk.c PDP1/pdp1_dcs.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I PDP1 -o BIN/pdp1 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP4 -I PDP18B -o BIN/pdp4 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP7 -I PDP18B -o BIN/pdp7 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection PDP8/pdp8_cpu.c PDP8/pdp8_clk.c PDP8/pdp8_df.c PDP8/pdp8_dt.c PDP8/pdp8_lp.c PDP8/pdp8_mt.c PDP8/pdp8_pt.c PDP8/pdp8_rf.c PDP8/pdp8_rk.c PDP8/pdp8_rx.c PDP8/pdp8_sys.c PDP8/pdp8_tt.c PDP8/pdp8_ttx.c PDP8/pdp8_rl.c PDP8/pdp8_tsc.c PDP8/pdp8_td.c PDP8/pdp8_ct.c PDP8/pdp8_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I PDP8 -o BIN/pdp8 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program PDP8/pdp8_cpu.c: In function 'sim_instr': PDP8/pdp8_cpu.c:347:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 347 | if (reason = sim_process_event ()) | ^~~~~~ PDP18B/pdp18b_dt.c: In function 'dt_svc': PDP18B/pdp18b_dt.c:1150:57: warning: "/*" within comment [-Wcomment] 1150 | /* /* ignore hdr */ | PDP18B/pdp18b_dt.c: In function 'dt_svc': PDP18B/pdp18b_dt.c:1150:57: warning: "/*" within comment [-Wcomment] 1150 | /* /* ignore hdr */ | PDP1/pdp1_cpu.c: In function 'sim_instr': PDP1/pdp1_cpu.c:549:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 549 | if (reason = sim_process_event ()) | ^~~~~~ PDP1/pdp1_cpu.c:613:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 613 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:615:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 615 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:621:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 621 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:623:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 623 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:629:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 629 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:631:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 631 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:641:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 641 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:643:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 643 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:651:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 651 | if (reason = Ea_ch (IR, &byno)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:653:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 653 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:662:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 662 | if (reason = Ea_ch (IR, &byno)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:664:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 664 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:686:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 686 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:688:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:694:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 694 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:696:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 696 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:702:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 702 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:709:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 709 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:711:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 711 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:718:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 718 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:720:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 720 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:727:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 727 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:734:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 734 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:758:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 758 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:760:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 760 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:772:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 772 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:774:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 774 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:787:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 787 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:789:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 789 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:801:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 801 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:803:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 803 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:813:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 813 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:815:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 815 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:827:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 827 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:829:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 829 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:836:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 836 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:838:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 838 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:866:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 866 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:874:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 874 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:892:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 892 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:894:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 894 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c:922:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 922 | if (reason = Ea (IR)) /* MA <- eff addr */ | ^~~~~~ PDP1/pdp1_cpu.c:924:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 924 | if (reason = Read ()) /* MB <- data */ | ^~~~~~ PDP1/pdp1_cpu.c: In function 'Ea': PDP1/pdp1_cpu.c:1365:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1365 | if (r = Read ()) /* read; err? */ | ^ PDP1/pdp1_cpu.c:1371:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1371 | if (r = Read ()) /* get ind word */ | ^ PDP1/pdp1_cpu.c: In function 'Ea_ch': PDP1/pdp1_cpu.c:1395:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1395 | if (r = Read ()) /* read; err? */ | ^ PDP1/pdp1_cpu.c:1400:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1400 | if (r = Read ()) /* get ind word */ | ^ PDP18B/pdp18b_cpu.c: In function 'sim_instr': PDP18B/pdp18b_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 607 | if (reason = sim_process_event ()) | ^~~~~~ PDP18B/pdp18b_cpu.c: In function 'sim_instr': PDP18B/pdp18b_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 607 | if (reason = sim_process_event ()) | ^~~~~~ PDP18B/pdp18b_cpu.c:582:7: warning: variable 'api_int' set but not used [-Wunused-but-set-variable] 582 | int32 api_int, api_usmd, skp; | ^~~~~~~ PDP18B/pdp18b_cpu.c:582:7: warning: variable 'api_int' set but not used [-Wunused-but-set-variable] 582 | int32 api_int, api_usmd, skp; | ^~~~~~~ At top level: PDP18B/pdp18b_cpu.c:443:20: warning: 'api_vec' defined but not used [-Wunused-const-variable=] 443 | static const int32 api_vec[API_HLVL][32] = { | ^~~~~~~ At top level: PDP18B/pdp18b_cpu.c:443:20: warning: 'api_vec' defined but not used [-Wunused-const-variable=] 443 | static const int32 api_vec[API_HLVL][32] = { | ^~~~~~~ PDP1/pdp1_sys.c: In function 'parse_sym': PDP1/pdp1_sys.c:598:30: warning: array subscript has type 'char' [-Wchar-subscripts] 598 | val[0] = ((ASCTOSIX (cptr[0]) & 077) << 12) | | ~~~~^~~ PDP1/pdp1_sys.c:443:38: note: in definition of macro 'ASCTOSIX' 443 | #define ASCTOSIX(x) (ascii_to_fiodec[x] & 077) | ^ PDP1/pdp1_sys.c:599:30: warning: array subscript has type 'char' [-Wchar-subscripts] 599 | ((ASCTOSIX (cptr[1]) & 077) << 6) | | ~~~~^~~ PDP1/pdp1_sys.c:443:38: note: in definition of macro 'ASCTOSIX' 443 | #define ASCTOSIX(x) (ascii_to_fiodec[x] & 077) | ^ PDP1/pdp1_sys.c:600:30: warning: array subscript has type 'char' [-Wchar-subscripts] 600 | (ASCTOSIX (cptr[2]) & 077); | ~~~~^~~ PDP1/pdp1_sys.c:443:38: note: in definition of macro 'ASCTOSIX' 443 | #define ASCTOSIX(x) (ascii_to_fiodec[x] & 077) | ^ PDP8/pdp8_dt.c: In function 'dt_svc': PDP8/pdp8_dt.c:967:57: warning: "/*" within comment [-Wcomment] 967 | /* /* ignore hdr */ | PDP8/pdp8_dt.c:971:13: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 971 | if (((dtsa & DTA_MODE) == 0) || (M[DT_WC] == 0)) | ^~ PDP8/pdp8_dt.c:973:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 973 | break; | ^~~~~ PDP18B/pdp18b_mt.c: In function 'mt_svc': PDP18B/pdp18b_mt.c:356:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^~ PDP18B/pdp18b_mt.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP18B/pdp18b_mt.c:375:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^~ PDP18B/pdp18b_mt.c:385:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^~ PDP18B/pdp18b_mt.c: In function 'mt_svc': PDP18B/pdp18b_mt.c:356:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^~ PDP18B/pdp18b_mt.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP18B/pdp18b_mt.c:375:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^~ PDP18B/pdp18b_mt.c:385:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^~ PDP8/pdp8_mt.c:123:57: warning: "/*" within comment [-Wcomment] 123 | /* #define STA_BAD 00020 /* bad tape?? */ | PDP8/pdp8_mt.c: In function 'mt_svc': PDP8/pdp8_mt.c:456:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ^~ PDP8/pdp8_mt.c:464:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 464 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP8/pdp8_mt.c:471:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 471 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^~ PDP8/pdp8_mt.c:481:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 481 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^~ PDP18B/pdp18b_stddev.c: In function 'ptr_svc': PDP18B/pdp18b_stddev.c:597:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 597 | while (temp = temp & (temp - 1)) | ^~~~ PDP18B/pdp18b_stddev.c: In function 'tti': PDP18B/pdp18b_stddev.c:997:30: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 997 | dat = dat | tti_unit.buf & TTI_MASK; /* return buffer */ | ^ PDP18B/pdp18b_stddev.c: In function 'ptr_svc': PDP18B/pdp18b_stddev.c:597:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 597 | while (temp = temp & (temp - 1)) | ^~~~ PDP18B/pdp18b_stddev.c: In function 'tti': PDP18B/pdp18b_stddev.c:997:30: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 997 | dat = dat | tti_unit.buf & TTI_MASK; /* return buffer */ | ^ PDP1/pdp1_dcs.c: In function 'dcsi_svc': PDP1/pdp1_dcs.c:254:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 254 | if (c = tmxr_getc_ln (&dcs_ldsc[ln])) { /* get char */ | ^ PDP18B/pdp18b_sys.c: In function 'fprint_sym': PDP18B/pdp18b_sys.c:1012:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1012 | if (sp = (inst & 03730)) | ^~ PDP18B/pdp18b_sys.c: In function 'fprint_sym': PDP18B/pdp18b_sys.c:1012:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1012 | if (sp = (inst & 03730)) | ^~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ PDP18B/pdp18b_tt1.c: In function 'ttix_svc': PDP18B/pdp18b_tt1.c:225:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^~~~ PDP18B/pdp18b_tt1.c: In function 'ttix_svc': PDP18B/pdp18b_tt1.c:225:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^~~~ PDP18B/pdp18b_fpp.c: In function 'fp15': PDP18B/pdp18b_fpp.c:256:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:265:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:273:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:281:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:283:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:299:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:312:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:320:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:326:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:340:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 340 | if (sta = Read (ar, &dat, RD)) | ^~~ PDP18B/pdp18b_fpp.c:348:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c: In function 'fp15_store': PDP18B/pdp18b_fpp.c:432:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^~~ PDP18B/pdp18b_fpp.c: In function 'fp15': PDP18B/pdp18b_fpp.c:256:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:265:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:273:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:281:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:283:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:299:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:312:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:320:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:326:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:340:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 340 | if (sta = Read (ar, &dat, RD)) | ^~~ PDP18B/pdp18b_fpp.c:348:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c: In function 'fp15_store': PDP18B/pdp18b_fpp.c:432:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^~~ PDP8/pdp8_ttx.c: In function 'ttix_svc': PDP8/pdp8_ttx.c:236:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 236 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^~~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ PDP8/pdp8_ct.c: In function 'ct70': PDP8/pdp8_ct.c:273:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 273 | if (uptr = ct_busy ()) /* op in progress? */ | ^~~~ PDP8/pdp8_ct.c: In function 'ct_svc': PDP8/pdp8_ct.c:436:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 436 | if (st = sim_tape_wrrecf (uptr, ct_xb, ct_bptr)) /* write, err? */ | ^~ PDP8/pdp8_ct.c:455:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 455 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP8/pdp8_ct.c:465:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 465 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP9 -I PDP18B -o BIN/pdp9 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection PDP18B/pdp18b_dt.c PDP18B/pdp18b_drm.c PDP18B/pdp18b_cpu.c PDP18B/pdp18b_lp.c PDP18B/pdp18b_mt.c PDP18B/pdp18b_rf.c PDP18B/pdp18b_rp.c PDP18B/pdp18b_stddev.c PDP18B/pdp18b_sys.c PDP18B/pdp18b_rb.c PDP18B/pdp18b_tt1.c PDP18B/pdp18b_fpp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DPDP15 -I PDP18B -o BIN/pdp15 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection PDP11/pdp11_fp.c PDP11/pdp11_cpu.c PDP11/pdp11_dz.c PDP11/pdp11_cis.c PDP11/pdp11_lp.c PDP11/pdp11_rk.c PDP11/pdp11_rl.c PDP11/pdp11_rp.c PDP11/pdp11_rx.c PDP11/pdp11_stddev.c PDP11/pdp11_sys.c PDP11/pdp11_tc.c PDP11/pdp11_tm.c PDP11/pdp11_ts.c PDP11/pdp11_io.c PDP11/pdp11_rq.c PDP11/pdp11_tq.c PDP11/pdp11_pclk.c PDP11/pdp11_ry.c PDP11/pdp11_pt.c PDP11/pdp11_hk.c PDP11/pdp11_xq.c PDP11/pdp11_xu.c PDP11/pdp11_vh.c PDP11/pdp11_rh.c PDP11/pdp11_tu.c PDP11/pdp11_cpumod.c PDP11/pdp11_cr.c PDP11/pdp11_rf.c PDP11/pdp11_dl.c PDP11/pdp11_ta.c PDP11/pdp11_rc.c PDP11/pdp11_kg.c PDP11/pdp11_ke.c PDP11/pdp11_dc.c PDP11/pdp11_io_lib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_PDP11 -I PDP11 -DUSE_NETWORK -I/usr/include/ -DUSE_TAP_NETWORK -o BIN/pdp11 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program PDP18B/pdp18b_dt.c: In function 'dt_svc': PDP18B/pdp18b_dt.c:1150:57: warning: "/*" within comment [-Wcomment] 1150 | /* /* ignore hdr */ | At top level: PDP18B/pdp18b_dt.c:342:20: warning: 'map_unit' defined but not used [-Wunused-const-variable=] 342 | static const int32 map_unit[16] = { /* Type 550 unit map */ | ^~~~~~~~ PDP11/pdp11_fp.c: In function 'fp11': PDP11/pdp11_fp.c:441:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 441 | if (sign = GET_SIGN_L (fac.l)) | ^~~~ PDP18B/pdp18b_dt.c: In function 'dt_svc': PDP18B/pdp18b_dt.c:1150:57: warning: "/*" within comment [-Wcomment] 1150 | /* /* ignore hdr */ | At top level: PDP18B/pdp18b_dt.c:342:20: warning: 'map_unit' defined but not used [-Wunused-const-variable=] 342 | static const int32 map_unit[16] = { /* Type 550 unit map */ | ^~~~~~~~ PDP11/pdp11_cpu.c: In function 'sim_instr': PDP11/pdp11_cpu.c:735:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 735 | if (t = trap_req & TRAP_ALL) { /* if a trap */ | ^ PDP18B/pdp18b_cpu.c: In function 'sim_instr': PDP18B/pdp18b_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 607 | if (reason = sim_process_event ()) | ^~~~~~ PDP18B/pdp18b_cpu.c: In function 'sim_instr': PDP18B/pdp18b_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 607 | if (reason = sim_process_event ()) | ^~~~~~ PDP18B/pdp18b_cpu.c:933:11: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 933 | if ((api_act & (API_ML0|API_ML1|API_ML2|API_ML3)) == 0) | ^~ PDP18B/pdp18b_cpu.c:936:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 936 | api_int = api_eval (&int_pend); | ^~~~~~~ PDP18B/pdp18b_mt.c: In function 'mt_svc': PDP18B/pdp18b_mt.c:356:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^~ PDP18B/pdp18b_mt.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP18B/pdp18b_mt.c:375:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^~ PDP18B/pdp18b_mt.c:385:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^~ PDP18B/pdp18b_lp.c: In function 'lp15_svc': PDP18B/pdp18b_lp.c:821:36: warning: array subscript has type 'char' [-Wchar-subscripts] 821 | if ((c[i] <= 037) && ctrl[c[i]]) { /* control char? */ | ~^~~ PDP18B/pdp18b_lp.c:824:26: warning: array subscript has type 'char' [-Wchar-subscripts] 824 | fputs (ctrl[c[i]], uptr->fileref); /* space */ | ~^~~ PDP11/pdp11_cis.c:173:21: warning: missing braces around initializer [-Wmissing-braces] 173 | static DSTR Dstr0 = { 0, 0, 0, 0, 0 }; | ^ | { } PDP11/pdp11_cis.c:207:36: warning: missing braces around initializer [-Wmissing-braces] 207 | static int32 opntab[128][MAXOPN] = { | ^ PDP11/pdp11_cis.c:323:31: warning: missing braces around initializer [-Wmissing-braces] 323 | static int32 binover[2][16] = { | ^ 324 | '{', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', | { 325 | '0', '0', '0', '0', '0', '0', | } 326 | '}', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', | { 327 | '0', '0', '0', '0', '0', '0' 328 | }; | } PDP11/pdp11_cis.c: In function 'cis11': PDP11/pdp11_cis.c:345:21: warning: missing braces around initializer [-Wmissing-braces] 345 | static DSTR Dstr1 = { 0, 0x10, 0, 0, 0 }; | ^ | { } PDP11/pdp11_cis.c:1137:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1137 | if (dst.sign = GET_SIGN_L (result)) | ^~~ PDP11/pdp11_cis.c: In function 'WriteDstr': PDP11/pdp11_cis.c:1270:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1270 | if (dst->val[i] = dst->val[i] & ~mask) /* test nz */ | ^~~ PDP11/pdp11_cis.c: In function 'NibbleRshift': PDP11/pdp11_cis.c:1526:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1526 | if (s = sc * 4) { | ^ PDP11/pdp11_cis.c: In function 'NibbleLshift': PDP11/pdp11_cis.c:1551:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1551 | if (s = sc * 4) { | ^ PDP18B/pdp18b_mt.c: In function 'mt_svc': PDP18B/pdp18b_mt.c:356:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 356 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) /* write rec, err? */ | ^~ PDP18B/pdp18b_mt.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 366 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP18B/pdp18b_mt.c:375:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 375 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^~ PDP18B/pdp18b_mt.c:385:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 385 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^~ At top level: PDP11/pdp11_cis.c:330:22: warning: 'movbuf' defined but not used [-Wunused-variable] 330 | static unsigned char movbuf[65536]; | ^~~~~~ PDP11/pdp11_rk.c: In function 'rk_svc': PDP11/pdp11_rk.c:548:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 548 | if (t = Map_WriteW (ma, 2, &rkxb[wc - 1])) { /* store last */ | ^ PDP11/pdp11_rk.c:554:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 554 | if (t = Map_WriteW (ma, wc << 1, rkxb)) { /* store buf */ | ^ PDP11/pdp11_rk.c:563:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 563 | if (t = Map_ReadW (ma, 2, &comp)) { /* get 1st word */ | ^ PDP11/pdp11_rk.c:571:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 571 | if (t = Map_ReadW (ma, wc << 1, rkxb)) { /* get buf */ | ^ PDP11/pdp11_rk.c:587:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 587 | if (err = ferror (uptr->fileref)) { /* read error? */ | ^~~ PDP18B/pdp18b_stddev.c: In function 'ptr_svc': PDP18B/pdp18b_stddev.c:597:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 597 | while (temp = temp & (temp - 1)) | ^~~~ PDP18B/pdp18b_stddev.c: In function 'tti': PDP18B/pdp18b_stddev.c:997:30: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 997 | dat = dat | tti_unit.buf & TTI_MASK; /* return buffer */ | ^ PDP11/pdp11_rl.c: In function 'rl_svc': PDP11/pdp11_rl.c:859:1: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 859 | if (DEBUG_PRS (rl_dev)) | ^~ PDP11/pdp11_rl.c:863:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 863 | if ((uptr->FNC >= RLCS_READ) && (err == 0)) { /* read (no hdr)? */ | ^~ PDP18B/pdp18b_stddev.c: In function 'clk_task_upd': PDP18B/pdp18b_stddev.c:456:8: warning: unused variable 'old' [-Wunused-variable] 456 | uint32 old = clk_task_timer; | ^~~ PDP18B/pdp18b_stddev.c: In function 'ptr_svc': PDP18B/pdp18b_stddev.c:597:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 597 | while (temp = temp & (temp - 1)) | ^~~~ PDP18B/pdp18b_stddev.c: In function 'tti': PDP18B/pdp18b_stddev.c:997:30: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 997 | dat = dat | tti_unit.buf & TTI_MASK; /* return buffer */ | ^ PDP18B/pdp18b_sys.c: In function 'fprint_sym': PDP18B/pdp18b_sys.c:1012:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1012 | if (sp = (inst & 03730)) | ^~ At top level: PDP18B/pdp18b_sys.c:900:14: warning: 'rar' defined but not used [-Wunused-function] 900 | static int32 rar (int32 c) | ^~~ PDP18B/pdp18b_sys.c: In function 'fprint_sym': PDP18B/pdp18b_sys.c:1012:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1012 | if (sp = (inst & 03730)) | ^~ At top level: PDP18B/pdp18b_sys.c:900:14: warning: 'rar' defined but not used [-Wunused-function] 900 | static int32 rar (int32 c) | ^~~ PDP18B/pdp18b_tt1.c: In function 'ttix_svc': PDP18B/pdp18b_tt1.c:225:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^~~~ PDP18B/pdp18b_tt1.c: In function 'ttix_svc': PDP18B/pdp18b_tt1.c:225:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 225 | if (temp = tmxr_getc_ln (&ttx_ldsc[ln])) { /* get char */ | ^~~~ PDP18B/pdp18b_fpp.c: In function 'fp15': PDP18B/pdp18b_fpp.c:256:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:265:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:273:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:281:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:283:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:299:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:312:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:320:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:326:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:340:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 340 | if (sta = Read (ar, &dat, RD)) | ^~~ PDP18B/pdp18b_fpp.c:348:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c: In function 'fp15_store': PDP18B/pdp18b_fpp.c:432:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^~~ PDP11/pdp11_sys.c: In function 'parse_sym': PDP11/pdp11_sys.c:1073:13: warning: this 'for' clause does not guard... [-Wmisleading-indentation] 1073 | for (i = 0; (opcode[i] != NULL) && | ^~~ PDP11/pdp11_sys.c:1075:14: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for' 1075 | if ((((opc_val[i] >> I_V_CL) & I_M_CL) != j) || | ^~ PDP18B/pdp18b_fpp.c: In function 'fp15': PDP18B/pdp18b_fpp.c:256:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 256 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:265:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 265 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:273:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 273 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:281:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 281 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:283:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 283 | if (sta = fp15_opnd (fir, ar, &fmb)) break; /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c:291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 291 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:299:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 299 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:312:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 312 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:320:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 320 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:326:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 326 | if (sta = fp15_opnd (fir, ar, &fma)) /* fetch op to FMA */ | ^~~ PDP18B/pdp18b_fpp.c:340:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 340 | if (sta = Read (ar, &dat, RD)) | ^~~ PDP18B/pdp18b_fpp.c:348:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 348 | if (sta = fp15_opnd (fir, ar, &fmb)) /* fetch op to FMB */ | ^~~ PDP18B/pdp18b_fpp.c: In function 'fp15_store': PDP18B/pdp18b_fpp.c:432:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 432 | if (sta = fp15_norm (ir, a, NULL, 0)) /* normalize */ | ^~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | PDP11/pdp11_tc.c: In function 'dt_svc': PDP11/pdp11_tc.c:995:57: warning: "/*" within comment [-Wcomment] 995 | /* else /* ignore hdr */ | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ PDP11/pdp11_tm.c: In function 'tm_go': PDP11/pdp11_tm.c:380:9: warning: "/*" within comment [-Wcomment] 380 | /* else /* uncomment this else if rewind/unload don't set done */ | PDP11/pdp11_tm.c: In function 'tm_svc': PDP11/pdp11_tm.c:442:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 442 | if (t = Map_WriteB (xma, cbc, tmxb)) { /* copy buf to mem */ | ^ PDP11/pdp11_tm.c:452:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 452 | if (t = Map_ReadB (xma, cbc, tmxb)) { /* copy mem to buf */ | ^ PDP11/pdp11_tm.c:458:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 458 | if (st = sim_tape_wrrecf (uptr, tmxb, cbc)) /* write rec, err? */ | ^~ PDP11/pdp11_tm.c:467:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 467 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP11/pdp11_tm.c:474:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 474 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* spc rec fwd, err? */ | ^~ PDP11/pdp11_tm.c:484:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 484 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* spc rec rev, err? */ | ^~ PDP11/pdp11_ts.c: In function 'ts_spacef': PDP11/pdp11_ts.c:493:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^~ PDP11/pdp11_ts.c: In function 'ts_spacer': PDP11/pdp11_ts.c:536:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^~ PDP11/pdp11_ts.c: In function 'ts_readf': PDP11/pdp11_ts.c:572:7: warning: variable 'wa' set but not used [-Wunused-but-set-variable] 572 | int32 wa; | ^~ PDP11/pdp11_ts.c: In function 'ts_readr': PDP11/pdp11_ts.c:622:32: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 622 | tsba = (cmdadh << 16) | cmdadl + fc; /* buf addr */ | ^ PDP11/pdp11_ts.c: In function 'ts_write': PDP11/pdp11_ts.c:669:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ^~ PDP11/pdp11_ts.c: In function 'ts_wtmk': PDP11/pdp11_ts.c:682:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP11/pdp11_io.c: In function 'build_dib_tab': PDP11/pdp11_io.c:376:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 376 | if (r = cpu_build_dib ()) /* build CPU entries */ | ^ PDP11/pdp11_io.c:382:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 382 | if (r = build_mbus_tab (dptr, dibp)) /* add to Mbus tab */ | ^ PDP11/pdp11_io.c:386:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 386 | if (r = build_ubus_tab (dptr, dibp)) /* add to Unibus tab */ | ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ In file included from PDP11/pdp11_rq.c:99: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] 213 | /* 5 /* reserved */ | PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] 401 | /* 14 /* reserved */ | PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] 402 | /* 15 /* reserved */ | PDP11/pdp11_rq.c: In function 'rq_abo': PDP11/pdp11_rq.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ^~~~ PDP11/pdp11_rq.c:1368:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^~~ PDP11/pdp11_rq.c:1369:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_avl': PDP11/pdp11_rq.c:1396:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_gus': PDP11/pdp11_rq.c:1450:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_onl': PDP11/pdp11_rq.c:1485:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_scc': PDP11/pdp11_rq.c:1523:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ^~ PDP11/pdp11_rq.c: In function 'rq_suc': PDP11/pdp11_rq.c:1550:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_fmt': PDP11/pdp11_rq.c:1579:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw': PDP11/pdp11_rq.c:1613:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw_valid': PDP11/pdp11_rq.c:1657:57: warning: "/*" within comment [-Wcomment] 1657 | /* if (lbn & 0xF0000000) return (ST_CMD | I_LBN); /* 'reasonable' lbn? */ | PDP11/pdp11_rq.c: In function 'rq_svc': PDP11/pdp11_rq.c:1728:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1728 | if (abc = tbc - t) { /* any xfer? */ | ^~~ PDP11/pdp11_rq.c:1755:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ^ PDP11/pdp11_rq.c: In function 'rq_show_unitq': PDP11/pdp11_rq.c:2589:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2589 | if (pkt = uptr->pktq) { | ^~~ PDP11/pdp11_rq.c:2593:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2593 | } while (pkt = cp->pak[pkt].link); | ^~~ PDP11/pdp11_rq.c: In function 'rq_show_ctrl': PDP11/pdp11_rq.c:2620:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2620 | if (pkt = cp->freq) { | ^~~ PDP11/pdp11_rq.c:2633:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2633 | if (pkt = cp->rspq) { | ^~~ PDP11/pdp11_rq.c:2637:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2637 | } while (pkt = cp->pak[pkt].link); | ^~~ In file included from PDP11/pdp11_tq.c:85: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] 213 | /* 5 /* reserved */ | PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] 401 | /* 14 /* reserved */ | PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] 402 | /* 15 /* reserved */ | PDP11/pdp11_tq.c: In function 'tq_mscp': PDP11/pdp11_tq.c:783:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ^~~~ PDP11/pdp11_tq.c:789:57: warning: "/*" within comment [-Wcomment] 789 | /* if (tq_cmf[cmd] & MD_CDL) /* clr cch lost? */ | PDP11/pdp11_tq.c: In function 'tq_abo': PDP11/pdp11_tq.c:861:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ^~~~ PDP11/pdp11_tq.c:874:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^~~ PDP11/pdp11_tq.c:875:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_avl': PDP11/pdp11_tq.c:903:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_gus': PDP11/pdp11_tq.c:958:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_onl': PDP11/pdp11_tq.c:983:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_scc': PDP11/pdp11_tq.c:1012:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ^~~~~~~ PDP11/pdp11_tq.c: In function 'tq_suc': PDP11/pdp11_tq.c:1036:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_flu': PDP11/pdp11_tq.c:1058:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_erase': PDP11/pdp11_tq.c:1074:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_wtm': PDP11/pdp11_tq.c:1095:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_pos': PDP11/pdp11_tq.c:1118:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_rw': PDP11/pdp11_tq.c:1150:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_svc': PDP11/pdp11_tq.c:1254:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ^ PDP11/pdp11_tq.c:1291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ^ PDP11/pdp11_tq.c: In function 'tq_show_unitq': PDP11/pdp11_tq.c:2236:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2236 | if (pkt = uptr->pktq) { | ^~~ PDP11/pdp11_tq.c:2240:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2240 | } while (pkt = tq_pkt[pkt].link); | ^~~ PDP11/pdp11_tq.c: In function 'tq_show_ctrl': PDP11/pdp11_tq.c:2265:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2265 | if (pkt = tq_freq) { | ^~~ PDP11/pdp11_tq.c:2278:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2278 | if (pkt = tq_rspq) { | ^~~ PDP11/pdp11_tq.c:2282:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2282 | } while (pkt = tq_pkt[pkt].link); | ^~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ PDP11/pdp11_hk.c: In function 'hk_svc': PDP11/pdp11_hk.c:890:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 890 | if (t = Map_ReadW (ba, 2, &comp)) { /* get 1st wd */ | ^ PDP11/pdp11_hk.c:898:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 898 | if (t = Map_ReadW (ba, wc << 1, hkxb)) { /* get buf */ | ^ PDP11/pdp11_hk.c:918:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 918 | if (t = Map_WriteW (ba, 2, &hkxb[wc - 1])) { | ^ PDP11/pdp11_hk.c:924:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 924 | if (t = Map_WriteW (ba, wc << 1, hkxb)) { /* put buf */ | ^ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ PDP11/pdp11_xq.c: In function 'xq_process_mop': PDP11/pdp11_xq.c:1086:28: warning: '<<' in boolean context, did you mean '<'? [-Wint-in-bool-context] 1086 | address = (meb->add_hi << 16) || (meb->add_mi << 8) || meb->add_lo; | ~~~~~~~~~~~~~^~~~~~ PDP11/pdp11_xq.c:1086:51: warning: '<<' in boolean context, did you mean '<'? [-Wint-in-bool-context] 1086 | address = (meb->add_hi << 16) || (meb->add_mi << 8) || meb->add_lo; | ~~~~~~~~~~~~~^~~~~ PDP11/pdp11_xq.c:1087:28: warning: '<<' in boolean context, did you mean '<'? [-Wint-in-bool-context] 1087 | size = (meb->siz_hi << 8) || meb->siz_lo; | ~~~~~~~~~~~~~^~~~~ PDP11/pdp11_xq.c:1075:10: warning: variable 'size' set but not used [-Wunused-but-set-variable] 1075 | uint16 size; | ^~~~ PDP11/pdp11_xq.c: In function 'xq_process_setup': PDP11/pdp11_xq.c:1190:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1190 | if (led = (len & XQ_SETUP_LD) >> 2) { | ^~~ PDP11/pdp11_xq.c: In function 'xq_process_bootrom': PDP11/pdp11_xq.c:2046:3: warning: enumeration value 'XQ_T_DELQA' not handled in switch [-Wswitch] 2046 | switch (xq->var->type) { | ^~~~~~ PDP11/pdp11_xq.c:2046:3: warning: enumeration value 'XQ_T_DELQA_PLUS' not handled in switch [-Wswitch] PDP11/pdp11_xq.c: In function 'xq_tmrsvc': PDP11/pdp11_xq.c:2534:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 2534 | if (--xq->var->sanity.timer <= 0) | ^ PDP11/pdp11_xu.c: In function 'xu_process_receive': PDP11/pdp11_xu.c:1044:24: warning: "/*" within comment [-Wcomment] 1044 | /* xu_dump_rxring(xu); /* debug receive ring */ | PDP11/pdp11_xu.c: In function 'xu_process_transmit': PDP11/pdp11_xu.c:1216:24: warning: "/*" within comment [-Wcomment] 1216 | /* xu_dump_txring(xu); /* debug receive ring */ | PDP11/pdp11_xu.c: In function 'xu_dump_rxring': PDP11/pdp11_xu.c:1683:12: warning: unused variable 'rstatus' [-Wunused-variable] 1683 | t_stat rstatus = Map_ReadW (ba, 8, rxhdr); /* get rxring entry[i] */ | ^~~~~~~ PDP11/pdp11_xu.c: In function 'xu_dump_txring': PDP11/pdp11_xu.c:1699:12: warning: unused variable 'tstatus' [-Wunused-variable] 1699 | t_stat tstatus = Map_ReadW (ba, 8, txhdr); /* get rxring entry[i] */ | ^~~~~~~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection PDP10/pdp10_fe.c PDP11/pdp11_dz.c PDP10/pdp10_cpu.c PDP10/pdp10_ksio.c PDP10/pdp10_lp20.c PDP10/pdp10_mdfp.c PDP10/pdp10_pag.c PDP10/pdp10_rp.c PDP10/pdp10_sys.c PDP10/pdp10_tim.c PDP10/pdp10_tu.c PDP10/pdp10_xtnd.c PDP11/pdp11_pt.c PDP11/pdp11_ry.c PDP11/pdp11_cr.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_PDP10 -DUSE_INT64 -I PDP10 -I PDP11 -o BIN/pdp10 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program In file included from PDP10/pdp10_fe.c:41: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | PDP11/pdp11_vh.c:296:60: warning: "/*" within comment [-Wcomment] 296 | /* #define DBG_XMT TMXR_DBG_XMT /* display Transmitted Data */ | PDP11/pdp11_vh.c:297:60: warning: "/*" within comment [-Wcomment] 297 | /* #define DBG_RCV TMXR_DBG_RCV /* display Received Data */ | In file included from PDP11/pdp11_dz.c:62: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | In file included from PDP10/pdp10_cpu.c:136: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | PDP10/pdp10_cpu.c: In function 'sim_instr': PDP10/pdp10_cpu.c:708:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 708 | if (i = sim_process_event ()) /* error? stop sim */ | ^ PDP10/pdp10_cpu.c:722:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 722 | if (vec = pi_ub_vec (qintr, &uba)) { /* Unibus interrupt? */ | ^~~ PDP10/pdp10_cpu.c:868:57: warning: "/*" within comment [-Wcomment] 868 | /* case 0100: MUUO /* UJEN */ | PDP10/pdp10_cpu.c:869:57: warning: "/*" within comment [-Wcomment] 869 | /* case 0101: MUUO /* unassigned */ | PDP10/pdp10_cpu.c:882:57: warning: "/*" within comment [-Wcomment] 882 | /* case 0104: MUUO /* JSYS (T20) */ | PDP10/pdp10_cpu.c:884:57: warning: "/*" within comment [-Wcomment] 884 | /* case 0106: MUUO /* GFMP (KL)*/ | PDP10/pdp10_cpu.c:885:57: warning: "/*" within comment [-Wcomment] 885 | /* case 0107: MUUO /* GFDV (KL) */ | PDP10/pdp10_cpu.c:912:57: warning: "/*" within comment [-Wcomment] 912 | /* case 0130: MUUO /* UFA */ | PDP10/pdp10_cpu.c:913:57: warning: "/*" within comment [-Wcomment] 913 | /* case 0131: MUUO /* DFN */ | PDP10/pdp10_cpu.c:917:13: warning: this 'else' clause does not guard... [-Wmisleading-indentation] 917 | else adjbp (ac, ea, pflgs); break; | ^~~~ PDP10/pdp10_cpu.c:917:41: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else' 917 | else adjbp (ac, ea, pflgs); break; | ^~~~~ PDP10/pdp10_cpu.c:923:57: warning: "/*" within comment [-Wcomment] 923 | /* case 0141: MUUO /* FADL */ | PDP10/pdp10_cpu.c:931:57: warning: "/*" within comment [-Wcomment] 931 | /* case 0151: MUUO /* FSBL */ | PDP10/pdp10_cpu.c:939:57: warning: "/*" within comment [-Wcomment] 939 | /* case 0161: MUUO /* FMPL */ | PDP10/pdp10_cpu.c:947:57: warning: "/*" within comment [-Wcomment] 947 | /* case 0171: MUUO /* FDVL */ | PDP10/pdp10_cpu.c:1011:17: warning: "/*" within comment [-Wcomment] 1011 | /* case 0254: /* shown later /* JRST */ | PDP10/pdp10_cpu.c:1011:57: warning: "/*" within comment [-Wcomment] PDP11/pdp11_tu.c: In function 'tu_svc': PDP11/pdp11_tu.c:650:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 650 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^~ PDP11/pdp11_tu.c:663:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 663 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^~ PDP11/pdp11_tu.c:674:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 674 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP11/pdp11_tu.c:690:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 690 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ^~ PDP11/pdp11_tu.c:742:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 742 | if (st = sim_tape_wrrecf (uptr, xbuf, tbc)) /* write rec, err? */ | ^~ PDP11/pdp11_tu.c:754:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 754 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ^~ PDP11/pdp11_tu.c:621:12: warning: variable 'r' set but not used [-Wunused-but-set-variable] 621 | t_stat st, r = SCPE_OK; | ^ PDP10/pdp10_cpu.c: In function 'test_int': PDP10/pdp10_cpu.c:2022:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2022 | if (t = sim_process_event ()) /* IO event? */ | ^ PDP11/pdp11_cpumod.c: In function 'cpu_build_dib': PDP11/pdp11_cpumod.c:1078:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1078 | if (r = build_ubus_tab (&cpu_dev, cnf_tab[i].dib)) /* add to dispatch tab */ | ^ In file included from PDP10/pdp10_ksio.c:72: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | PDP10/pdp10_ksio.c: In function 'ReadIO': PDP10/pdp10_ksio.c:404:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 404 | for (i = 0; dibp = dib_tab[i]; i++ ) { | ^~~~ PDP10/pdp10_ksio.c: In function 'WriteIO': PDP10/pdp10_ksio.c:421:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 421 | for (i = 0; dibp = dib_tab[i]; i++ ) { | ^~~~ PDP11/pdp11_rf.c:145:14: warning: missing braces around initializer [-Wmissing-braces] 145 | DIB rf_dib = { | ^ In file included from PDP10/pdp10_lp20.c:42: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | PDP10/pdp10_lp20.c:61:57: warning: "/*" within comment [-Wcomment] 61 | /* define TX_INTR 04000 /* interrupt */ | PDP10/pdp10_lp20.c:63:57: warning: "/*" within comment [-Wcomment] 63 | /* define TX_XLAT 01000 /* translate */ | PDP10/pdp10_lp20.c:64:57: warning: "/*" within comment [-Wcomment] 64 | /* define TX_DVFU 00400 /* DAVFU */ | PDP10/pdp10_lp20.c: In function 'lp20_adv': PDP10/pdp10_lp20.c:566:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 566 | if (lppagc = (lppagc - 1) & PAGC_MASK) { /* decr page cntr */ | ^~~~~~ PDP10/pdp10_lp20.c: In function 'lp20_davfu': PDP10/pdp10_lp20.c:595:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 595 | if (lppagc = (lppagc - 1) & PAGC_MASK) { /* decr page cntr */ | ^~~~~~ PDP11/pdp11_dl.c: In function 'dli_svc': PDP11/pdp11_dl.c:349:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 349 | if (temp = tmxr_getc_ln (&dlx_ldsc[ln])) { /* get char */ | ^~~~ In file included from PDP10/pdp10_mdfp.c:101: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | PDP10/pdp10_mdfp.c: In function 'fdv': PDP10/pdp10_mdfp.c:496:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 496 | if (savhi = a.fhi) { /* dvd = 0? quo = 0 */ | ^~~~~ PDP11/pdp11_ta.c: In function 'ta_svc': PDP11/pdp11_ta.c:400:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 400 | if (st = sim_tape_wrrecf (uptr, ta_xb, ta_bptr)) /* write, err? */ | ^~ PDP11/pdp11_ta.c:406:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 406 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP11/pdp11_ta.c:416:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 416 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ^~ PDP11/pdp11_ta.c:428:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 428 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rev, err? */ | ^~ In file included from PDP10/pdp10_pag.c:79: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | In file included from PDP10/pdp10_rp.c:71: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | PDP10/pdp10_rp.c: In function 'rp_wr': PDP10/pdp10_rp.c:612:18: warning: variable 'dtype' set but not used [-Wunused-but-set-variable] 612 | int32 cs1f, drv, dtype, i, j; | ^~~~~ PDP10/pdp10_rp.c: In function 'rp_svc': PDP10/pdp10_rp.c:954:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 954 | if (fc10 = twc10 & (RP_NUMWD - 1)) { /* fill? */ | ^~~~ PDP10/pdp10_rp.c: At top level: PDP10/pdp10_rp.c:1194:33: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses] 1194 | 0713001000000+(IOBA_UBMAP+1 & RMASK), /* wrio 0,763001(1); set ubmap */ | ^ PDP10/pdp10_rp.c:1241:33: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses] 1241 | 0715000000000+(IOBA_UBMAP+1 & RMASK), /* iowrq 0,763001 ; set ubmap */ | ^ In file included from PDP10/pdp10_sys.c:42: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | PDP10/pdp10_sys.c:123:1: warning: "/*" within comment [-Wcomment] 123 | /* RIM10 loader | PDP10/pdp10_sys.c: In function 'fprint_sym': PDP10/pdp10_sys.c:696:16: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] 696 | int32 i, j, c, cflag, ac, xr, y, dev; | ^~~~~ PDP10/pdp10_sys.c: In function 'parse_sym': PDP10/pdp10_sys.c:823:7: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] 823 | int32 cflag, i, j; | ^~~~~ PDP11/pdp11_ke.c: In function 'ke_wr': PDP11/pdp11_ke.c:255:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 255 | if (sign = GET_SIGN_W (ke_AC)) /* sext operand */ | ^~~~ PDP11/pdp11_ke.c:285:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 285 | if (sign = GET_SIGN_W (ke_AC)) /* sext operand */ | ^~~~ In file included from PDP10/pdp10_tim.c:41: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | In file included from PDP10/pdp10_tu.c:93: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | PDP10/pdp10_tu.c: In function 'tu_svc': PDP10/pdp10_tu.c:836:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 836 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^~ PDP10/pdp10_tu.c:850:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 850 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^~ PDP10/pdp10_tu.c:862:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 862 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP10/pdp10_tu.c:892:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 892 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ^~ PDP10/pdp10_tu.c:939:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 939 | if (st = sim_tape_wrrecf (uptr, xbuf, fc)) /* write rec, err? */ | ^~ PDP10/pdp10_tu.c:954:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 954 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ^~ PDP10/pdp10_tu.c:809:12: warning: variable 'r' set but not used [-Wunused-but-set-variable] 809 | t_stat st, r = SCPE_OK; | ^ PDP10/pdp10_tu.c: At top level: PDP10/pdp10_tu.c:1201:33: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses] 1201 | 0713001000000+(IOBA_UBMAP+1 & RMASK), /* wrio 0,763001(1); set ubmap */ | ^ PDP10/pdp10_tu.c:1239:33: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses] 1239 | 0714000000000+(IOBA_UBMAP+1 & RMASK), /* iowri 0,763001 ; set ubmap */ | ^ In file included from PDP10/pdp10_xtnd.c:66: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | PDP10/pdp10_xtnd.c:157:34: warning: missing braces around initializer [-Wmissing-braces] 157 | static const d10 pwrs10[23][2] = { | ^ 158 | 0, 0, | { } 159 | 0, 1, | { } 160 | 0, 10, | { } 161 | 0, 100, | { } 162 | 0, 1000, | { } 163 | 0, 10000, | { } 164 | 0, 100000, | { } 165 | 0, 1000000, | { } 166 | 0, 10000000, | { } 167 | 0, 100000000, | { } 168 | 0, 1000000000, | { } 169 | 0, 10000000000, | { } 170 | 2, 31280523264, | { } 171 | 29, 3567587328, | { } 172 | 291, 1316134912, | { } 173 | 2910, 13161349120, | { } 174 | 29103, 28534276096, | { } 175 | 291038, 10464854016, | { } 176 | 2910383, 1569325056, | { } 177 | 29103830, 15693250560, | { } 178 | 291038304, 19493552128, | { } 179 | 2910383045, 23136829440, | { } 180 | 29103830456, 25209864192 | { 181 | }; | } In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ In file included from PDP11/pdp11_pt.c:36: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | In file included from PDP11/pdp11_ry.c:45: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | In file included from PDP11/pdp11_cr.c:168: PDP10/pdp10_defs.h:590:57: warning: "/*" within comment [-Wcomment] 590 | /* #define READC 1 /* console read */ | PDP10/pdp10_defs.h:592:57: warning: "/*" within comment [-Wcomment] 592 | /* #define WRITEC 3 /* console write */ | In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ sim_console.c: In function 'sim_poll_kbd': scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_ether.c: In function 'eth_get_nic_hw_addr': sim_ether.c:1336:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ^ sim_ether.c: In function '_eth_writer': sim_ether.c:1522:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1522 | while (request = dev->write_requests) { | ^~~~~~~ sim_ether.c: In function 'eth_open': sim_ether.c:1621:8: warning: unused variable 'dev_name' [-Wunused-variable] 1621 | char dev_name[64] = ""; | ^~~~~~~~ sim_ether.c: In function 'eth_close': sim_ether.c:1830:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1830 | while (buffer = dev->write_buffers) { | ^~~~~~ sim_ether.c:1834:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1834 | while (buffer = dev->write_requests) { | ^~~~~~ sim_ether.c: In function 'eth_write': sim_ether.c:2087:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2087 | if (request = dev->write_buffers) | ^~~~~~~ At top level: sim_ether.c:2178:1: warning: '_eth_test_multicast_hash' defined but not used [-Wunused-function] 2178 | _eth_test_multicast_hash() | ^~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection VAX/vax_cpu.c VAX/vax_cpu1.c VAX/vax_fpa.c VAX/vax_io.c VAX/vax_cis.c VAX/vax_octa.c VAX/vax_cmode.c VAX/vax_mmu.c VAX/vax_stddev.c VAX/vax_sysdev.c VAX/vax_sys.c VAX/vax_syscm.c VAX/vax_syslist.c PDP11/pdp11_rl.c PDP11/pdp11_rq.c PDP11/pdp11_ts.c PDP11/pdp11_dz.c PDP11/pdp11_lp.c PDP11/pdp11_tq.c PDP11/pdp11_xq.c PDP11/pdp11_ry.c PDP11/pdp11_vh.c PDP11/pdp11_cr.c PDP11/pdp11_io_lib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_VAX -DUSE_INT64 -DUSE_ADDR64 -I VAX -I PDP11 -DUSE_NETWORK -I/usr/include/ -DUSE_TAP_NETWORK -o BIN/vax -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program In file included from VAX/vax_cpu.c:182: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_cpu.c:182: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | VAX/vax_cpu.c: In function 'sim_instr': VAX/vax_cpu.c:645:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 645 | if (temp = GET_TRAP (trpirq)) { /* trap? */ | ^~~~ VAX/vax_cpu.c:653:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 653 | else if (temp = GET_IRQL (trpirq)) { /* interrupt? */ | ^~~~ In file included from VAX/vax_cpu1.c:72: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_cpu1.c:72: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from VAX/vax_fpa.c:59: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_fpa.c:59: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from VAX/vax_io.c:52: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_io.c:52: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | VAX/vax_io.c: In function 'build_dib_tab': VAX/vax_io.c:795:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 795 | if (r = build_ubus_tab (dptr, dibp)) /* add to bus tab */ | ^ In file included from VAX/vax_cis.c:53: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_cis.c:53: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | VAX/vax_cis.c:1228:59: warning: "/*" within comment [-Wcomment] 1228 | /* if (((c & 0xF0) > 0x90) || /* check hi digit */ | VAX/vax_cis.c:1229:59: warning: "/*" within comment [-Wcomment] 1229 | /* ((c & 0x0F) > 0x09)) /* check lo digit */ | In file included from VAX/vax_octa.c:47: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_octa.c:47: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection VAX/vax_cpu.c VAX/vax_cpu1.c VAX/vax_fpa.c VAX/vax_cis.c VAX/vax_octa.c VAX/vax_cmode.c VAX/vax_mmu.c VAX/vax_sys.c VAX/vax_syscm.c VAX/vax780_stddev.c VAX/vax780_sbi.c VAX/vax780_mem.c VAX/vax780_uba.c VAX/vax780_mba.c VAX/vax780_fload.c VAX/vax780_syslist.c PDP11/pdp11_rl.c PDP11/pdp11_rq.c PDP11/pdp11_ts.c PDP11/pdp11_dz.c PDP11/pdp11_lp.c PDP11/pdp11_tq.c PDP11/pdp11_xu.c PDP11/pdp11_ry.c PDP11/pdp11_cr.c PDP11/pdp11_rp.c PDP11/pdp11_tu.c PDP11/pdp11_hk.c PDP11/pdp11_io_lib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DVM_VAX -DVAX_780 -DUSE_INT64 -DUSE_ADDR64 -I VAX -I PDP11 -DUSE_NETWORK -I/usr/include/ -DUSE_TAP_NETWORK -o BIN/vax780 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program In file included from VAX/vax_cmode.c:40: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_cmode.c:40: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from VAX/vax_cpu.c:182: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | VAX/vax_cpu.c: In function 'sim_instr': VAX/vax_cpu.c:645:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 645 | if (temp = GET_TRAP (trpirq)) { /* trap? */ | ^~~~ VAX/vax_cpu.c:653:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 653 | else if (temp = GET_IRQL (trpirq)) { /* interrupt? */ | ^~~~ In file included from VAX/vax_mmu.c:50: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_mmu.c:50: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from VAX/vax_stddev.c:48: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_stddev.c:48: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from VAX/vax_sysdev.c:55: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_sysdev.c:55: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | VAX/vax_sysdev.c:407:18: warning: missing braces around initializer [-Wmissing-braces] 407 | DIB sysd_dib[] = { | ^ 408 | 0, 0, NULL, NULL, | { VAX/vax_sysdev.c:407:18: warning: missing braces around initializer [-Wmissing-braces] 407 | DIB sysd_dib[] = { | ^ 408 | 0, 0, NULL, NULL, | { 409 | 2, IVCL (TMR0), 0, { &tmr0_inta, &tmr1_inta } 410 | }; | } In file included from VAX/vax_cpu1.c:72: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_sys.c:47: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_sys.c:47: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | VAX/vax_sys.c:117:45: warning: missing braces around initializer [-Wmissing-braces] 117 | const uint16 drom[NUM_INST][MAX_SPEC + 1] = { | ^ VAX/vax_sys.c: In function 'parse_spec': VAX/vax_sys.c:1176:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1176 | if (tptr = parse_rnum (cptr, &rn)) { /* look for Rn */ | ^~~~ In file included from VAX/vax_fpa.c:59: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_syscm.c:34: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_syscm.c:34: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from VAX/vax_syslist.c:31: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_cis.c:53: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from VAX/vax_syslist.c:31: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | VAX/vax_cis.c:74:25: warning: missing braces around initializer [-Wmissing-braces] 74 | static DSTR Dstr_zero = { 0, 0, 0, 0, 0 }; | ^ | { } VAX/vax_cis.c:75:24: warning: missing braces around initializer [-Wmissing-braces] 75 | static DSTR Dstr_one = { 0, 0x10, 0, 0, 0 }; | ^ | { } VAX/vax_cis.c: In function 'op_cis': VAX/vax_cis.c:334:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 334 | if (r = sim_process_event ()) { /* presumably WRU */ | ^ VAX/vax_cis.c: In function 'ReadDstr': VAX/vax_cis.c:1228:59: warning: "/*" within comment [-Wcomment] 1228 | /* if (((c & 0xF0) > 0x90) || /* check hi digit */ | VAX/vax_cis.c:1229:59: warning: "/*" within comment [-Wcomment] 1229 | /* ((c & 0x0F) > 0x09)) /* check lo digit */ | VAX/vax_cis.c: In function 'NibbleRshift': VAX/vax_cis.c:1553:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1553 | if (s = sc * 4) { | ^ VAX/vax_cis.c: In function 'NibbleLshift': VAX/vax_cis.c:1577:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1577 | if (s = sc * 4) { | ^ In file included from PDP11/pdp11_rl.c:93: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_rl.c:93: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | PDP11/pdp11_rl.c: In function 'rl_svc': PDP11/pdp11_rl.c:859:1: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 859 | if (DEBUG_PRS (rl_dev)) | ^~ PDP11/pdp11_rl.c:863:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 863 | if ((uptr->FNC >= RLCS_READ) && (err == 0)) { /* read (no hdr)? */ | ^~ In file included from VAX/vax_octa.c:47: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | VAX/vax_octa.c: In function 'op_octa': VAX/vax_octa.c:190:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 190 | if (r = op_tsth (opnd[0])) { /* test for 0 */ | ^ VAX/vax_octa.c:201:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 201 | if (r = op_tsth (opnd[0])) { /* test for 0 */ | ^ In file included from PDP11/pdp11_rq.c:77: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_rq.c:77: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from PDP11/pdp11_rq.c:99: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] 213 | /* 5 /* reserved */ | PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] 401 | /* 14 /* reserved */ | PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] 402 | /* 15 /* reserved */ | PDP11/pdp11_rq.c: In function 'rq_abo': PDP11/pdp11_rq.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ^~~~ PDP11/pdp11_rq.c:1368:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^~~ PDP11/pdp11_rq.c:1369:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_avl': PDP11/pdp11_rq.c:1396:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_gus': PDP11/pdp11_rq.c:1450:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_onl': PDP11/pdp11_rq.c:1485:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_scc': PDP11/pdp11_rq.c:1523:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ^~ PDP11/pdp11_rq.c: In function 'rq_suc': PDP11/pdp11_rq.c:1550:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_fmt': PDP11/pdp11_rq.c:1579:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw': PDP11/pdp11_rq.c:1613:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw_valid': PDP11/pdp11_rq.c:1657:57: warning: "/*" within comment [-Wcomment] 1657 | /* if (lbn & 0xF0000000) return (ST_CMD | I_LBN); /* 'reasonable' lbn? */ | PDP11/pdp11_rq.c: In function 'rq_svc': PDP11/pdp11_rq.c:1728:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1728 | if (abc = tbc - t) { /* any xfer? */ | ^~~ PDP11/pdp11_rq.c:1755:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ^ PDP11/pdp11_rq.c: In function 'rq_show_unitq': PDP11/pdp11_rq.c:2589:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2589 | if (pkt = uptr->pktq) { | ^~~ PDP11/pdp11_rq.c:2593:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2593 | } while (pkt = cp->pak[pkt].link); | ^~~ PDP11/pdp11_rq.c: In function 'rq_show_ctrl': PDP11/pdp11_rq.c:2620:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2620 | if (pkt = cp->freq) { | ^~~ PDP11/pdp11_rq.c:2633:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2633 | if (pkt = cp->rspq) { | ^~~ PDP11/pdp11_rq.c:2637:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2637 | } while (pkt = cp->pak[pkt].link); | ^~~ In file included from VAX/vax_cmode.c:40: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | VAX/vax_cmode.c: In function 'op_cmode': VAX/vax_cmode.c:624:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 624 | if (sign = ((src & WSIGN)? 1: 0)) | ^~~~ In file included from PDP11/pdp11_ts.c:93: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_ts.c:93: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | PDP11/pdp11_ts.c: In function 'ts_spacef': PDP11/pdp11_ts.c:493:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^~ PDP11/pdp11_ts.c: In function 'ts_spacer': PDP11/pdp11_ts.c:536:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^~ PDP11/pdp11_ts.c: In function 'ts_readf': PDP11/pdp11_ts.c:572:7: warning: variable 'wa' set but not used [-Wunused-but-set-variable] 572 | int32 wa; | ^~ PDP11/pdp11_ts.c: In function 'ts_readr': PDP11/pdp11_ts.c:622:32: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 622 | tsba = (cmdadh << 16) | cmdadl + fc; /* buf addr */ | ^ PDP11/pdp11_ts.c: In function 'ts_write': PDP11/pdp11_ts.c:669:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ^~ PDP11/pdp11_ts.c: In function 'ts_wtmk': PDP11/pdp11_ts.c:682:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ In file included from VAX/vax_mmu.c:50: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from PDP11/pdp11_dz.c:68: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_dz.c:68: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from VAX/vax_sys.c:47: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | VAX/vax_sys.c:117:45: warning: missing braces around initializer [-Wmissing-braces] 117 | const uint16 drom[NUM_INST][MAX_SPEC + 1] = { | ^ VAX/vax_sys.c: In function 'parse_spec': VAX/vax_sys.c:1176:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1176 | if (tptr = parse_rnum (cptr, &rn)) { /* look for Rn */ | ^~~~ In file included from PDP11/pdp11_lp.c:45: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_lp.c:45: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from VAX/vax_syscm.c:34: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from PDP11/pdp11_tq.c:68: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_tq.c:68: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from PDP11/pdp11_tq.c:85: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] 213 | /* 5 /* reserved */ | PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] 401 | /* 14 /* reserved */ | PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] 402 | /* 15 /* reserved */ | PDP11/pdp11_tq.c: In function 'tq_mscp': PDP11/pdp11_tq.c:783:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ^~~~ PDP11/pdp11_tq.c:789:57: warning: "/*" within comment [-Wcomment] 789 | /* if (tq_cmf[cmd] & MD_CDL) /* clr cch lost? */ | PDP11/pdp11_tq.c: In function 'tq_abo': PDP11/pdp11_tq.c:861:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ^~~~ PDP11/pdp11_tq.c:874:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^~~ PDP11/pdp11_tq.c:875:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_avl': PDP11/pdp11_tq.c:903:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_gus': PDP11/pdp11_tq.c:958:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_onl': PDP11/pdp11_tq.c:983:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_scc': PDP11/pdp11_tq.c:1012:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ^~~~~~~ PDP11/pdp11_tq.c: In function 'tq_suc': PDP11/pdp11_tq.c:1036:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_flu': PDP11/pdp11_tq.c:1058:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_erase': PDP11/pdp11_tq.c:1074:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_wtm': PDP11/pdp11_tq.c:1095:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_pos': PDP11/pdp11_tq.c:1118:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_rw': PDP11/pdp11_tq.c:1150:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_svc': PDP11/pdp11_tq.c:1254:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ^ PDP11/pdp11_tq.c:1291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ^ PDP11/pdp11_tq.c: In function 'tq_show_unitq': PDP11/pdp11_tq.c:2236:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2236 | if (pkt = uptr->pktq) { | ^~~ PDP11/pdp11_tq.c:2240:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2240 | } while (pkt = tq_pkt[pkt].link); | ^~~ PDP11/pdp11_tq.c: In function 'tq_show_ctrl': PDP11/pdp11_tq.c:2265:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2265 | if (pkt = tq_freq) { | ^~~ PDP11/pdp11_tq.c:2278:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2278 | if (pkt = tq_rspq) { | ^~~ PDP11/pdp11_tq.c:2282:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2282 | } while (pkt = tq_pkt[pkt].link); | ^~~ In file included from VAX/vax780_stddev.c:59: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax780_sbi.c:36: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | VAX/vax780_sbi.c:220:1: warning: "/*" within comment [-Wcomment] 220 | /* Find highest priority vectorable interrupt */ | VAX/vax780_sbi.c: In function 'vax780_boot_parse': VAX/vax780_sbi.c:641:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 641 | if (slptr = strchr (gbuf, '/')) { /* found slash? */ | ^~~~~ VAX/vax780_sbi.c: In function 'build_dib_tab': VAX/vax780_sbi.c:787:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 787 | if (r = build_nexus_tab (dptr, dibp)) /* add to dispatch table */ | ^ VAX/vax780_sbi.c:791:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 791 | if (r = build_mbus_tab (dptr, dibp)) | ^ VAX/vax780_sbi.c:795:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 795 | if (r = build_ubus_tab (dptr, dibp)) /* add to dispatch tab */ | ^ In file included from PDP11/pdp11_xq.h:72, from PDP11/pdp11_xq.c:252: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_xq.h:72, from PDP11/pdp11_xq.c:252: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | PDP11/pdp11_xq.c: In function 'xq_process_mop': PDP11/pdp11_xq.c:1086:28: warning: '<<' in boolean context, did you mean '<'? [-Wint-in-bool-context] 1086 | address = (meb->add_hi << 16) || (meb->add_mi << 8) || meb->add_lo; | ~~~~~~~~~~~~~^~~~~~ PDP11/pdp11_xq.c:1086:51: warning: '<<' in boolean context, did you mean '<'? [-Wint-in-bool-context] 1086 | address = (meb->add_hi << 16) || (meb->add_mi << 8) || meb->add_lo; | ~~~~~~~~~~~~~^~~~~ PDP11/pdp11_xq.c:1087:28: warning: '<<' in boolean context, did you mean '<'? [-Wint-in-bool-context] 1087 | size = (meb->siz_hi << 8) || meb->siz_lo; | ~~~~~~~~~~~~~^~~~~ PDP11/pdp11_xq.c:1075:10: warning: variable 'size' set but not used [-Wunused-but-set-variable] 1075 | uint16 size; | ^~~~ PDP11/pdp11_xq.c: In function 'xq_process_setup': PDP11/pdp11_xq.c:1190:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1190 | if (led = (len & XQ_SETUP_LD) >> 2) { | ^~~ PDP11/pdp11_xq.c: In function 'xq_tmrsvc': PDP11/pdp11_xq.c:2534:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 2534 | if (--xq->var->sanity.timer <= 0) | ^ In file included from VAX/vax780_mem.c:31: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | VAX/vax780_mem.c:101:19: warning: missing braces around initializer [-Wmissing-braces] 101 | DIB mctl0_dib[] = { TR_MCTL0, 0, &mctl_rdreg, &mctl_wrreg, 0 }; | ^ VAX/vax780_mem.c:120:19: warning: missing braces around initializer [-Wmissing-braces] 120 | DIB mctl1_dib[] = { TR_MCTL1, 0, &mctl_rdreg, &mctl_wrreg, 0 }; | ^ In file included from VAX/vax780_uba.c:34: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from PDP11/pdp11_ry.c:50: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_ry.c:50: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from VAX/vax780_mba.c:31: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from PDP11/pdp11_vh.c:75: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_vh.c:75: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | PDP11/pdp11_vh.c:296:60: warning: "/*" within comment [-Wcomment] 296 | /* #define DBG_XMT TMXR_DBG_XMT /* display Transmitted Data */ | PDP11/pdp11_vh.c:297:60: warning: "/*" within comment [-Wcomment] 297 | /* #define DBG_RCV TMXR_DBG_RCV /* display Received Data */ | In file included from VAX/vax780_fload.c:44: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax780_syslist.c:30: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from PDP11/pdp11_cr.c:175: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_cr.c:175: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from PDP11/pdp11_rl.c:93: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | PDP11/pdp11_rl.c: In function 'rl_svc': PDP11/pdp11_rl.c:859:1: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 859 | if (DEBUG_PRS (rl_dev)) | ^~ PDP11/pdp11_rl.c:863:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 863 | if ((uptr->FNC >= RLCS_READ) && (err == 0)) { /* read (no hdr)? */ | ^~ In file included from PDP11/pdp11_io_lib.c:31: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from VAX/vax_defs.h:726, from PDP11/pdp11_io_lib.c:31: VAX/vaxmod_defs.h:181:57: warning: "/*" within comment [-Wcomment] 181 | /* #define CMCTLSIZE (18 << 2) /* 18 registers */ | In file included from PDP11/pdp11_rq.c:77: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from PDP11/pdp11_rq.c:99: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] 213 | /* 5 /* reserved */ | PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] 401 | /* 14 /* reserved */ | PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] 402 | /* 15 /* reserved */ | PDP11/pdp11_rq.c: In function 'rq_abo': PDP11/pdp11_rq.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (uptr = rq_getucb (cp, lu)) { /* get unit */ | ^~~~ PDP11/pdp11_rq.c:1368:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1368 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^~~ PDP11/pdp11_rq.c:1369:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1369 | while (tpkt = cp->pak[prv].link) { /* walk list */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_avl': PDP11/pdp11_rq.c:1396:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1396 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_gus': PDP11/pdp11_rq.c:1450:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1450 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_onl': PDP11/pdp11_rq.c:1485:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1485 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_scc': PDP11/pdp11_rq.c:1523:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1523 | if (cp->htmo = cp->pak[pkt].d[SCC_TMO]) /* set timeout */ | ^~ PDP11/pdp11_rq.c: In function 'rq_suc': PDP11/pdp11_rq.c:1550:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1550 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_fmt': PDP11/pdp11_rq.c:1579:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1579 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw': PDP11/pdp11_rq.c:1613:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1613 | if (uptr = rq_getucb (cp, lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_rq.c: In function 'rq_rw_valid': PDP11/pdp11_rq.c:1657:57: warning: "/*" within comment [-Wcomment] 1657 | /* if (lbn & 0xF0000000) return (ST_CMD | I_LBN); /* 'reasonable' lbn? */ | PDP11/pdp11_rq.c: In function 'rq_svc': PDP11/pdp11_rq.c:1728:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1728 | if (abc = tbc - t) { /* any xfer? */ | ^~~ PDP11/pdp11_rq.c:1755:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1755 | if (t = Map_WriteW (ba, tbc, rqxb)) { /* store, nxm? */ | ^ PDP11/pdp11_rq.c: In function 'rq_show_unitq': PDP11/pdp11_rq.c:2589:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2589 | if (pkt = uptr->pktq) { | ^~~ PDP11/pdp11_rq.c:2593:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2593 | } while (pkt = cp->pak[pkt].link); | ^~~ PDP11/pdp11_rq.c: In function 'rq_show_ctrl': PDP11/pdp11_rq.c:2620:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2620 | if (pkt = cp->freq) { | ^~~ PDP11/pdp11_rq.c:2633:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2633 | if (pkt = cp->rspq) { | ^~~ PDP11/pdp11_rq.c:2637:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2637 | } while (pkt = cp->pak[pkt].link); | ^~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ In file included from PDP11/pdp11_ts.c:93: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | PDP11/pdp11_ts.c: In function 'ts_spacef': PDP11/pdp11_ts.c:493:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 493 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^~ PDP11/pdp11_ts.c: In function 'ts_spacer': PDP11/pdp11_ts.c:536:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 536 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^~ PDP11/pdp11_ts.c: In function 'ts_readf': PDP11/pdp11_ts.c:572:7: warning: variable 'wa' set but not used [-Wunused-but-set-variable] 572 | int32 wa; | ^~ PDP11/pdp11_ts.c: In function 'ts_readr': PDP11/pdp11_ts.c:622:32: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 622 | tsba = (cmdadh << 16) | cmdadl + fc; /* buf addr */ | ^ PDP11/pdp11_ts.c: In function 'ts_write': PDP11/pdp11_ts.c:669:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 669 | if (st = sim_tape_wrrecf (uptr, tsxb, fc)) /* write rec, err? */ | ^~ PDP11/pdp11_ts.c: In function 'ts_wtmk': PDP11/pdp11_ts.c:682:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 682 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ In file included from PDP11/pdp11_dz.c:68: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from PDP11/pdp11_lp.c:45: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from PDP11/pdp11_tq.c:68: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from PDP11/pdp11_tq.c:85: PDP11/pdp11_mscp.h:213:57: warning: "/*" within comment [-Wcomment] 213 | /* 5 /* reserved */ | PDP11/pdp11_mscp.h:258:57: warning: "/*" within comment [-Wcomment] 258 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:265:57: warning: "/*" within comment [-Wcomment] 265 | /* 8 - 15 /* reserved */ | PDP11/pdp11_mscp.h:401:57: warning: "/*" within comment [-Wcomment] 401 | /* 14 /* reserved */ | PDP11/pdp11_mscp.h:402:57: warning: "/*" within comment [-Wcomment] 402 | /* 15 /* reserved */ | PDP11/pdp11_tq.c: In function 'tq_mscp': PDP11/pdp11_tq.c:783:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 783 | if (uptr = tq_getucb (lu)) { /* valid unit? */ | ^~~~ PDP11/pdp11_tq.c:789:57: warning: "/*" within comment [-Wcomment] 789 | /* if (tq_cmf[cmd] & MD_CDL) /* clr cch lost? */ | PDP11/pdp11_tq.c: In function 'tq_abo': PDP11/pdp11_tq.c:861:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 861 | if (uptr = tq_getucb (lu)) { /* get unit */ | ^~~~ PDP11/pdp11_tq.c:874:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 874 | else if (prv = uptr->pktq) { /* srch pkt q */ | ^~~ PDP11/pdp11_tq.c:875:16: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 875 | while (tpkt = tq_pkt[prv].link) { /* walk list */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_avl': PDP11/pdp11_tq.c:903:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 903 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_gus': PDP11/pdp11_tq.c:958:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 958 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_onl': PDP11/pdp11_tq.c:983:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 983 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_scc': PDP11/pdp11_tq.c:1012:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1012 | if (tq_htmo = tq_pkt[pkt].d[SCC_TMO]) /* set timeout */ | ^~~~~~~ PDP11/pdp11_tq.c: In function 'tq_suc': PDP11/pdp11_tq.c:1036:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1036 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_flu': PDP11/pdp11_tq.c:1058:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1058 | if (uptr = tq_getucb (lu)) /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_erase': PDP11/pdp11_tq.c:1074:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1074 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_wtm': PDP11/pdp11_tq.c:1095:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1095 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_pos': PDP11/pdp11_tq.c:1118:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1118 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_rw': PDP11/pdp11_tq.c:1150:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1150 | if (uptr = tq_getucb (lu)) { /* unit exist? */ | ^~~~ PDP11/pdp11_tq.c: In function 'tq_svc': PDP11/pdp11_tq.c:1254:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1254 | if (t = Map_WriteB (ba, wbc, tqxb)) { /* store, nxm? */ | ^ PDP11/pdp11_tq.c:1291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1291 | if (t = Map_ReadB (ba, bc, tqxb)) { /* fetch buf, nxm? */ | ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ PDP11/pdp11_tq.c: In function 'tq_show_unitq': PDP11/pdp11_tq.c:2236:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2236 | if (pkt = uptr->pktq) { | ^~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ PDP11/pdp11_tq.c:2240:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2240 | } while (pkt = tq_pkt[pkt].link); | ^~~ PDP11/pdp11_tq.c: In function 'tq_show_ctrl': PDP11/pdp11_tq.c:2265:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2265 | if (pkt = tq_freq) { | ^~~ PDP11/pdp11_tq.c:2278:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2278 | if (pkt = tq_rspq) { | ^~~ PDP11/pdp11_tq.c:2282:22: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2282 | } while (pkt = tq_pkt[pkt].link); | ^~~ In file included from PDP11/pdp11_xu.h:55, from PDP11/pdp11_xu.c:100: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | PDP11/pdp11_xu.c: In function 'xu_process_receive': PDP11/pdp11_xu.c:1044:24: warning: "/*" within comment [-Wcomment] 1044 | /* xu_dump_rxring(xu); /* debug receive ring */ | PDP11/pdp11_xu.c: In function 'xu_process_transmit': PDP11/pdp11_xu.c:1216:24: warning: "/*" within comment [-Wcomment] 1216 | /* xu_dump_txring(xu); /* debug receive ring */ | PDP11/pdp11_xu.c: In function 'xu_dump_rxring': PDP11/pdp11_xu.c:1683:12: warning: unused variable 'rstatus' [-Wunused-variable] 1683 | t_stat rstatus = Map_ReadW (ba, 8, rxhdr); /* get rxring entry[i] */ | ^~~~~~~ PDP11/pdp11_xu.c: In function 'xu_dump_txring': PDP11/pdp11_xu.c:1699:12: warning: unused variable 'tstatus' [-Wunused-variable] 1699 | t_stat tstatus = Map_ReadW (ba, 8, txhdr); /* get rxring entry[i] */ | ^~~~~~~ In file included from PDP11/pdp11_ry.c:50: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ In file included from PDP11/pdp11_cr.c:175: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from PDP11/pdp11_rp.c:58: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | sim_ether.c: In function 'eth_get_nic_hw_addr': sim_ether.c:1336:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ^ sim_ether.c: In function '_eth_writer': sim_ether.c:1522:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1522 | while (request = dev->write_requests) { | ^~~~~~~ sim_ether.c: In function 'eth_open': sim_ether.c:1621:8: warning: unused variable 'dev_name' [-Wunused-variable] 1621 | char dev_name[64] = ""; | ^~~~~~~~ sim_ether.c: In function 'eth_close': sim_ether.c:1830:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1830 | while (buffer = dev->write_buffers) { | ^~~~~~ sim_ether.c:1834:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1834 | while (buffer = dev->write_requests) { | ^~~~~~ sim_ether.c: In function 'eth_write': sim_ether.c:2087:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2087 | if (request = dev->write_buffers) | ^~~~~~~ At top level: sim_ether.c:2178:1: warning: '_eth_test_multicast_hash' defined but not used [-Wunused-function] 2178 | _eth_test_multicast_hash() | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from PDP11/pdp11_tu.c:63: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | PDP11/pdp11_tu.c: In function 'tu_svc': PDP11/pdp11_tu.c:650:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 650 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^~ PDP11/pdp11_tu.c:663:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 663 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^~ PDP11/pdp11_tu.c:674:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 674 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ PDP11/pdp11_tu.c:690:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 690 | if (st = sim_tape_rdrecf (uptr, xbuf, &tbc, MT_MAXFR)) { /* read fwd */ | ^~ PDP11/pdp11_tu.c:742:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 742 | if (st = sim_tape_wrrecf (uptr, xbuf, tbc)) /* write rec, err? */ | ^~ PDP11/pdp11_tu.c:754:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 754 | if (st = sim_tape_rdrecr (uptr, xbuf + 4, &tbc, MT_MAXFR)) { /* read rev */ | ^~ PDP11/pdp11_tu.c:621:12: warning: variable 'r' set but not used [-Wunused-but-set-variable] 621 | t_stat st, r = SCPE_OK; | ^ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ In file included from PDP11/pdp11_hk.c:60: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | PDP11/pdp11_hk.c: In function 'hk_svc': PDP11/pdp11_hk.c:890:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 890 | if (t = Map_ReadW (ba, 2, &comp)) { /* get 1st wd */ | ^ PDP11/pdp11_hk.c:898:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 898 | if (t = Map_ReadW (ba, wc << 1, hkxb)) { /* get buf */ | ^ PDP11/pdp11_hk.c:918:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 918 | if (t = Map_WriteW (ba, 2, &hkxb[wc - 1])) { | ^ PDP11/pdp11_hk.c:924:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 924 | if (t = Map_WriteW (ba, wc << 1, hkxb)) { /* put buf */ | ^ In file included from PDP11/pdp11_io_lib.c:31: VAX/vax_defs.h:476:57: warning: "/*" within comment [-Wcomment] 476 | /* #define PR_TB 5 /* impossible */ | In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_ether.c: In function 'eth_get_nic_hw_addr': sim_ether.c:1336:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1336 | if (f = fopen("NIC.hwaddr", "r")) { | ^ sim_ether.c: In function '_eth_writer': sim_ether.c:1522:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1522 | while (request = dev->write_requests) { | ^~~~~~~ sim_ether.c: In function 'eth_open': sim_ether.c:1621:8: warning: unused variable 'dev_name' [-Wunused-variable] 1621 | char dev_name[64] = ""; | ^~~~~~~~ sim_ether.c: In function 'eth_close': sim_ether.c:1830:11: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1830 | while (buffer = dev->write_buffers) { | ^~~~~~ sim_ether.c:1834:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1834 | while (buffer = dev->write_requests) { | ^~~~~~ sim_ether.c: In function 'eth_write': sim_ether.c:2087:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2087 | if (request = dev->write_buffers) | ^~~~~~~ At top level: sim_ether.c:2178:1: warning: '_eth_test_multicast_hash' defined but not used [-Wunused-function] 2178 | _eth_test_multicast_hash() | ^~~~~~~~~~~~~~~~~~~~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection NOVA/nova_sys.c NOVA/nova_cpu.c NOVA/nova_dkp.c NOVA/nova_dsk.c NOVA/nova_lp.c NOVA/nova_mta.c NOVA/nova_plt.c NOVA/nova_pt.c NOVA/nova_clk.c NOVA/nova_tt.c NOVA/nova_tt1.c NOVA/nova_qty.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I NOVA -o BIN/nova -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program NOVA/nova_cpu.c: In function 'sim_instr': NOVA/nova_cpu.c:246:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 246 | if ( ((x) <= AUTO_TOP) && ((x) >= AUTO_INC) ) \ | ^ NOVA/nova_cpu.c:463:16: note: in expansion of macro 'IND_STEP' 463 | indf = IND_STEP (MA); | ^~~~~~~~ NOVA/nova_cpu.c:246:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 246 | if ( ((x) <= AUTO_TOP) && ((x) >= AUTO_INC) ) \ | ^ NOVA/nova_cpu.c:468:20: note: in expansion of macro 'IND_STEP' 468 | indf = IND_STEP (MA); /* indirect loop */ | ^~~~~~~~ NOVA/nova_cpu.c:246:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 246 | if ( ((x) <= AUTO_TOP) && ((x) >= AUTO_INC) ) \ | ^ NOVA/nova_cpu.c:625:24: note: in expansion of macro 'IND_STEP' 625 | indf = IND_STEP (MA); | ^~~~~~~~ NOVA/nova_cpu.c:246:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 246 | if ( ((x) <= AUTO_TOP) && ((x) >= AUTO_INC) ) \ | ^ NOVA/nova_cpu.c:630:28: note: in expansion of macro 'IND_STEP' 630 | indf = IND_STEP (MA); /* resolve indirect */ | ^~~~~~~~ NOVA/nova_cpu.c:983:13: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 983 | if ( pulse == iopP ) | ^~ NOVA/nova_cpu.c:992:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 992 | break ; | ^~~~~ NOVA/nova_dkp.c: In function 'dkp_svc': NOVA/nova_dkp.c:912:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 912 | if (err = ferror (uptr->fileref)) | ^~~ NOVA/nova_dkp.c:928:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 928 | if (err = ferror (uptr->fileref)) | ^~~ NOVA/nova_mta.c: In function 'mta_svc': NOVA/nova_mta.c:415:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 415 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ^~ NOVA/nova_mta.c:424:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 424 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ NOVA/nova_mta.c:438:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 438 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^~ NOVA/nova_mta.c:450:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 450 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^~ NOVA/nova_mta.c: In function 'mta_upddsta': NOVA/nova_mta.c:496:57: warning: "/*" within comment [-Wcomment] 496 | /* if (mta_ep) { /* if polling */ | NOVA/nova_mta.c:497:57: warning: "/*" within comment [-Wcomment] 497 | /* u = uptr - mta_dev.units; /* unit num */ | NOVA/nova_mta.c:499:1: warning: "/*" within comment [-Wcomment] 499 | /* set polling interupt... | NOVA/nova_mta.c:500:1: warning: "/*" within comment [-Wcomment] 500 | /* } */ | NOVA/nova_tt1.c: In function 'tti1_svc': NOVA/nova_tt1.c:187:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 187 | if (temp = tmxr_getc_ln (&tt1_ldsc)) { /* get char */ | ^~~~ NOVA/nova_qty.c: In function 'qty_update_status': NOVA/nova_qty.c:225:58: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 225 | #define QTY_LINE_BITS( line, bits ) qty_status[ (line) ] & bits | ^ NOVA/nova_qty.c:441:26: note: in expansion of macro 'QTY_LINE_BITS' 441 | status = QTY_LINE_BITS( line, QTY_S_DMASK ) | QTY_S_RI ; | ^~~~~~~~~~~~~ NOVA/nova_qty.c: In function 'qty_common_svc': NOVA/nova_qty.c:606:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 606 | if ( (newln >= 0) && qty_mdm ) | ^ NOVA/nova_qty.c: In function 'alm': NOVA/nova_qty.c:994:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 994 | if ( alm_line < qty_max ) | ^ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection NOVA/eclipse_cpu.c NOVA/eclipse_tt.c NOVA/nova_sys.c NOVA/nova_dkp.c NOVA/nova_dsk.c NOVA/nova_lp.c NOVA/nova_mta.c NOVA/nova_plt.c NOVA/nova_pt.c NOVA/nova_clk.c NOVA/nova_tt1.c NOVA/nova_qty.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I NOVA -DECLIPSE -o BIN/eclipse -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program NOVA/eclipse_cpu.c: In function 'sim_instr': NOVA/eclipse_cpu.c:747:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 747 | if (reason = sim_process_event ()) | ^~~~~~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection HP2100/hp2100_stddev.c HP2100/hp2100_dp.c HP2100/hp2100_dq.c HP2100/hp2100_dr.c HP2100/hp2100_lps.c HP2100/hp2100_ms.c HP2100/hp2100_mt.c HP2100/hp2100_mux.c HP2100/hp2100_cpu.c HP2100/hp2100_fp.c HP2100/hp2100_sys.c HP2100/hp2100_lpt.c HP2100/hp2100_ipl.c HP2100/hp2100_ds.c HP2100/hp2100_cpu0.c HP2100/hp2100_cpu1.c HP2100/hp2100_cpu2.c HP2100/hp2100_cpu3.c HP2100/hp2100_cpu4.c HP2100/hp2100_cpu5.c HP2100/hp2100_cpu6.c HP2100/hp2100_cpu7.c HP2100/hp2100_fp1.c HP2100/hp2100_baci.c HP2100/hp2100_mpx.c HP2100/hp2100_pif.c HP2100/hp2100_di.c HP2100/hp2100_di_da.c HP2100/hp_disclib.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DHAVE_INT64 -I HP2100 -o BIN/hp2100 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program In file included from HP2100/hp2100_stddev.c:113: HP2100/hp2100_stddev.c: In function 'ptrio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:434:13: note: in expansion of macro 'setstdSKF' 434 | setstdSKF (ptr); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:434:13: note: in expansion of macro 'setstdSKF' 434 | setstdSKF (ptr); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:439:13: note: in expansion of macro 'setstdSKF' 439 | setstdSKF (ptr); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:439:13: note: in expansion of macro 'setstdSKF' 439 | setstdSKF (ptr); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_stddev.c:444:25: note: in expansion of macro 'IORETURN' 444 | stat_data = IORETURN (SCPE_OK, ptr_unit.buf); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_stddev.c:466:13: note: in expansion of macro 'setstdPRL' 466 | setstdPRL (ptr); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_stddev.c:467:13: note: in expansion of macro 'setstdIRQ' 467 | setstdIRQ (ptr); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_stddev.c:468:13: note: in expansion of macro 'setstdSRQ' 468 | setstdSRQ (ptr); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_stddev.c: In function 'ptpio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:651:13: note: in expansion of macro 'setstdSKF' 651 | setstdSKF (ptp); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:651:13: note: in expansion of macro 'setstdSKF' 651 | setstdSKF (ptp); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:656:13: note: in expansion of macro 'setstdSKF' 656 | setstdSKF (ptp); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:656:13: note: in expansion of macro 'setstdSKF' 656 | setstdSKF (ptp); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_stddev.c:662:29: note: in expansion of macro 'IORETURN' 662 | stat_data = IORETURN (SCPE_OK, PTP_LOW); /* report as out of tape */ | ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_stddev.c:664:29: note: in expansion of macro 'IORETURN' 664 | stat_data = IORETURN (SCPE_OK, 0); | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_stddev.c:692:13: note: in expansion of macro 'setstdPRL' 692 | setstdPRL (ptp); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_stddev.c:693:13: note: in expansion of macro 'setstdIRQ' 693 | setstdIRQ (ptp); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_stddev.c:694:13: note: in expansion of macro 'setstdSRQ' 694 | setstdSRQ (ptp); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_stddev.c: In function 'ttyio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:767:13: note: in expansion of macro 'setstdSKF' 767 | setstdSKF (tty); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:767:13: note: in expansion of macro 'setstdSKF' 767 | setstdSKF (tty); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:772:13: note: in expansion of macro 'setstdSKF' 772 | setstdSKF (tty); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:772:13: note: in expansion of macro 'setstdSKF' 772 | setstdSKF (tty); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_stddev.c:782:25: note: in expansion of macro 'IORETURN' 782 | stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_stddev.c:819:13: note: in expansion of macro 'setstdPRL' 819 | setstdPRL (tty); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_stddev.c:820:13: note: in expansion of macro 'setstdIRQ' 820 | setstdIRQ (tty); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_stddev.c:821:13: note: in expansion of macro 'setstdSRQ' 821 | setstdSRQ (tty); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_stddev.c: In function 'tto_out': HP2100/hp2100_stddev.c:945:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 945 | if (r = sim_putchar_s (c)) return r; /* output char */ | ^ In file included from HP2100/hp2100_stddev.c:113: HP2100/hp2100_stddev.c: In function 'clkio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:1071:13: note: in expansion of macro 'setstdSKF' 1071 | setstdSKF (clk); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:1071:13: note: in expansion of macro 'setstdSKF' 1071 | setstdSKF (clk); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:1076:13: note: in expansion of macro 'setstdSKF' 1076 | setstdSKF (clk); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_stddev.c:1076:13: note: in expansion of macro 'setstdSKF' 1076 | setstdSKF (clk); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_stddev.c:1081:25: note: in expansion of macro 'IORETURN' 1081 | stat_data = IORETURN (SCPE_OK, clk_error); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_stddev.c:1115:20: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1115 | if ((clk_unit.flags & UNIT_DIAG) == 0) /* calibrated? */ | ^ In file included from HP2100/hp2100_stddev.c:113: HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_stddev.c:1129:13: note: in expansion of macro 'setstdPRL' 1129 | setstdPRL (clk); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_stddev.c:1130:13: note: in expansion of macro 'setstdIRQ' 1130 | setstdIRQ (clk); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_stddev.c:1131:13: note: in expansion of macro 'setstdSRQ' 1131 | setstdSRQ (clk); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_dp.c:193:57: warning: "/*" within comment [-Wcomment] 193 | /* 0000200 /* unused */ | In file included from HP2100/hp2100_dp.c:122: HP2100/hp2100_dp.c: In function 'dpdio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dp.c:433:13: note: in expansion of macro 'setstdSKF' 433 | setstdSKF (dpd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dp.c:433:13: note: in expansion of macro 'setstdSKF' 433 | setstdSKF (dpd); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dp.c:438:13: note: in expansion of macro 'setstdSKF' 438 | setstdSKF (dpd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dp.c:438:13: note: in expansion of macro 'setstdSKF' 438 | setstdSKF (dpd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_dp.c:443:25: note: in expansion of macro 'IORETURN' 443 | stat_data = IORETURN (SCPE_OK, dpd_ibuf); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_dp.c:497:17: note: in expansion of macro 'setstdPRL' 497 | setstdPRL (dpd); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_dp.c:498:17: note: in expansion of macro 'setstdIRQ' 498 | setstdIRQ (dpd); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_dp.c:501:13: note: in expansion of macro 'setstdSRQ' 501 | setstdSRQ (dpd); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_dp.c: In function 'dpcio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dp.c:563:13: note: in expansion of macro 'setstdSKF' 563 | setstdSKF (dpc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dp.c:563:13: note: in expansion of macro 'setstdSKF' 563 | setstdSKF (dpc); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dp.c:568:13: note: in expansion of macro 'setstdSKF' 568 | setstdSKF (dpc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dp.c:568:13: note: in expansion of macro 'setstdSKF' 568 | setstdSKF (dpc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_dp.c:578:25: note: in expansion of macro 'IORETURN' 578 | stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_dp.c:658:13: note: in expansion of macro 'setstdPRL' 658 | setstdPRL (dpc); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_dp.c:659:13: note: in expansion of macro 'setstdIRQ' 659 | setstdIRQ (dpc); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_dp.c:660:13: note: in expansion of macro 'setstdSRQ' 660 | setstdSRQ (dpc); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_dp.c: In function 'dp_goc': HP2100/hp2100_dp.c:697:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 697 | if (t = sim_is_active (&dpc_unit[drv])) { /* still seeking? */ | ^ HP2100/hp2100_dp.c: In function 'dpc_svc': HP2100/hp2100_dp.c:909:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 909 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^~~ HP2100/hp2100_dp.c:912:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 912 | if (err = ferror (uptr->fileref)) break; | ^~~ HP2100/hp2100_dp.c:956:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 956 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^~~ HP2100/hp2100_dp.c:959:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 959 | if (err = ferror (uptr->fileref)) break; /* error? */ | ^~~ HP2100/hp2100_dq.c:103:57: warning: "/*" within comment [-Wcomment] 103 | /* 000 /* unused */ | In file included from HP2100/hp2100_dq.c:80: HP2100/hp2100_dq.c: In function 'dqdio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dq.c:329:13: note: in expansion of macro 'setstdSKF' 329 | setstdSKF (dqd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dq.c:329:13: note: in expansion of macro 'setstdSKF' 329 | setstdSKF (dqd); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dq.c:334:13: note: in expansion of macro 'setstdSKF' 334 | setstdSKF (dqd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dq.c:334:13: note: in expansion of macro 'setstdSKF' 334 | setstdSKF (dqd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_dq.c:339:25: note: in expansion of macro 'IORETURN' 339 | stat_data = IORETURN (SCPE_OK, dqd_ibuf); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_dq.c:377:13: note: in expansion of macro 'setstdPRL' 377 | setstdPRL (dqd); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_dq.c:378:13: note: in expansion of macro 'setstdIRQ' 378 | setstdIRQ (dqd); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_dq.c:379:13: note: in expansion of macro 'setstdSRQ' 379 | setstdSRQ (dqd); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_dq.c: In function 'dqcio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dq.c:431:13: note: in expansion of macro 'setstdSKF' 431 | setstdSKF (dqc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dq.c:431:13: note: in expansion of macro 'setstdSKF' 431 | setstdSKF (dqc); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dq.c:436:13: note: in expansion of macro 'setstdSKF' 436 | setstdSKF (dqc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_dq.c:436:13: note: in expansion of macro 'setstdSKF' 436 | setstdSKF (dqc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_dq.c:441:25: note: in expansion of macro 'IORETURN' 441 | stat_data = IORETURN (SCPE_OK, 0); /* no data */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_dq.c:496:13: note: in expansion of macro 'setstdPRL' 496 | setstdPRL (dqc); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_dq.c:497:13: note: in expansion of macro 'setstdIRQ' 497 | setstdIRQ (dqc); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_dq.c:498:13: note: in expansion of macro 'setstdSRQ' 498 | setstdSRQ (dqc); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_dq.c: In function 'dq_goc': HP2100/hp2100_dq.c:533:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 533 | if (t = sim_is_active (&dqc_unit[drv])) { /* still seeking? */ | ^ HP2100/hp2100_dq.c: In function 'dqc_svc': HP2100/hp2100_dq.c:743:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 743 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^~~ HP2100/hp2100_dq.c:746:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 746 | if (err = ferror (uptr->fileref)) break; | ^~~ HP2100/hp2100_dq.c:789:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 789 | if (err = fseek (uptr->fileref, da * sizeof (int16), | ^~~ HP2100/hp2100_dq.c:792:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 792 | if (err = ferror (uptr->fileref)) break; | ^~~ NOVA/nova_dkp.c: In function 'dkp_svc': NOVA/nova_dkp.c:912:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 912 | if (err = ferror (uptr->fileref)) | ^~~ NOVA/nova_dkp.c:928:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 928 | if (err = ferror (uptr->fileref)) | ^~~ In file included from HP2100/hp2100_dr.c:107: HP2100/hp2100_dr.c: In function 'drdio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_dr.c:360:25: note: in expansion of macro 'IORETURN' 360 | stat_data = IORETURN (SCPE_OK, drd_ibuf); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_dr.c:400:13: note: in expansion of macro 'setstdSRQ' 400 | setstdSRQ (drd); /* set SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_dr.c: In function 'drcio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_dr.c:458:17: note: in expansion of macro 'setSKF' 458 | setSKF (!(CALC_SCP (sim_gtime()))); /* skip if nearing end of sector */ | ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_dr.c:464:17: note: in expansion of macro 'setSKF' 464 | setSKF (!sim_is_active (&drd_unit[TMR_ORG])); /* skip if origin seen */ | ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_dr.c:486:25: note: in expansion of macro 'IORETURN' 486 | stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ | ^~~~~~~~ In file included from HP2100/hp2100_lps.c:135: HP2100/hp2100_lps.c: In function 'lpsio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_lps.c:313:13: note: in expansion of macro 'setstdSKF' 313 | setstdSKF (lps); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_lps.c:313:13: note: in expansion of macro 'setstdSKF' 313 | setstdSKF (lps); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_lps.c:318:13: note: in expansion of macro 'setstdSKF' 318 | setstdSKF (lps); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_lps.c:318:13: note: in expansion of macro 'setstdSKF' 318 | setstdSKF (lps); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_lps.c:337:25: note: in expansion of macro 'IORETURN' 337 | stat_data = IORETURN (SCPE_OK, lps_sta); /* diag, rtn status */ | ^~~~~~~~ HP2100/hp2100_lps.c:375:20: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 375 | if (!(signal_set & ioCLC)) /* CLC not asserted simultaneously? */ | ^ In file included from HP2100/hp2100_lps.c:135: HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_lps.c:430:13: note: in expansion of macro 'setstdPRL' 430 | setstdPRL (lps); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_lps.c:431:13: note: in expansion of macro 'setstdIRQ' 431 | setstdIRQ (lps); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_lps.c:432:13: note: in expansion of macro 'setstdSRQ' 432 | setstdSRQ (lps); /* set standard SRQ signal */ | ^~~~~~~~~ In file included from HP2100/hp2100_ms.c:79: HP2100/hp2100_ms.c: In function 'msdio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ms.c:403:13: note: in expansion of macro 'setstdSKF' 403 | setstdSKF (msd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ms.c:403:13: note: in expansion of macro 'setstdSKF' 403 | setstdSKF (msd); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ms.c:407:13: note: in expansion of macro 'setstdSKF' 407 | setstdSKF (msd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ms.c:407:13: note: in expansion of macro 'setstdSKF' 407 | setstdSKF (msd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_ms.c:411:25: note: in expansion of macro 'IORETURN' 411 | stat_data = IORETURN (SCPE_OK, msd_buf); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_ms.c:438:13: note: in expansion of macro 'setstdPRL' 438 | setstdPRL (msd); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_ms.c:439:13: note: in expansion of macro 'setstdIRQ' 439 | setstdIRQ (msd); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_ms.c:440:13: note: in expansion of macro 'setstdSRQ' 440 | setstdSRQ (msd); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_ms.c: In function 'mscio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ms.c:507:13: note: in expansion of macro 'setstdSKF' 507 | setstdSKF (msc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ms.c:507:13: note: in expansion of macro 'setstdSKF' 507 | setstdSKF (msc); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ms.c:512:13: note: in expansion of macro 'setstdSKF' 512 | setstdSKF (msc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ms.c:512:13: note: in expansion of macro 'setstdSKF' 512 | setstdSKF (msc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_ms.c:545:25: note: in expansion of macro 'IORETURN' 545 | stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_ms.c:649:13: note: in expansion of macro 'setstdPRL' 649 | setstdPRL (msc); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_ms.c:650:13: note: in expansion of macro 'setstdIRQ' 650 | setstdIRQ (msc); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_ms.c:651:13: note: in expansion of macro 'setstdSRQ' 651 | setstdSRQ (msc); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_ms.c: In function 'msc_svc': HP2100/hp2100_ms.c:740:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 740 | if (st = ms_write_gap (uptr)) { /* write initial gap; error? */ | ^~ HP2100/hp2100_ms.c:750:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 750 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ HP2100/hp2100_ms.c:756:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 756 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^~ HP2100/hp2100_ms.c:764:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 764 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^~ HP2100/hp2100_ms.c:834:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 834 | if (st = ms_write_gap (uptr)) { /* write initial gap; error? */ | ^~ HP2100/hp2100_ms.c:858:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 858 | if (st = sim_tape_wrrecf (uptr, msxb, ms_ptr)) { /* write, err? */ | ^~ HP2100/hp2100_ms.c: In function 'ms_write_gap': HP2100/hp2100_ms.c:897:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 897 | if (st = sim_tape_wrgap (uptr, gap_len, tape_bpi)) /* write gap */ | ^~ HP2100/hp2100_ms.c: In function 'ms_clear': HP2100/hp2100_ms.c:977:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 977 | if (st = sim_tape_wrrecf (uptr, msxb, ms_ptr | MTR_ERF)) | ^~ NOVA/nova_mta.c: In function 'mta_svc': NOVA/nova_mta.c:415:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 415 | if (st = sim_tape_wrrecf (uptr, mtxb, tbc)) { /* write rec, err? */ | ^~ NOVA/nova_mta.c:424:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 424 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ NOVA/nova_mta.c:438:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 438 | if (st = sim_tape_sprecf (uptr, &tbc)) { /* space rec fwd, err? */ | ^~ NOVA/nova_mta.c:450:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 450 | if (st = sim_tape_sprecr (uptr, &tbc)) { /* space rec rev, err? */ | ^~ NOVA/nova_mta.c: In function 'mta_upddsta': NOVA/nova_mta.c:496:57: warning: "/*" within comment [-Wcomment] 496 | /* if (mta_ep) { /* if polling */ | NOVA/nova_mta.c:497:57: warning: "/*" within comment [-Wcomment] 497 | /* u = uptr - mta_dev.units; /* unit num */ | NOVA/nova_mta.c:499:1: warning: "/*" within comment [-Wcomment] 499 | /* set polling interupt... | NOVA/nova_mta.c:500:1: warning: "/*" within comment [-Wcomment] 500 | /* } */ | In file included from HP2100/hp2100_mt.c:83: HP2100/hp2100_mt.c: In function 'mtdio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mt.c:277:13: note: in expansion of macro 'setstdSKF' 277 | setstdSKF (mtd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mt.c:277:13: note: in expansion of macro 'setstdSKF' 277 | setstdSKF (mtd); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mt.c:281:13: note: in expansion of macro 'setstdSKF' 281 | setstdSKF (mtd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mt.c:281:13: note: in expansion of macro 'setstdSKF' 281 | setstdSKF (mtd); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_mt.c:285:25: note: in expansion of macro 'IORETURN' 285 | stat_data = IORETURN (SCPE_OK, mtc_unit.buf); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_mt.c:303:13: note: in expansion of macro 'setstdSRQ' 303 | setstdSRQ (mtd); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_mt.c: In function 'mtcio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mt.c:364:13: note: in expansion of macro 'setstdSKF' 364 | setstdSKF (mtc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mt.c:364:13: note: in expansion of macro 'setstdSKF' 364 | setstdSKF (mtc); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mt.c:369:13: note: in expansion of macro 'setstdSKF' 369 | setstdSKF (mtc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mt.c:369:13: note: in expansion of macro 'setstdSKF' 369 | setstdSKF (mtc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_mt.c:386:25: note: in expansion of macro 'IORETURN' 386 | stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_mt.c:446:13: note: in expansion of macro 'setstdPRL' 446 | setstdPRL (mtc); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_mt.c:447:13: note: in expansion of macro 'setstdIRQ' 447 | setstdIRQ (mtc); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_mt.c:448:13: note: in expansion of macro 'setstdSRQ' 448 | setstdSRQ (mtc); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_mt.c: In function 'mtc_svc': HP2100/hp2100_mt.c:498:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 498 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ HP2100/hp2100_mt.c:507:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 507 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space rec fwd, err? */ | ^~ HP2100/hp2100_mt.c:512:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 512 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rec rev, err? */ | ^~ HP2100/hp2100_mt.c:561:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 561 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_ptr)) { /* write, err? */ | ^~ HP2100/hp2100_mt.c: In function 'mt_clear': HP2100/hp2100_mt.c:630:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 630 | if (st = sim_tape_wrrecf (&mtc_unit, mtxb, mt_ptr | MTR_ERF)) | ^~ In file included from HP2100/hp2100_mux.c:137: HP2100/hp2100_mux.c: In function 'muxlio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mux.c:633:13: note: in expansion of macro 'setstdSKF' 633 | setstdSKF (muxl); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mux.c:633:13: note: in expansion of macro 'setstdSKF' 633 | setstdSKF (muxl); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mux.c:638:13: note: in expansion of macro 'setstdSKF' 638 | setstdSKF (muxl); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mux.c:638:13: note: in expansion of macro 'setstdSKF' 638 | setstdSKF (muxl); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_mux.c:643:25: note: in expansion of macro 'IORETURN' 643 | stat_data = IORETURN (SCPE_OK, muxl_ibuf); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_mux.c:653:16: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 653 | if (DEBUG_PRI (muxu_dev, DEB_CPU)) | ^ HP2100/hp2100_mux.c:711:43: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 711 | muxl_obuf & ~OTL_PAR | | ^ In file included from HP2100/hp2100_mux.c:137: HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_mux.c:757:13: note: in expansion of macro 'setstdPRL' 757 | setstdPRL (muxl); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_mux.c:758:13: note: in expansion of macro 'setstdIRQ' 758 | setstdIRQ (muxl); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_mux.c:759:13: note: in expansion of macro 'setstdSRQ' 759 | setstdSRQ (muxl); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_mux.c: In function 'muxuio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_mux.c:803:25: note: in expansion of macro 'IORETURN' 803 | stat_data = IORETURN (SCPE_OK, muxu_ibuf); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_mux.c: In function 'muxcio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mux.c:870:13: note: in expansion of macro 'setstdSKF' 870 | setstdSKF (muxc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mux.c:870:13: note: in expansion of macro 'setstdSKF' 870 | setstdSKF (muxc); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mux.c:875:13: note: in expansion of macro 'setstdSKF' 875 | setstdSKF (muxc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mux.c:875:13: note: in expansion of macro 'setstdSKF' 875 | setstdSKF (muxc); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_mux.c:890:25: note: in expansion of macro 'IORETURN' 890 | stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_mux.c:954:13: note: in expansion of macro 'setstdPRL' 954 | setstdPRL (muxc); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_mux.c:955:13: note: in expansion of macro 'setstdIRQ' 955 | setstdIRQ (muxc); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_mux.c:956:13: note: in expansion of macro 'setstdSRQ' 956 | setstdSRQ (muxc); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_mux.c: In function 'mux_receive': HP2100/hp2100_mux.c:1110:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1110 | if (DEBUG_PRI (muxu_dev, DEB_XFER)) | ^ HP2100/hp2100_mux.c: In function 'mux_data_int': HP2100/hp2100_mux.c:1163:25: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1163 | mux_rbuf[i] & LIL_CHAR | | ^ HP2100/hp2100_mux.c:1179:25: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1179 | mux_rbuf[i] & LIL_CHAR | | ^ HP2100/hp2100_mux.c:1195:25: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1195 | mux_rbuf[i] & LIL_CHAR | | ^ HP2100/hp2100_mux.c: In function 'mux_ctrl_int': HP2100/hp2100_mux.c:241:26: warning: '<<' in boolean context, did you mean '<'? [-Wint-in-bool-context] 239 | #define LIC_TSTI(ch) (((muxc_lia[ch] ^ muxc_ota[ch]) & \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 240 | ((muxc_ota[ch] & (OTC_ES2|OTC_ES1)) >> OTC_V_ES)) \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 241 | << LIC_V_I) | ^~~~~~~~~~~ HP2100/hp2100_mux.c:1230:9: note: in expansion of macro 'LIC_TSTI' 1230 | if (LIC_TSTI (muxc_chan)) { /* status change? */ | ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'sim_instr': HP2100/hp2100_cpu.c:1057:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1057 | for (i = 0; dptr = sim_devices [i]; i++) { /* loop thru dev */ | ^~~~ HP2100/hp2100_cpu.c:1470:56: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1467 | if (((PC == err_PC) || /* RTE through RTE-IVB */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1468 | ((PC == (err_PC - 1)) && /* RTE-6/VM */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1469 | ((ReadW (PC) & I_MRG) == I_ISZ))) && /* RTE jump target */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1470 | (mp_fence == CLEAR) && (M [xeqt] == 0) && /* RTE idle indications */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1471 | (M [tbg] == clk_dib.select_code) || /* RTE verification */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from HP2100/hp2100_cpu.c:444: HP2100/hp2100_cpu.c: In function 'iogrp': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:1984:38: note: in expansion of macro 'IORETURN' 1984 | ioreturn = devdisp (dev, signal_set, IORETURN (SCPE_OK, iodata)); /* dispatch I/O signal */ | ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'devdisp': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:2018:40: note: in expansion of macro 'IORETURN' 2018 | IORETURN (SCPE_OK, data)); | ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'calc_int': HP2100/hp2100_cpu.c:2156:9: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 2156 | else if (req_grant [1]) /* device in upper half */ | ^ In file included from HP2100/hp2100_cpu.c:444: HP2100/hp2100_cpu.c: In function 'cpuio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_cpu.c:2750:13: note: in expansion of macro 'setSKF' 2750 | setSKF (!ion); /* skip if interrupt system is off */ | ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_cpu.c:2754:13: note: in expansion of macro 'setSKF' 2754 | setSKF (ion); /* skip if interupt system is on */ | ^~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:2758:25: note: in expansion of macro 'IORETURN' 2758 | stat_data = IORETURN (SCPE_OK, 0); /* returns 0 */ | ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'ovflio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_cpu.c:2840:13: note: in expansion of macro 'setSKF' 2840 | setSKF (!O); /* skip if overflow is clear */ | ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_cpu.c:2844:13: note: in expansion of macro 'setSKF' 2844 | setSKF (O); /* skip if overflow is set */ | ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:2848:25: note: in expansion of macro 'IORETURN' 2848 | stat_data = IORETURN (SCPE_OK, SR); /* read switch register value */ | ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'pwrfio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:2899:25: note: in expansion of macro 'IORETURN' 2899 | stat_data = IORETURN (SCPE_OK, intaddr); /* input CIR value */ | ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'protio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_cpu.c:2992:13: note: in expansion of macro 'setSKF' 2992 | setSKF (!mp_mevff); /* skip if MP interrupt */ | ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_cpu.c:2996:13: note: in expansion of macro 'setSKF' 2996 | setSKF (mp_mevff); /* skip if DMS interrupt */ | ^~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:3000:25: note: in expansion of macro 'IORETURN' 3000 | stat_data = IORETURN (SCPE_OK, mp_viol); /* read MP violation register */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_cpu.c:3024:13: note: in expansion of macro 'setPRL' 3024 | setPRL (PRO, !mp_flag); /* set PRL signal */ | ^~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_cpu.c:3025:13: note: in expansion of macro 'setIRQ' 3025 | setIRQ (PRO, mp_flag); /* set IRQ signal */ | ^~~~~~ HP2100/hp2100_cpu.c: In function 'dmasio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:3098:25: note: in expansion of macro 'IORETURN' 3098 | stat_data = IORETURN (SCPE_OK, data); /* merge status and remaining word count */ | ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'dmapio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_cpu.c:3183:13: note: in expansion of macro 'setstdSKF' 3183 | setstdSKF (dma [ch]); /* skip if transfer in progress */ | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_cpu.c:3183:13: note: in expansion of macro 'setstdSKF' 3183 | setstdSKF (dma [ch]); /* skip if transfer in progress */ | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_cpu.c:3187:13: note: in expansion of macro 'setstdSKF' 3187 | setstdSKF (dma [ch]); /* skip if transfer is complete */ | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_cpu.c:3187:13: note: in expansion of macro 'setstdSKF' 3187 | setstdSKF (dma [ch]); /* skip if transfer is complete */ | ^~~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:3192:29: note: in expansion of macro 'IORETURN' 3192 | stat_data = IORETURN (SCPE_OK, DMASK); /* return all ones */ | ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:3194:29: note: in expansion of macro 'IORETURN' 3194 | stat_data = IORETURN (SCPE_OK, 0); /* return all zeros */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_cpu.c:3227:13: note: in expansion of macro 'setstdPRL' 3227 | setstdPRL (dma [ch]); | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_cpu.c:3228:13: note: in expansion of macro 'setstdIRQ' 3228 | setstdIRQ (dma [ch]); | ^~~~~~~~~ HP2100/hp2100_cpu.c: In function 'nullio': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:3292:8: note: in expansion of macro 'IORETURN' 3292 | return IORETURN (stop_dev, data); /* flag missing device */ | ^~~~~~~~ HP2100/hp2100_cpu.c: In function 'dma_cycle': HP2100/hp2100_cpu.c:3354:11: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 3354 | if (bytes && !even || dma [ch].cw3 != DMASK) { /* normal cycle? */ | ~~~~~~^~~~~~~~ In file included from HP2100/hp2100_cpu.c:444: HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:3380:25: note: in expansion of macro 'IORETURN' 3380 | IORETURN (SCPE_OK, 0)); | ^~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_cpu.c:3419:25: note: in expansion of macro 'IORETURN' 3419 | IORETURN (SCPE_OK, data)); | ^~~~~~~~ HP2100/hp2100_cpu.c:3425:47: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 3425 | dma [ch].cw2 = input | (dma [ch].cw2 + 1) & VAMASK; /* increment address */ HP2100/hp2100_cpu.c: In function 'dev_conflict': HP2100/hp2100_cpu.c:3614:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3614 | for (i = 0; dptr = sim_devices[i]; i++) { | ^~~~ HP2100/hp2100_cpu.c:3632:25: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3632 | for (j = 0; dptr = sim_devices[j]; j++) { | ^~~~ HP2100/hp2100_cpu.c: In function 'cpu_set_model': HP2100/hp2100_cpu.c:3733:33: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 3733 | cpu_unit.flags = cpu_unit.flags & ~UNIT_OPTS | /* set typical features */ HP2100/hp2100_cpu.c:3794:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 3794 | if (result == SCPE_OK) /* memory change OK? */ | ^ HP2100/hp2100_cpu.c: In function 'cpu_show_model': HP2100/hp2100_cpu.c:3813:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 3813 | if (UNIT_CPU_FAMILY == UNIT_FAMILY_21XX) /* valid only for 21xx */ | ^ HP2100/hp2100_cpu.c: In function 'cpu_set_opt': HP2100/hp2100_cpu.c:3849:9: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 3849 | else if (UNIT_CPU_MODEL == UNIT_1000_F) | ^ NOVA/nova_tt1.c: In function 'tti1_svc': NOVA/nova_tt1.c:187:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 187 | if (temp = tmxr_getc_ln (&tt1_ldsc)) { /* get char */ | ^~~~ NOVA/nova_qty.c: In function 'qty_update_status': NOVA/nova_qty.c:225:58: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 225 | #define QTY_LINE_BITS( line, bits ) qty_status[ (line) ] & bits | ^ NOVA/nova_qty.c:441:26: note: in expansion of macro 'QTY_LINE_BITS' 441 | status = QTY_LINE_BITS( line, QTY_S_DMASK ) | QTY_S_RI ; | ^~~~~~~~~~~~~ NOVA/nova_qty.c: In function 'qty_common_svc': NOVA/nova_qty.c:606:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 606 | if ( (newln >= 0) && qty_mdm ) | ^ NOVA/nova_qty.c: In function 'alm': NOVA/nova_qty.c:994:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 994 | if ( alm_line < qty_max ) | ^ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ HP2100/hp2100_sys.c: In function 'parse_sym': HP2100/hp2100_sys.c:611:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 611 | if (k = (strcmp (gbuf, "C") == 0)) { /* C specified? */ | ^ HP2100/hp2100_sys.c:615:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 615 | else if (k = (strcmp (gbuf, "Z") == 0)) { /* Z specified? */ | ^ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ In file included from HP2100/hp2100_lpt.c:76: HP2100/hp2100_lpt.c: In function 'lptio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_lpt.c:190:13: note: in expansion of macro 'setstdSKF' 190 | setstdSKF (lpt); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_lpt.c:190:13: note: in expansion of macro 'setstdSKF' 190 | setstdSKF (lpt); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_lpt.c:195:13: note: in expansion of macro 'setstdSKF' 195 | setstdSKF (lpt); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_lpt.c:195:13: note: in expansion of macro 'setstdSKF' 195 | setstdSKF (lpt); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_lpt.c:216:25: note: in expansion of macro 'IORETURN' 216 | stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_lpt.c:244:13: note: in expansion of macro 'setstdPRL' 244 | setstdPRL (lpt); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_lpt.c:245:13: note: in expansion of macro 'setstdIRQ' 245 | setstdIRQ (lpt); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_lpt.c:246:13: note: in expansion of macro 'setstdSRQ' 246 | setstdSRQ (lpt); /* set standard SRQ signal */ | ^~~~~~~~~ In file included from HP2100/hp2100_ipl.c:67: HP2100/hp2100_ipl.c: In function 'iplio': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ipl.c:332:13: note: in expansion of macro 'setstdSKF' 332 | setstdSKF (ipl [card]); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ipl.c:332:13: note: in expansion of macro 'setstdSKF' 332 | setstdSKF (ipl [card]); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ipl.c:337:13: note: in expansion of macro 'setstdSKF' 337 | setstdSKF (ipl [card]); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ipl.c:337:13: note: in expansion of macro 'setstdSKF' 337 | setstdSKF (ipl [card]); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_ipl.c:342:25: note: in expansion of macro 'IORETURN' 342 | stat_data = IORETURN (SCPE_OK, uptr->IBUF); /* get return data */ | ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_ipl.c:385:28: note: in expansion of macro 'IORETURN' 385 | return IORETURN (STOP_NOCONN, 0); /* lose */ | ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_ipl.c:398:28: note: in expansion of macro 'IORETURN' 398 | return IORETURN (SCPE_IOERR, 0); | ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_ipl.c:413:24: note: in expansion of macro 'IORETURN' 413 | return IORETURN (SCPE_UNATT, 0); /* lose */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_ipl.c:433:13: note: in expansion of macro 'setstdPRL' 433 | setstdPRL (ipl [card]); | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_ipl.c:434:13: note: in expansion of macro 'setstdIRQ' 434 | setstdIRQ (ipl [card]); | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_ipl.c:435:13: note: in expansion of macro 'setstdSRQ' 435 | setstdSRQ (ipl [card]); | ^~~~~~~~~ HP2100/hp2100_ipl.c: In function 'ipl_attach': HP2100/hp2100_ipl.c:626:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 626 | if (t = ipl_check_conn (uptr)) /* established? */ | ^ In file included from HP2100/hp2100_ds.c:118: HP2100/hp2100_ds.c: In function 'ds_io': HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_ds.c:459:13: note: in expansion of macro 'setSKF' 459 | setSKF (mac_cntlr.state != cntlr_busy); /* skip if the controller is not busy */ | ^~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ds.c:464:13: note: in expansion of macro 'setstdSKF' 464 | setstdSKF (ds); /* assert SKF if the flag is set */ | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_ds.c:464:13: note: in expansion of macro 'setstdSKF' 464 | setstdSKF (ds); /* assert SKF if the flag is set */ | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_ds.c:470:25: note: in expansion of macro 'IORETURN' 470 | stat_data = IORETURN (SCPE_OK, data); /* merge in the return status */ | ^~~~~~~~ HP2100/hp2100_defs.h:360:46: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_ds.c:543:29: note: in expansion of macro 'IORETURN' 543 | stat_data = IORETURN (status, 0); /* return the status from the controller */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_ds.c:580:13: note: in expansion of macro 'setstdPRL' 580 | setstdPRL (ds); /* set the standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_ds.c:581:13: note: in expansion of macro 'setstdIRQ' 581 | setstdIRQ (ds); /* set the standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_ds.c:582:13: note: in expansion of macro 'setSRQ' 582 | setSRQ (dibptr->select_code, ds.srq); /* set the SRQ signal */ | ^~~~~~ HP2100/hp2100_ds.c: In function 'ds_boot': HP2100/hp2100_ds.c:1172:9: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1172 | SR = SR & (IBL_OPT | IBL_DS_HEAD) /* set S to a reasonable value */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu0.c: In function 'cpu_ds': HP2100/hp2100_cpu0.c:133:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 133 | if (reason = cpu_ops (op_ds[entry], op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu0.c: In function 'cpu_user': HP2100/hp2100_cpu0.c:194:57: warning: "/*" within comment [-Wcomment] 194 | /* case 000: /* 105000-105017 */ | HP2100/hp2100_cpu0.c:195:57: warning: "/*" within comment [-Wcomment] 195 | /* return cpu_user_00 (IR, intrq); /* uncomment to handle instruction */ | HP2100/hp2100_cpu0.c:197:57: warning: "/*" within comment [-Wcomment] 197 | /* case 001: /* 105020-105037 */ | HP2100/hp2100_cpu0.c:198:57: warning: "/*" within comment [-Wcomment] 198 | /* return cpu_user_01 (IR, intrq); /* uncomment to handle instruction */ | HP2100/hp2100_cpu0.c:200:57: warning: "/*" within comment [-Wcomment] 200 | /* case 0nn: /* other cases as needed */ | HP2100/hp2100_cpu0.c:201:57: warning: "/*" within comment [-Wcomment] 201 | /* return cpu_user_nn (IR, intrq); /* uncomment to handle instruction */ | HP2100/hp2100_cpu0.c:206:57: warning: "/*" within comment [-Wcomment] 206 | /* case 021: /* 10x420-10x437 */ | HP2100/hp2100_cpu0.c:207:57: warning: "/*" within comment [-Wcomment] 207 | /* return cpu_user_21 (IR, intrq); /* uncomment to handle instruction */ | HP2100/hp2100_cpu0.c:209:57: warning: "/*" within comment [-Wcomment] 209 | /* case 0nn: /* other cases as needed */ | HP2100/hp2100_cpu0.c:210:57: warning: "/*" within comment [-Wcomment] 210 | /* return cpu_user_nn (IR, intrq); /* uncomment to handle instruction */ | HP2100/hp2100_cpu0.c: In function 'cpu_user_20': HP2100/hp2100_cpu0.c:247:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 247 | if (reason = cpu_ops (op_user_20 [entry], op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu0.c:253:57: warning: "/*" within comment [-Wcomment] 253 | /* break; /* uncomment to handle instruction */ | HP2100/hp2100_cpu0.c:256:57: warning: "/*" within comment [-Wcomment] 256 | /* break; /* uncomment to handle instruction */ | HP2100/hp2100_cpu0.c:258:57: warning: "/*" within comment [-Wcomment] 258 | /* case 0nn: /* other cases as needed */ | HP2100/hp2100_cpu0.c:259:57: warning: "/*" within comment [-Wcomment] 259 | /* break; /* uncomment to handle instruction */ | sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ HP2100/hp2100_cpu1.c: In function 'cpu_eau': HP2100/hp2100_cpu1.c:196:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 196 | if ((cpu_unit.flags & UNIT_EAU) == 0) /* option installed? */ | ^ HP2100/hp2100_cpu1.c:248:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 248 | if (reason = cpu_ops (OP_K, op, intrq)) /* get operand */ | ^~~~~~ HP2100/hp2100_cpu1.c:265:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 265 | if (reason = cpu_ops (OP_K, op, intrq)) /* get operand */ | ^~~~~~ HP2100/hp2100_cpu1.c:267:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 267 | if (rs = qs = BR & SIGN) { /* save divd sign, neg? */ | ^~ HP2100/hp2100_cpu1.c:320:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 320 | if (reason = cpu_ops (OP_D, op, intrq)) /* get operand */ | ^~~~~~ HP2100/hp2100_cpu1.c:327:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 327 | if (reason = cpu_ops (OP_A, op, intrq)) /* get operand */ | ^~~~~~ HP2100/hp2100_cpu1.c: In function 'cpu_ops': HP2100/hp2100_cpu1.c:737:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 737 | if (reason = resolve (ReadW (PC), &MA, irq)) /* resolve indirects */ | ^~~~~~ HP2100/hp2100_cpu2.c: In function 'cpu_dms': HP2100/hp2100_cpu2.c:247:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 247 | if (reason = cpu_ops (op_dms[entry], op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu2.c: In function 'cpu_eig': HP2100/hp2100_cpu2.c:613:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 613 | if (reason = cpu_ops (op_eig[entry], op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu2.c: In function 'cpu_iop': HP2100/hp2100_cpu2.c:992:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 992 | if (reason = cpu_ops (op_iop[entry], op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu3.c: In function 'cpu_ffp': HP2100/hp2100_cpu3.c:189:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 189 | if (reason = cpu_ops (op_ffp_e[entry], op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu3.c:197:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 197 | if (reason = cpu_ops (op_ffp_f[entry], op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu3.c:420:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 420 | if (reason = resolve (da, &MA, intrq)) { /* resolve indirects */ | ^~~~~~ HP2100/hp2100_cpu3.c:438:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 438 | if (reason = cpu_ops (OP_KK, op2, intrq)) { /* get 1st, 2nd ranges */ | ^~~~~~ HP2100/hp2100_cpu3.c:464:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 464 | if (reason = resolve (MA, &MA, intrq)) { /* resolve indirect */ | ^~~~~~ HP2100/hp2100_cpu3.c: In function 'cpu_dbi': HP2100/hp2100_cpu3.c:647:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 647 | if (reason = cpu_ops (op_dbi[entry], op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu4.c: In function 'cpu_fpp': HP2100/hp2100_cpu4.c:264:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 264 | if (reason = cpu_ops (op_fpp[entry], op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu4.c: In function 'cpu_sis': HP2100/hp2100_cpu4.c:603:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 603 | if (reason = cpu_ops (op_sis[entry], op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu5.c: In function 'cpu_rte_vma': HP2100/hp2100_cpu5.c:653:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 653 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu5.c: In function 'cpu_rte_ema': HP2100/hp2100_cpu5.c:1364:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1364 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^~~~~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ HP2100/hp2100_cpu6.c: In function 'cpu_save_regs': HP2100/hp2100_cpu6.c:251:34: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 251 | WriteW (save_area + 3, (E << 15) & SIGN | O & 1); /* save E and O */ HP2100/hp2100_cpu6.c: In function 'cpu_rte_os': HP2100/hp2100_cpu6.c:397:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 397 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu6.c:400:40: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 400 | tbg_tick = tbg_tick || (IR == 0105357) && iotrap; /* set TBG interrupting flag */ | ~~~~~~~~~~~~~~~~^~~~~~~~~ HP2100/hp2100_cpu6.c:547:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 547 | if (reason = resolve (ma, &ma, intrq)) { /* resolve indirect */ | ^~~~~~ HP2100/hp2100_cpu6.c:552:36: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 552 | WriteW (ma, ReadW (ma) & ~I_DEVMASK | AR); /* set SC into instruction */ HP2100/hp2100_cpu6.c:623:26: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 623 | if ((E == 0) && (key == op[0].word) || /* for E = 0, key = arg? */ | ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_cpu6.c:713:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 713 | if (reason = resolve (ma, &ma, intrq)) { /* resolve indirect */ | ^~~~~~ HP2100/hp2100_cpu7.c: In function 'cpu_vis': HP2100/hp2100_cpu7.c:388:1: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 388 | if (pattern != OP_N) | ^~ HP2100/hp2100_cpu7.c:394:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 394 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^~ HP2100/hp2100_cpu7.c:394:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 394 | if (reason = cpu_ops (pattern, op, intrq)) /* get instruction operands */ | ^~~~~~ HP2100/hp2100_cpu7.c: In function 'cpu_signal': HP2100/hp2100_cpu7.c:656:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 656 | if (reason = cpu_ops (op_signal[entry], op, intrq)) /* get instruction operands */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ HP2100/hp2100_fp1.c: In function 'fp_prec': HP2100/hp2100_fp1.c:1148:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1148 | if (result) /* want result precision? */ | ^ In file included from HP2100/hp2100_baci.c:156: HP2100/hp2100_baci.c: In function 'baci_io': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_baci.c:579:13: note: in expansion of macro 'setstdSKF' 579 | setstdSKF (baci); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_baci.c:579:13: note: in expansion of macro 'setstdSKF' 579 | setstdSKF (baci); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_baci.c:584:13: note: in expansion of macro 'setstdSKF' 584 | setstdSKF (baci); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_baci.c:584:13: note: in expansion of macro 'setstdSKF' 584 | setstdSKF (baci); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_baci.c:608:25: note: in expansion of macro 'IORETURN' 608 | stat_data = IORETURN (SCPE_OK, data); /* merge in return status */ | ^~~~~~~~ HP2100/hp2100_baci.c:673:28: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 673 | if (baci_term.flags & UNIT_DIAG) /* diagnostic mode? */ | ^ In file included from HP2100/hp2100_baci.c:156: HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_baci.c:745:13: note: in expansion of macro 'setstdPRL' 745 | setstdPRL (baci); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_baci.c:746:13: note: in expansion of macro 'setstdIRQ' 746 | setstdIRQ (baci); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_baci.c:747:13: note: in expansion of macro 'setSRQ' 747 | setSRQ (dibptr->select_code, baci.srq); /* set SRQ signal */ | ^~~~~~ HP2100/hp2100_baci.c: In function 'master_reset': HP2100/hp2100_baci.c:1110:31: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1110 | baci_status = baci_status & ~IN_MODEM | IN_SPARE; /* clear loopback status, set BA */ | ^ HP2100/hp2100_baci.c: In function 'update_status': HP2100/hp2100_baci.c:1160:28: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1160 | !(baci_icw & OUT_DCPC) && /* or under program control */ | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1161 | (baci_status & IN_FIFOIRQ) || /* and FIFO interrupt? */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_baci.c:1163:30: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1162 | (IO_MODE == RECV) && /* or receiving */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1163 | (baci_edsiw & OUT_ENCM) && /* and char mode */ | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1164 | (baci_fget != baci_fput)) { /* and FIFO not empty? */ | ~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_baci.c:1188:24: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1188 | ((IO_MODE == XMIT) && (baci_fcount < 128) || /* and xmit and room in FIFO */ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_baci.c: In function 'fifo_put': HP2100/hp2100_baci.c:1384:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1384 | if (DEBUG_PRI (baci_dev, DEB_BUF)) | ^ HP2100/hp2100_baci.c: In function 'clock_uart': HP2100/hp2100_baci.c:1450:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1450 | if ((baci_uart_clk & 017) == 0) /* end of a bit? */ | ^ HP2100/hp2100_baci.c:1476:35: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1475 | (baci_uart_clk == 8) && /* or last stop bit */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1476 | (baci_cfcw & OUT_STBITS) && /* and extra stop bit requested */ | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1477 | ((baci_cfcw & OUT_CHARSIZE) == 0))) { /* and 1.5 stop bits used? */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from HP2100/hp2100_mpx.c:141: HP2100/hp2100_mpx.c: In function 'mpx_io': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mpx.c:839:13: note: in expansion of macro 'setstdSKF' 839 | setstdSKF (mpx); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mpx.c:839:13: note: in expansion of macro 'setstdSKF' 839 | setstdSKF (mpx); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mpx.c:844:13: note: in expansion of macro 'setstdSKF' 844 | setstdSKF (mpx); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_mpx.c:844:13: note: in expansion of macro 'setstdSKF' 844 | setstdSKF (mpx); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_mpx.c:849:25: note: in expansion of macro 'IORETURN' 849 | stat_data = IORETURN (SCPE_OK, mpx_ibuf); /* return info */ | ^~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_mpx.c:935:13: note: in expansion of macro 'setstdPRL' 935 | setstdPRL (mpx); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_mpx.c:936:13: note: in expansion of macro 'setstdIRQ' 936 | setstdIRQ (mpx); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_mpx.c:937:13: note: in expansion of macro 'setstdSRQ' 937 | setstdSRQ (mpx); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_mpx.c: In function 'exec_command': HP2100/hp2100_mpx.c:1120:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 1120 | if (port >= 0) /* port defined? */ | ^~ HP2100/hp2100_mpx.c:1123:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 1123 | if ((buf_avail (ioread, port) == 1) && /* one buffer remaining? */ | ^~ HP2100/hp2100_mpx.c:1156:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1156 | if (port >= 0) /* port defined? */ | ^ HP2100/hp2100_mpx.c:1211:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 1211 | if (port >= 0) /* port defined? */ | ^~ HP2100/hp2100_mpx.c:1214:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 1214 | if (mpx_param & FC_FORCE_XON) /* force XON? */ | ^~ HP2100/hp2100_mpx.c:1254:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1254 | if (port >= 0) /* port defined? */ | ^ HP2100/hp2100_mpx.c: In function 'mpx_cntl_svc': HP2100/hp2100_mpx.c:1379:39: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1379 | mpx_ibuf = mpx_uicode & UI_REASON | mpx_portkey; /* report UI reason and port key */ | ^ HP2100/hp2100_mpx.c: In function 'mpx_line_svc': HP2100/hp2100_mpx.c:1787:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1787 | if (rt & RT_ENAB_EDIT) /* editing enabled? */ | ^ HP2100/hp2100_mpx.c:1929:41: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1929 | if ((buf_avail (iowrite, port) < 2) && /* more to transmit? */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1930 | !(mpx_flags [port] & (FL_WAITACK | FL_XOFF)) || /* and transmission not suspended */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_mpx.c: In function 'buf_get': HP2100/hp2100_mpx.c:2476:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 2476 | if (DEBUG_PRI (mpx_dev, DEB_BUF)) | ^ At top level: HP2100/hp2100_mpx.c:447:11: warning: 'FL_DO_ENQACK_V' defined but not used [-Wunused-const-variable=] 447 | BITFIELD (FL_DO_ENQACK, 0, 1) /* Port flags: do ENQ/ACK handshake */ | ^~~~~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:446:11: warning: 'FL_WAITACK_V' defined but not used [-Wunused-const-variable=] 446 | BITFIELD (FL_WAITACK, 1, 1) /* Port flags: ENQ sent, waiting for ACK */ | ^~~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:445:11: warning: 'FL_WREMPT_V' defined but not used [-Wunused-const-variable=] 445 | BITFIELD (FL_WREMPT, 2, 1) /* Port flags: write buffer is emptying */ | ^~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:444:11: warning: 'FL_WRFILL_V' defined but not used [-Wunused-const-variable=] 444 | BITFIELD (FL_WRFILL, 3, 1) /* Port flags: write buffer is filling */ | ^~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:443:11: warning: 'FL_RDEMPT_V' defined but not used [-Wunused-const-variable=] 443 | BITFIELD (FL_RDEMPT, 4, 1) /* Port flags: read buffer is emptying */ | ^~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:442:11: warning: 'FL_RDFILL_V' defined but not used [-Wunused-const-variable=] 442 | BITFIELD (FL_RDFILL, 5, 1) /* Port flags: read buffer is filling */ | ^~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:441:11: warning: 'FL_RDOVFLOW_V' defined but not used [-Wunused-const-variable=] 441 | BITFIELD (FL_RDOVFLOW, 6, 1) /* Port flags: read buffers overflowed */ | ^~~~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:440:11: warning: 'FL_WANTBUF_V' defined but not used [-Wunused-const-variable=] 440 | BITFIELD (FL_WANTBUF, 7, 1) /* Port flags: UI / write buffer available */ | ^~~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:439:11: warning: 'FL_HAVEBUF_V' defined but not used [-Wunused-const-variable=] 439 | BITFIELD (FL_HAVEBUF, 8, 1) /* Port flags: UI / read buffer available */ | ^~~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:438:11: warning: 'FL_BREAK_V' defined but not used [-Wunused-const-variable=] 438 | BITFIELD (FL_BREAK, 9, 1) /* Port flags: UI / break detected */ | ^~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:437:11: warning: 'FL_XOFF_V' defined but not used [-Wunused-const-variable=] 437 | BITFIELD (FL_XOFF, 10, 1) /* Port flags: XOFF stopped transmission */ | ^~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:436:11: warning: 'FL_ALERT_V' defined but not used [-Wunused-const-variable=] 436 | BITFIELD (FL_ALERT, 11, 1) /* Port flags: alert for terminate recv buffer */ | ^~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:432:11: warning: 'SK_ENQACK_V' defined but not used [-Wunused-const-variable=] 432 | BITFIELD (SK_ENQACK, 7, 1) /* Set key: disable or enable ENQ/ACK */ | ^~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:431:11: warning: 'SK_PARITY' defined but not used [-Wunused-const-variable=] 431 | BITFIELD (SK_PARITY, 8, 2) /* Set key: parity select */ | ^~~~~~~~~ HP2100/hp2100_mpx.c:168:25: note: in definition of macro 'BITFIELD' 168 | static const uint32 NAME = ((1 << (BITWIDTH)) - 1) << (STARTBIT); | ^~~~ HP2100/hp2100_mpx.c:431:11: warning: 'SK_PARITY_V' defined but not used [-Wunused-const-variable=] 431 | BITFIELD (SK_PARITY, 8, 2) /* Set key: parity select */ | ^~~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:430:11: warning: 'SK_STOPBITS' defined but not used [-Wunused-const-variable=] 430 | BITFIELD (SK_STOPBITS, 10, 2) /* Set key: stop bits */ | ^~~~~~~~~~~ HP2100/hp2100_mpx.c:168:25: note: in definition of macro 'BITFIELD' 168 | static const uint32 NAME = ((1 << (BITWIDTH)) - 1) << (STARTBIT); | ^~~~ HP2100/hp2100_mpx.c:429:11: warning: 'SK_BRG_V' defined but not used [-Wunused-const-variable=] 429 | BITFIELD (SK_BRG, 12, 1) /* Set key: baud rate generator 0/1 */ | ^~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ HP2100/hp2100_mpx.c:428:11: warning: 'SK_MODEM' defined but not used [-Wunused-const-variable=] 428 | BITFIELD (SK_MODEM, 13, 1) /* Set key: hardwired or modem */ | ^~~~~~~~ HP2100/hp2100_mpx.c:168:25: note: in definition of macro 'BITFIELD' 168 | static const uint32 NAME = ((1 << (BITWIDTH)) - 1) << (STARTBIT); | ^~~~ HP2100/hp2100_mpx.c:428:11: warning: 'SK_MODEM_V' defined but not used [-Wunused-const-variable=] 428 | BITFIELD (SK_MODEM, 13, 1) /* Set key: hardwired or modem */ | ^~~~~~~~ HP2100/hp2100_mpx.c:167:25: note: in definition of macro 'BITFIELD' 167 | static const uint32 NAME ## _V = STARTBIT; \ | ^~~~ In file included from HP2100/hp2100_pif.c:97: HP2100/hp2100_pif.c: In function 'pif_io': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_pif.c:251:17: note: in expansion of macro 'setstdSKF' 251 | setstdSKF (pif); /* card responds to SFC */ | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_pif.c:251:17: note: in expansion of macro 'setstdSKF' 251 | setstdSKF (pif); /* card responds to SFC */ | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_pif.c:257:17: note: in expansion of macro 'setstdSKF' 257 | setstdSKF (pif); /* card responds to SFS */ | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_pif.c:257:17: note: in expansion of macro 'setstdSKF' 257 | setstdSKF (pif); /* card responds to SFS */ | ^~~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_pif.c:302:17: note: in expansion of macro 'setstdPRL' 302 | setstdPRL (pif); /* set standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_pif.c:303:17: note: in expansion of macro 'setstdIRQ' 303 | setstdIRQ (pif); /* set standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:436:25: note: in expansion of macro 'setSRQ' 436 | #define setstdSRQ(N) setSRQ (dibptr->select_code, N.flag); | ^~~~~~ HP2100/hp2100_pif.c:304:17: note: in expansion of macro 'setstdSRQ' 304 | setstdSRQ (pif); /* set standard SRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_pif.c:308:17: note: in expansion of macro 'setPRL' 308 | setPRL (dibptr->select_code, !(pif.control | pif.flag)); | ^~~~~~ HP2100/hp2100_pif.c:309:46: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Wparentheses] 309 | setIRQ (dibptr->select_code, !pif.control & pif.flag & pif.flagbuf); | ^~~~~~~~~~~~ HP2100/hp2100_defs.h:424:77: note: in definition of macro 'setIRQ' 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_pif.c:309:17: note: in expansion of macro 'setIRQ' 309 | setIRQ (dibptr->select_code, !pif.control & pif.flag & pif.flagbuf); | ^~~~~~ In file included from HP2100/hp2100_di.c:100: HP2100/hp2100_di.c: In function 'di_io': HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_di.c:474:13: note: in expansion of macro 'setstdSKF' 474 | setstdSKF (di [card]); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_di.c:474:13: note: in expansion of macro 'setstdSKF' 474 | setstdSKF (di [card]); | ^~~~~~~~~ HP2100/hp2100_defs.h:431:51: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~ HP2100/hp2100_defs.h:360:49: note: in definition of macro 'IORETURN' 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_di.c:479:13: note: in expansion of macro 'setstdSKF' 479 | setstdSKF (di [card]); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_defs.h:421:37: note: in expansion of macro 'IORETURN' 421 | #define setSKF(B) stat_data = IORETURN (SCPE_OK, (uint16) ((B) ? ioSKF : ioNONE)) | ^~~~~~~~ HP2100/hp2100_defs.h:431:25: note: in expansion of macro 'setSKF' 431 | #define setstdSKF(N) setSKF ((signal == ioSFC) && !N.flag || \ | ^~~~~~ HP2100/hp2100_di.c:479:13: note: in expansion of macro 'setstdSKF' 479 | setstdSKF (di [card]); | ^~~~~~~~~ HP2100/hp2100_defs.h:360:52: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 360 | #define IORETURN(E,D) ((uint32) ((E) << 16 | (D) & DMASK)) /* form I/O handler return value */ | ^ HP2100/hp2100_di.c:530:25: note: in expansion of macro 'IORETURN' 530 | stat_data = IORETURN (SCPE_OK, data); /* merge in the return status */ | ^~~~~~~~ HP2100/hp2100_di.c:610:20: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 610 | if (FIFO_FULL) /* is the FIFO full? */ | ^ HP2100/hp2100_di.c:629:27: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 628 | di_card->status_register | ~~~~~~~~~~~~~~~~~~~~~~~~ 629 | & ~(STAT_LSTN | STAT_TALK) /* clear listen and talk status */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from HP2100/hp2100_di.c:100: HP2100/hp2100_defs.h:423:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 423 | #define setPRL(S,B) dev_prl[(S)/32] = dev_prl[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:434:25: note: in expansion of macro 'setPRL' 434 | #define setstdPRL(N) setPRL (dibptr->select_code, !(N.control & N.flag)); | ^~~~~~ HP2100/hp2100_di.c:720:13: note: in expansion of macro 'setstdPRL' 720 | setstdPRL (di [card]); /* set the standard PRL signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:424:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 424 | #define setIRQ(S,B) dev_irq[(S)/32] = dev_irq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_defs.h:435:25: note: in expansion of macro 'setIRQ' 435 | #define setstdIRQ(N) setIRQ (dibptr->select_code, N.control & N.flag & N.flagbuf); | ^~~~~~ HP2100/hp2100_di.c:721:13: note: in expansion of macro 'setstdIRQ' 721 | setstdIRQ (di [card]); /* set the standard IRQ signal */ | ^~~~~~~~~ HP2100/hp2100_defs.h:425:59: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 425 | #define setSRQ(S,B) dev_srq[(S)/32] = dev_srq[(S)/32] & ~BIT_M (S) | (((B) & 1) << BIT_V (S)) | ^ HP2100/hp2100_di.c:723:13: note: in expansion of macro 'setSRQ' 723 | setSRQ (dibptr->select_code, /* set the SRQ signal if control and SRQ are set */ | ^~~~~~ HP2100/hp2100_di.c: In function 'di_set_address': HP2100/hp2100_di.c:838:35: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 838 | dptr->flags = dptr->flags & ~DEV_BUSADR /* store the new address in the device flags */ HP2100/hp2100_di.c:853:35: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 853 | uptr->flags = uptr->flags & ~UNIT_BUSADR /* the address is valid; change it */ HP2100/hp2100_di.c: In function 'di_bus_control': HP2100/hp2100_di.c:1117:32: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1117 | new_state = di [card].bus_cntl & ~deny | assert; /* set up the new control state */ | ~~~~~~~~~~~~~~~~~~~^~~~~~~ HP2100/hp2100_di.c: In function 'update_state': HP2100/hp2100_di.c:1455:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1455 | if (di_card->cntl_register & CNTL_LSTN) /* is the card a listener? */ | ^ HP2100/hp2100_di.c:1470:3: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1470 | && di_card->status_register & STAT_IRL /* and the input register is loaded, */ | ^ HP2100/hp2100_di.c:1485:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1485 | && di_card->cntl_register & CNTL_IRL /* and notification is wanted? */ | ^ HP2100/hp2100_di.c:1489:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1488 | || di_card->eor == SET /* or was the end of record seen */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1489 | && !(di_card->status_register & STAT_IRL) /* and the input register was unloaded? */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_di.c:1492:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1492 | && di_card->cntl_register & CNTL_CIC /* and the card is not controller? */ | ^ HP2100/hp2100_di.c:1495:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1495 | && di_card->cntl_register & CNTL_REN /* and notification is wanted? */ | ^ HP2100/hp2100_di.c:1498:5: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1498 | && di_card->cntl_register & CNTL_IFC) { /* and notification is wanted? */ | ^ HP2100/hp2100_di.c: In function 'fifo_unload': HP2100/hp2100_di.c:1816:21: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1816 | data = data & ~(DATA_ATN | DATA_EOI) /* substitute the ATN/EOI tag values */ | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_di.c:1870:33: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1870 | di_card->bus_cntl & ~BUS_ATN /* from the ATN tag value */ HP2100/hp2100_di.c:1874:29: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1874 | di_card->bus_cntl & ~BUS_EOI /* from the EOI tag value */ HP2100/hp2100_di.c:1859:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1859 | if (di_card->cntl_register & CNTL_TALK) /* is the card talking? */ | ^ HP2100/hp2100_di_da.c: In function 'da_boot': HP2100/hp2100_di_da.c:1218:9: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1218 | SR = SR & (IBL_OPT | IBL_DS_HEAD) /* set S to a reasonable value */ | ~~~^~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_di_da.c: In function 'da_bus_accept': HP2100/hp2100_di_da.c:1598:19: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1597 | if (if_state [unit] == read_wait /* if we're waiting for a send data secondary */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1598 | && message_address != 0x00 /* but it's not there */ | ^~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp2100_di_da.c:1741:16: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1741 | if (icd_cntlr [unit].length == 0) /* is this the last parameter? */ | ^ HP2100/hp2100_di_da.c:1790:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1790 | if (initiated && DEBUG_PRI (da_dev, DEB_RWSC)) | ^ HP2100/hp_disclib.c: In function 'dl_start_command': HP2100/hp_disclib.c:764:23: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 764 | if (props->unit_check && !uptr /* if the unit number is checked and is invalid */ | ~~~~~~~~~~~~~~~~~~^~~~~~~~ HP2100/hp_disclib.c: In function 'dl_load_unload': HP2100/hp_disclib.c:1566:9: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1566 | else if (!(sim_switches & SIM_SW_REST)) /* modify the flags only if not restoring */ | ^ HP2100/hp_disclib.c: In function 'start_write': HP2100/hp_disclib.c:1900:14: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1900 | || !verify && !(uptr->flags & UNIT_FMT)) /* or is formatting required but not enabled? */ | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ HP2100/hp_disclib.c: In function 'position_sector': HP2100/hp_disclib.c:2044:12: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 2044 | if (uptr->STAT & DL_S2SC) /* did a seek check occur? */ | ^ HP2100/hp_disclib.c: In function 'set_timer': HP2100/hp_disclib.c:2294:4: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 2294 | if (cvptr->type == MAC) /* is this a MAC controller? */ | ^ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection I1401/i1401_lp.c I1401/i1401_cpu.c I1401/i1401_iq.c I1401/i1401_cd.c I1401/i1401_mt.c I1401/i1401_dp.c I1401/i1401_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I I1401 -o BIN/i1401 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program I1401/i1401_cpu.c: In function 'sim_instr': I1401/i1401_cpu.c:550:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 550 | if (reason = sim_process_event ()) | ^~~~~~ I1401/i1401_cpu.c:1042:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1042 | if (reason = iomod (ilnt, D, r_mod)) /* valid modifier? */ | ^~~~~~ I1401/i1401_cpu.c:1052:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1052 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^~~~~~ I1401/i1401_cpu.c:1062:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1062 | if (reason = iomod (ilnt, D, p_mod)) /* valid modifier? */ | ^~~~~~ I1401/i1401_cpu.c:1072:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1072 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^~~~~~ I1401/i1401_cpu.c:1085:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1085 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^~~~~~ I1401/i1401_cpu.c:1098:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1098 | if (reason = iomod (ilnt, D, NULL)) /* valid modifier? */ | ^~~~~~ I1401/i1401_cpu.c:1111:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1111 | if (reason = iomod (ilnt, D, w_mod)) /* valid modifier? */ | ^~~~~~ I1401/i1401_cpu.c:1125:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1125 | if (reason = iomod (ilnt, D, ss_mod)) /* valid modifier? */ | ^~~~~~ I1401/i1401_cpu.c:1127:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1127 | if (reason = select_stack (D)) /* sel stack, error? */ | ^~~~~~ I1401/i1401_cpu.c:1135:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1135 | if (reason = carriage_control (D)) /* car ctrl, error? */ | ^~~~~~ I1401/i1401_cpu.c:1157:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1157 | else if (reason = iomod (ilnt, D, mtf_mod)) /* valid modifier? */ | ^~~~~~ I1401/i1401_iq.c: In function 'inq_io': I1401/i1401_iq.c:97:1: warning: "/*" within comment [-Wcomment] 97 | /* return SCPE_OK; /* return if no req */ | I1401/i1401_iq.c:97:57: warning: "/*" within comment [-Wcomment] sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ I1401/i1401_cd.c: In function 'read_card': I1401/i1401_cd.c:187:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 187 | if (r = cdr_svc (&cdr_unit)) /* process */ | ^ I1401/i1401_mt.c: In function 'mt_reset': I1401/i1401_mt.c:454:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 454 | if (uptr = mt_sel_unit (i)) { | ^~~~ I1401/i1401_dp.c: In function 'dp_io': I1401/i1401_dp.c:272:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 272 | if (r = dp_rdsec (uptr, psec, flg, qwc)) /* read sector */ | ^ I1401/i1401_dp.c:281:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 281 | if (r = dp_nexsec (uptr, psec, dcf)) /* find next */ | ^ I1401/i1401_dp.c:292:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 292 | if (r = dp_rdadr (uptr, psec, flg, qwc)) /* read addr */ | ^ I1401/i1401_dp.c:294:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 294 | if (r = dp_rdsec (uptr, psec, flg, qwc)) /* read data */ | ^ I1401/i1401_dp.c:315:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 315 | if (r = dp_wrsec (uptr, psec, flg)) /* write data */ | ^ I1401/i1401_dp.c:321:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 321 | if (r = dp_nexsec (uptr, psec, dcf)) /* find next */ | ^ I1401/i1401_dp.c:334:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 334 | if (r = dp_wradr (uptr, psec, flg)) /* write addr */ | ^ I1401/i1401_dp.c:336:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 336 | if (r = dp_wrsec (uptr, psec, flg)) /* write data */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ I1401/i1401_cpu.c:225:15: warning: type of 'select_stack' does not match original declaration [-Wlto-type-mismatch] 225 | extern t_stat select_stack (int32 mod); | ^ I1401/i1401_cd.c:359:8: note: type mismatch in parameter 2 359 | t_stat select_stack (int32 ilnt, int32 mod) | ^ I1401/i1401_cd.c:359:8: note: type 'int32' should match type 'void' I1401/i1401_cd.c:359:8: note: 'select_stack' was previously declared here gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection I1620/i1620_cd.c I1620/i1620_dp.c I1620/i1620_pt.c I1620/i1620_tty.c I1620/i1620_cpu.c I1620/i1620_lp.c I1620/i1620_fp.c I1620/i1620_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I I1620 -o BIN/i1620 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program I1620/i1620_cd.c:113:1: warning: "/*" within comment [-Wcomment] 113 | /* Card reader (ASCII) to numeric (one digit) */ | I1620/i1620_cd.c: In function 'cdr': I1620/i1620_cd.c:245:37: warning: array subscript has type 'char' [-Wchar-subscripts] 245 | cdc = cdr_to_num[cdr_buf[i]]; /* translate */ | ~~~~~~~^~~ I1620/i1620_cd.c:262:37: warning: array subscript has type 'char' [-Wchar-subscripts] 262 | cdc = cdr_to_alp[cdr_buf[i]]; /* translate */ | ~~~~~~~^~~ I1620/i1620_dp.c: In function 'dp': I1620/i1620_dp.c:209:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 209 | if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read sector */ | ^ I1620/i1620_dp.c:219:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 219 | if (r = dp_rdadr (uptr, psec, qnr, qwc)) /* read addr */ | ^ I1620/i1620_dp.c:221:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 221 | if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read data */ | ^ I1620/i1620_dp.c:234:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 234 | if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */ | ^ I1620/i1620_dp.c:236:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 236 | if (r = dp_wrsec (uptr, psec, qnr)) /* write data */ | ^ I1620/i1620_dp.c:248:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 248 | if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */ | ^ I1620/i1620_dp.c:250:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 250 | if (r = dp_wradr (uptr, psec, qnr)) /* write addr */ | ^ I1620/i1620_dp.c:252:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 252 | if (r = dp_wrsec (uptr, psec, qnr)) /* write data */ | ^ I1620/i1620_tty.c: In function 'tti_rnum': I1620/i1620_tty.c:263:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 263 | else if (cp = strchr (tti_to_num, raw)) /* legal? */ | ^~ I1620/i1620_cpu.c: In function 'sim_instr': I1620/i1620_cpu.c:479:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 479 | if (reason = sim_process_event ()) | ^~~~~~ I1620/i1620_sys.c: In function 'parse_sym': I1620/i1620_sys.c:487:23: warning: array subscript has type 'char' [-Wchar-subscripts] 487 | t = cdr_to_alp[t]; /* convert */ | ^ I1620/i1620_sys.c:505:23: warning: array subscript has type 'char' [-Wchar-subscripts] 505 | t = cdr_to_alp[t]; /* convert */ | ^ I1620/i1620_sys.c:555:8: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 555 | while (t = *fptr++) { /* loop through */ | ^ I1620/i1620_sys.c:569:8: warning: array subscript has type 'char' [-Wchar-subscripts] 569 | val[t] = val[t] | FLAG; /* set flag */ | ^ I1620/i1620_sys.c:569:17: warning: array subscript has type 'char' [-Wchar-subscripts] 569 | val[t] = val[t] | FLAG; /* set flag */ | ^ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection S3/s3_cd.c S3/s3_cpu.c S3/s3_disk.c S3/s3_lp.c S3/s3_pkb.c S3/s3_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I S3 -o BIN/s3 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection ALTAIR/altair_sio.c ALTAIR/altair_cpu.c ALTAIR/altair_dsk.c ALTAIR/altair_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I ALTAIR -o BIN/altair -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program S3/s3_cd.c: In function 'read_card': S3/s3_cd.c:283:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 283 | if (r = cdr_svc (&cdr_unit)) return r; /* process */ | ^ S3/s3_cd.c:328:39: warning: array subscript has type 'char' [-Wchar-subscripts] 328 | rbuf[i] = ascii_to_ebcdic[rbuf[i]]; /* convert to EBCDIC */ | ~~~~^~~ S3/s3_cd.c: In function 'cdr_svc': S3/s3_cd.c:349:63: warning: array subscript has type 'char' [-Wchar-subscripts] 349 | for (i = 0; i < CDR_WIDTH; i++) rbuf[i] = ebcdic_to_ascii[rbuf[i]]; | ~~~~^~~ S3/s3_cpu.c: In function 'sim_instr': S3/s3_cpu.c:530:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 530 | if (reason = sim_process_event ()) break; | ^~~~~~ ALTAIR/altair_cpu.c: In function 'sim_instr': ALTAIR/altair_cpu.c:316:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 316 | if (reason = sim_process_event ()) break; | ^~~~~~ ALTAIR/altair_cpu.c:369:37: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 369 | DAR = DAR | (M[PC] <<8) & 0xFF00;; | ~~~~~~~~~~~~^~~~~~~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ ALTAIR/altair_dsk.c: In function 'dsk12': ALTAIR/altair_dsk.c:313:18: warning: variable 'rtn' set but not used [-Wunused-but-set-variable] 313 | static int32 rtn, i; | ^~~ ALTAIR/altair_dsk.c: In function 'writebuf': ALTAIR/altair_dsk.c:353:11: warning: variable 'rtn' set but not used [-Wunused-but-set-variable] 353 | int32 rtn, i; | ^~~ S3/s3_disk.c: In function 'dsk': S3/s3_disk.c:203:11: warning: variable 'F' set but not used [-Wunused-but-set-variable] 203 | int32 F, C, S, N, usave; | ^ ALTAIR/altair_sys.c: In function 'fprint_sym': ALTAIR/altair_sys.c:186:7: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] 186 | int32 cflag, c1, c2, inst, adr; | ^~~~~ ALTAIR/altair_sys.c: In function 'parse_sym': ALTAIR/altair_sys.c:234:7: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] 234 | int32 cflag, i = 0, j, r; | ^~~~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ S3/s3_sys.c:124:27: warning: missing braces around initializer [-Wmissing-braces] 124 | struct opdef opcode[75] = { | ^ 125 | "HPL", 0x00,0,0,0, /* Halt Program Level */ | { } 126 | "A", 0x06,0,1,3, /* Add to Register: A R,AADD */ | { } 127 | "ST", 0x04,0,1,3, /* Store Register */ | { } 128 | "L", 0x05,0,1,3, /* Load Register */ | { } 129 | "LA", 0x02,0,1,1, /* Load Address */ | { } 130 | "ZAZ", 0x04,0,2,2, /* Zero and Add Zoned */ | { } 131 | "AZ", 0x06,0,2,2, /* Add Zoned Decimal */ | { } 132 | "SZ", 0x07,0,2,2, /* Subtract Zoned Decimal */ | { } 133 | "ALC", 0x0E,0,2,2, /* Add Logical: ALC BADD,AADD,LEN */ | { } 134 | "SLC", 0x0F,0,2,2, /* Sub Logical: SLC BADD,AADD,LEN */ | { } 135 | "MVC", 0x0C,0,2,2, /* Move Chars MVX BADD,AADD,LEN */ | { } 136 | "ED", 0x0A,0,2,2, /* Edit: ED BADD,AADD,LEN */ | { } 137 | "ITC", 0x0B,0,2,2, /* Insert Chars: ITC BADD,AADD,LEN */ | { } 138 | "CLC", 0x0D,0,2,2, /* Compare Logical: CLC BADD,AADD,LEN */ | { } 139 | "MVI", 0x0C,0,3,3, /* Move Immediate */ | { } 140 | "SBN", 0x0A,0,3,3, /* Set Bits On */ | { } 141 | "SBF", 0x0B,0,3,3, /* Set Bits Off */ | { } 142 | "CLI", 0x0D,0,3,3, /* Compare Immediate */ | { } 143 | "TBN", 0x08,0,3,3, /* Test Bits On */ | { } 144 | "TBF", 0x09,0,3,3, /* Test Bits Off */ | { } 145 | "APL", 0x01,0,4,0, /* Advance Program Level */ | { } 146 | "SIO", 0x03,0,5,0, /* Start I/O */ | { } 147 | "SNS", 0x00,0,6,3, /* Sense I/O */ | { } 148 | "LIO", 0x01,0,6,3, /* Load I/O */ | { } 149 | "TIO", 0x01,0,6,1, /* Test I/O */ | { } 150 | "J", 0x02,0,7,0, /* Jump Unconditional */ | { } 151 | "J", 0x02,0x87,7,0, /* Alternate J */ | { } 152 | "JH", 0x02,132,7,0, /* Jump if High */ | { } 153 | "JL", 0x02,130,7,0, /* Jump if Low */ | { } 154 | "JE", 0x02,129,7,0, /* Jump if Equal */ | { } 155 | "JNH", 0x02,4,7,0, /* Jump if Not High */ | { } 156 | "JNL", 0x02,2,7,0, /* Jump if Not Low */ | { } 157 | "JNE", 0x02,1,7,0, /* Jump if Not Equal */ | { } 158 | "JOZ", 0x02,136,7,0, /* Jump if Overflow Zoned */ | { } 159 | "JOL", 0x02,160,7,0, /* Jump if Overflow Logical */ | { } 160 | "JNOZ", 0x02,8,7,0, /* Jump if No Overflow Zoned */ | { } 161 | "JNOL", 0x02,32,7,0, /* Jump if No Overflow Logical */ | { } 162 | "JT", 0x02,16,7,0, /* Jump if True */ | { } 163 | "JF", 0x02,144,7,0, /* Jump if False */ | { } 164 | "JP", 0x02,132,7,0, /* Jump if Plus */ | { } 165 | "JM", 0x02,130,7,0, /* Jump if Minus */ | { } 166 | "JZ", 0x02,129,7,0, /* Jump if Zero */ | { } 167 | "JNP", 0x02,4,7,0, /* Jump if Not Plus */ | { } 168 | "JNM", 0x02,2,7,0, /* Jump if Not Minus */ | { } 169 | "JNZ", 0x02,1,7,0, /* Jump if Not Zero */ | { } 170 | "NOPJ", 0x02,0x80,7,0, /* Never Jump - NOP */ | { } 171 | "B", 0x00,0x00,8,1, /* Branch Unconditional */ | { } 172 | "B", 0x00,0x87,8,1, /* Alternate B */ | { } 173 | "BH", 0x00,0x84,8,1, /* Branch if High */ | { } 174 | "BL", 0x00,0x82,8,1, /* Branch if Low */ | { } 175 | "BE", 0x00,0x81,8,1, /* Branch if Equal */ | { } 176 | "BNH", 0x00,0x04,8,1, /* Branch if Not High */ | { } 177 | "BNL", 0x00,0x02,8,1, /* Branch if Not Low */ | { } 178 | "BNE", 0x00,0x01,8,1, /* Branch if Not Equal */ | { } 179 | "BOZ", 0x00,0x88,8,1, /* Branch if Overflow Zoned */ | { } 180 | "BOL", 0x00,0xA0,8,1, /* Branch if Overflow Logical */ | { } 181 | "BNOZ", 0x00,0x08,8,1, /* Branch if No Overflow Zoned */ | { } 182 | "BNOL", 0x00,0x20,8,1, /* Branch if No Overflow Logical */ | { } 183 | "BT", 0x00,0x10,8,1, /* Branch if True */ | { } 184 | "BF", 0x00,0x90,8,1, /* Branch if False */ | { } 185 | "BP", 0x00,0x84,8,1, /* Branch if Plus */ | { } 186 | "BM", 0x00,0x82,8,1, /* Branch if Minus */ | { } 187 | "BZ", 0x00,0x81,8,1, /* Branch if Zero */ | { } 188 | "BNP", 0x00,0x04,8,1, /* Branch if Not Plus */ | { } 189 | "BNM", 0x00,0x02,8,1, /* Branch if Not Minus */ | { } 190 | "BNZ", 0x00,0x01,8,1, /* Branch if Not Zero */ | { } 191 | "NOPB", 0x00,0x80,8,1, /* Never Branch - NOP */ | { } 192 | "MZZ", 0x08,0,9,2, /* Move Zone to Zone */ | { } 193 | "MNZ", 0x08,1,9,2, /* Move Numeric to Zone */ | { } 194 | "MZN", 0x08,2,9,2, /* Move Zone to Numeric */ | { } 195 | "MNN", 0x08,3,9,2, /* Move Numeric to Numeric */ | { } 196 | "MVX", 0x08,0,2,2, /* Move Hex: MVX BADD,AADD,CODE */ | { } 197 | "JC", 0x02,0,3,0, /* Jump on Specified Condition bits */ | { } 198 | "BC", 0x00,0,3,1, /* Branch on Specified Condition */ | { } 199 | "***", 0x00,0,0,0 | { 200 | }; | } S3/s3_sys.c: In function 'printf_sym': S3/s3_sys.c:273:7: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] 273 | int32 cflag, c1, c2, group, len1, len2, inst, aaddr, baddr; | ^~~~~ S3/s3_sys.c: In function 'parse_sym': S3/s3_sys.c:507:7: warning: variable 'cflag' set but not used [-Wunused-but-set-variable] 507 | int32 cflag, i = 0, j, r, oplen, addtyp, saveaddr, vptr; | ^~~~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection AltairZ80/altairz80_cpu.c AltairZ80/altairz80_cpu_nommu.c AltairZ80/altairz80_dsk.c AltairZ80/disasm.c AltairZ80/altairz80_sio.c AltairZ80/altairz80_sys.c AltairZ80/altairz80_hdsk.c AltairZ80/altairz80_net.c AltairZ80/flashwriter2.c AltairZ80/i86_decode.c AltairZ80/i86_ops.c AltairZ80/i86_prim_ops.c AltairZ80/i8272.c AltairZ80/insnsd.c AltairZ80/mfdc.c AltairZ80/n8vem.c AltairZ80/vfdhd.c AltairZ80/s100_disk1a.c AltairZ80/s100_disk2.c AltairZ80/s100_disk3.c AltairZ80/s100_fif.c AltairZ80/s100_mdriveh.c AltairZ80/s100_mdsad.c AltairZ80/s100_selchan.c AltairZ80/s100_ss1.c AltairZ80/s100_64fdc.c AltairZ80/s100_scp300f.c AltairZ80/sim_imd.c AltairZ80/wd179x.c AltairZ80/s100_hdc1001.c AltairZ80/s100_if3.c AltairZ80/s100_adcs6.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I AltairZ80 -o BIN/altairz80 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program AltairZ80/altairz80_cpu.c: In function 'sim_instr_mmu': AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1975:17: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1975 | CHECK_BREAK_TWO_BYTES_EXTENDED(SP - 2, SP - 1, (timerInterrupt = TRUE, IFF_S |= 1)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1991:17: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1991 | CHECK_BREAK_TWO_BYTES_EXTENDED(SP - 2, SP - 1, (keyboardInterrupt = TRUE, IFF_S |= 1)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:2281:17: note: in expansion of macro 'CHECK_BREAK_WORD' 2281 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:2369:17: note: in expansion of macro 'CHECK_BREAK_WORD' 2369 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection GRI/gri_cpu.c GRI/gri_stddev.c GRI/gri_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I GRI -o BIN/gri -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3467:21: note: in expansion of macro 'CHECK_BREAK_WORD' 3467 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3476:17: note: in expansion of macro 'CHECK_BREAK_WORD' 3476 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' 118 | CHECK_BREAK_WORD(SP - 2); \ | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3491:17: note: in expansion of macro 'CALLC' 3491 | CALLC(!TSTFLAG(Z)); /* also updates tStates */ | ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3496:17: note: in expansion of macro 'CHECK_BREAK_WORD' 3496 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3512:17: note: in expansion of macro 'CHECK_BREAK_WORD' 3512 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3520:21: note: in expansion of macro 'CHECK_BREAK_WORD' 3520 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3533:17: note: in expansion of macro 'CHECK_BREAK_WORD' 3533 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' 118 | CHECK_BREAK_WORD(SP - 2); \ | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3712:17: note: in expansion of macro 'CALLC' 3712 | CALLC(TSTFLAG(Z)); /* also updates tStates */ | ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' 118 | CHECK_BREAK_WORD(SP - 2); \ | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3716:17: note: in expansion of macro 'CALLC' 3716 | CALLC(1); /* also updates tStates */ | ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3731:17: note: in expansion of macro 'CHECK_BREAK_WORD' 3731 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3743:21: note: in expansion of macro 'CHECK_BREAK_WORD' 3743 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3752:17: note: in expansion of macro 'CHECK_BREAK_WORD' 3752 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' 118 | CHECK_BREAK_WORD(SP - 2); \ | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3768:17: note: in expansion of macro 'CALLC' 3768 | CALLC(!TSTFLAG(C)); /* also updates tStates */ | ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3773:17: note: in expansion of macro 'CHECK_BREAK_WORD' 3773 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3789:17: note: in expansion of macro 'CHECK_BREAK_WORD' 3789 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3797:21: note: in expansion of macro 'CHECK_BREAK_WORD' 3797 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' 118 | CHECK_BREAK_WORD(SP - 2); \ | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3835:17: note: in expansion of macro 'CALLC' 3835 | CALLC(TSTFLAG(C)); /* also updates tStates */ | ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3872:25: note: in expansion of macro 'CHECK_BREAK_WORD' 3872 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:3915:25: note: in expansion of macro 'CHECK_BREAK_WORD' 3915 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4575:25: note: in expansion of macro 'CHECK_BREAK_WORD' 4575 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4581:25: note: in expansion of macro 'CHECK_BREAK_WORD' 4581 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4589:25: note: in expansion of macro 'CHECK_BREAK_WORD' 4589 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4625:17: note: in expansion of macro 'CHECK_BREAK_WORD' 4625 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4637:21: note: in expansion of macro 'CHECK_BREAK_WORD' 4637 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4646:17: note: in expansion of macro 'CHECK_BREAK_WORD' 4646 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4657:17: note: in expansion of macro 'CHECK_BREAK_WORD' 4657 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' 118 | CHECK_BREAK_WORD(SP - 2); \ | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4664:17: note: in expansion of macro 'CALLC' 4664 | CALLC(!TSTFLAG(P)); /* also updates tStates */ | ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4669:17: note: in expansion of macro 'CHECK_BREAK_WORD' 4669 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4681:17: note: in expansion of macro 'CHECK_BREAK_WORD' 4681 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4689:21: note: in expansion of macro 'CHECK_BREAK_WORD' 4689 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' 118 | CHECK_BREAK_WORD(SP - 2); \ | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4721:17: note: in expansion of macro 'CALLC' 4721 | CALLC(TSTFLAG(P)); /* also updates tStates */ | ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4756:25: note: in expansion of macro 'CHECK_BREAK_WORD' 4756 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4798:25: note: in expansion of macro 'CHECK_BREAK_WORD' 4798 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4843:25: note: in expansion of macro 'CHECK_BREAK_WORD' 4843 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4851:25: note: in expansion of macro 'CHECK_BREAK_WORD' 4851 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4890:25: note: in expansion of macro 'CHECK_BREAK_WORD' 4890 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4935:25: note: in expansion of macro 'CHECK_BREAK_WORD' 4935 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:4980:25: note: in expansion of macro 'CHECK_BREAK_WORD' 4980 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5021:25: note: in expansion of macro 'CHECK_BREAK_WORD' 5021 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5063:25: note: in expansion of macro 'CHECK_BREAK_WORD' 5063 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5096:25: note: in expansion of macro 'CHECK_BREAK_WORD' 5096 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5103:25: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 5103 | CHECK_BREAK_TWO_BYTES(HL, DE); | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5165:25: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 5165 | CHECK_BREAK_TWO_BYTES(HL, DE); | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5224:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 5224 | CHECK_BREAK_TWO_BYTES(HL, DE); | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5295:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 5295 | CHECK_BREAK_TWO_BYTES(HL, DE); | ^~~~~~~~~~~~~~~~~~~~~ GRI/gri_cpu.c: In function 'sim_instr': GRI/gri_cpu.c:424:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 424 | if (reason = sim_process_event ()) | ^~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5373:17: note: in expansion of macro 'CHECK_BREAK_WORD' 5373 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5385:21: note: in expansion of macro 'CHECK_BREAK_WORD' 5385 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5394:17: note: in expansion of macro 'CHECK_BREAK_WORD' 5394 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' 118 | CHECK_BREAK_WORD(SP - 2); \ | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5410:17: note: in expansion of macro 'CALLC' 5410 | CALLC(!TSTFLAG(S)); /* also updates tStates */ | ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5415:17: note: in expansion of macro 'CHECK_BREAK_WORD' 5415 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5427:17: note: in expansion of macro 'CHECK_BREAK_WORD' 5427 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5435:21: note: in expansion of macro 'CHECK_BREAK_WORD' 5435 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:118:9: note: in expansion of macro 'CHECK_BREAK_WORD' 118 | CHECK_BREAK_WORD(SP - 2); \ | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5464:17: note: in expansion of macro 'CALLC' 5464 | CALLC(TSTFLAG(S)); /* also updates tStates */ | ^~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5501:25: note: in expansion of macro 'CHECK_BREAK_WORD' 5501 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:5544:25: note: in expansion of macro 'CHECK_BREAK_WORD' 5544 | CHECK_BREAK_WORD(temp); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:6204:25: note: in expansion of macro 'CHECK_BREAK_WORD' 6204 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:6210:25: note: in expansion of macro 'CHECK_BREAK_WORD' 6210 | CHECK_BREAK_WORD(SP); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:6218:25: note: in expansion of macro 'CHECK_BREAK_WORD' 6218 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1810:45: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 1810 | if ((brl == TRUE) || (brl == FALSE) && (sim_brk_lookup((a2) \ | ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 1811 | & 0xffff, SWMASK('M')) == TRUE)) { \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1820:39: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES_EXTENDED' 1820 | #define CHECK_BREAK_TWO_BYTES(a1, a2) CHECK_BREAK_TWO_BYTES_EXTENDED(a1, a2,;) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:1822:29: note: in expansion of macro 'CHECK_BREAK_TWO_BYTES' 1822 | #define CHECK_BREAK_WORD(a) CHECK_BREAK_TWO_BYTES(a, (a + 1)) | ^~~~~~~~~~~~~~~~~~~~~ AltairZ80/altairz80_cpu.c:6256:13: note: in expansion of macro 'CHECK_BREAK_WORD' 6256 | CHECK_BREAK_WORD(SP - 2); | ^~~~~~~~~~~~~~~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection I7094/i7094_cpu.c I7094/i7094_cpu1.c I7094/i7094_io.c I7094/i7094_cd.c I7094/i7094_clk.c I7094/i7094_com.c I7094/i7094_drm.c I7094/i7094_dsk.c I7094/i7094_sys.c I7094/i7094_lp.c I7094/i7094_mt.c I7094/i7094_binloader.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -DUSE_INT64 -I I7094 -o BIN/i7094 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program I7094/i7094_cpu.c: In function 'sim_instr': I7094/i7094_cpu.c:667:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 667 | if (reason = sim_process_event ()) /* process events */ | ^~~~~~ I7094/i7094_cpu.c:674:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 674 | if (reason = ch_proc (i)) | ^~~~~~ I7094/i7094_cpu.c:1976:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1976 | if (r = sim_process_event ()) /* process events */ | ^ I7094/i7094_cpu.c:1982:33: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1982 | if (r = ch_proc (j)) | ^ I7094/i7094_cpu.c: In function 'cpu_fprint_one_inst': I7094/i7094_cpu.c:2441:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 2441 | else if (ch = HIST_CH (pc)) { /* channel? */ | ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection Interdata/id16_cpu.c Interdata/id16_sys.c Interdata/id_dp.c Interdata/id_fd.c Interdata/id_fp.c Interdata/id_idc.c Interdata/id_io.c Interdata/id_lp.c Interdata/id_mt.c Interdata/id_pas.c Interdata/id_pt.c Interdata/id_tt.c Interdata/id_uvc.c Interdata/id16_dboot.c Interdata/id_ttp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I Interdata -o BIN/id16 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program Interdata/id16_cpu.c: In function 'sim_instr': Interdata/id16_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 607 | if (reason = sim_process_event ()) | ^~~~~~ I7094/i7094_io.c: In function 'ch_op_start': I7094/i7094_io.c:798:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 798 | if (r = ch9_wr (ch, ir, 0)) /* write to dev */ | ^ I7094/i7094_io.c: In function 'ch_proc': I7094/i7094_io.c:1006:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1006 | if (r = ch9_sel (ch, CHSL_SNS)) /* send sense to dev */ | ^ I7094/i7094_io.c:1022:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1022 | if (r = ch9_sel (ch, CHSL_RDS)) /* send read sel */ | ^ I7094/i7094_io.c:1028:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1028 | if (r = ch9_sel (ch, CHSL_WRS)) /* end write sel */ | ^ I7094/i7094_io.c:1038:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1038 | if (r = ch9_wr (ch, 0, CH9DF_STOP)) /* send stop */ | ^ I7094/i7094_io.c:1058:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1058 | else if (r = ch9_wr_getw (ch)) /* no, write */ | ^ I7094/i7094_io.c:1167:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1167 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ^ I7094/i7094_io.c:1177:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1177 | if (r = ch6_wr_getw (ch, FALSE)) /* send wd to dev; err? */ | ^ I7094/i7094_io.c:1187:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1187 | if (r = ch6_wr_getw (ch, FALSE)) /* send wd to dev; err? */ | ^ I7094/i7094_io.c:1196:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1196 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ^ I7094/i7094_io.c:1206:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1206 | if (r = ch6_wr_getw (ch, TRUE)) /* send wd to dev; err? */ | ^ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ Interdata/id16_sys.c: In function 'fprint_sym_m': Interdata/id16_sys.c:355:32: warning: variable 'vp' set but not used [-Wunused-but-set-variable] 355 | uint32 i, j, inst, r1, r2, ea, vp; | ^~ Interdata/id16_sys.c: In function 'parse_sym_m': Interdata/id16_sys.c:573:7: warning: variable 'st' set but not used [-Wunused-but-set-variable] 573 | int32 st, r1, r2; | ^~ I7094/i7094_cd.c: In function 'cdr_svc': I7094/i7094_cd.c:242:49: warning: array subscript has type 'char' [-Wchar-subscripts] 242 | else colbin = bcd_to_colbin[cdr_cbuf[col]]; /* cvt to col binary */ | ~~~~~~~~^~~~~ I7094/i7094_cd.c: In function 'cdp_card_end': I7094/i7094_cd.c:450:28: warning: array subscript has type 'char' [-Wchar-subscripts] 450 | cdp_cbuf[col] = pch[bcd]; /* -> ASCII */ | ^ GRI/gri_cpu.c:252:15: warning: type of 'tty_rd' does not match original declaration [-Wlto-type-mismatch] 252 | extern uint32 tty_rd (uint32 src); | ^ GRI/gri_stddev.c:212:8: note: type mismatch in parameter 1 212 | uint32 tty_rd (int32 src, int32 ea) | ^ GRI/gri_stddev.c:212:8: note: type 'int32' should match type 'uint32' GRI/gri_stddev.c:212:8: note: 'tty_rd' was previously declared here GRI/gri_cpu.c:248:15: warning: type of 'hsrp_rd' does not match original declaration [-Wlto-type-mismatch] 248 | extern uint32 hsrp_rd (uint32 src); | ^ GRI/gri_stddev.c:303:8: note: type mismatch in parameter 1 303 | uint32 hsrp_rd (int32 src, int32 ea) | ^ GRI/gri_stddev.c:303:8: note: type 'int32' should match type 'uint32' GRI/gri_stddev.c:303:8: note: 'hsrp_rd' was previously declared here Interdata/id_dp.c: In function 'dp_svc': Interdata/id_dp.c:422:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 422 | if (r = dp_rds (uptr)) /* read sec, err? */ | ^ Interdata/id_dp.c:441:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 441 | if (r = dp_wds (uptr)) /* write sec, err? */ | ^ Interdata/id_dp.c:396:8: warning: variable 't' set but not used [-Wunused-but-set-variable] 396 | uint32 t; | ^ I7094/i7094_com.c: In function 'com_show_oneq': I7094/i7094_com.c:1178:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1178 | if (entc = com_show_qsumm (st, lh, name)) { | ^~~~ Interdata/id_idc.c:99:57: warning: "/*" within comment [-Wcomment] 99 | /* 0x40 /* unused */ | Interdata/id_idc.c: In function 'idc_svc': Interdata/id_idc.c:579:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 579 | if (r = idc_rds (uptr)) /* read sec, err? */ | ^ Interdata/id_idc.c:598:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 598 | if (r = idc_wds (uptr)) /* write sec, err? */ | ^ Interdata/id_idc.c:506:8: warning: variable 't' set but not used [-Wunused-but-set-variable] 506 | uint32 t; | ^ Interdata/id_io.c: In function 'sch_set_nchan': Interdata/id_io.c:361:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 361 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru dev */ | ^~~~ Interdata/id_io.c: In function 'int_getdev': Interdata/id_io.c:442:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 442 | if (r = int_req[i] & int_enb[i]) { /* find nz int wd */ | ^ Interdata/id_io.c: In function 'devtab_init': Interdata/id_io.c:633:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 633 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^~~~ I7094/i7094_dsk.c: In function 'dsk_svc': I7094/i7094_dsk.c:696:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 696 | if (r = dsk_init_trk (udptr, trk)) { /* read track, err? */ | ^ I7094/i7094_dsk.c:703:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (r = dsk_xfer_done (uaptr, dtyp)) { /* transfer done? */ | ^ I7094/i7094_dsk.c:724:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 724 | if (r = dsk_init_trk (udptr, trk)) { /* read track, err? */ | ^ I7094/i7094_dsk.c:745:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 745 | if (r = dsk_xfer_done (uaptr, dtyp)) { /* transfer done? */ | ^ I7094/i7094_dsk.c:758:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 758 | if (r = dsk_wr_trk (udptr, trk)) /* write track; err? */ | ^ I7094/i7094_dsk.c:849:25: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 849 | if (r = dsk_wr_trk (udptr, trk + i)) /* wr track; err? */ | ^ Interdata/id_mt.c: In function 'mt_svc': Interdata/id_mt.c:371:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 371 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_bptr)) /* write, err? */ | ^~ Interdata/id_mt.c:377:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 377 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ Interdata/id_mt.c:405:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 405 | if (st = sim_tape_sprecr (uptr, &tbc)) /* skip rec rev, err? */ | ^~ I7094/i7094_lp.c: In function 'lpt_end_line': I7094/i7094_lp.c:333:24: warning: array subscript has type 'char' [-Wchar-subscripts] 333 | lpt_cbuf[col] = pch[bcd]; /* -> ASCII */ | ^ I7094/i7094_mt.c: In function 'mt_svc': I7094/i7094_mt.c:567:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 567 | if (r = mt_map_err (uptr, r)) /* map status */ | ^ I7094/i7094_mt.c: In function 'mt_rec_end': I7094/i7094_mt.c:739:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 739 | if (r = mt_map_err (uptr, r)) /* map error */ | ^ Interdata/id_pas.c: In function 'pasi_svc': Interdata/id_pas.c:337:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 337 | if (c = tmxr_getc_ln (&pas_ldsc[ln])) { /* any char? */ | ^ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ Interdata/id_ttp.c: In function 'ttp': Interdata/id_ttp.c:133:10: warning: variable 'old_cmd' set but not used [-Wunused-but-set-variable] 133 | int32 t, old_cmd; | ^~~~~~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection Interdata/id32_cpu.c Interdata/id32_sys.c Interdata/id_dp.c Interdata/id_fd.c Interdata/id_fp.c Interdata/id_idc.c Interdata/id_io.c Interdata/id_lp.c Interdata/id_mt.c Interdata/id_pas.c Interdata/id_pt.c Interdata/id_tt.c Interdata/id_uvc.c Interdata/id32_dboot.c Interdata/id_ttp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I Interdata -o BIN/id32 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program Interdata/id32_cpu.c: In function 'sim_instr': Interdata/id32_cpu.c:667:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 667 | if (reason = sim_process_event ()) | ^~~~~~ Interdata/id32_sys.c: In function 'parse_sym_m': Interdata/id32_sys.c:672:31: warning: variable 'vp' set but not used [-Wunused-but-set-variable] 672 | uint32 i, j, df, db, t, inst, vp; | ^~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ Interdata/id_dp.c: In function 'dp_svc': Interdata/id_dp.c:422:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 422 | if (r = dp_rds (uptr)) /* read sec, err? */ | ^ Interdata/id_dp.c:441:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 441 | if (r = dp_wds (uptr)) /* write sec, err? */ | ^ Interdata/id_dp.c:396:8: warning: variable 't' set but not used [-Wunused-but-set-variable] 396 | uint32 t; | ^ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ Interdata/id_idc.c:99:57: warning: "/*" within comment [-Wcomment] 99 | /* 0x40 /* unused */ | Interdata/id_idc.c: In function 'idc_svc': Interdata/id_idc.c:579:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 579 | if (r = idc_rds (uptr)) /* read sec, err? */ | ^ Interdata/id_idc.c:598:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 598 | if (r = idc_wds (uptr)) /* write sec, err? */ | ^ Interdata/id_idc.c:506:8: warning: variable 't' set but not used [-Wunused-but-set-variable] 506 | uint32 t; | ^ Interdata/id_io.c: In function 'sch_set_nchan': Interdata/id_io.c:361:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 361 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru dev */ | ^~~~ Interdata/id_io.c: In function 'int_getdev': Interdata/id_io.c:442:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 442 | if (r = int_req[i] & int_enb[i]) { /* find nz int wd */ | ^ Interdata/id_io.c: In function 'devtab_init': Interdata/id_io.c:633:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 633 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^~~~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ Interdata/id_mt.c: In function 'mt_svc': Interdata/id_mt.c:371:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 371 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_bptr)) /* write, err? */ | ^~ Interdata/id_mt.c:377:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 377 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ Interdata/id_mt.c:405:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 405 | if (st = sim_tape_sprecr (uptr, &tbc)) /* skip rec rev, err? */ | ^~ Interdata/id_pas.c: In function 'pasi_svc': Interdata/id_pas.c:337:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 337 | if (c = tmxr_getc_ln (&pas_ldsc[ln])) { /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ Interdata/id_ttp.c: In function 'ttp': Interdata/id_ttp.c:133:10: warning: variable 'old_cmd' set but not used [-Wunused-but-set-variable] 133 | int32 t, old_cmd; | ^~~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ /usr/bin/ld: /tmp/ccqLJE80.o (symbol from plugin): in function `intr': (.text+0x0): multiple definition of `intr'; /tmp/ccDpIZG4.o (symbol from plugin):(.text+0x0): first defined here /usr/bin/ld: /tmp/ccypYQ40.o (symbol from plugin): in function `aad_word': (.text+0x0): multiple definition of `intr'; /tmp/ccDpIZG4.o (symbol from plugin):(.text+0x0): first defined here scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ /usr/bin/ld: /tmp/ccjphbh3.o (symbol from plugin): in function `exit_cmd': (.text+0x0): multiple definition of `sim_vm_init'; /tmp/ccy2n4Y4.o (symbol from plugin):(.text+0x0): first defined here sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection SDS/sds_cpu.c SDS/sds_drm.c SDS/sds_dsk.c SDS/sds_io.c SDS/sds_lp.c SDS/sds_mt.c SDS/sds_mux.c SDS/sds_rad.c SDS/sds_stddev.c SDS/sds_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I SDS -o BIN/sds -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection LGP/lgp_cpu.c LGP/lgp_stddev.c LGP/lgp_sys.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I LGP -o BIN/lgp -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program LGP/lgp_cpu.c: In function 'sim_instr': LGP/lgp_cpu.c:291:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 291 | if (r = sim_process_event ()) | ^ LGP/lgp_cpu.c:311:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 311 | if (r = cpu_one_inst (oPC, IR)) { /* one instr; error? */ | ^ SDS/sds_cpu.c: In function 'sim_instr': SDS/sds_cpu.c:388:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 388 | if (reason = sim_process_event ()) /* process */ | ^~~~~~ SDS/sds_cpu.c:395:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 395 | if (reason = chan_process ()) /* process */ | ^~~~~~ SDS/sds_cpu.c: In function 'one_inst': SDS/sds_cpu.c:509:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 509 | if (r = Write (0, dat)) | ^ SDS/sds_cpu.c:528:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 528 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:530:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 530 | if (r = Read (va, &A)) /* get operand */ | ^ SDS/sds_cpu.c:535:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 535 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:537:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 537 | if (r = Read (va, &B)) /* get operand */ | ^ SDS/sds_cpu.c:542:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 542 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:544:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 544 | if (r = Read (va, &X)) /* get operand */ | ^ SDS/sds_cpu.c:549:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 549 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:551:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 551 | if (r = Write (va, A)) /* write operand */ | ^ SDS/sds_cpu.c:556:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 556 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:558:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 558 | if (r = Write (va, B)) /* write operand */ | ^ SDS/sds_cpu.c:563:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 563 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:565:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 565 | if (r = Write (va, X)) /* write operand */ | ^ SDS/sds_cpu.c:570:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 570 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:578:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 578 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:580:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 580 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:582:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 582 | if (r = Write (va, A)) /* write A */ | ^ SDS/sds_cpu.c:590:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 590 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:592:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 592 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:598:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 598 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:600:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 600 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:607:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 607 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:609:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 609 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:615:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 615 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:617:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 617 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:624:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 624 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:626:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 626 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:629:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 629 | if (r = Write (va, dat)) /* rewrite */ | ^ SDS/sds_cpu.c:634:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 634 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:636:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 636 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:639:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 639 | if (r = Write (va, dat)) /* rewrite */ | ^ SDS/sds_cpu.c:644:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 644 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:646:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 646 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:652:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 652 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:654:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 654 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:660:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 660 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:662:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 662 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:668:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 668 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:670:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 670 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:676:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 676 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:678:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 678 | if (r = Read (va, &dat)) /* get operand */ | ^ LGP/lgp_cpu.c: In function 'cpu_set_exec': LGP/lgp_cpu.c:747:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 747 | if (r = sim_process_event ()) | ^ SDS/sds_cpu.c:686:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 686 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:688:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:695:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 695 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:697:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 697 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:704:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 704 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:706:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 706 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:713:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 713 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:715:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 715 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:722:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 722 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:724:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 724 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:731:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 731 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:733:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 733 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:740:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 740 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:742:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 742 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:745:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 745 | if (r = Write (va, dat)) /* rewrite */ | ^ SDS/sds_cpu.c:752:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 752 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:754:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 754 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:777:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 777 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:779:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 779 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:786:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 786 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:788:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 788 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:795:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 795 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:799:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 799 | if (r = Read (va, &dat)) /* test dest access */ | ^ SDS/sds_cpu.c:807:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 807 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:813:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 813 | if (r = Write (va, dat)) /* write ret word */ | ^ SDS/sds_cpu.c:820:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 820 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:822:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 822 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:840:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 840 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:842:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 842 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:912:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 912 | if (r = EaSh (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:937:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 937 | if (r = EaSh (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:992:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 992 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:994:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 994 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:996:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 996 | if (r = op_miwy (inst, dat)) /* process inst */ | ^ SDS/sds_cpu.c:1005:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1005 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:1007:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1007 | if (r = op_wyim (inst, &dat)) /* process inst */ | ^ SDS/sds_cpu.c:1009:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1009 | if (r = Write (va, dat)) | ^ SDS/sds_cpu.c:1018:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1018 | if (r = op_eomd (inst)) /* process inst */ | ^ SDS/sds_cpu.c:1028:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1028 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:1030:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1030 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:1032:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1032 | if (r = op_pot (dat)) /* process inst */ | ^ SDS/sds_cpu.c:1041:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1041 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:1043:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1043 | if (r = op_pin (&dat)) /* process inst */ | ^ SDS/sds_cpu.c:1045:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1045 | if (r = Write (va, dat)) /* write result */ | ^ SDS/sds_cpu.c:1054:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1054 | if (r = op_sks (inst, &dat)) /* process inst */ | ^ SDS/sds_cpu.c: In function 'Ea': SDS/sds_cpu.c:1088:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1088 | if (r = Read (va, &wd)) /* read ind; fails? */ | ^ SDS/sds_cpu.c: In function 'EaSh': SDS/sds_cpu.c:1115:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1115 | if (r = Read (va, &wd)) /* read ind; fails? */ | ^ SDS/sds_cpu.c: In function 'ShfR48': SDS/sds_cpu.c:1344:39: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses] 1344 | B = ((B >> sc) | (A << (24 - sc)) & DMASK); SDS/sds_cpu.c: In function 'rtc_inst': SDS/sds_cpu.c:1572:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1572 | if (r = Ea (inst, &va)) /* decode eff addr */ | ^ SDS/sds_cpu.c:1574:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1574 | if (r = Read (va, &dat)) /* get operand */ | ^ SDS/sds_cpu.c:1577:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1577 | if (r = Write (va, dat)) /* rewrite */ | ^ LGP/lgp_stddev.c: In function 'ttr_svc': LGP/lgp_stddev.c:397:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 397 | if (r = read_reader (uptr, ttr_stopioe, (int32 *) &tti_buf)) | ^ LGP/lgp_stddev.c: In function 'ptr_svc': LGP/lgp_stddev.c:418:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 418 | if (r = read_reader (uptr, ptr_stopioe, &uptr->buf)) | ^ LGP/lgp_stddev.c: In function 'write_tto': LGP/lgp_stddev.c:551:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 551 | if (r = sim_putchar_s (ch)) /* write char */ | ^ LGP/lgp_sys.c: In function 'parse_sym': LGP/lgp_sys.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 366 | if (tptr = strchr (hex_decode, c)) | ^~~~ LGP/lgp_sys.c: In function 'parse_sym_m': LGP/lgp_sys.c:391:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 391 | if (tptr = strchr (opcode, gbuf[0])) | ^~~~ SDS/sds_dsk.c: In function 'dsk': SDS/sds_dsk.c:207:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 207 | if (r = dsk_read_buf (inst)) /* read sector */ | ^ SDS/sds_dsk.c:222:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 222 | if (r = dsk_write_buf (inst)) /* write sector */ | ^ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ SDS/sds_io.c: In function 'op_eomd': SDS/sds_io.c:339:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 339 | if (r = dev_dsp[dev][ch] (IO_CONN, inst, NULL)) /* connect */ | ^ SDS/sds_io.c: In function 'io_init': SDS/sds_io.c:961:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 961 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ SDS/sds_lp.c: In function 'lpt': SDS/sds_lp.c:180:24: warning: suggest parentheses around '&&' within '||' [-Wparentheses] 180 | (t == 004) && !lpt_err) /* 11062: !err */ | ~~~~~~~~~~~^~~~~~~~~~~ SDS/sds_mt.c: In function 'mt': SDS/sds_mt.c:238:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 238 | if (r = mt_wrend (inst)) /* end record */ | ^ SDS/sds_mt.c:245:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 245 | if (r = mt_wrend (inst)) /* end record */ | ^ SDS/sds_mux.c: In function 'muxi_svc': SDS/sds_mux.c:366:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 366 | if (c = tmxr_getc_ln (&mux_ldsc[ln])) { /* get char */ | ^ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ SDS/sds_stddev.c: In function 'ptp_svc': SDS/sds_stddev.c:398:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 398 | if (r = ptp_out (0)) | ^ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection H316/h316_stddev.c H316/h316_lp.c H316/h316_cpu.c H316/h316_sys.c H316/h316_mt.c H316/h316_fhd.c H316/h316_dp.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I H316 -o BIN/h316 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program H316/h316_stddev.c: In function 'pt_attach': H316/h316_stddev.c:393:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 393 | if (r = attach_unit (uptr, cptr)) | ^ H316/h316_cpu.c: In function 'sim_instr': H316/h316_cpu.c:427:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 427 | if (reason = sim_process_event ()) | ^~~~~~ H316/h316_cpu.c:461:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 461 | if (r = (t >> IOT_V_REASON)) | ^ H316/h316_cpu.c:531:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 531 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:540:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 540 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:551:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 551 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:557:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 557 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:567:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 567 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:573:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 573 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:586:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 586 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:599:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 599 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:608:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 608 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:618:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 618 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:627:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 627 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:635:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 635 | if (reason = Ea (MB & ~IDX, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:641:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 641 | if (reason = Ea (MB & ~IDX, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:649:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 649 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:660:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 660 | if (reason = Ea (MB, &Y)) /* eff addr */ | ^~~~~~ H316/h316_cpu.c:829:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 829 | if (reason = stop_inst) /* stop on undef? */ | ^~~~~~ H316/h316_cpu.c:862:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 862 | if (reason = stop_inst) /* stop on undef? */ | ^~~~~~ H316/h316_cpu.c:902:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 902 | if (reason = stop_inst) /* stop on undef? */ | ^~~~~~ H316/h316_cpu.c:938:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 938 | if (reason = stop_inst) /* stop on undef? */ | ^~~~~~ H316/h316_cpu.c:1006:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1006 | else if (reason = stop_inst) | ^~~~~~ H316/h316_cpu.c: In function 'devtab_init': H316/h316_cpu.c:1503:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1503 | for (i = 0; dptr = sim_devices[i]; i++) { /* loop thru devices */ | ^~~~ H316/h316_sys.c: In function 'parse_sym': H316/h316_sys.c:367:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 367 | if (k = (strcmp (gbuf, "C") == 0)) { /* C specified? */ | ^ H316/h316_sys.c:371:18: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 371 | else if (k = (strcmp (gbuf, "Z") == 0)) { /* Z specified? */ | ^ H316/h316_mt.c: In function 'mt_svc': H316/h316_mt.c:374:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 374 | if (st = sim_tape_wrtmk (uptr)) /* write tmk, err? */ | ^~ H316/h316_mt.c:379:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 379 | if (st = sim_tape_sprecf (uptr, &tbc)) /* space fwd, err? */ | ^~ H316/h316_mt.c:384:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 384 | if (st = sim_tape_sprecr (uptr, &tbc)) /* space rev, err? */ | ^~ H316/h316_mt.c:458:21: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 458 | if (st = sim_tape_wrrecf (uptr, mtxb, mt_ptr)) /* write, err? */ | ^~ H316/h316_fhd.c: In function 'fhdio': H316/h316_fhd.c:222:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 222 | if (((fnc == 000) && fhd_rdy) || /* 0 = skip if ready */ | ^~ H316/h316_fhd.c:228:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 228 | break; | ^~~~~ H316/h316_dp.c: In function 'dp_svc': H316/h316_dp.c:620:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 620 | if (r = dp_rdtrk (uptr, dpxb, uptr->CYL, h)) /* get track; error? */ | ^ H316/h316_dp.c:725:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 725 | if (r = dp_rdtrk (uptr, dpxb, uptr->CYL, h)) /* get track; error? */ | ^ H316/h316_dp.c:753:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 753 | if (r = dp_wrwd (uptr, dp_buf)) /* wr word, error? */ | ^ H316/h316_dp.c: In function 'dp_wrwd': H316/h316_dp.c:858:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 858 | if (r = dp_wrdone (uptr, STA_UNSER)) /* dump track */ | ^ H316/h316_dp.c: In function 'dp_setformat': H316/h316_dp.c:1020:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1020 | if (r = dp_wrtrk (uptr, tbuf, c, h)) | ^ H316/h316_dp.c: In function 'dp_showformat': H316/h316_dp.c:1046:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1046 | if (r = dp_rdtrk (uptr, tbuf, c, h)) | ^ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection swtp6800/common/mp-a.c swtp6800/common/m6800.c swtp6800/common/m6810.c swtp6800/common/bootrom.c swtp6800/common/dc-4.c swtp6800/common/mp-s.c swtp6800/swtp6800/mp-a_sys.c swtp6800/common/mp-b2.c swtp6800/common/mp-8m.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I swtp6800/swtp6800 -o BIN/swtp6800mp-a -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ swtp6800/common/m6800.c: In function 'sim_instr': swtp6800/common/m6800.c:319:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 319 | if (reason = sim_process_event ()) | ^~~~~~ swtp6800/common/m6800.c:318:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 318 | if (sim_interval <= 0) /* check clock queue */ | ^~ swtp6800/common/m6800.c:321:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 321 | if (mem_fault) { /* memory fault? */ | ^~ swtp6800/common/m6800.c: In function 'condevalVa': swtp6800/common/m6800.c:1895:18: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:39: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1893:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1893 | if (get_flag(CF)) | ^ swtp6800/common/m6800.c: In function 'condevalVs': swtp6800/common/m6800.c:1903:47: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] 1903 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || | ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1904:19: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] 1904 | ((op1 & 0x80 == 0) && (op2 & 0x80))); | ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1902:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1902 | if (get_flag(CF)) | ^ swtp6800/common/m6810.c: In function 'm6810_get_mbyte': swtp6800/common/m6810.c:114:21: warning: unused variable 'len' [-Wunused-variable] 114 | int32 val, org, len; | ^~~ swtp6800/common/m6810.c:114:16: warning: unused variable 'org' [-Wunused-variable] 114 | int32 val, org, len; | ^~~ swtp6800/common/bootrom.c: In function 'BOOTROM_config': swtp6800/common/bootrom.c:147:61: warning: suggest parentheses around '-' inside '<<' [-Wparentheses] 147 | BOOTROM_unit.capac = 0x200 << (val >> UNIT_V_MSIZE) - 1; /* set EPROM size */ | ~~~~~~~~~~~~~~~~~~~~~~^~~ swtp6800/common/bootrom.c: In function 'BOOTROM_reset': swtp6800/common/bootrom.c:166:12: warning: unused variable 'r' [-Wunused-variable] 166 | t_stat r; | ^ swtp6800/common/dc-4.c: In function 'fdcdrv': swtp6800/common/dc-4.c:371:10: warning: unused variable 'buf' [-Wunused-variable] 371 | char buf[128]; | ^~~ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ swtp6800/common/mp-8m.c: In function 'mp_8m_put_mbyte': swtp6800/common/mp-8m.c:180:21: warning: unused variable 'type' [-Wunused-variable] 180 | int32 org, len, type; | ^~~~ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ gcc -std=c99 -U__STRICT_ANSI__ -O2 -finline-functions -fgcse-after-reload -fpredictive-commoning -fipa-cp-clone -fno-unsafe-loop-optimizations -fno-strict-overflow -flto -fwhole-program -Wno-unused-result -I . -D_GNU_SOURCE -DUSE_READER_THREAD -DHAVE_DLOPEN=so -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fasynchronous-unwind-tables -fstack-clash-protection swtp6800/common/mp-a2.c swtp6800/common/m6800.c swtp6800/common/m6810.c swtp6800/common/bootrom.c swtp6800/common/dc-4.c swtp6800/common/mp-s.c swtp6800/swtp6800/mp-a2_sys.c swtp6800/common/mp-b2.c swtp6800/common/mp-8m.c swtp6800/common/i2716.c scp.c sim_console.c sim_fio.c sim_timer.c sim_sock.c sim_tmxr.c sim_ether.c sim_tape.c -I swtp6800/swtp6800 -o BIN/swtp6800mp-a2 -lm -lrt -lpthread -ldl -lpcap -flto -fwhole-program swtp6800/common/m6800.c: In function 'sim_instr': swtp6800/common/m6800.c:319:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 319 | if (reason = sim_process_event ()) | ^~~~~~ swtp6800/common/m6800.c:318:9: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 318 | if (sim_interval <= 0) /* check clock queue */ | ^~ swtp6800/common/m6800.c:321:13: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 321 | if (mem_fault) { /* memory fault? */ | ^~ swtp6800/common/m6800.c: In function 'condevalVa': swtp6800/common/m6800.c:1895:18: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1895:39: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] 1895 | (op1 & 0x80 == 0) && (op2 & 0x80 == 0))); | ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1893:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1893 | if (get_flag(CF)) | ^ swtp6800/common/m6800.c: In function 'condevalVs': swtp6800/common/m6800.c:1903:47: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] 1903 | COND_SET_FLAG_V(((op1 & 0x80) && (op2 & 0x80 == 0)) || | ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1904:19: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] 1904 | ((op1 & 0x80 == 0) && (op2 & 0x80))); | ^ swtp6800/common/m6800.c:106:9: note: in definition of macro 'COND_SET_FLAG_V' 106 | if (COND) SET_FLAG(VF); else CLR_FLAG(VF) | ^~~~ swtp6800/common/m6800.c:1902:8: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 1902 | if (get_flag(CF)) | ^ swtp6800/common/m6810.c: In function 'm6810_get_mbyte': swtp6800/common/m6810.c:114:21: warning: unused variable 'len' [-Wunused-variable] 114 | int32 val, org, len; | ^~~ swtp6800/common/m6810.c:114:16: warning: unused variable 'org' [-Wunused-variable] 114 | int32 val, org, len; | ^~~ swtp6800/common/bootrom.c: In function 'BOOTROM_config': swtp6800/common/bootrom.c:147:61: warning: suggest parentheses around '-' inside '<<' [-Wparentheses] 147 | BOOTROM_unit.capac = 0x200 << (val >> UNIT_V_MSIZE) - 1; /* set EPROM size */ | ~~~~~~~~~~~~~~~~~~~~~~^~~ swtp6800/common/bootrom.c: In function 'BOOTROM_reset': swtp6800/common/bootrom.c:166:12: warning: unused variable 'r' [-Wunused-variable] 166 | t_stat r; | ^ swtp6800/common/dc-4.c: In function 'fdcdrv': swtp6800/common/dc-4.c:371:10: warning: unused variable 'buf' [-Wunused-variable] 371 | char buf[128]; | ^~~ swtp6800/common/mp-8m.c: In function 'mp_8m_put_mbyte': swtp6800/common/mp-8m.c:180:21: warning: unused variable 'type' [-Wunused-variable] 180 | int32 org, len, type; | ^~~~ swtp6800/common/i2716.c: In function 'i2716_attach': swtp6800/common/i2716.c:124:23: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat=] 124 | printf("i2716%d: Unable to open ROM file %s\n", uptr - i2716_dev.units, uptr->filename); | ~^ ~~~~~~~~~~~~~~~~~~~~~~ | | | | int long int | %ld swtp6800/common/i2716.c: In function 'i2716_reset': swtp6800/common/i2716.c:154:12: warning: unused variable 'r' [-Wunused-variable] 154 | t_stat r; | ^ swtp6800/common/i2716.c:153:17: warning: unused variable 'c' [-Wunused-variable] 153 | int32 i, j, c, base; | ^ swtp6800/common/i2716.c:153:14: warning: unused variable 'j' [-Wunused-variable] 153 | int32 i, j, c, base; | ^ In file included from scp.c:189: sim_rev.h:363:1: warning: "/*" within comment [-Wcomment] 363 | /* V3.8 revision history | sim_rev.h:716:1: warning: "/*" within comment [-Wcomment] 716 | /* V3.7 revision history | sim_rev.h:988:1: warning: "/*" within comment [-Wcomment] 988 | /* V3.6 revision history | sim_rev.h:1162:1: warning: "/*" within comment [-Wcomment] 1162 | /* V3.5 revision history | sim_rev.h:1298:1: warning: "/*" within comment [-Wcomment] 1298 | /* V3.4 revision history | sim_rev.h:1336:1: warning: "/*" within comment [-Wcomment] 1336 | /* V3.3 revision history | sim_rev.h:1588:1: warning: "/*" within comment [-Wcomment] 1588 | /* V3.2 revision history | sim_rev.h:1787:1: warning: "/*" within comment [-Wcomment] 1787 | /* V3.1 revision history | sim_rev.h:1900:1: warning: "/*" within comment [-Wcomment] 1900 | /* V3.0 revision history | sim_rev.h:2066:1: warning: "/*" within comment [-Wcomment] 2066 | /* V2.10 revision history | sim_rev.h:2364:1: warning: "/*" within comment [-Wcomment] 2364 | /* V2.9 revision history | scp.c: In function 'main': scp.c:681:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 681 | if (np = match_ext (nbuf, "EXE")) /* remove .exe */ | ^~ scp.c:688:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 688 | if (cptr = sim_brk_getact (cbuf, CBUFSIZE)) /* pending action? */ | ^~~~ scp.c:703:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 703 | if (cmdp = find_cmd (gbuf)) /* lookup command */ | ^~~~ scp.c: In function 'help_cmd': scp.c:770:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 770 | if (cmdp = find_cmd (gbuf)) { | ^~~~ scp.c: In function 'do_cmd': scp.c:914:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 914 | if (cmdp = find_cmd (gbuf)) { /* lookup command */ | ^~~~ scp.c: In function 'set_cmd': scp.c:1094:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1094 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1099:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1099 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1105:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1105 | else if (gcmdp = find_ctab (set_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1113:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1113 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1126:29: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1126 | if (cvptr = strchr (gbuf, '=')) | ^~~~~ scp.c:1159:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1159 | if (glbr = find_c1tab (ctbr, gbuf)) { /* global match? */ | ^~~~ scp.c: In function 'show_cmd_fi': scp.c:1352:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1352 | if (shptr = find_shtab (show_glob_tab, gbuf)) /* global? */ | ^~~~~ scp.c:1355:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1355 | if (dptr = find_dev (gbuf)) { /* device match? */ | ^~~~ scp.c:1360:10: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1360 | else if (dptr = find_unit (gbuf, &uptr)) { /* unit match? */ | ^~~~ scp.c:1380:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1380 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ scp.c:1399:13: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1399 | if (shptr = find_shtab (shtb, gbuf)) /* global match? */ | ^~~~~ scp.c: In function 'ssh_break': scp.c:1803:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 1803 | if (aptr = strchr (cptr, ';')) { /* ;action? */ | ^~~~ scp.c: In function 'get_ipaddr': scp.c:3702:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3702 | if (portp = strchr (gbuf, ':')) /* x:y? split */ | ^~~~~ scp.c: In function 'find_unit': scp.c:3785:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3785 | if (dptr = find_dev (cptr)) { /* exact match? */ | ^~~~ scp.c: In function 'find_reg_glob': scp.c:3865:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 3865 | if (rptr = find_reg (cptr, optr, dptr)) { /* found? */ | ^~~~ scp.c: In function 'get_search': scp.c:4083:26: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4083 | for (logop = cmpop = -1; c = *cptr++; ) { /* loop thru clauses */ | ^ scp.c:4084:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4084 | if (sptr = strchr (logstr, c)) { /* check for mask */ | ^~~~ scp.c:4091:14: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4091 | else if (sptr = strchr (cmpstr, c)) { /* check for boolop */ | ^~~~ scp.c: In function 'sim_brk_getact': scp.c:4756:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 4756 | if (ep = strchr (sim_brk_act, ';')) { /* cmd delimiter? */ | ^~ sim_console.c: In function 'sim_set_console': sim_console.c:165:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 165 | if (cvptr = strchr (gbuf, '=')) /* = value? */ | ^~~~~ sim_console.c:168:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 168 | if (ctptr = find_ctab (set_con_tab, gbuf)) { /* match? */ | ^~~~~ sim_console.c: In function 'sim_show_console': sim_console.c:193:9: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 193 | if (shptr = find_shtab (show_con_tab, gbuf)) | ^~~~~ sim_console.c: In function 'sim_poll_kbd': sim_console.c:462:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 462 | if (c = tmxr_getc_ln (&sim_con_ldsc)) /* any char? */ | ^ sim_tmxr.c: In function 'tmxr_poll_tx': sim_tmxr.c:486:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] 486 | if (lp->conn == 0) /* skip if !conn */ | ^~ sim_tmxr.c:488:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' 488 | nbytes = tmxr_send_buffered_data (lp); /* buffered bytes */ | ^~~~~~ sim_tape.c: In function 'sim_tape_rdrecf': sim_tape.c:407:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 407 | if (st = sim_tape_rdlntf (uptr, &tbc)) /* read rec lnt */ | ^~ sim_tape.c: In function 'sim_tape_rdrecr': sim_tape.c:456:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses] 456 | if (st = sim_tape_rdlntr (uptr, &tbc)) /* read rec lnt */ | ^~ In function 'strcpy', inlined from 'URLContents.constprop' at AltairZ80/altairz80_sio.c:76:5: /usr/include/bits/string_fortified.h:90:10: warning: '__builtin_strcpy' writing one too many bytes into a region of a size that depends on 'strlen' [-Wstringop-overflow=] 90 | return __builtin___strcpy_chk (__dest, __src, __bos (__dest)); | ^ AltairZ80/altairz80_sio.c: In function 'URLContents.constprop': AltairZ80/altairz80_sio.c:75:14: note: at offset 0 to an object with size at most 1023 allocated by 'malloc' here 75 | result = malloc(strlen(str)); | ^ collect2: error: ld returned 1 exit status make: *** [makefile:748: BIN/altairz80] Error 1 make: *** Waiting for unfinished jobs.... error: Bad exit status from /var/tmp/rpm-tmp.OIUWW3 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.OIUWW3 (%build) Child return code was: 1 EXCEPTION: [Error()] Traceback (most recent call last): File "/usr/lib/python3.8/site-packages/mockbuild/trace_decorator.py", line 95, in trace result = func(*args, **kw) File "/usr/lib/python3.8/site-packages/mockbuild/util.py", line 746, in do_with_status raise exception.Error("Command failed: \n # %s\n%s" % (command, output), child.returncode) mockbuild.exception.Error: Command failed: # bash --login -c /usr/bin/rpmbuild -bb --target riscv64 --nodeps /builddir/build/SPECS/simh.spec